Debian Bug report logs - #1117444
pygobject: GioUnix.DesktopAppInfo requires extraneous parameter to get_filename() when using GLib 2.84.x

Display info messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Jongmin Kim <jmkim@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: Cannot run: TypeError by GioUnix.DesktopAppInfo.get_filename() in gtweak/utils.py

Date: Mon, 06 Oct 2025 03:43:20 +0900

Package: gnome-tweaks
Version: 49.0-1
Severity: important
Tags: patch

Dear gnome-tweaks maintainers,

After a recent update, gnome-tweaks fails to start with the following
traceback:

    Traceback (most recent call last):
      File "/usr/bin/gnome-tweaks", line 100, in <module>
        from gtweak.app import GnomeTweaks
      File "/usr/lib/python3/dist-packages/gtweak/app.py", line 13, in <module>
        from gtweak.tweakview import Window
      File "/usr/lib/python3/dist-packages/gtweak/tweakview.py", line 20, in <module>
        from gtweak.tweaks.tweak_group_startup import TWEAK_GROUP as StartupApplicationTweaks
      File "/usr/lib/python3/dist-packages/gtweak/tweaks/tweak_group_startup.py", line 348, in <module>
        TWEAK_GROUP = AutostartTweakGroup()
      File "/usr/lib/python3/dist-packages/gtweak/tweaks/tweak_group_startup.py", line 243, in __init__
        self._startup_dapps = self._get_startup_desktop_files()
                              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
      File "/usr/lib/python3/dist-packages/gtweak/tweaks/tweak_group_startup.py", line 327, in _get_startup_desktop_files
        if not AutostartFile(dappinfo).is_start_at_login_enabled():
               ~~~~~~~~~~~~~^^^^^^^^^^
      File "/usr/lib/python3/dist-packages/gtweak/utils.py", line 156, in __init__
        self._desktop_file = appinfo.get_filename()
                             ~~~~~~~~~~~~~~~~~~~~^^
    TypeError: GioUnix.DesktopAppInfo.get_filename() takes exactly 1 argument (0 given)

This issue seems to be caused by a change in the GI bindings. This issue
was already reported to upstream:

    https://gitlab.gnome.org/GNOME/gnome-tweaks/-/issues/528

With the proposed patch, gnome-tweaks starts normally. The proposed patch
is available at:

    https://gitlab.gnome.org/GNOME/gnome-tweaks/-/merge_requests/173

--- /usr/lib/python3/dist-packages/gtweak/utils.py.orig	2025-10-06 03:00:24.377253424 +0900
+++ /usr/lib/python3/dist-packages/gtweak/utils.py	2025-10-06 03:34:26.743701735 +0900
@@ -134,7 +134,7 @@

     @staticmethod
     def get_desktop_files():
-        return [a.get_filename() for a in Gio.app_info_get_all()]
+        return [a.get_filename(a) for a in Gio.app_info_get_all()]

     @staticmethod
     def get_user_autostart_files():
@@ -153,7 +153,7 @@
 class AutostartFile:
     def __init__(self, appinfo, autostart_desktop_filename="", exec_cmd="", extra_exec_args=""):
         if appinfo:
-            self._desktop_file = appinfo.get_filename()
+            self._desktop_file = appinfo.get_filename(appinfo)
             self._autostart_desktop_filename = autostart_desktop_filename or os.path.basename(self._desktop_file)
             self._create_file = False
         elif autostart_desktop_filename:

-- System Information:
Debian Release: forky/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 6.16.9+deb14-amd64 (SMP w/22 CPU threads; PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_US.UTF-8), LANGUAGE=en_US.UTF-8
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages gnome-tweaks depends on:
ii  dconf-gsettings-backend [gsettings-backend]  0.49.0-1
ii  gir1.2-adw-1                                 1.8.0-1
ii  gir1.2-gdesktopenums-3.0                     49.0-1
ii  gir1.2-glib-2.0                              2.84.4-3
ii  gir1.2-gnomedesktop-4.0                      44.4-1
ii  gir1.2-gtk-4.0                               4.20.1+ds-2
ii  gir1.2-gudev-1.0                             238-7
ii  gir1.2-notify-0.7                            0.8.6-2
ii  gir1.2-pango-1.0                             1.56.3-2
ii  gnome-settings-daemon                        48.1-2
ii  gnome-shell-common                           48.5-2
ii  gsettings-desktop-schemas                    49.0-1
ii  mutter-common                                48.5-1
ii  python3                                      3.13.7-1
ii  python3-gi                                   3.50.0-7
ii  user-session-migration                       0.5.0

gnome-tweaks recommends no packages.

Versions of packages gnome-tweaks suggests:
ii  gnome-shell-extension-prefs  48.5-2

-- no debconf information

Message #10 received at 1117444@bugs.debian.org (full text, mbox, reply):

From: Simon McVittie <smcv@debian.org>

To: Jongmin Kim <jmkim@debian.org>, 1117444@bugs.debian.org

Cc: python3-gi@packages.debian.org

Subject: Re: Bug#1117444: Cannot run: TypeError by GioUnix.DesktopAppInfo.get_filename() in gtweak/utils.py

Date: Sun, 5 Oct 2025 20:09:10 +0100

Control: tags -1 - patch

On Mon, 06 Oct 2025 at 03:43:20 +0900, Jongmin Kim wrote:
>With the proposed patch, gnome-tweaks starts normally.
...
>-        return [a.get_filename() for a in Gio.app_info_get_all()]
>+        return [a.get_filename(a) for a in Gio.app_info_get_all()]

I don't think this is a correct solution: instance methods on an object 
are not meant to require the instance to be passed as an explicit 
parameter. It might work as a short-term workaround for now, with the 
specific combination of GLib and pygobject versions you're currently 
using, but it seems very likely that it will regress as soon as the 
underlying bug is fixed (most likely in pygobject, or possibly in GLib).

I suspect this is actually a pygobject regression, probably related to 
the changes that were made for GLib 2.86 compatibility.

    smcv

Message #17 received at 1117444@bugs.debian.org (full text, mbox, reply):

From: Simon McVittie <smcv@debian.org>

To: Jongmin Kim <jmkim@debian.org>, 1117444@bugs.debian.org

Cc: python3-gi@packages.debian.org

Subject: Re: Bug#1117444: Cannot run: TypeError by GioUnix.DesktopAppInfo.get_filename() in gtweak/utils.py

Date: Sun, 5 Oct 2025 20:35:12 +0100

Control: reassign -1 python3-gi 3.50.0-7
Control: retitle -1 pygobject: GioUnix.DesktopAppInfo requires extraneous parameter to get_filename() when using GLib 2.84.x
Control: affects -1 + gnome-tweaks

Here is a minimal reproducer for the bug. You need python3-gi and at 
least one .desktop file: "apt install python3-gi xterm" is sufficient.

> $ python3
> >>> from gi.repository import Gio
> >>> Gio.app_info_get_all()[0].get_filename()

This works fine with GLib 2.86 from experimental: it tells me the 
filename of one of my .desktop files. However, the same fails with GLib 
2.84 from testing/unstable:

> $ python3
> >>> from gi.repository import Gio
> >>> Gio.app_info_get_all()[0].get_filename()
> Traceback (most recent call last):
>   File "<python-input-2>", line 1, in <module>
>     Gio.app_info_get_all()[0].get_filename()
>     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
> TypeError: GioUnix.DesktopAppInfo.get_filename() takes exactly 1 argument (0 given)

I think this is a regression in pygobject caused by the patches that 
were added to make it forward-compatible with GLib 2.86. Unfortunately 
it seems that at least one of those changes is not fully 
backward-compatible with GLib 2.84.

One way to resolve this would be if the release team give the go-ahead 
to do the GLib 2.86 transition; the other way would be to revert or 
improve the pygobject changes (and if they are reverted for now, reapply 
them as part of the GLib 2.86 transition).

I am confident that the proposed patch to gnome-tweaks is *not* a valid 
solution, because it would introduce the opposite regression when used 
with both the new pygobject and the new GLib:

> $ python3
> >>> from gi.repository import Gio
> >>> app = Gio.app_info_get_all()[0]
> >>> app.get_filename()
> '/usr/share/applications/io.github.fabiangreffrath.Hexen.desktop'
> >>> app.get_filename(app)
> Traceback (most recent call last):
>   File "<python-input-3>", line 1, in <module>
>     app.get_filename(app)
>     ~~~~~~~~~~~~~~~~^^^^^
> TypeError: GioUnix.DesktopAppInfo.get_filename() takes exactly 1 argument (2 given)

Instead, I think this needs to be fixed in pygobject.

    smcv

Message #50 received at 1117444-submitter@bugs.debian.org (full text, mbox, reply):

From: Simon McVittie <noreply@salsa.debian.org>

To: 1117444-submitter@bugs.debian.org

Subject: Bug#1117444 marked as pending in pygobject

Date: Wed, 08 Oct 2025 20:20:58 +0000

Control: tag -1 pending

Hello,

Bug #1117444 in pygobject reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/gnome-team/pygobject/-/commit/19a01ea7a2ffb01874e1773fb00a3d8d2846f8d1

------------------------------------------------------------------------
Add proposed patches to fix DesktopAppInfo regressions

Closes: #1117444
------------------------------------------------------------------------

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/1117444

Message #59 received at 1117444-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 1117444-close@bugs.debian.org

Subject: Bug#1117444: fixed in pygobject 3.50.0-8

Date: Sun, 12 Oct 2025 12:36:11 +0000

[Message part 1 (text/plain, inline)]

Source: pygobject
Source-Version: 3.50.0-8
Done: Simon McVittie <smcv@debian.org>

We believe that the bug you reported is fixed in the latest version of
pygobject, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1117444@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Simon McVittie <smcv@debian.org> (supplier of updated pygobject package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 12 Oct 2025 13:03:03 +0100
Source: pygobject
Architecture: source
Version: 3.50.0-8
Distribution: unstable
Urgency: medium
Maintainer: Debian GNOME Maintainers <pkg-gnome-maintainers@lists.alioth.debian.org>
Changed-By: Simon McVittie <smcv@debian.org>
Closes: 1117444
Changes:
 pygobject (3.50.0-8) unstable; urgency=medium
 .
   * Team upload
   * d/p/tests-Exercise-all-methods-defined-by-GDesktopAppInfo.patch,
     d/p/tests-Exercise-the-methods-of-GUnixInputStream-GUnixOutpu.patch,
     d/p/tests-Exercise-GioUnix.FDMessage-methods.patch,
     d/p/overrides-Make-GioUnix-work-as-intended-with-older-GLib.patch,
     d/p/tests-Test-GioUnix-compatibility-on-all-GLib-versions-bac.patch:
     Add proposed patches to fix DesktopAppInfo regressions
     (Closes: #1117444)
   * d/control: Bump required GLib version to 2.80.
     The patches added in 3.50.0-5 and subsequent versions require this.
   * d/control: Standards-Version: 4.7.2 (no changes required)
   * d/control: Remove Rules-Requires-Root, unnecessary since trixie
Checksums-Sha1:
 839ed42c7f544ca96822a947d12da23145975d9a 3095 pygobject_3.50.0-8.dsc
 748d0bd3d335f6e3793f66b6b7b23191a6e66fff 32008 pygobject_3.50.0-8.debian.tar.xz
 fc8875795b3c22a207f670f7c927cec8b4650312 1902236 pygobject_3.50.0-8.git.tar.xz
 affbcf7e97b4ee08c3abe3a84935dcb07487e3c0 18230 pygobject_3.50.0-8_source.buildinfo
Checksums-Sha256:
 e220a50434a29fa0ebffac469e0aeb27054b8eec4b715731807efbaef942451b 3095 pygobject_3.50.0-8.dsc
 c0a30a93398820036d399a668979517542771e048a1b41aab1d4feea8daa60e0 32008 pygobject_3.50.0-8.debian.tar.xz
 ef2076cb6c345e82649739c7f62ebee123eaa0ba0e720a7ed5f64d7395509fb8 1902236 pygobject_3.50.0-8.git.tar.xz
 91601d9b1460b2bdce2530d0ca130bb4e335bf816ac04eb8632cbba28407c099 18230 pygobject_3.50.0-8_source.buildinfo
Files:
 46fad13bd166ac9054e41e928fd88d13 3095 python optional pygobject_3.50.0-8.dsc
 9879df50617d28f26d11fb062d1484a5 32008 python optional pygobject_3.50.0-8.debian.tar.xz
 dd06e8ef40190cc0252d7200499520ee 1902236 python optional pygobject_3.50.0-8.git.tar.xz
 f169b2688559386c2e3a1a12ffc2df9a 18230 python optional pygobject_3.50.0-8_source.buildinfo
Git-Tag-Info: tag=4556d98371d1e4ef84b227ab8d93cd8084776651 fp=7a073ad1ae694fa25bff62e5235c099d3eb33076
Git-Tag-Tagger: Simon McVittie <smcv@debian.org>

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEN02M5NuW6cvUwJcqYG0ITkaDwHkFAmjrmasACgkQYG0ITkaD
wHnarQ//SP7Ov5FA8wUtvNwpsyYDq/WmERf+C0MHL+If76ndr2x90+4UZFz0d5Xm
TOb1B4fhbH5ovBXYk115bC5QIbT9u2ErnvqMmYmmyosIjno5c6b/jUZF8DCaC0zM
lTkg45bfd/mf8noBVLgYa6BFsyK8yjjTh+eHOitqO766wiM+JlBxix2p613QaDRX
BkP/KK4QL4FRxSUxZIxRIZGew5jmygVlc+ZZpnovc4VIv2DBbsTuBg2N4SBNih8J
GVeu5uEOYNp8Y8YmuLs1rNrioLqL9TMIV1cDIqQ6JnzWdzQWXZn6AOK+ev6WeydQ
pVhuiPorYRimtDazbHEZk+HsZ725iPU6wgN07d2EQXKohjxQcxera1wjykawrNpR
VH4hyZ3sKu5Y4jlkmSev1ArNXnj4FBFkg5tp6FSSYSFbTzBqE3AHevR49yPPaA1T
Vg9WHUx+OnollLiBAMtlxTlCZLH3AGhcGyCOlU6JgDSGjym217yCOMWfO60r+lyB
bgIJZUOjEUYwYFtJ8tor1xzObuRM6heJ91nNddJx01vPUC4z6M988XGlqPVSUQAg
zfVGtsDCm2SigmfHqobYIM6PAB3HoJyivmzv93URiEdX2NGbdNM1SPm5j0H7P5UF
Phgrs/Eyv40XQTgSPdiGb73Tl+lFBR3OwM3ulIrQtTvXK+WAjMM=
=7d6Y
-----END PGP SIGNATURE-----

[Message part 2 (application/pgp-signature, inline)]

Send a report that this bug log contains spam.