Debian Bug report logs - #1057231
btrfs-progs: will FTBFS when udev.pc changes udevdir

Display info messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Chris Hofstaedtler <zeha@debian.org>

To: submit@bugs.debian.org

Subject: btrfs-progs: installs files into /lib/udev/rules.d

Date: Fri, 1 Dec 2023 22:59:20 +0100

Package: btrfs-progs
Version: 6.3.2-1
Severity: normal
User: helmutg@debian.org
Usertags: dep17m2

Dear Maintainer,

your package installs the files /lib/udev/rules.d/64-btrfs-dm.rules
and /lib/udev/rules.d/64-btrfs-zoned.rules.

For the ongoing UsrMerge effort [1], /lib needs to become "empty", IOW no
package should install a file there. Instead, files should be installed
into /usr/lib.

Apparently these paths are hard-coded, either in the upstream build system
or the packaging.

Please change your package to install into /usr/lib/udev/rules.d at your
earliest convenience. Per the wiki, it is useful to first upload to
experimental and wait a few days for the dumat tool to evaluate the
change, and only then upload to unstable.

At a later point during the trixie cycle, I expect this bug will become
release-critical.

Thanks for considering,
Chris

[1] https://wiki.debian.org/UsrMerge

Message #10 received at 1057231@bugs.debian.org (full text, mbox, reply):

From: Chris Hofstaedtler <zeha@debian.org>

To: 1057231@bugs.debian.org

Subject: Re: Bug#1057231: btrfs-progs: installs files into /lib/udev/rules.d

Date: Sat, 2 Dec 2023 00:42:26 +0100

Control: retitle -1 btrfs-progs: will FTBFS when udev.pc changes udevdir
Control: tags -1 + ftbfs

* Chris Hofstaedtler <zeha@debian.org> [231201 23:37]:
> Apparently these paths are hard-coded, either in the upstream build system
> or the packaging.

My apologies, the rebuild test failed to catch the real problem
here:

btrfs-progs upstream's configure(.ac) uses udevdir from udev.pc.
This is great.
However: the Debian packaging then hard-codes the /lib path. When
udev.pc changes udevdir, btrfs-progs will FTBFS. Build log snippet:

...
/usr/bin/install -c -m755 -d /<<PKGBUILDDIR>>/debian/tmp/usr/lib/udev/rules.d
/usr/bin/install -c -m644 64-btrfs-dm.rules 64-btrfs-zoned.rules /<<PKGBUILDDIR>>/debian/tmp/usr/lib/udev/rules.d
...
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   debian/rules override_dh_install
make[1]: Entering directory '/<<PKGBUILDDIR>>'
dh_install
dh_install: warning: Cannot find (any matches for) "lib/" (tried in ., debian/tmp)

dh_install: warning: btrfs-progs missing files: lib/
dh_install: error: missing files, aborting
make[1]: *** [debian/rules:45: override_dh_install] Error 25
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:18: binary] Error 2
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2


A future proof option is to do something like this:

In d/rules, set:
    export deb_udevdir = $(shell pkg-config --variable=udevdir udev | sed s,^/,,)

In d/install, use:
    ${env:deb_udevdir}/rules.d


Best,
Chris

Message #27 received at 1057231-maintonly@bugs.debian.org (full text, mbox, reply):

From: Chris Hofstaedtler <zeha@debian.org>

To: 1057319-maintonly@bugs.debian.org, 1057240-maintonly@bugs.debian.org, 1057243-maintonly@bugs.debian.org, 1057245-maintonly@bugs.debian.org, 1057231-maintonly@bugs.debian.org

Subject: will FTBFS on udev.pc change: raising severity

Date: Tue, 12 Dec 2023 10:25:42 +0100

Hi,

it is almost time to change udev.pc, and then your package will
FTBFS. I've raised the bug severity to important.

Once the udev.pc change gets uploaded, I'll ping these bugs again
(and raise to serious).

In the meantime, please go ahead and apply the patch.

Thanks,
Chris

Message #34 received at 1057231-maintonly@bugs.debian.org (full text, mbox, reply):

From: Chris Hofstaedtler <zeha@debian.org>

To: 1057231-maintonly@bugs.debian.org, 1057240-maintonly@bugs.debian.org

Cc: control@bugs.debian.org

Subject: udev.pc was changed

Date: Sun, 24 Dec 2023 13:34:46 +0100

severity 1057231 serious
severity 1057240 serious
severity 1057245 serious
severity 1058828 serious
thanks

udev.pc was changed today. Your package will now either FTBFS or
introduce a policy violation on a rebuild.

Chris

Message #39 received at 1057231-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 1057231-close@bugs.debian.org

Subject: Bug#1057231: fixed in btrfs-progs 6.6.3-1

Date: Sun, 31 Dec 2023 02:34:19 +0000

Source: btrfs-progs
Source-Version: 6.6.3-1
Done: Adam Borowski <kilobyte@angband.pl>

We believe that the bug you reported is fixed in the latest version of
btrfs-progs, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1057231@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Adam Borowski <kilobyte@angband.pl> (supplier of updated btrfs-progs package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Fri, 29 Dec 2023 19:03:32 +0100
Source: btrfs-progs
Architecture: source
Version: 6.6.3-1
Distribution: unstable
Urgency: medium
Maintainer: Adam Borowski <kilobyte@angband.pl>
Changed-By: Adam Borowski <kilobyte@angband.pl>
Closes: 1030950 1044007 1055372 1057231
Changes:
 btrfs-progs (6.6.3-1) unstable; urgency=medium
 .
   * New upstream release (closes: #1055372).
   * Add B-Dep on python3-sphinx-rtd-theme, required for building docs.
   * Fix failure to build twice in a row (closes: #1044007).
   * Query udevdir via pkg-config, fixing FTBFS (closes: #1057231).
   * Build with support for converting from reiserfs (closes: #1030950).
   * Temporarily move the VCS to sr.ht
   * Slightly improve description.
   * Standardize debian/rules somewhat.
Checksums-Sha1:
 fcf81535f8251a698fbe5f474f2606f219c15330 2523 btrfs-progs_6.6.3-1.dsc
 1da2d3c6370a865187afc9fc46d9514ae90781e0 2557216 btrfs-progs_6.6.3.orig.tar.xz
 2271d220817ed3edc9f927ea87474082f86feea3 16972 btrfs-progs_6.6.3-1.debian.tar.xz
 d575dd983e164c7368cc1a85bb08c9367fe69238 11834 btrfs-progs_6.6.3-1_amd64.buildinfo
Checksums-Sha256:
 029216f0cad8cf13e2c76168d7b3fd176b3c3e5fc8b5b1e1258f6fe8ff1f9fed 2523 btrfs-progs_6.6.3-1.dsc
 f41ce53f6673ff551ee4a3fe7dc9601e5a0dde6b6d09177d1fab62718abc6d9a 2557216 btrfs-progs_6.6.3.orig.tar.xz
 add51f16e9102954d3b40938415e481715705ea60eddcd52d346855995cb53df 16972 btrfs-progs_6.6.3-1.debian.tar.xz
 8a2a46c479c94c81d1802d50049a7e2d16ae69c28a3c0cc575aefc31052ebf74 11834 btrfs-progs_6.6.3-1_amd64.buildinfo
Files:
 665ef7337374f5a5d6ccfafc3c6a7758 2523 admin optional btrfs-progs_6.6.3-1.dsc
 a26465478fd2d009cc2fe9f035cc299d 2557216 admin optional btrfs-progs_6.6.3.orig.tar.xz
 b24156e1c6fedf140c135aae6e0510c3 16972 admin optional btrfs-progs_6.6.3-1.debian.tar.xz
 8a9eae9c1d393d1c5dd614f1757b818c 11834 admin optional btrfs-progs_6.6.3-1_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE4qYmHjkArtfNxmcIWogwR199EGEFAmWQx+AACgkQWogwR199
EGFdRBAA1+bl2/BfliuBx08YrN1H/E+wNuhaNFjl2KFSY8hm6l+6FHCE3ubWORj0
cippOzk1Cr0oOHU65BW2l/SlqAggerH7RIY6+9j27G2tvMENe5svzqohznurgVFI
Fh6Joy7PUjeEuftlVnVapcsJyEx5CVoS7+X9ZgMgpih+gOa0p7N70Kmn71JqOrUg
HP4BTv08hn52HI3iOmExeFnf4Y3l5YOGAwyeAGQsoH406F9+O0oC1yd5+2tskFtK
PUK4EPoT61zGg6bbWb6ZgVhsT8ENYYZdqox1n90wxopHTjIOzRdhT6PCMpYbpf5n
wFmd/Maf7xPJf4D34sjkKAJyocJkPBsDyKrIoe9aYOGns0yuzpSXOgDAFZzaLPVG
qyD2Cbm0ypf6hZtjLcS09C3F8GDG1ors3buh8xmIxPRhOO8iOxZF/R3snQgZNB12
RzUnvBN8cxZ5vEMF8L7zyb3bB7X/xCKGX0DI0It0aXtLnuz8/YgCxYcPetOwhyZ1
s9g4OHCqvPsD+GAoiIYFEsf+tDLkAuJgeVXB/cLL2Jm727H+N8eMMun2mCx2XRCU
CkUDuirEQSaVvinjUgP/XMI78bgf9MkuVb6fgPGQkVJEa15zWKzIeIBrM84Ew8Xl
zVvPCtOXk7PJ46/ozK3VsqO9qW8IO83kZXXg6j03PUOahM99jFQ=
=64cx
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.