Debian Bug report logs - #1021310
libsdl2: FTBFS on hppa - testevdev: FAILED: 1

Display info messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: John David Anglin <dave.anglin@bell.net>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: libsdl2: FTBFS on hppa - testevdev: FAILED: 1

Date: Wed, 05 Oct 2022 14:43:00 +0000

Source: libsdl2
Version: 2.24.0+dfsg-2
Severity: serious
Tags: ftbfs
Justification: fails to build from source (but built successfully in the past)

Dear Maintainer,

Build fails in testsuite:

Thinkpad USB keyboard with Trackpoint - Trackpoint...
	Expected 0x00000003
		MOUSE
		KEYBOARD
	Got      0x00000000
No information...
	OK
testevdev: FAILED: 1
testfilesystem...
INFO: base path: '/<<PKGBUILDDIR>>/debian/build-tests/'
INFO: pref path: '/<<PKGBUILDDIR>>/debian/.debhelper/generated/_source/home/.local/share/libsdl/test_filesystem/'
INFO: pref path: '/<<PKGBUILDDIR>>/debian/.debhelper/generated/_source/home/.local/share/test_filesystem/'
testfilesystem: OK
...
testdisplayinfo: OK
make[2]: *** [Makefile:416: check] Error 1
make[2]: Leaving directory '/<<PKGBUILDDIR>>/debian/build-tests'
dh_auto_test: error: cd debian/build-tests && make -j4 check "TESTSUITEFLAGS=-j4 --verbose" VERBOSE=1 V=1 returned exit code 2
make[1]: *** [debian/rules:142: override_dh_auto_test-arch] Error 25
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:81: binary-arch] Error 2
dpkg-buildpackage: error: debian/rules binary-arch subprocess returned exit status 2

Full log is here:
https://buildd.debian.org/status/fetch.php?pkg=libsdl2&arch=hppa&ver=2.24.1%2Bdfsg-1&stamp=1664977752&raw=0

Similar fail occurs on powerpc.

Regards,
Dave Anglin

-- System Information:
Debian Release: bookworm/sid
  APT prefers buildd-unstable
  APT policy: (500, 'buildd-unstable'), (500, 'unstable')
Architecture: hppa (parisc64)

Kernel: Linux 5.19.13+ (SMP w/4 CPU threads)
Kernel taint flags: TAINT_WARN
Locale: LANG=C, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)

Message #10 received at 1021310@bugs.debian.org (full text, mbox, reply):

From: Simon McVittie <smcv@debian.org>

To: John David Anglin <dave.anglin@bell.net>, 1021310@bugs.debian.org

Subject: Re: Bug#1021310: libsdl2: FTBFS on hppa - testevdev: FAILED: 1

Date: Wed, 5 Oct 2022 16:11:13 +0100

Control: severity -1 normal
Control: tags -1 + help

On Wed, 05 Oct 2022 at 14:43:00 +0000, John David Anglin wrote:
> Justification: fails to build from source (but built successfully in the past)

hppa is not a release architecture, so FTBFS on hppa is not RC.

This test-case seems to have been failing on hppa around 75% of the time
since it was added. I don't know why it would do that, because this
test-case should be deterministic: it's inspecting a simulation of the
capabilitities info that we would have received from the kernel for a
particular input device, and running SDL's algorithm to guess what type
of input device it represents (keyboard, mouse, gamepad, etc.). When it
fails on hppa, the failure mode is that none of the bits representing a
device type get set.

It seems to be reliable on release architectures, including i386 which is
32-bit and s390x which is big-endian.

Non-release architecture porters are welcome to investigate why this
is going wrong on their favourite architecture, and if the root cause
turns out to be a bug in SDL, I'm sure upstream would appreciate a patch.

    smcv

Message #19 received at 1021310@bugs.debian.org (full text, mbox, reply):

From: John David Anglin <dave.anglin@bell.net>

To: 1021310@bugs.debian.org

Subject: Re: Bug#1021310: libsdl2: FTBFS on hppa - testevdev: FAILED: 1

Date: Wed, 5 Oct 2022 11:45:59 -0400

On 2022-10-05 11:11 a.m., Simon McVittie wrote:
> It seems to be reliable on release architectures, including i386 which is
> 32-bit and s390x which is big-endian.
Seems to be a 32-bit big-endian issue as same fail occurs on powerpc but not ppc64 or ppc64el.
Possibly, wrong word in 64-bit type is being tested on hppa and powerpc.

Dave

-- 
John David Anglin  dave.anglin@bell.net

Message #24 received at 1021310@bugs.debian.org (full text, mbox, reply):

From: Helge Deller <deller@gmx.de>

To: 1021310@bugs.debian.org, John David Anglin <dave.anglin@bell.net>

Subject: libsdl2: FTBFS on hppa - patch attached

Date: Sun, 9 Oct 2022 12:13:23 +0200

[Message part 1 (text/plain, inline)]

As Dave wrote, it's (partly) a 32-bit big-endian issue.

This check in test/testevdev.c

#if ULONG_MAX == 0xFFFFFFFFUL
#   define SwapLongLE(X) SDL_SwapLE32(X)
#else
    /* assume 64-bit */
#   define SwapLongLE(X) SDL_SwapLE64(X)
#endif

always chooses the #else part, because the <limits.h> file
isn't #included and thus ULONG_MAX isn't defined.

Adding:
#include <limits.h>
to the top of test/testevdev.c,
or applying the attached patch fixes the build on hppa (and probably power).

[libsdl2.patch (text/x-patch, attachment)]

Message #35 received at 1021310-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 1021310-close@bugs.debian.org

Subject: Bug#1021310: fixed in libsdl2 2.24.2+dfsg-1

Date: Wed, 02 Nov 2022 00:50:11 +0000

Source: libsdl2
Source-Version: 2.24.2+dfsg-1
Done: Simon McVittie <smcv@debian.org>

We believe that the bug you reported is fixed in the latest version of
libsdl2, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1021310@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Simon McVittie <smcv@debian.org> (supplier of updated libsdl2 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 01 Nov 2022 22:14:15 +0000
Source: libsdl2
Architecture: source
Version: 2.24.2+dfsg-1
Distribution: unstable
Urgency: medium
Maintainer: Debian SDL packages maintainers <pkg-sdl-maintainers@lists.alioth.debian.org>
Changed-By: Simon McVittie <smcv@debian.org>
Closes: 1021310
Changes:
 libsdl2 (2.24.2+dfsg-1) unstable; urgency=medium
 .
   * New upstream stable release
     - Includes a change to fix a test failure on 32-bit big-endian
       (hppa, mips, powerpc). Thanks to Helge Deller (Closes: #1021310)
   * d/p/build-Expand-version-info-in-SDL_REVISION-and-SDL_GetRevi.patch,
     d/p/build-Add-a-mechanism-to-mark-builds-with-vendor-info.patch:
     Backport patches from upstream git to add vendor information to binaries
Checksums-Sha1:
 a5f533627bd728f2ca6514f9eccd04f740cb08f2 3145 libsdl2_2.24.2+dfsg-1.dsc
 3cef102ce5803159b306ee3b64eaa808f1a6db55 4902928 libsdl2_2.24.2+dfsg.orig.tar.gz
 d0166ba7d5fc454f4933083d00a6e6b5be03f5c0 37820 libsdl2_2.24.2+dfsg-1.debian.tar.xz
 dc2006a201f8c8472e99f3c9317e9542e2b52385 10601 libsdl2_2.24.2+dfsg-1_source.buildinfo
Checksums-Sha256:
 b9ea18fe5492df1c9e8a9b389f18eefaf8b6821b00c4ab3bf0b4211db5cbe26d 3145 libsdl2_2.24.2+dfsg-1.dsc
 72f6671887ac3ec200153b9ce3fe02d5e4dcc7f7257e6f954c424178014924e2 4902928 libsdl2_2.24.2+dfsg.orig.tar.gz
 e30149ba41b585eb2ef35dd4eacd5911e7979c757b41445213e0e672f02076ca 37820 libsdl2_2.24.2+dfsg-1.debian.tar.xz
 7f6c6b0492cee13c7c67cb3b42297073953905d3da47dfcbdb1cdeafdc0c6158 10601 libsdl2_2.24.2+dfsg-1_source.buildinfo
Files:
 0a311088892124e4724f339e8a25a188 3145 libs optional libsdl2_2.24.2+dfsg-1.dsc
 d5d245d4fec9e3eb816d1d017922b28e 4902928 libs optional libsdl2_2.24.2+dfsg.orig.tar.gz
 db4b6e2f09ecafc24ba78e44e09b11b5 37820 libs optional libsdl2_2.24.2+dfsg-1.debian.tar.xz
 698c1900af408ed76de84d11cae11dd7 10601 libs optional libsdl2_2.24.2+dfsg-1_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEENuxaZEik9e95vv6Y4FrhR4+BTE8FAmNhvFsACgkQ4FrhR4+B
TE/ngw//eU2JdWI73kpzdmQoPsYSDrEcRYL0VXNb1Tt/xcgL5RpmxDbR+CKgV8fU
7zLaYNtGc74JXR20xvvq+GilFtxdwG099ZDoqBgX9Qs9HrdXg6MLgIbhYlWSIxl9
cr6GvgsHUEPSs7ifIcd0vVfCtjpiEdhKeWtDa7Vuadv+ptIWaJQlKw3yRziMz/Fs
xrjISq+fLOpow+6eVRuvwBTmZ8FPnFdYimrh69MNmJILc6zqLkP4AfRlpW7rieHd
9Gp/g4+4+FiFbKk6dAX6XdYflx3Y6PKzMFFivJ07xFC3ZYN0BTnQt7762/yH6eVF
uU6QlCB9Tj+oTLTPBZ8SnltQDNDi08hakxa+l4FzMXqF6+cBjpkBi8yxoFdqXDfv
A+L1TcnncUGciD68Buga4aSSlS3SWTl3dJP7LpSu6ErEpUeV7CXE696Ma9GsDTA1
cJ+iXpvcN/8ZZ6Ft7EUXCTpEjsEbYM8Zsa42AgUe1dq6iiZ2tjK4+3dpmPuoxoIR
M2MoAViE9c035Baygvsp4/kD2+EMAJAay+jnotmizHoEuCStWm3FBfakvF6ufb9W
/7tO4Q1l7vwRprGno/SDkNNpBWisAOMG1H0UeQaVSOlt6MXOc5vAKWOLMqTDcHKz
E8JoXdXTXPVshDZbJ4vh00+DBZc40pjZ0g6gQ6zZ8e/mguQuv9o=
=AdFf
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.