Debian Bug report logs - #711529
gnome-terminal: FTBFS on GNU/kFreeBSD

Display info messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Petr Salinger <Petr.Salinger@seznam.cz>

To: submit@bugs.debian.org

Subject: gnome-terminal: FTBFS on GNU/kFreeBSD

Date: Fri, 7 Jun 2013 16:13:57 +0200 (CEST)

Package: gnome-terminal
Version: 3.8.2-1
Severity: serious
Tags: patch
User: debian-bsd@lists.debian.org
Usertags: kfreebsd


Hi,

the current version fails to build on GNU/kFreeBSD.
The F_DUPFD_CLOEXEC is not widespread fcntl, see also changes between
http://pubs.opengroup.org/onlinepubs/009695399/functions/fcntl.html
http://pubs.opengroup.org/onlinepubs/9699919799/functions/fcntl.html

Please allow also fallback variant.

Petr


--- src/terminal-screen.c
+++ src/terminal-screen.c
@@ -190,8 +190,20 @@
 static TerminalURLFlavour *url_regex_flavors;
 static guint n_url_regexes;

+#ifdef __linux__
+static inline int dup_cloexec(int fd, int hint)
+{
+  return fcntl (fd, F_DUPFD_CLOEXEC, hint);
+}
+#else
+static inline int dup_cloexec(int fd, int hint)
+{
+  if ((fd = fcntl (fd, F_DUPFD, hint)) == -1)
+    return -1;
+  return fcntl (fd, F_SETFD, FD_CLOEXEC);
+}
+
 /* See bug #697024 */
-#ifndef __linux__

 #undef dup3
 #define dup3 fake_dup3
@@ -1342,7 +1355,7 @@
       for (j = 0; j < n_fds; j++) {
         if (fds[j] == target_fd) {
           do {
-            fd = fcntl (fds[j], F_DUPFD_CLOEXEC, 10);
+            fd = dup_cloexec(fds[j], 10);
           } while (fd == -1 && errno == EINTR);
           if (fd == -1)
             _exit (127);

Message #10 received at 711529@bugs.debian.org (full text, mbox, reply):

From: Emilio Pozuelo Monfort <pochu@debian.org>

To: Petr Salinger <Petr.Salinger@seznam.cz>, 711529@bugs.debian.org

Subject: Re: Bug#711529: gnome-terminal: FTBFS on GNU/kFreeBSD

Date: Tue, 11 Jun 2013 11:43:36 +0200

On 07/06/13 16:13, Petr Salinger wrote:
> Package: gnome-terminal
> Version: 3.8.2-1
> Severity: serious
> Tags: patch
> User: debian-bsd@lists.debian.org
> Usertags: kfreebsd
> 
> 
> Hi,
> 
> the current version fails to build on GNU/kFreeBSD.
> The F_DUPFD_CLOEXEC is not widespread fcntl, see also changes between
> http://pubs.opengroup.org/onlinepubs/009695399/functions/fcntl.html
> http://pubs.opengroup.org/onlinepubs/9699919799/functions/fcntl.html

Seems like a POSIX.2008 addition.

> Please allow also fallback variant.

The patch seems fine but given that F_DUPFD_CLOEXEC has been implemented in
FreeBSD[1], I wonder if the __linux__ test shouldn't be changed to a
HAVE_F_DUPFD_CLOEXEC check (or to a hurd one). How long do you think it'll take
for Debian's freebsd kernel to have that?

I'll look at making an upload later today. Thanks for the fix!

Regards,
Emilio

[1] http://www.freebsd.org/releases/8.4R/relnotes-detailed.html

> --- src/terminal-screen.c
> +++ src/terminal-screen.c
> @@ -190,8 +190,20 @@
>  static TerminalURLFlavour *url_regex_flavors;
>  static guint n_url_regexes;
> 
> +#ifdef __linux__
> +static inline int dup_cloexec(int fd, int hint)
> +{
> +  return fcntl (fd, F_DUPFD_CLOEXEC, hint);
> +}
> +#else
> +static inline int dup_cloexec(int fd, int hint)
> +{
> +  if ((fd = fcntl (fd, F_DUPFD, hint)) == -1)
> +    return -1;
> +  return fcntl (fd, F_SETFD, FD_CLOEXEC);
> +}
> +
>  /* See bug #697024 */
> -#ifndef __linux__
> 
>  #undef dup3
>  #define dup3 fake_dup3
> @@ -1342,7 +1355,7 @@
>        for (j = 0; j < n_fds; j++) {
>          if (fds[j] == target_fd) {
>            do {
> -            fd = fcntl (fds[j], F_DUPFD_CLOEXEC, 10);
> +            fd = dup_cloexec(fds[j], 10);
>            } while (fd == -1 && errno == EINTR);
>            if (fd == -1)
>              _exit (127);
> 
> _______________________________________________
> pkg-gnome-maintainers mailing list
> pkg-gnome-maintainers@lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-gnome-maintainers
> 

Message #15 received at 711529@bugs.debian.org (full text, mbox, reply):

From: Emilio Pozuelo Monfort <pochu@debian.org>

To: Petr Salinger <Petr.Salinger@seznam.cz>, 711529@bugs.debian.org

Subject: Re: Bug#711529: gnome-terminal: FTBFS on GNU/kFreeBSD

Date: Tue, 11 Jun 2013 11:55:09 +0200

On 11/06/13 11:43, Emilio Pozuelo Monfort wrote:
> On 07/06/13 16:13, Petr Salinger wrote:
>> Package: gnome-terminal
>> Version: 3.8.2-1
>> Severity: serious
>> Tags: patch
>> User: debian-bsd@lists.debian.org
>> Usertags: kfreebsd
>>
>>
>> Hi,
>>
>> the current version fails to build on GNU/kFreeBSD.
>> The F_DUPFD_CLOEXEC is not widespread fcntl, see also changes between
>> http://pubs.opengroup.org/onlinepubs/009695399/functions/fcntl.html
>> http://pubs.opengroup.org/onlinepubs/9699919799/functions/fcntl.html
> 
> Seems like a POSIX.2008 addition.
> 
>> Please allow also fallback variant.
> 
> The patch seems fine but given that F_DUPFD_CLOEXEC has been implemented in
> FreeBSD[1], I wonder if the __linux__ test shouldn't be changed to a
> HAVE_F_DUPFD_CLOEXEC check (or to a hurd one). How long do you think it'll take
> for Debian's freebsd kernel to have that?

Actually Hurd has had support for F_DUPFD_CLOEXEC for a while, so this should
either be __FreeBSD_kernel__ (or whatever) or a HAVE_F_DUPFD_CLOEXEC (with the
appropriate configure check) or perhaps even an #ifdef F_DUPFD_CLOEXEC (assuming
it will be a define in kfreebsd, it is one on linux and hurd).

Emilio

Message #20 received at 711529@bugs.debian.org (full text, mbox, reply):

From: Emilio Pozuelo Monfort <pochu27@gmail.com>

To: Petr Salinger <Petr.Salinger@seznam.cz>, 711529@bugs.debian.org

Subject: Re: Bug#711529: gnome-terminal: FTBFS on GNU/kFreeBSD

Date: Tue, 11 Jun 2013 12:21:17 +0200

On 11/06/13 11:55, Emilio Pozuelo Monfort wrote:
> On 11/06/13 11:43, Emilio Pozuelo Monfort wrote:
>> On 07/06/13 16:13, Petr Salinger wrote:
>>> Package: gnome-terminal
>>> Version: 3.8.2-1
>>> Severity: serious
>>> Tags: patch
>>> User: debian-bsd@lists.debian.org
>>> Usertags: kfreebsd
>>>
>>>
>>> Hi,
>>>
>>> the current version fails to build on GNU/kFreeBSD.
>>> The F_DUPFD_CLOEXEC is not widespread fcntl, see also changes between
>>> http://pubs.opengroup.org/onlinepubs/009695399/functions/fcntl.html
>>> http://pubs.opengroup.org/onlinepubs/9699919799/functions/fcntl.html
>>
>> Seems like a POSIX.2008 addition.
>>
>>> Please allow also fallback variant.
>>
>> The patch seems fine but given that F_DUPFD_CLOEXEC has been implemented in
>> FreeBSD[1], I wonder if the __linux__ test shouldn't be changed to a
>> HAVE_F_DUPFD_CLOEXEC check (or to a hurd one). How long do you think it'll take
>> for Debian's freebsd kernel to have that?
> 
> Actually Hurd has had support for F_DUPFD_CLOEXEC for a while, so this should
> either be __FreeBSD_kernel__ (or whatever) or a HAVE_F_DUPFD_CLOEXEC (with the
> appropriate configure check) or perhaps even an #ifdef F_DUPFD_CLOEXEC (assuming
> it will be a define in kfreebsd, it is one on linux and hurd).

Given the following from [1]

"The <fcntl.h> header shall define the following symbolic constants for the cmd
argument used by fcntl(). The values shall be unique and shall be suitable for
use in #if preprocessing directives"

I say we can just do an #ifdef F_DUPFD_CLOEXEC

I'll adjust the patch for that and upload.

Cheers,
Emilio

[1] http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/fcntl.h.html

Message #25 received at 711529@bugs.debian.org (full text, mbox, reply):

From: Petr Salinger <Petr.Salinger@seznam.cz>

To: Emilio Pozuelo Monfort <pochu27@gmail.com>

Cc: 711529@bugs.debian.org

Subject: Re: Bug#711529: gnome-terminal: FTBFS on GNU/kFreeBSD

Date: Tue, 11 Jun 2013 15:25:31 +0200 (CEST)

> The patch seems fine but given that F_DUPFD_CLOEXEC has been implemented in
> FreeBSD[1], I wonder if the __linux__ test shouldn't be changed to a
> HAVE_F_DUPFD_CLOEXEC check (or to a hurd one). How long do you think it'll take
> for Debian's freebsd kernel to have that?

The version in stable does not support it, and upgrade wheezy -> jessie 
should be doable under wheezy kernel.
I expect that jessie one (9.2+) will support it.

> Actually Hurd has had support for F_DUPFD_CLOEXEC for a while, so this should
> either be __FreeBSD_kernel__ (or whatever) or a HAVE_F_DUPFD_CLOEXEC (with the
> appropriate configure check) or perhaps even an #ifdef F_DUPFD_CLOEXEC (assuming
> it will be a define in kfreebsd, it is one on linux and hurd).

> "The <fcntl.h> header shall define the following symbolic constants for the cmd
> argument used by fcntl(). The values shall be unique and shall be suitable for
> use in #if preprocessing directives"
>
> I say we can just do an #ifdef F_DUPFD_CLOEXEC

Good idea.
The libc might provide wrapper inside fcntl together with defining
F_DUPFD_CLOEXEC to support older kernels.

Cheers

	Petr

Message #30 received at 711529-close@bugs.debian.org (full text, mbox, reply):

From: Emilio Pozuelo Monfort <pochu@debian.org>

To: 711529-close@bugs.debian.org

Subject: Bug#711529: fixed in gnome-terminal 3.8.3-1

Date: Tue, 11 Jun 2013 21:18:55 +0000

Source: gnome-terminal
Source-Version: 3.8.3-1

We believe that the bug you reported is fixed in the latest version of
gnome-terminal, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 711529@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Emilio Pozuelo Monfort <pochu@debian.org> (supplier of updated gnome-terminal package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Tue, 11 Jun 2013 22:02:43 +0200
Source: gnome-terminal
Binary: gnome-terminal gnome-terminal-data
Architecture: source all amd64
Version: 3.8.3-1
Distribution: unstable
Urgency: low
Maintainer: Debian GNOME Maintainers <pkg-gnome-maintainers@lists.alioth.debian.org>
Changed-By: Emilio Pozuelo Monfort <pochu@debian.org>
Description: 
 gnome-terminal - GNOME terminal emulator application
 gnome-terminal-data - Data files for the GNOME terminal emulator
Closes: 711529
Changes: 
 gnome-terminal (3.8.3-1) unstable; urgency=low
 .
   * New upstream release.
   * debian/control.in:
     + Update build dependencies.
   * debian/patches/10_kfreebsd-f_dupfd_cloexec.patch:
     + New patch, don't use F_DUPFD_CLOEXEC if it's not defined (e.g.
       on kFreeBSD). Thanks Petr Salinger for the initial patch.
       Closes: #711529.
Checksums-Sha1: 
 0af9f40b38948f8bb7cc728b16b6d92f9654953a 1896 gnome-terminal_3.8.3-1.dsc
 64b570d85cba7bfb730adec0a18883d9f7dd66cd 1614300 gnome-terminal_3.8.3.orig.tar.xz
 3028a0a5bb6d304e0ff26b550a404aa32a65e6b3 26796 gnome-terminal_3.8.3-1.debian.tar.gz
 b3c90606c557d5725ade073352189b85bf200935 1131154 gnome-terminal-data_3.8.3-1_all.deb
 f0c549b26676d3ca92b71027c742f58d70e7ae88 576754 gnome-terminal_3.8.3-1_amd64.deb
Checksums-Sha256: 
 5a280c0a256b4267810886a659a774ab8e358b84a59fbf9d3abb8a9f2e536430 1896 gnome-terminal_3.8.3-1.dsc
 b368a9220f9a50fecdb57ba8ce7008c65e3c236bc700325a45ecb806f3ab4651 1614300 gnome-terminal_3.8.3.orig.tar.xz
 120239d06b7b58208daa48bd473bc3aa88e21ae2a3d70edce9888c37e3e3b34a 26796 gnome-terminal_3.8.3-1.debian.tar.gz
 140e6508dffc8778e8f101455161c613902d8055e17c32840725f75483ec9143 1131154 gnome-terminal-data_3.8.3-1_all.deb
 14f7ae3f4f8044f93b7bc6b0c95a92b75c70abc7d33e2aad301018ff6a53e74c 576754 gnome-terminal_3.8.3-1_amd64.deb
Files: 
 95d7bdc8119ef5e805bb63b5446ef8f0 1896 gnome optional gnome-terminal_3.8.3-1.dsc
 0f29fd0831ba142b11f9a9ec19533feb 1614300 gnome optional gnome-terminal_3.8.3.orig.tar.xz
 f3abe67b8a8c8dacd0e07c6733bf725d 26796 gnome optional gnome-terminal_3.8.3-1.debian.tar.gz
 18af902cd8e67ca81e547cd8d76f397d 1131154 gnome optional gnome-terminal-data_3.8.3-1_all.deb
 c4c63cda3d50fa7a09935afb8c6f4558 576754 gnome optional gnome-terminal_3.8.3-1_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iEYEARECAAYFAlG3iQ8ACgkQhTV17EoIsv6i1wCggARB/4+mv3kh5rCDBfutskY1
//EAoL6EpoJ+NOeD5rycn9z2w+eNO+M1
=HBee
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.