Debian Bug report logs - #998803
busybox: Debian’s busybox’ tr violates POSIX

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Christoph Anton Mitterer <calestyo@scientia.net>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: busybox: Debian’s busybox’ tr violates POSIX

Date: Sun, 07 Nov 2021 23:25:11 +0100

Package: busybox
Version: 1:1.30.1-7+b1
Severity: important


Hey.

Unlike mandated by POSIX:
https://pubs.opengroup.org/onlinepubs/9699919799/utilities/tr.html

busybox' tr in Debian doesn't seem to understand any of the character classes,...
and I'd guess neither the other formats given in the EXTENDED DESCRIPTION of POSIX.

Not only does it not understand this, but it even takes such characters literal so e.g. when using
busybox tr -d '[:alpha:]' it will remove 'a' and so on.


It seems that this comes from:
# CONFIG_FEATURE_TR_CLASSES is not set

in the various configs.


And I guess:
# CONFIG_FEATURE_TR_EQUIV is not set

should be set as well.


Actually, this bug has probably severity grave, since it may easily break any
unrelated package which expects tr to work as it should.


Cheers,
Chris.

Message #10 received at 998803@bugs.debian.org (full text, mbox, reply):

From: Diederik de Haas <didi.debian@cknow.org>

To: 998803@bugs.debian.org

Subject: Re: busybox: Debian’s busybox’ tr violates POSIX

Date: Fri, 12 Nov 2021 16:30:02 +0100

[Message part 1 (text/plain, inline)]

On Sun, 07 Nov 2021 23:25:11 +0100 Christoph Anton Mitterer <calestyo@scientia.net> wrote:
> Package: busybox
> Version: 1:1.30.1-7+b1
> 
> Unlike mandated by POSIX:
> https://pubs.opengroup.org/onlinepubs/9699919799/utilities/tr.html
> 
> busybox' tr in Debian doesn't seem to understand any of the character
> classes,...

I actually thought that busybox itself didn't support it:
https://github.com/debian-pi/raspbian-ua-netinst/commit/41f93fca88590ed916fa70987cd010dcd8e9300b

Now that I learned that it was a Debian config issue, I created a MR to fix it:
https://salsa.debian.org/installer-team/busybox/-/merge_requests/8

Cheers,
  Diederik

[signature.asc (application/pgp-signature, inline)]

Message #13 received at 998803-submitter@bugs.debian.org (full text, mbox, reply):

From: Chris Boot <noreply@salsa.debian.org>

To: 998803-submitter@bugs.debian.org

Subject: Bug#998803 marked as pending in busybox

Date: Wed, 12 Jan 2022 10:59:31 +0000

Control: tag -1 pending

Hello,

Bug #998803 in busybox reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/installer-team/busybox/-/commit/7b2b88ac462ebc48627b7a9b504352c4c70df32a

------------------------------------------------------------------------
Enable FEATURE_TR_CLASSES and FEATURE_TR_EQUIV

These settings were added 11 years ago as 'not set', so I couldn't find
an explicit reason why it should be disabled. Also, in upstream it is
enabled by default. And supporting classes and equivs is mandated by
POSIX, so enable these options.

Closes: #998803
------------------------------------------------------------------------

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/998803

Message #20 received at 998803@bugs.debian.org (full text, mbox, reply):

From: Christoph Anton Mitterer <calestyo@scientia.org>

To: 998803@bugs.debian.org

Cc: bootc@debian.org

Subject: Re: Bug#998803: marked as pending in busybox

Date: Wed, 12 Jan 2022 17:40:41 +0100

Hey Chris.

Shouldn't this also done in at least the config for the static
busybox... and likely also the udeb?
(I can of course make a PR if that helps.)


Similarly, udeb doesn't set CONFIG_DESKTOP=y which affects POSIX
correctness (see #995833).


Cheers,
Chris.

Message #25 received at 998803@bugs.debian.org (full text, mbox, reply):

From: Chris Boot <bootc@debian.org>

To: Christoph Anton Mitterer <calestyo@scientia.org>, 998803@bugs.debian.org

Subject: Re: Bug#998803: marked as pending in busybox

Date: Wed, 12 Jan 2022 16:55:37 +0000

On 12/01/2022 16:40, Christoph Anton Mitterer wrote:
> Hey Chris.
> 
> Shouldn't this also done in at least the config for the static
> busybox... and likely also the udeb?
> (I can of course make a PR if that helps.)
> 
> 
> Similarly, udeb doesn't set CONFIG_DESKTOP=y which affects POSIX
> correctness (see #995833).

Yes, we probably do want to do that. I was going to vimdiff the configs 
to see what we might need to change and harmonise between them. And 
thanks for pointing out CONFIG_DESKTOP, though, I wasn't aware of it.

Cheers,
Chris

-- 
Chris Boot
bootc@debian.org

Message #30 received at 998803@bugs.debian.org (full text, mbox, reply):

From: Christoph Anton Mitterer <calestyo@scientia.org>

To: Chris Boot <bootc@debian.org>, 998803@bugs.debian.org

Subject: Re: Bug#998803: marked as pending in busybox

Date: Wed, 12 Jan 2022 18:53:44 +0100

On Wed, 2022-01-12 at 16:55 +0000, Chris Boot wrote:
> I was going to vimdiff the configs 
> to see what we might need to change and harmonise between them.

That sounds like a good idea... and I guess it would be reasonable to
keep everything identical, and for the cases where this is really not
desired, properly document why exactly this isn't done, so that in the
future one would know why.

Thanks,
Chris.

Message #35 received at 998803-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 998803-close@bugs.debian.org

Subject: Bug#998803: fixed in busybox 1:1.35.0-1

Date: Mon, 06 Jun 2022 18:48:58 +0000

Source: busybox
Source-Version: 1:1.35.0-1
Done: Michael Tokarev <mjt@tls.msk.ru>

We believe that the bug you reported is fixed in the latest version of
busybox, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 998803@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Michael Tokarev <mjt@tls.msk.ru> (supplier of updated busybox package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Mon, 06 Jun 2022 21:25:41 +0300
Source: busybox
Architecture: source
Version: 1:1.35.0-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Michael Tokarev <mjt@tls.msk.ru>
Closes: 891806 891857 949626 985674 995833 998803 998804 999567 1002663
Changes:
 busybox (1:1.35.0-1) unstable; urgency=medium
 .
   [ Nobuhiro Iwamatsu ]
   * Enable stty applet in busybox-udeb. Closes: #891806
 .
   [ Diederik de Haas ]
   * Enable CONFIG_FEATURE_TR_CLASSES and CONFIG_FEATURE_TR_EQUIV in deb
     config. Closes: #998803
 .
   [ Yuval Freund ]
   * Fix special case for /32 subnets. Closes: #891857
 .
   [ Chris Boot ]
   * New upstream release. Closes: #1002663
     - Closes: #985674 [CVE-2021-28831]
     - Closes: #999567 [CVE-2021-42373, CVE-2021-42374, CVE-2021-42375,
     CVE-2021-42376, CVE-2021-42377, CVE-2021-42378, CVE-2021-42379,
     CVE-2021-42380, CVE-2021-42381, CVE-2021-42382, CVE-2021-42383,
     CVE-2021-42384, CVE-2021-42385, CVE-2021-42386]
     - Closes: #995833 (uudecode /dev/stdout)
   * Refresh and rework patches:
     - Drop patches cherry-picked from upstream.
     - Drop ignore-ip-valid_lft.patch: no longer needed.
     - Rework version.patch: KBUILD_STR() has been dropped.
     - Temporarily drop kFreeBSD patches pending rework.
   * Update busybox configurations for new upstream version
   * Don't run test suite in verbose mode: it's easier to read without.
 .
   [ Michael Tokarev ]
   * d/control: add myself to upladers
   * switch to debhelper-compat=13
   * d/control: add ${misc:Pre-Depends} for packages with the startup scripts
   * enable tr classes for static build to
   * enable less applet for udeb (Closes: #949626)
   * enable base64 applet for regular and static (Closes: #998804)
   * d/rules: stop filtering -Wformat-security from CFLAG, it is okay now
   * d/rules: simplify the clean rule, omit dh in there
   * d/rules: made build-% depending on config-%
   * d/rules: steal build targets from dh which adds unnecessary indirection
   * d/rules: only do install & binary targets with dh
   * d/rules: set SHELL to sh -e to catch errors in shell fragments
   * d/rules: rework build/install procedure to be more robust wrt the
     environment variables: ensure busybox is built only once with right
     CFLAGS/CPPFLAGS/etc settings and not rebuilt during install time
   * many more smaller tweaks to d/rules:
     - fast inline version of architecture.mk
     - move examples & docs install from d/rules to d/*.{docs,examples}
     - switch from ${b} to $b
     - allow overriding verbose build by specifying V=
     - add shortcut targets build-deb configure-udeb test-static etc
     - export ECHO=/bin/echo for testsuite (it builds its own if no -e)
   * remove scripts-echo.c-fix-NUL-handling-in-abc-0-def.patch - not needed
     with the right ECHO=
   * d/bysybox-static.lintian-overrides: add uses-dpkg-database-directly
   * spelling.diff: two spelling fixes for the source
   * d/changelog: strip trailing space
   * d/control: mark zip build-dependency with <!nocheck>
   * udeb config: enable awk applet the same way as for regular/static builds
Checksums-Sha1:
 589367e2e8634bdac3ca95d1591ebb2bc908d696 1966 busybox_1.35.0-1.dsc
 36a1766206c8148bc06aca4e1f134016d40912d0 2480624 busybox_1.35.0.orig.tar.bz2
 1bcea7a5a519529134b68041332df8559791b9af 50072 busybox_1.35.0-1.debian.tar.xz
 31e2009f61fa2264efd93d575f9953c37870bf88 6029 busybox_1.35.0-1_source.buildinfo
Checksums-Sha256:
 9925ed7f56e796b3914f6912fcf0351e291b5e4b523bcec4c7f4e483bdb43234 1966 busybox_1.35.0-1.dsc
 faeeb244c35a348a334f4a59e44626ee870fb07b6884d68c10ae8bc19f83a694 2480624 busybox_1.35.0.orig.tar.bz2
 6a708d28e7ae5a79ea7fe5620c010b79ecb6e6f9fdbb3e5529438dd1dc0f9da4 50072 busybox_1.35.0-1.debian.tar.xz
 48fdab25d9804ef23a8596da1a2ffdb9ae6c879fdcaa2d60b6cac01ab9cf3a36 6029 busybox_1.35.0-1_source.buildinfo
Files:
 68b11fd8a12e4dc301c7998b2144536d 1966 utils optional busybox_1.35.0-1.dsc
 585949b1dd4292b604b7d199866e9913 2480624 utils optional busybox_1.35.0.orig.tar.bz2
 9b007c3169293631c739804ec949aac3 50072 utils optional busybox_1.35.0-1.debian.tar.xz
 e23c9be5d91ab7dbf873d4c339b71787 6029 utils optional busybox_1.35.0-1_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQFDBAEBCAAtFiEEe3O61ovnosKJMUsicBtPaxppPlkFAmKeRuoPHG1qdEB0bHMu
bXNrLnJ1AAoJEHAbT2saaT5Zxd0H/3Nw4puGY4gERk6Z0Zoer1gu9zdskZ2J2fyb
EweJNRrC5Vsl6WAjq49I5hHvlcUkhbWaHOmUePyl26NDK8eBrR1MGwrSGR9d2Eei
D4SBo+AFE/mbIrYMWuX/6zXkeaTY0RLYKxN38V8BucXOH2N9og52Wa4nOdvIWUSQ
CHKTg2Ts3ZQuwx2qofyvUl2eYR6eGC12lhgavesMyfy0a4GIhPg+bEUXtOJH2d08
ZGwKyD7V/N42ZotXxERjbEUG3plHNFuX6glDDgCeumQN4zNqHjcwa9OuPM49Di0w
o14J9iThYvwiBLkgGb2v6DkgHnPEj58jsH/3iXrSSr22OsvqmAE=
=2AVY
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.