Debian Bug report logs - #997689
smplayer: please make the build reproducible

Package: src:smplayer; Maintainer for src:smplayer is Debian Multimedia Maintainers <debian-multimedia@lists.debian.org>;

Reported by: "Chris Lamb" <lamby@debian.org>

Date: Sun, 24 Oct 2021 09:18:02 UTC

Severity: wishlist

Tags: patch

Found in version smplayer/21.8.0-1

Fixed in version 22.2.0~ds0-1

Done: Vagrant Cascadian <vagrant@reproducible-builds.org>

Bug is archived. No further changes may be made.

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to debian-bugs-dist@lists.debian.org, reproducible-bugs@lists.alioth.debian.org, Debian Multimedia Maintainers <debian-multimedia@lists.debian.org>:
Bug#997689; Package src:smplayer. (Sun, 24 Oct 2021 09:18:04 GMT) (full text, mbox, link).

Acknowledgement sent to "Chris Lamb" <lamby@debian.org>:
New Bug report received and forwarded. Copy sent to reproducible-bugs@lists.alioth.debian.org, Debian Multimedia Maintainers <debian-multimedia@lists.debian.org>. (Sun, 24 Oct 2021 09:18:04 GMT) (full text, mbox, link).

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

[Message part 1 (text/plain, inline)]

Source: smplayer
Version: 21.8.0-1
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: timestamps
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0] we noticed that
smplayer could not be built reproducibly.

This is because it embedded a timestamp in the smplayer.appdata.xml
file. Strangely, this line was commented out (from an XML parser's
perspective, that is), but it still renders the build unreproducible:

   -    <!-- <release version="21.8.0" date="2022-11-25"/> -->
   +    <!-- <release version="21.8.0" date="2021-10-24"/> -->

Patch attached that uses SOURCE_DATE_EPOCH.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

[smplayer.diff.txt (text/plain, attachment)]

Reply sent to Vagrant Cascadian <vagrant@reproducible-builds.org>:
You have taken responsibility. (Thu, 29 Dec 2022 21:51:05 GMT) (full text, mbox, link).

Notification sent to "Chris Lamb" <lamby@debian.org>:
Bug acknowledged by developer. (Thu, 29 Dec 2022 21:51:06 GMT) (full text, mbox, link).

Message #10 received at 997689-done@bugs.debian.org (full text, mbox, reply):

[Message part 1 (text/plain, inline)]

Version: 22.2.0~ds0-1

On 2021-10-24, Chris Lamb wrote:
> Whilst working on the Reproducible Builds effort [0] we noticed that
> smplayer could not be built reproducibly.
>
> This is because it embedded a timestamp in the smplayer.appdata.xml
> file. Strangely, this line was commented out (from an XML parser's
> perspective, that is), but it still renders the build unreproducible:
>
>    -    <!-- <release version="21.8.0" date="2022-11-25"/> -->
>    +    <!-- <release version="21.8.0" date="2021-10-24"/> -->
>
> Patch attached that uses SOURCE_DATE_EPOCH.

This appears to have been fixed either upstream or in the toolchain:

  https://tests.reproducible-builds.org/debian/history/smplayer.html

All uploads of 22.2.0~ds0-1 have been building reproducibly.

Marking as done.

live well,
  vagrant

[signature.asc (application/pgp-signature, inline)]

Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Fri, 27 Jan 2023 07:32:14 GMT) (full text, mbox, link).

Send a report that this bug log contains spam.

Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Wed May 17 11:13:30 2023; Machine Name: buxtehude

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Debian Bug report logs - #997689 smplayer: please make the build reproducible

Debian Bug report logs - #997689
smplayer: please make the build reproducible