Debian Bug report logs - #996679
flightgear: reproducible builds: Embeds date in .xml file dependent on timezone

Reply or subscribe to this bug.

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: submit@bugs.debian.org

Subject: flightgear: reproducible builds: Embeds date in .xml file dependent on timezone

Date: Sun, 17 Oct 2021 02:01:02 -0700

[Message part 1 (text/plain, inline)]

Source: flightgear
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: timestamps timezone
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The timezone affects the date embedded in an .xml file:

  https://tests.reproducible-builds.org/debian/rb-pkg/bookworm/amd64/diffoscope-results/flightgear.html

  ./usr/share/metainfo/org.flightgear.FlightGear.metainfo.xml

  <release·version="2020.3.6"·date="2021-02-13"·/>
vs.
  <release·version="2020.3.6"·date="2021-02-14"·/>

The attached patch fixes this by setting the timestamp to use the UTC
timezone.


With this patch applied, flightgear should become reproducible on
tests.reproducible-builds.org.


Thanks for maintaining flightgear!


live well,
  vagrant

[0001-package-CMakeLists.txt-Use-UTC-timestamp.patch (text/x-diff, inline)]

From 7970a34ab1342887ccf1d6f56eead7125b48c54d Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Sun, 17 Oct 2021 08:54:17 +0000
Subject: [PATCH] package/CMakeLists.txt: Use UTC timestamp.

While cmake respects SOURCE_DATE_EPOCH, the timezone may still change
the date stamp used.

https://reproducible-builds.org/docs/source-date-epoch/
---
 package/CMakeLists.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/CMakeLists.txt b/package/CMakeLists.txt
index 4572a28..6c7d696 100644
--- a/package/CMakeLists.txt
+++ b/package/CMakeLists.txt
@@ -3,7 +3,7 @@
 # switch to parsing this from flightgear/version file explicity,
 # but it's only needed by AppStream metainfo for the moment
 
-string(TIMESTAMP FG_CMAKE_TIMESTAMP "%Y-%m-%d")
+string(TIMESTAMP FG_CMAKE_TIMESTAMP "%Y-%m-%d" UTC)
 
 if(${CMAKE_SYSTEM_NAME} MATCHES "Linux")
     # our .desktop file specifies --launcher, so only install it for
-- 
2.33.0

[signature.asc (application/pgp-signature, inline)]

Send a report that this bug log contains spam.