Debian Bug report logs - #995747
xnee: reproducible builds: embeds /bin/sh or /bin/bash depending on /bin/sh symlink

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: submit@bugs.debian.org

Subject: xnee: reproducible builds: embeds /bin/sh or /bin/bash depending on /bin/sh symlink

Date: Mon, 04 Oct 2021 17:40:26 -0700

[Message part 1 (text/plain, inline)]

Source: xnee
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: shell
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The example simple_bash.sh embeds either /bin/bash or /bin/sh depending
on what the /bin/sh symlink points to:

  https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/xnee.html

  /usr/share/doc/cnee/examples/simple_bash.sh

  #!·/bin/bash
vs.
  #!·/bin/sh

The attached patch fixes this by hard-coding to use /bin/bash, instead
of the Makefile BASH variable.

There are still other outstanding issues affecting the reproducibility
of xnee, but this should help reduce the differences to troubleshoot the
remaining issues.

Thanks for maintaining xnee!

live well,
  vagrant

[0001-examples-Makefile.am-Patch-to-hard-code-path-to-bash.patch (text/x-diff, inline)]

From 603e131203b5f06141920ee8931121c159dc02e7 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Tue, 5 Oct 2021 00:31:10 +0000
Subject: [PATCH] examples/Makefile.am: Patch to hard-code path to bash.

When /bin/sh is a symlink to bash, the value of the BASH variable gets
set to /bin/sh, but /bin/sh may not always point to bash on the
running system.

https://tests.reproducible-builds.org/debian/issues/unstable/bin_sh_is_bash_issue.html
---
 examples/Makefile.am | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/examples/Makefile.am b/examples/Makefile.am
index c08a110..7ea6bf8 100644
--- a/examples/Makefile.am
+++ b/examples/Makefile.am
@@ -6,7 +6,7 @@ pkgdatadir=$(datadir)/xnee/
 CLEAN_FILES=simple_bash.sh
 
 simple_bash.sh: simple_bash.sh.in1
-	echo "#!" "$(BASH)"                     > simple_bash.sh
+	echo "#!" "/bin/bash"                   > simple_bash.sh
 	echo " "                               >> simple_bash.sh 
 	echo " "                               >> simple_bash.sh 
 	echo "if [ -f ${bindir}/bin/cnee ]"    >> simple_bash.sh 
-- 
2.33.0

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 995747-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 995747-close@bugs.debian.org

Subject: Bug#995747: fixed in xnee 3.19-7

Date: Thu, 07 Oct 2021 20:24:46 +0000

Source: xnee
Source-Version: 3.19-7
Done: Vincent Bernat <bernat@debian.org>

We believe that the bug you reported is fixed in the latest version of
xnee, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 995747@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Vincent Bernat <bernat@debian.org> (supplier of updated xnee package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 07 Oct 2021 21:55:33 +0200
Source: xnee
Architecture: source
Version: 3.19-7
Distribution: unstable
Urgency: medium
Maintainer: Vincent Bernat <bernat@debian.org>
Changed-By: Vincent Bernat <bernat@debian.org>
Closes: 995747
Changes:
 xnee (3.19-7) unstable; urgency=medium
 .
   * d/patches: add patch by Vagrant Cascadian to improve reproducibility.
     Closes: #995747.
Checksums-Sha1:
 aa3103301f932002435a9b35f94de28df325784d 2212 xnee_3.19-7.dsc
 2830e71b099c5e814878971a2040e85bbd6f9a07 1893109 xnee_3.19.orig.tar.gz
 e953593d77d251dc072b7a10518c27184f01df83 16475812 xnee_3.19-7.debian.tar.xz
 2fb80afbf2debf968abc56c9ba5c8848cb83c048 12795 xnee_3.19-7_amd64.buildinfo
Checksums-Sha256:
 4f4ca6e006c8035ff18dff413931a6705e1409c238d083c06ad269ee766c92f3 2212 xnee_3.19-7.dsc
 52a41e5cf62f81b7a3e5b58124eb3565e1e12028abda63f547fbbe0d98a2c212 1893109 xnee_3.19.orig.tar.gz
 93498a53552acf65ff1ebf82718a3af67b1606f2351c472afa3f36e64d7d805a 16475812 xnee_3.19-7.debian.tar.xz
 1731bac2cf229955b68f91c90a2a11cdbcda7664b48c070b66d7b3912b7e144f 12795 xnee_3.19-7_amd64.buildinfo
Files:
 e973cec50f93235ae2e323ee764bc4fd 2212 x11 optional xnee_3.19-7.dsc
 560e8126950d8d4e7c30fc844d556482 1893109 x11 optional xnee_3.19.orig.tar.gz
 5cefe900ffcc87bcdb9846dd49fe82b8 16475812 x11 optional xnee_3.19-7.debian.tar.xz
 30ba70b0f62ee866e11867843ee61dfa 12795 x11 optional xnee_3.19-7_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJFBAEBCAAwFiEErvI0h2bzccaJpzYAlaQv6DU1JfkFAmFfUUASHGJlcm5hdEBk
ZWJpYW4ub3JnAAoJEJWkL+g1NSX5AWkP90IKGu5ZLVWIbJV08hwGerjWbOBQ4IFj
5VE47jsQjhrBUWzLPvFc8gOtj+iVNDz9Giu/peatmtCBVppvW0WTKlTisMSZxZKo
YU7z94zkcaVpvp7s/fPq0eAqMrclA+vhFWKO9FxjZ4YY+EvAnec+Yzz/5yXxA3GH
N1sJrP2KNlJv18hoAjpdsfpL2v/gfdBlxmAjkzBCukpFd0NyymDc8ZpKP/eZYLCe
DkFDbDWFNcUXwYl0ozGgt094POwwo2ZO8/0PYbofrZIFN7fZsvbCh5WBtyB9YIbg
PAstFizSHv3AXL0HR+QEtftz7z9e+YODRQnobeLQ77sGHtfv2EHBArlzMc6R0keE
scXw6Tg/fiCPqWzUT0HHsrWpps2JdkQjyRM1iovzGLaLP6mRGVGN29KXcuDb3jbs
CXPBb3I9jYu8m0pUNJPWvOUS3ifsd/qSiiLMXsHzOxknqPN4EZc6161/H/FKh+Ge
hMM0tFjsDAVc4WjH8pdFCKBEwum04PUn4L92ZTwevfRQ3MTYdlazNlZ+2sSHfiIC
rEhlqAID+3KZ0v1s1lOWwRPC++qhkTx9nvTfnJGDtNQDc7ooAELMmVmqlvJER5p6
EmRN8BJ4RK5uC36Cs6kOH4fOZc3qL3/7IwYbu6D4EEkGOocjS0uEpWuJhSa071J+
Cpm3yP6Z1kw=
=fxVj
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.