Debian Bug report logs - #995143
xdmf: reproducible builds: Embeds buildpath, kernel and uname path

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: submit@bugs.debian.org

Subject: xdmf: reproducible builds: Embeds buildpath, kernel and uname path

Date: Sun, 26 Sep 2021 17:44:45 -0700

[Message part 1 (text/plain, inline)]

Source: xdmf
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath usrmerge kernel
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The build path, kernel version and path to the uname binary are
embedded in /usr/lib/x86_64-linux-gnu/cmake/Xdmf/XdmfConfig.cmake,
which cause reproducibility issues.

  https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/xdmf.html

  set(XDMF_CMAKE_BINARY_DIR "/build/1st/xdmf-3.0+git20190531/debian/build-mpi-python3.9")
  vs.
  set(XDMF_CMAKE_BINARY_DIR "/build/2/xdmf-3.0+git20190531/2nd/debian/build-mpi-python3.9")

The attached patch fixes this by sanitizing these values in the
XdmfConfig.cmake file.

It is unclear if XdmfConfig.cmake actually needs to be included in the
package; a better course of action might be to remove the file entirely.


With this patch applied(or removing XdmfConfig.cmake from the package),
xdmf should become reproducible on tests.reproducible-builds.org.


Thanks for maintaining xdmf!


live well,
  vagrant

[0001-debian-rules-Sanitize-XdmfConfig.cmake-to-fix-reprod.patch (text/x-diff, inline)]

From 143591a985b25b0baf340537af7a00d51ac9fde1 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Mon, 27 Sep 2021 00:04:08 +0000
Subject: [PATCH] debian/rules: Sanitize XdmfConfig.cmake to fix
 reproducibility issues.

The build path, kernel version and path to the uname binary are
embedded in /usr/lib/x86_64-linux-gnu/cmake/Xdmf/XdmfConfig.cmake,
which cause reproducibility issues.

https://tests.reproducible-builds.org/debian/issues/captures_build_path_issue.html
https://tests.reproducible-builds.org/debian/issues/captures_kernel_version_via_CMAKE_SYSTEM_issue.html
https://tests.reproducible-builds.org/debian/issues/paths_vary_due_to_usrmerge_issue.html
---
 debian/rules | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/debian/rules b/debian/rules
index 321ae850..c95f8b43 100755
--- a/debian/rules
+++ b/debian/rules
@@ -91,6 +91,12 @@ override_dh_auto_install:
 		cp debian/build-serial-$$p/lib/__*.so   $(PY3DEST)/usr/lib/$$p/dist-packages/xdmf/NoMpi ; \
 		cp debian/build-mpi-$$p/lib/__*.so   $(PY3DEST)/usr/lib/$$p/dist-packages/xdmf ; \
 		done
+	# Remove build path and kernel version, and adjust path to
+	# uname to make build reproducible
+	sed -i -e "s,$(CURDIR),BUILDDIR,g" \
+		-e "s,/usr/bin/uname,/bin/uname,g" \
+		-e "s,$(shell uname -r),,g" \
+		debian/tmp/usr/lib/x86_64-linux-gnu/cmake/Xdmf/XdmfConfig.cmake
 
 override_dh_auto_fixperms:
 	dh_auto_fixperms
-- 
2.30.2

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 995143-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 995143-close@bugs.debian.org

Subject: Bug#995143: fixed in xdmf 3.0+git20190531-8

Date: Tue, 28 Sep 2021 15:03:38 +0000

Source: xdmf
Source-Version: 3.0+git20190531-8
Done: Alastair McKinstry <mckinstry@debian.org>

We believe that the bug you reported is fixed in the latest version of
xdmf, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 995143@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Alastair McKinstry <mckinstry@debian.org> (supplier of updated xdmf package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 28 Sep 2021 14:09:50 +0100
Source: xdmf
Architecture: source
Version: 3.0+git20190531-8
Distribution: unstable
Urgency: medium
Maintainer: Alastair McKinstry <mckinstry@debian.org>
Changed-By: Alastair McKinstry <mckinstry@debian.org>
Closes: 995141 995143
Changes:
 xdmf (3.0+git20190531-8) unstable; urgency=medium
 .
   * Move to debhelper level 13
   * Add d/not-installed for "hand-installed" files
   * Standards-Version: 4.6.0; no changes required
   * Update d/gpb.conf to DEP-14 branch names
   * Point vcx-git to d/latest branch. Closes: #995141
   * Make XdmfConfig.cmake reproducible, thanks to Vagrant. Closes: #995143
Checksums-Sha1:
 055c1bb73640e3f975d94bfa88b61102df5bee31 2242 xdmf_3.0+git20190531-8.dsc
 ce6a059f016ea3ebe9ed04ddf343028357c213b2 11076 xdmf_3.0+git20190531-8.debian.tar.xz
Checksums-Sha256:
 2b4b9bbe6d141654ce1cf330a765e9aa17861d303913fd6705466445dd2baaa0 2242 xdmf_3.0+git20190531-8.dsc
 4167ebd998159905db5d4b2cf6bf17a2f8cdfca4d0c919ec2a5e0767cd71875d 11076 xdmf_3.0+git20190531-8.debian.tar.xz
Files:
 c788f486b5dd980f7dc5c80598fb90aa 2242 science optional xdmf_3.0+git20190531-8.dsc
 7ef593870cdbeed3e86b7d93529dcf61 11076 science optional xdmf_3.0+git20190531-8.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEgjg86RZbNHx4cIGiy+a7Tl2a06UFAmFTK1YACgkQy+a7Tl2a
06XKGA//VqHTAApsrxiikjMJkGrS8DUrO4VMiA2ZmG5TIiy3Nl+RUApmLtTqZcjE
GjA6etm2EfGyW5JKfbVA/Pa9f59iK/D+mTac5230zJHbQudvS6FG/VooA1zi9qVf
bMaQMNr+U0d1I83gj2lWW1q4hJ+DyhSwmEbQBm+eFVHk0LQT76bMBH7DcZTz5/cb
myAaUWDFg+dYsE9WwJh3AmILCI4sl+9jk9AORabGYlslmbJCYwg4j0OzAxoEpCjZ
wnSkZixcJXfRJY5ZNx58tBAUpnQRQRvBL6KNhViL3bxMXJHQPY+lx66r4dNe+xOR
TPIzTOPgShSLDcua8Z7RDIH5Ya/idjOj3TxZVTZCf1jf5SFyOwr/3kH2JThNtJdM
2hns3Xtcm75aQUwdVjuPO7tMzr1k2n3ntumK/5JbsWV8Ia8mJAfqrcCMhbSbgBgn
QfSW3wFVO/9ppvrFz65cU1SG1nKP44TGSTVqbURh5OfseA+n7zmhyd/vs8vuVJJG
tFN4mCdAauqiSRCESNdHIwIv/3G4nZcznCN2EMP3ejE83OLw6J53sl5qsaIMnogw
MF6binQqbrjRD+AicZ7qSBPrGYkJvMRdVlr0xK4aE1SvMnKX+cWqTN3gtz8OMeuQ
kSImmkch7qmgT3qcDC3fzn4tF2eNWqvdwYEVvBRtt1/o41Zx1RA=
=WFVC
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.