Debian Bug report logs - #994941
util-linux: HiFive Unmatched partitions are named "Unleashed"

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Alexandre Ghiti <alexandre.ghiti@canonical.com>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: util-linux: HiFive Unmatched partitions are named "Unleashed"

Date: Thu, 23 Sep 2021 17:22:52 +0200

[Message part 1 (text/plain, inline)]

Package: util-linux
Version: 2.36.1-8
Severity: normal
Tags: patch
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu impish ubuntu-patch

Dear Maintainer,

   * What led up to the situation?

ubuntu@ubuntu:~$ sudo fdisk -l
Disk /dev/mmcblk0: 29.72 GiB, 31914983424 bytes, 62333952 sectors
Units: sectors of 1 * 512 = 512 bytes
Sector size (logical/physical): 512 bytes / 512 bytes
I/O size (minimum/optimal): 512 bytes / 512 bytes
Disklabel type: gpt
Disk identifier: 892D1327-1A07-4589-A149-ED0F3B603575

Device           Start      End  Sectors  Size Type
/dev/mmcblk0p1  235554 62333918 62098365 29.6G Linux filesystem
/dev/mmcblk0p12 227362   235553     8192    4M Linux filesystem
/dev/mmcblk0p13     34     2081     2048    1M HiFive Unleashed FSBL
/dev/mmcblk0p14   2082    10273     8192    4M HiFive Unleashed BBL
/dev/mmcblk0p15  10274   227361   217088  106M EFI System

   * What exactly did you do (or not do) that was effective (or
     ineffective)?

Please see https://bugs.launchpad.net/ubuntu/+source/util-linux/+bug/1944741.

Thanks for considering the attached patch.

-- System Information:
Debian Release: bullseye/sid
  APT prefers hirsute-updates
  APT policy: (500, 'hirsute-updates'), (500, 'hirsute-security'), (500, 'hirsute'), (100, 'hirsute-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.11.0-31-generic (SMP w/16 CPU threads)
Kernel taint flags: TAINT_WARN, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_US.UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

[util-linux_2.36.1-8ubuntu2.debdiff (text/plain, attachment)]

Message #14 received at 994941@bugs.debian.org (full text, mbox, reply):

From: Alexandre Ghiti <alexandre.ghiti@canonical.com>

To: 994941@bugs.debian.org

Subject: Update debdiff

Date: Fri, 24 Sep 2021 05:31:55 +0200

[Message part 1 (text/plain, inline)]

[util_linux_debdiff.patch (text/x-patch, attachment)]

Message #17 received at 994941-submitter@bugs.debian.org (full text, mbox, reply):

From: Chris Hofstaedtler <noreply@salsa.debian.org>

To: 994941-submitter@bugs.debian.org

Subject: Bug#994941 marked as pending in util-linux

Date: Mon, 27 Sep 2021 15:49:56 +0000

Control: tag -1 pending

Hello,

Bug #994941 in util-linux reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/debian/util-linux/-/commit/6c62c32456decefc148d6a324675d914ff674c25

------------------------------------------------------------------------
Add upstream-applied patches for requested features

* Use more passive wording in hardlink.1
* fallocate: Let user choose larger buffers for IO reading
* Update HiFive partition names

Closes: #994941
Thanks: Alexandre Ghiti, Eduard Bloch
Gbp-Dch: full
------------------------------------------------------------------------

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/994941

Message #24 received at 994941@bugs.debian.org (full text, mbox, reply):

From: Alexandre Ghiti <alexandre.ghiti@canonical.com>

To: 994941@bugs.debian.org

Subject: Additional patch

Date: Tue, 12 Oct 2021 15:35:20 +0200

[Message part 1 (text/plain, inline)]

Although the initial patchset works, I think it would be cleaner to
also change the translation files so that they take into account the
changes in the partition names.

I attach 2 debdiff:
- util_linux_debdiff_2.patch: it can be applied on top of the first
patch that was already applied.
- util_linux_debdiff_complete.patch: the debdiff for all the changes,
the one already applied and the new one.

Sorry for that.

Thanks,

Alexandre Ghiti

[util_linux_debdiff_2.patch (text/x-patch, attachment)]

[util_linux_debdiff_complete.patch (text/x-patch, attachment)]

Message #29 received at 994941@bugs.debian.org (full text, mbox, reply):

From: Chris Hofstaedtler <zeha@debian.org>

To: Alexandre Ghiti <alexandre.ghiti@canonical.com>, 994941@bugs.debian.org

Subject: Re: Bug#994941: Additional patch

Date: Fri, 15 Oct 2021 18:01:50 +0200

Hello Alexandre,

* Alexandre Ghiti <alexandre.ghiti@canonical.com> [211012 15:39]:
> Although the initial patchset works, I think it would be cleaner to
> also change the translation files so that they take into account the
> changes in the partition names.
> 
> I attach 2 debdiff:
> - util_linux_debdiff_2.patch: it can be applied on top of the first
> patch that was already applied.
> - util_linux_debdiff_complete.patch: the debdiff for all the changes,
> the one already applied and the new one.

Thanks for the follow up, but I believe your translation patch is
basically a no-op:
- Your initial patch changed the source strings.
- If my understanding of gettext is correct, the changed source
  strings would just show up untranslated.
- The "translated" strings are not really translations but 1:1
  just the exact same strings as the original source strings.

Translators will pick up the source string change on their own time,
and in the meantime I believe there is no user-visible change.
I would very much like to avoid carrying the translation patch in
Debian for this reason, and just wait for upstream and upstream
translators to do their thing.

Please let me know if I missed something or you have additional
insight :-)

Many thanks,
Chris

Message #34 received at 994941-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 994941-close@bugs.debian.org

Subject: Bug#994941: fixed in util-linux 2.37.2-4

Date: Tue, 19 Oct 2021 15:20:08 +0000

Source: util-linux
Source-Version: 2.37.2-4
Done: Chris Hofstaedtler <zeha@debian.org>

We believe that the bug you reported is fixed in the latest version of
util-linux, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 994941@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Chris Hofstaedtler <zeha@debian.org> (supplier of updated util-linux package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 19 Oct 2021 14:02:14 +0000
Source: util-linux
Architecture: source
Version: 2.37.2-4
Distribution: unstable
Urgency: medium
Maintainer: util-linux packagers <util-linux@packages.debian.org>
Changed-By: Chris Hofstaedtler <zeha@debian.org>
Closes: 992516 994941 996751 996764
Changes:
 util-linux (2.37.2-4) unstable; urgency=medium
 .
   [ Debian Janitor ]
   * Use secure URI in Homepage field.
   * Remove 1 obsolete maintscript entry.
   * Re-export upstream signing key without extra signatures.
 .
   [ Chris Hofstaedtler ]
   * Add upstream-applied patches for requested features
     * Use more passive wording in hardlink.1
     * fallocate: Let user choose larger buffers for IO reading
     * Update HiFive partition names
       Thanks to Alexandre Ghiti, Eduard Bloch (Closes: #994941)
     * more: add upstream patch for "Erase line before writing the filename"
       Thanks to Vincent Smeets (Closes: #992516)
   * Apply upstream patch to remove accidental nbsp from blockdev output
     (Closes: #996751)
   * Apply upstreamed patch to fix FTBFS with mkswap on ext3 in cowbuilder.
     Thanks to Mark Hindley <mark@hindley.org.uk> (Closes: #996764)
Checksums-Sha1:
 aafc4f270d0287df55bbee6d09bdeeec1e3ee0a0 4454 util-linux_2.37.2-4.dsc
 a225a60195894b9c71a1353bf627edf21621fed4 97648 util-linux_2.37.2-4.debian.tar.xz
 122a8e3b8d28bb20e44a4366f338a43e911cd422 7583 util-linux_2.37.2-4_source.buildinfo
Checksums-Sha256:
 a312bd385e6730207c6a96808367714af6bd0b318c09b8b87dd5f02f4ba9e91c 4454 util-linux_2.37.2-4.dsc
 2639bef2d22c57f6e5394e51f892f7d2df39050d663df4864361fbaac3fd5897 97648 util-linux_2.37.2-4.debian.tar.xz
 8d87e30135d23c1715eceb01a3a76d0bf111d861e23dc1a059da54aec4d1cb70 7583 util-linux_2.37.2-4_source.buildinfo
Files:
 1c5007267977afae80363d6c82aa3e8d 4454 base required util-linux_2.37.2-4.dsc
 cb390a9cd03059feab92194c490f0eba 97648 base required util-linux_2.37.2-4.debian.tar.xz
 c6bc570c30ba364b4e64fa807e8c1e22 7583 base required util-linux_2.37.2-4_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEfRrP+tnggGycTNOSXBPW25MFLgMFAmFu3FEACgkQXBPW25MF
LgMnhxAAkKngK5hOzyUnaQP9asgYvIulSYl+523lwTenAjaYXcX8dsZ6wup580Sv
XwDsslw98UW/cgtiX+3mb6AgE5YYFbTujwLc5qrPWc/+jiWHpr/ECy5WQLKCLvbp
myeQ7M563vRvon//a+GnEsnbZnlxcquR01XZCbaEvkbbcuxVx9KAPT+NmMd57y6V
LhnkfyqvT4vr3TX7jpsz+Jf3HyAitZP0rFyOb4xl7kMYmlbK6XSGRU1GfCq3kRg0
rIu8wOsSF7OL+fB0oPSjGMK1wP8agsOg3q+Q+WuQZj58Am74ihNh66EpwOCL33we
fn6cGiBHkgIxImZo6LAUmKHn1XyDNpz34K2oEWgBZA2vHxRFWEkNfBOtpxulrQwC
5Dj3xvy5/pwHfniODOu1/y+EVY/2IzszvEFxAh1SdVdYb2+HYOATiXjo50JLSDPS
80sxxP52ysxkYv28BrH1zLtrHXCzlC1+y7WG91fL+y3WW3FTW1utTuzu8o7hnY3P
KGIEm6ila677lIRW4H8eaD/7f76cgAQmKvXvLHvN1x9dgTcBoDHi8a5/qt0YzaLd
EuY3/qiwxky6cCNOIgffcXSNALC6M2ooti2PX6CCNQBafYMH6Hrtqgp4WBElWnSn
R4xkEw4/30l1wauxtWsDEwVHxdbVHGYq0RLocaKHCVaUDLFI0Bo=
=8kHa
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.