Debian Bug report logs - #993674
ga: please make the build reproducible

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Simon McVittie <smcv@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: ga: please make the build reproducible

Date: Sat, 4 Sep 2021 17:31:21 +0100

[Message part 1 (text/plain, inline)]

Source: ga
Version: 5.7.2-2
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: usrmerge
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

libglobalarrays-dev gets different -L paths in the ga-config script,
depending on whether the build happens to have been done on a system
where /usr/lib64 exists.

On Debian systems, /usr/lib64 will normally exist on 64-bit systems that
have merged-/usr (via the usrmerge package or debootstrap --merged-usr),
such as systems that were installed with debian-installer as buster or
later, but will not normally exist on traditional non-merged-/usr systems.

This can be seen on the reproducible-builds.org infra, which uses
non-merged-/usr for "build 1" and merged-/usr for "build 2":
https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/ga.html

If you have sbuild available, an easy way to reproduce this is to build
for amd64 twice, once with --add-depends=usrmerge and once without.

It is never necessary for Debian packages to use -L/usr/lib or -I/usr/include
explicitly, because Debian's compilers have those directories in their
default search paths. Similarly, it is never necessary for Debian packages
for "lib64" architectures like amd64 to use -L/usr/lib64 explicitly.
This means ga can be made reproducible by not specifying /usr, and instead
relying on the armci library being in the default compiler search path.

Please consider the attached patch. It does not eliminate all the unnecessary
-I/usr/include or -L/usr/lib, only the ones that can be a problem for
reproducible builds, and seems like a net simplification for the package
in general.

The changes that result in the ga-config script when applying the patch
look something like this (quoting from diffoscope output):

│ │ │ ├── ./usr/bin/ga-config
│ │ │ │ @@ -263,30 +263,30 @@
│ │ │ │  dep_libs=`$prefix/bin/armci-config --libs`
│ │ │ │  
│ │ │ │  fi
│ │ │ │  
│ │ │ │  
│ │ │ │  f77="mpif90"
│ │ │ │  cc="mpicc"
│ │ │ │ -cppflags="     -I/usr/include -I/usr/include"
│ │ │ │ -network_cppflags=" -I/usr/include"
│ │ │ │ +cppflags="     -I/usr/include"
│ │ │ │ +network_cppflags=""
│ │ │ │  cflags=""
│ │ │ │  fflags=" -fdefault-integer-8"
│ │ │ │  fint="-fdefault-integer-8"
│ │ │ │  blas_size="4"
│ │ │ │  scalapack_size="4"
│ │ │ │  use_blas="1"
│ │ │ │  use_lapack="1"
│ │ │ │  use_scalapack="1"
│ │ │ │  use_peigs="0"
│ │ │ │  use_elpa="0"
│ │ │ │  use_elpa_2015="0"
│ │ │ │  use_elpa_2016="0"
│ │ │ │ -ldflags="     -L/usr/lib64 -L/usr/lib"
│ │ │ │ -network_ldflags=" -L/usr/lib64"
│ │ │ │ +ldflags="     -L/usr/lib"
│ │ │ │ +network_ldflags=""
│ │ │ │  libs="-lga  -lscalapack-openmpi  -lopenblas  -lopenblas $dep_libs"
│ │ │ │  network_libs=" -larmci"
│ │ │ │  flibs=" -L/usr/lib/gcc/x86_64-linux-gnu/10 -L/usr/lib/gcc/x86_64-linux-gnu/10/../../../x86_64-linux-gnu -L/usr/lib/gcc/x86_64-linux-gnu/10/../../../../lib -L/lib/x86_64-linux-gnu -L/lib/../lib -L/usr/lib/x86_64-linux-gnu -L/usr/lib/../lib -L/usr/lib/gcc/x86_64-linux-gnu/10/../../.. -lgfortran -lm -lquadmath"
│ │ │ │  enable_f77_true=""
│ │ │ │  version="5.7.1"
│ │ │ │  
│ │ │ │  if test "x$enable_f77_true" = x; then :

    smcv

[0001-d-rules-Don-t-specify-path-to-armci-for-reproducible.patch (text/x-diff, attachment)]

Message #8 received at 993674-submitter@bugs.debian.org (full text, mbox, reply):

From: Drew Parsons <noreply@salsa.debian.org>

To: 993674-submitter@bugs.debian.org

Subject: Bug#993674 marked as pending in ga

Date: Sun, 13 Feb 2022 23:02:10 +0000

Control: tag -1 pending

Hello,

Bug #993674 in ga reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/debichem-team/ga/-/commit/2e998c0faf4005bf5a990982dcfc51346f251ba3

------------------------------------------------------------------------
configure with default path for armci

to improve build reproducibility.

Thanks Simon McVittie.

Closes: #993674.
------------------------------------------------------------------------

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/993674

Message #15 received at 993674-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 993674-close@bugs.debian.org

Subject: Bug#993674: fixed in ga 5.8.1-1

Date: Sun, 13 Feb 2022 23:18:50 +0000

Source: ga
Source-Version: 5.8.1-1
Done: Drew Parsons <dparsons@debian.org>

We believe that the bug you reported is fixed in the latest version of
ga, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 993674@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Drew Parsons <dparsons@debian.org> (supplier of updated ga package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sun, 13 Feb 2022 23:12:40 +0100
Source: ga
Architecture: source
Version: 5.8.1-1
Distribution: unstable
Urgency: medium
Maintainer: Debichem Team <debichem-devel@lists.alioth.debian.org>
Changed-By: Drew Parsons <dparsons@debian.org>
Closes: 993674
Changes:
 ga (5.8.1-1) unstable; urgency=medium
 .
   * Team upload.
 .
   [ Drew Parsons ]
   * update debian/watch to watch releases/download links not tags
     (see https://github.com/GlobalArrays/ga/pull/240)
   * New upstream release.
   * provide a simple man page for ga-config (generated by help2man)
   * update debian/upstream/metadata to use Other-References not Homepage
     (see https://wiki.debian.org/UpstreamMetadata)
     Add Repository fields pointing to upstream github repo.
   * remove duplicate reference to armci/src/xfer/caccumulate.c in
     debian/copyright
   * Standards-Version: 4.6.0
   * debhelper compatibility level 13
     - mark uninstalled *.x and *.la files in debian/not-installed
   * configure with default path for armci to improve build
     reproducibility. Thanks Simon McVittie. Closes: #993674.
Checksums-Sha1:
 eca9903f328dfaccf3eed9a822b33dfc44091e64 1997 ga_5.8.1-1.dsc
 2ae61e448846960037d03659b3d03a9c8f81036d 6492890 ga_5.8.1.orig.tar.gz
 a81756c1d4d39e7de351edb84ad7dc6e63a073a7 8568 ga_5.8.1-1.debian.tar.xz
Checksums-Sha256:
 44337fccc383bde739a16f56505613da7fbde51241fb0ea4a9b7d1d78f67f3c3 1997 ga_5.8.1-1.dsc
 844639b52444f839854cf9735203a76a9052fd485f2d4eae70d21d03a7ecaade 6492890 ga_5.8.1.orig.tar.gz
 5bef20a21c033a49b2c8aa9e90b3ef576277b3d24b4903cabd6960d3b9c046a6 8568 ga_5.8.1-1.debian.tar.xz
Files:
 d7367971b792251ceb26a5a3b6a9a3b0 1997 science optional ga_5.8.1-1.dsc
 c1ff8f7409b9a12e85b60f919438baad 6492890 science optional ga_5.8.1.orig.tar.gz
 f3ab693d8e0c62f9c8815f8cadfd2035 8568 science optional ga_5.8.1-1.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEI8mpPlhYGekSbQo2Vz7x5L1aAfoFAmIJipQACgkQVz7x5L1a
Afpatw//bfNY508go57addyGiF6qaq/DraNcjuFlszNZF3p+JxGXyQdAm10ORm35
Q5U8JrdZIpuFGiaBqbwn0b1sja98MnviSJmUrlAqU/n3G34qzT6WFMIQRsJ+MPVf
VxDE4ubMyLxGWloyKiY8PgDGv60Zam6qbtFf2e8Gieb635/x45UaqsvX9hmCm/N+
Vq7tsIjS6Wmb8YQnhJlpCrMCu4wowtMqkQMgMQ466YpsMKYoi9cMncT6NzHKS9jr
hyoL0KbBdONC5kwxPhf+CO3BX01bum3Lng8Xz0CJXhmbwiVBjZfrat746ipPZpIB
Mf2Gjn8giqu80SK1uOEPnlUuqVqF8e+1YsuevN9wUP9zLfTNlPjAxDKHeUe7gBv9
lf5j4GjspJEYWhIxKJliIHMgwtg5soWVBe8ww3lgo1IoeBEfH7tmDYPtiWf9b7+9
DT0l5Hy208Saj2gzKuztpq1n+AKJwV//zn3o6ai9+RDkoz8S3JOZYLttQjyqyi4+
F11TEIz+ZCwn3VBEWtdII588ZaiMx4MfWErew7hJq9EMb3FSl1OOaGjS6HNbuMtR
70IxV7Y7w9nmLPjCGsXvFEphCB8QPabS1mSiR75nTmbHfzok5R1bVAWrPHRZk8Tn
Jjhg1cLz+oBSBVU0J1LqwcxLAFVvvZ7EAcsG4dk8w1FeDlX1HfI=
=3gS5
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.