Debian Bug report logs - #993304
samtools: please make the build reproducible

version graph

Package: src:samtools; Maintainer for src:samtools is Debian Med Packaging Team <debian-med-packaging@lists.alioth.debian.org>;

Reported by: "Chris Lamb" <lamby@debian.org>

Date: Mon, 30 Aug 2021 13:57:02 UTC

Severity: wishlist

Tags: patch

Found in version samtools/1.13-1

Fixed in version samtools/1.13-2

Done: Andreas Tille <tille@debian.org>

Bug is archived. No further changes may be made.

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, reproducible-bugs@lists.alioth.debian.org, Debian Med Packaging Team <debian-med-packaging@lists.alioth.debian.org>:
Bug#993304; Package src:samtools. (Mon, 30 Aug 2021 13:57:04 GMT) (full text, mbox, link).


Acknowledgement sent to "Chris Lamb" <lamby@debian.org>:
New Bug report received and forwarded. Copy sent to reproducible-bugs@lists.alioth.debian.org, Debian Med Packaging Team <debian-med-packaging@lists.alioth.debian.org>. (Mon, 30 Aug 2021 13:57:04 GMT) (full text, mbox, link).


Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>
To: submit@bugs.debian.org
Subject: samtools: please make the build reproducible
Date: Mon, 30 Aug 2021 14:55:21 +0100
[Message part 1 (text/plain, inline)]
Source: samtools
Version: 1.13-1
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0] we noticed that
samtools could not be built reproducibly.

This is because it includes the build flags in the binary to include
in --version output, but this will encode the buildpath due to
dpkg-buildflags(1) embedding (for example) -ffile-prefix-map.

Patch attached that normalises these paths to a placeholder entry
using sed(1).

 [0] https://reproducible-builds.org/


Regards,

--
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-
[samtools.diff.txt (text/plain, attachment)]

Reply sent to Andreas Tille <tille@debian.org>:
You have taken responsibility. (Mon, 30 Aug 2021 15:06:09 GMT) (full text, mbox, link).


Notification sent to "Chris Lamb" <lamby@debian.org>:
Bug acknowledged by developer. (Mon, 30 Aug 2021 15:06:09 GMT) (full text, mbox, link).


Message #10 received at 993304-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>
To: 993304-close@bugs.debian.org
Subject: Bug#993304: fixed in samtools 1.13-2
Date: Mon, 30 Aug 2021 15:03:53 +0000
Source: samtools
Source-Version: 1.13-2
Done: Andreas Tille <tille@debian.org>

We believe that the bug you reported is fixed in the latest version of
samtools, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 993304@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Andreas Tille <tille@debian.org> (supplier of updated samtools package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Mon, 30 Aug 2021 16:32:37 +0200
Source: samtools
Architecture: source
Version: 1.13-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Med Packaging Team <debian-med-packaging@lists.alioth.debian.org>
Changed-By: Andreas Tille <tille@debian.org>
Closes: 993304
Changes:
 samtools (1.13-2) unstable; urgency=medium
 .
   [ Étienne Mollier ]
   * d/control: bump B-D libhts-dev (>= 1.13~); builds otherwise break against
     older htslib versions.
 .
   [ Andreas Tille ]
   * make the build reproducible (Thanks for the patch to Chris Lamb)
     Closes: #993304
Checksums-Sha1:
 3583faa3cfb03a9424b2d2efb58583c300ae1762 2290 samtools_1.13-2.dsc
 83d77dce5c46721c7e15686aa06f5a57f910f46a 20600 samtools_1.13-2.debian.tar.xz
 15191f28cd20a04fc884131f046d1c352b81a3ef 7199 samtools_1.13-2_amd64.buildinfo
Checksums-Sha256:
 bb17e35ecad1711feace7392c3a67d000116866433b6b1765ca306621ad55499 2290 samtools_1.13-2.dsc
 c032291accc4201d51dbffd3af6fba038522fc9102b6558de1700fcbd4920842 20600 samtools_1.13-2.debian.tar.xz
 c71f3bebe84833d7e0d968ab1098ec710c27f592abdb48f6b03c6ae5651cd06e 7199 samtools_1.13-2_amd64.buildinfo
Files:
 d8ef89e3c7fe6983d5c0c9c0d2e63c2b 2290 science optional samtools_1.13-2.dsc
 51058b7f72bb9ce3f16b510b17e280d2 20600 science optional samtools_1.13-2.debian.tar.xz
 7bcaf6fbc54debcc3d4a0945a1ff424f 7199 science optional samtools_1.13-2_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJFBAEBCgAvFiEE8fAHMgoDVUHwpmPKV4oElNHGRtEFAmEs7L8RHHRpbGxlQGRl
Ymlhbi5vcmcACgkQV4oElNHGRtEX7A/8DcnCq0RJQYGo9/y0tTOpYcLoNSvmbOuu
udJ/aqjyCXbNZcq4FyiLxbvH1NvA/IYfnNQhcZyGyz2yTyKDEhcJ8xSbBwSmcDs0
XYB+/701PnNJ7aejw28e9LlRM+gUqVSmQn8jCKiEdQnEcxcG3lO5rOKtEB3eE5Me
Uv1sqG4/zZZqP/hLpj1m4s4qYpGOx4z0i6SSfXpb8/F24+EHsc8i10kh//zqQS9p
rJrdupksiuiTlLCxbdrsLkTNADhMxZrNXc/7A6ePReGYZcwflYV4GGabN0zlwwKU
EXNHHkpTfFplFD4j/0Q5Trs8W1UjFK3r+JnCDrytrouxoosroFyEYZOSxFB413qO
0wBP7h3RMDTYCCrcACB/r531jGvks2M2xOO7dM2hDB8RhemfuuY+lors2cdjoUB4
0onw1+ZCAscufLxaA4/hnQG55OcwR6IhAn94xq+RfvEquaXjflZBL7Fyfl/1goXD
euZP0RnMhKCWpffk51OM7fVjA5zUB/zzd78Ln97POlsTyYZ5XeLuTDC20U3BJ0cQ
RTu08nnbpsVNxrrlJI6EhgRLgyHBBynYyEy5wT81YXDHobyiYlJSDmr8OSlRjO6I
HbyHUUf5PT71iVJ2N189fSipOG5jGpCNRqUU1/c7D+ur9nsvg5lvH578ifjsDf/z
OHpYJVM7NDM=
=DTbF
-----END PGP SIGNATURE-----




Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Tue, 28 Sep 2021 07:24:53 GMT) (full text, mbox, link).


Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Wed May 17 12:04:21 2023; Machine Name: bembo

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.