Debian Bug report logs - #992060
pytsk: please make the build reproducible

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>

To: submit@bugs.debian.org

Subject: pytsk: please make the build reproducible

Date: Tue, 10 Aug 2021 11:34:57 +0100

[Message part 1 (text/plain, inline)]

Source: pytsk
Version: 20200117-3
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: randomness
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0] we noticed that
pytsk could not be built reproducibly.

This is because it generated a pytsk3.c file in a nondeterministic
manner, specifically by naively iterating over a Python set()
structure.

Patch attached.

 [0] https://reproducible-builds.org/


Regards,

--
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

[pytsk.diff.txt (text/plain, attachment)]

Message #12 received at 992060@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>

To: 992060@bugs.debian.org

Subject: Re: pytsk: please make the build reproducible

Date: Tue, 10 Aug 2021 06:42:46 -0400 (EDT)

forwarded 992060 https://github.com/py4n6/pytsk/pull/81
thanks

I've forwarded this upstream here:

  https://github.com/py4n6/pytsk/pull/81


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #19 received at 992060@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: 992060@bugs.debian.org

Subject: Re: Bug#992060: pytsk: please make the build reproducible

Date: Thu, 29 Dec 2022 11:31:27 -0800

[Message part 1 (text/plain, inline)]

Control: tags 992060 pending

On 2021-08-10, Chris Lamb wrote:
> Whilst working on the Reproducible Builds effort [0] we noticed that
> pytsk could not be built reproducibly.
>
> This is because it generated a pytsk3.c file in a nondeterministic
> manner, specifically by naively iterating over a Python set()
> structure.

I have uploaded an NMU to DELAYED/10 applying the patch included
upstream:

diff -Nru pytsk-20200117/debian/changelog pytsk-20200117/debian/changelog
--- pytsk-20200117/debian/changelog	2021-01-27 06:48:04.000000000 -0800
+++ pytsk-20200117/debian/changelog	2022-12-29 11:12:45.000000000 -0800
@@ -1,3 +1,13 @@
+pytsk (20200117-3.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+
+  [ Chris Lamb ]
+  * debian/patches: Changes to generation of pytsk3.c for reproducible
+    build (Closes: #992060)
+
+ -- Vagrant Cascadian <vagrant@reproducible-builds.org>  Thu, 29 Dec 2022 11:12:45 -0800
+
 pytsk (20200117-3) unstable; urgency=medium
 
   * Team upload.
diff -Nru pytsk-20200117/debian/patches/changes-to-generation-of-pytsk3.c-for-re.patch pytsk-20200117/debian/patches/changes-to-generation-of-pytsk3.c-for-re.patch
--- pytsk-20200117/debian/patches/changes-to-generation-of-pytsk3.c-for-re.patch	1969-12-31 16:00:00.000000000 -0800
+++ pytsk-20200117/debian/patches/changes-to-generation-of-pytsk3.c-for-re.patch	2022-12-29 11:12:45.000000000 -0800
@@ -0,0 +1,27 @@
+From: Chris Lamb <chris@chris-lamb.co.uk>
+Date: Tue, 10 Aug 2021 11:57:34 +0100
+X-Dgit-Generated: 20200117-3.1 986f3e5bd0dd74f93dca15637e2c1242c6546d76
+Subject: Changes to generation of pytsk3.c for reproducible build
+
+(Closes: #992060)
+
+Merged upstream as
+https://github.com/py4n6/pytsk/commit/f2b9ffa642a83127eb0e517a1f0ed4a22a99199a
+in pull request https://github.com/py4n6/pytsk/pull/81
+
+---
+
+--- pytsk-20200117.orig/class_parser.py
++++ pytsk-20200117/class_parser.py
+@@ -913,8 +913,9 @@ uint64_t integer_object_copy_to_uint64(P
+         for class_name in self.classes.keys():
+             self.initialise_class(class_name, out, done)
+ 
+-        # Add the constants in here
+-        for constant, type in self.constants:
++        # Add the constants here. Make sure they are sorted so builds
++        # of pytsk3.c are reproducible.
++        for constant, type in sorted(self.constants):
+             if type == "integer":
+                 out.write(
+                     "    tmp = PyLong_FromUnsignedLongLong((uint64_t) {0:s});\n".format(constant))
diff -Nru pytsk-20200117/debian/patches/series pytsk-20200117/debian/patches/series
--- pytsk-20200117/debian/patches/series	2021-01-27 06:48:04.000000000 -0800
+++ pytsk-20200117/debian/patches/series	2022-12-29 11:12:45.000000000 -0800
@@ -1,2 +1,3 @@
 0001-Link-system-tsk-statically-talloc-dynamically-instea.patch
 change-lexer.patch
+changes-to-generation-of-pytsk3.c-for-re.patch


live well,
  vagrant

[signature.asc (application/pgp-signature, inline)]

Message #26 received at 992060@bugs.debian.org (full text, mbox, reply):

From: Hilko Bengen <bengen@debian.org>

To: Vagrant Cascadian <vagrant@reproducible-builds.org>

Cc: 992060@bugs.debian.org

Subject: Re: Bug#992060: pytsk: please make the build reproducible

Date: Thu, 29 Dec 2022 21:55:24 +0100

* Vagrant Cascadian:

> I have uploaded an NMU to DELAYED/10 applying the patch included
> upstream:

Looks good to me. Feel free to reschedule the upload to hit unstable
immediately.

Cheers,
-Hilko

Message #31 received at 992060@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: Hilko Bengen <bengen@debian.org>

Cc: 992060@bugs.debian.org

Subject: Re: Bug#992060: pytsk: please make the build reproducible

Date: Thu, 29 Dec 2022 13:17:33 -0800

[Message part 1 (text/plain, inline)]

On 2022-12-29, Hilko Bengen wrote:
> * Vagrant Cascadian:
>
>> I have uploaded an NMU to DELAYED/10 applying the patch included
>> upstream:
>
> Looks good to me. Feel free to reschedule the upload to hit unstable
> immediately.

Thanks... rescheduled!

live well,
  vagrant

[signature.asc (application/pgp-signature, inline)]

Message #36 received at 992060-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 992060-close@bugs.debian.org

Subject: Bug#992060: fixed in pytsk 20200117-3.1

Date: Thu, 29 Dec 2022 21:35:17 +0000

Source: pytsk
Source-Version: 20200117-3.1
Done: Vagrant Cascadian <vagrant@reproducible-builds.org>

We believe that the bug you reported is fixed in the latest version of
pytsk, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 992060@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Vagrant Cascadian <vagrant@reproducible-builds.org> (supplier of updated pytsk package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Thu, 29 Dec 2022 11:12:45 -0800
Source: pytsk
Architecture: source
Version: 20200117-3.1
Distribution: unstable
Urgency: medium
Maintainer: Debian Security Tools <team+pkg-security@tracker.debian.org>
Changed-By: Vagrant Cascadian <vagrant@reproducible-builds.org>
Closes: 992060
Changes:
 pytsk (20200117-3.1) unstable; urgency=medium
 .
   * Non-maintainer upload.
 .
   [ Chris Lamb ]
   * debian/patches: Changes to generation of pytsk3.c for reproducible
     build (Closes: #992060)
Checksums-Sha1:
 e4255516ac6930476a41186c57ef6b0b378ea3ac 1626 pytsk_20200117-3.1.dsc
 a5d6204f77988f3a513e1c2e364d33d7568fb796 7792 pytsk_20200117-3.1.debian.tar.xz
Checksums-Sha256:
 6091c663e26f39eef7d0e04fb08ec00852bdbb8a937941e68545e6beff6bfd01 1626 pytsk_20200117-3.1.dsc
 52d25fb1637c294e8a9045e4704ab275b8df3f5278379f91516255c31923ec65 7792 pytsk_20200117-3.1.debian.tar.xz
Files:
 135371820761e3f1475a86dea3a039f0 1626 python optional pytsk_20200117-3.1.dsc
 91ee31e24fbbc7c38431c3fbfa458783 7792 python optional pytsk_20200117-3.1.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iJYEARYKAD4WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCY63qFSAcdmFncmFudEBy
ZXByb2R1Y2libGUtYnVpbGRzLm9yZwAKCRDcUY/If5cWqpsoAP4z64LCe93Ol0Yl
iKINHIS+e8kyr06TzJ1NPcC2gKEeowD/aPuN8Q8qeAd/1rPrpDuZ2x9/kKHrXVfm
/k2yKLRm3gQ=
=iP2E
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.