Debian Bug report logs - #991927
grub2: reproducible builds: embeds /bin/sh or /bin/bash depending on /bin/sh symlink

Reply or subscribe to this bug.

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: submit@bugs.debian.org

Subject: grub2: reproducible builds: embeds /bin/sh or /bin/bash depending on /bin/sh symlink

Date: Thu, 05 Aug 2021 15:04:45 -0700

[Message part 1 (text/plain, inline)]

Source: grub2
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: shell
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Various modinfo.sh files embed either /bin/bash or /bin/sh depending on
what the /bin/sh symlink points to:

  https://tests.reproducible-builds.org/debian/rb-pkg/bullseye/amd64/diffoscope-results/grub2.html

  ./usr/lib/grub/i386-coreboot/modinfo.sh

  #!/bin/bash
  vs.
  #!/bin/sh


The attached patch fixes this by passing SHELL=/bin/bash to configure in
debian/rules.
 

There are still several other outstanding issues affecting the
reproducibility of grub2, but this should help reduce the differences to
troubleshoot the remaining issues.


Thanks for maintaining grub2!


live well,
  vagrant

[0001-debian-rules-pass-SHELL-bin-bash-to-configure.patch (text/x-diff, inline)]

From fd07d6a7baf460de36e29f4cb994200f2ad731d3 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Sun, 25 Jul 2021 23:03:37 +0000
Subject: [PATCH 1/3] debian/rules: pass SHELL=/bin/bash to configure.

The /bin/sh symlink may affect weather /bin/bash or /bin/sh is
embedded in various modinfo.sh files.

The configure script apparently is looking for features or behavior
that might not be available in all shells, and falls back to using
bash when /bin/sh does not support the desired functionality.
---
 debian/rules | 1 +
 1 file changed, 1 insertion(+)

diff --git a/debian/rules b/debian/rules
index be8f870c8..33309f333 100755
--- a/debian/rules
+++ b/debian/rules
@@ -44,6 +44,7 @@ CC := gcc-10
 confflags = \
 	PACKAGE_VERSION="$(deb_version)" PACKAGE_STRING="GRUB $(deb_version)" \
 	CC=$(CC) TARGET_CC=$(CC) \
+	SHELL=/bin/bash \
 	--libdir=\$${prefix}/lib --libexecdir=\$${prefix}/lib \
 	--enable-grub-mkfont \
 	--disable-grub-emu-usb
-- 
2.32.0

[signature.asc (application/pgp-signature, inline)]

Send a report that this bug log contains spam.