Debian Bug report logs - #991285
unblock: strip-nondeterminism/1.12-0.1

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Holger Levsen <holger@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: unblock: strip-nondeterminism/1.12-0.1

Date: Mon, 19 Jul 2021 20:19:29 +0200

[Message part 1 (text/plain, inline)]

Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
x-debbugs-cc: reproducible-builds@lists.alioth.debian.org

Hi,

I'm wondering whether it makes sense to unblock strip-nondeterminism 1.12.0-1,
which has been uploaded on 2021-05-07 and which since then (or rather shortly after)
has been used on the buildds when building packages. There haven't been any bugs
filed since the upload and the changes are pretty small:

strip-nondeterminism (1.12.0-1) unstable; urgency=medium

  [ Chris Lamb ]
  * Support normalising Python "pyzip" files -- ie. zip-compressed .py files
    with a regular Python shebang. (Closes: reproducible-builds/strip-nondeterminism#18)
  * Drop single-debian-patch, etc.

  [ Bernhard M. Wiedemann ]
  * Move exception handling closer to call using perl's "//" operator.

The debdiffstat is:

 debdiff strip-nondeterminism_1.11.0-1.dsc strip-nondeterminism_1.12.0-1.dsc|diffstat
 debian/changelog                               |   12 ++
 debian/source/options                          |    1 
 debian/source/patch-header                     |   17 ----
 lib/File/StripNondeterminism.pm                |   11 ++
 lib/File/StripNondeterminism/handlers/pyzip.pm |  106 +++++++++++++++++++++++++
 5 files changed, 128 insertions(+), 19 deletions(-)

and the full debdiff is attached.

Rather obviously this more or less against the freeze guidelines but given the
fact that it's been used in many bullseye builds during the freeze I thought
I'd ask.
And I decided to ask via a bug report. Feel free to close or unblock :)

(And before you ask: I don't really know why I didn't file this unblock request
earlier. I guess it's because the change is not soo relevant but then I somehow
continued to be bothered by the fact that bullseye is build with packages from
out of bullseye and so I finally decided to ask anyway.)

unblock strip-nondeterminism/1.12-0.1

and thank you for releasing bullseye and dealing with requests like these! ;)


-- 
cheers,
	Holger

 ⢀⣴⠾⠻⢶⣦⠀
 ⣾⠁⢠⠒⠀⣿⡁  holger@(debian|reproducible-builds|layer-acht).org
 ⢿⡄⠘⠷⠚⠋⠀  OpenPGP: B8BF54137B09D35CF026FE9D 091AB856069AAA1C
 ⠈⠳⣄

"A developed country is not a place where the poor have cars. It's where the
rich use public transportation." (quote attributed to several people)

[strip-nondeterminism_1.12.0-1.diff (text/x-diff, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 991285@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>

To: "Holger Levsen" <holger@debian.org>, 991285@bugs.debian.org

Subject: Re: Bug#991285: unblock: strip-nondeterminism/1.12-0.1

Date: Tue, 20 Jul 2021 09:45:49 +0100

Holger Levsen wrote:

> strip-nondeterminism (1.12.0-1) unstable; urgency=medium
>
>   [ Chris Lamb ]
>   * Support normalising Python "pyzip" files -- ie. zip-compressed .py files
>     with a regular Python shebang. (Closes:  reproducible-builds/strip-nondeterminism#18)
>   * Drop single-debian-patch, etc.
>
>   [ Bernhard M. Wiedemann ]
>   * Move exception handling closer to call using perl's "//" operator.

As the author/merger of these changes, I would support an unblock and
have no reason to suspect that this might cause a regression,
especially given the codepaths that were modified.

However, the problems that this version fixes are relatively minor and
were actually to address issues that were initially discovered in
openSUSE, not Debian. They do affect Debian, but this remark provides
some insight on the impact of the issue in Debian itself.

However, as Holger mentions, the strongest argument for an unblock is
the following:

> Rather obviously this more or less against the freeze guidelines but given the
> fact that it's been used in many bullseye builds during the freeze  [...]

Either way though, it's always nice to minimise the diff, but I would
perfectly understand if this is rather too late.


Regards,

--
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org 🍥 chris-lamb.co.uk
       `-

Message #15 received at 991285-done@bugs.debian.org (full text, mbox, reply):

From: Graham Inggs <ginggs@debian.org>

To: Chris Lamb <lamby@debian.org>, 991285-done@bugs.debian.org, Holger Levsen <holger@debian.org>

Subject: Re: Bug#991285: unblock: strip-nondeterminism/1.12-0.1

Date: Tue, 20 Jul 2021 11:33:40 +0200

Unblocked.

Send a report that this bug log contains spam.