Debian Bug report logs - #991177
libdebian-installer: reproducible builds: Embeds build path in libdebian-installer-extra.so.*

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: submit@bugs.debian.org

Subject: libdebian-installer: reproducible builds: Embeds build path in libdebian-installer-extra.so.*

Date: Fri, 16 Jul 2021 07:13:05 -0700

[Message part 1 (text/plain, inline)]

Source: libdebian-installer
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The build path is embedded in various places in
libdebian-installer-extra.so.*:

  https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/libdebian-installer.html

  ./usr/lib/x86_64-linux-gnu/libdebian-installer-extra.so.4.0.8 

  /build/1st/libdebian-installer-0.121/build/src/../../src/list.c:30
  vs.
  /build/2/libdebian-installer-0.121/2nd/build/src/../../src/list.c:30

The attached patch fixes this by passing -ffile-prefix-map to CFLAGS in
debian/rules.

Alternately, with recent versions of dpkg, using dpkg-buildflags to set
CFLAGS should pass this option by default.


Thanks for maintaining libdebian-installer!


live well,
  vagrant

[0001-debian-rules-Add-ffile-prefix-map-to-CFLAGS.patch (text/x-diff, inline)]

From 5222acd3ccb659da12cb877398375ceab2a44388 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Fri, 16 Jul 2021 13:59:17 +0000
Subject: [PATCH] debian/rules: Add -ffile-prefix-map to CFLAGS.

This avoids embedding the build path in the resulting binaries and
debug symbols.

https://reproducible-builds.org/docs/build-path/
---
 debian/rules | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/debian/rules b/debian/rules
index 7307a7b..0f394c2 100755
--- a/debian/rules
+++ b/debian/rules
@@ -8,6 +8,10 @@ DEB_HOST_ARCH_OS    := $(shell dpkg-architecture -qDEB_HOST_ARCH_OS 2>/dev/null)
 #CFLAGS = -Wall -W -Werror -ggdb -Wstrict-prototypes -Wmissing-declarations -Wmissing-prototypes
 CFLAGS = -Wall -W -ggdb -Wmissing-declarations
 
+# Avoid embedding build paths in the binaries
+# https://reproducible-builds.org/docs/build-path/
+CFLAGS += -ffile-prefix-map=$(CURDIR)=.
+
 ifneq (,$(findstring noopt,$(DEB_BUILD_OPTIONS)))
 	CFLAGS += -O0
 else
-- 
2.32.0

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 991177@bugs.debian.org (full text, mbox, reply):

From: Cyril Brulebois <kibi@debian.org>

To: Vagrant Cascadian <vagrant@reproducible-builds.org>, 991177@bugs.debian.org

Subject: Re: Bug#991177: libdebian-installer: reproducible builds: Embeds build path in libdebian-installer-extra.so.*

Date: Fri, 16 Jul 2021 20:31:23 +0200

[Message part 1 (text/plain, inline)]

Hello,

Vagrant Cascadian <vagrant@reproducible-builds.org> (2021-07-16):
> The build path is embedded in various places in
> libdebian-installer-extra.so.*:
> 
>   https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/libdebian-installer.html
> 
>   ./usr/lib/x86_64-linux-gnu/libdebian-installer-extra.so.4.0.8 
> 
>   /build/1st/libdebian-installer-0.121/build/src/../../src/list.c:30
>   vs.
>   /build/2/libdebian-installer-0.121/2nd/build/src/../../src/list.c:30
> 
> The attached patch fixes this by passing -ffile-prefix-map to CFLAGS in
> debian/rules.
> 
> Alternately, with recent versions of dpkg, using dpkg-buildflags to set
> CFLAGS should pass this option by default.
> 
> 
> Thanks for maintaining libdebian-installer!

I know we haven't always been stellar when it comes to merging repro
build work, sorry about that. Any chance you could chase^Wremind us
about such issues once Bullseye (r0, and maybe r1) is out the door?

Thanks already!


Cheers,
-- 
Cyril Brulebois (kibi@debian.org)            <https://debamax.com/>
D-I release manager -- Release team member -- Freelance Consultant

[signature.asc (application/pgp-signature, inline)]

Message #15 received at 991177@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: Cyril Brulebois <kibi@debian.org>, 991177@bugs.debian.org

Subject: Re: Bug#991177: libdebian-installer: reproducible builds: Embeds build path in libdebian-installer-extra.so.*

Date: Sun, 18 Jul 2021 14:40:51 -0700

[Message part 1 (text/plain, inline)]

On 2021-07-16, Cyril Brulebois wrote:
> Vagrant Cascadian <vagrant@reproducible-builds.org> (2021-07-16):
>> The build path is embedded in various places in
>> libdebian-installer-extra.so.*:
>> 
>>   https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/libdebian-installer.html
>> 
>>   ./usr/lib/x86_64-linux-gnu/libdebian-installer-extra.so.4.0.8 
>> 
>>   /build/1st/libdebian-installer-0.121/build/src/../../src/list.c:30
>>   vs.
>>   /build/2/libdebian-installer-0.121/2nd/build/src/../../src/list.c:30
>> 
>> The attached patch fixes this by passing -ffile-prefix-map to CFLAGS in
>> debian/rules.
>> 
>> Alternately, with recent versions of dpkg, using dpkg-buildflags to set
>> CFLAGS should pass this option by default.
>> 
>> 
>> Thanks for maintaining libdebian-installer!
>
> I know we haven't always been stellar when it comes to merging repro
> build work, sorry about that. Any chance you could chase^Wremind us
> about such issues once Bullseye (r0, and maybe r1) is out the door?

Sure, will gently nudge sometime early in the bookworm development
cycle...


live well,
  vagrant

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 991177@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: Cyril Brulebois <kibi@debian.org>, 991177@bugs.debian.org

Subject: Re: Bug#991177: libdebian-installer: reproducible builds: Embeds build path in libdebian-installer-extra.so.*

Date: Sat, 16 Oct 2021 15:59:39 -0700

[Message part 1 (text/plain, inline)]

On 2021-07-16, Cyril Brulebois wrote:
> Vagrant Cascadian <vagrant@reproducible-builds.org> (2021-07-16):
>> The build path is embedded in various places in
>> libdebian-installer-extra.so.*:
>> 
>>   https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/libdebian-installer.html
>> 
>>   ./usr/lib/x86_64-linux-gnu/libdebian-installer-extra.so.4.0.8 
>> 
>>   /build/1st/libdebian-installer-0.121/build/src/../../src/list.c:30
>>   vs.
>>   /build/2/libdebian-installer-0.121/2nd/build/src/../../src/list.c:30
>> 
>> The attached patch fixes this by passing -ffile-prefix-map to CFLAGS in
>> debian/rules.
>> 
>> Alternately, with recent versions of dpkg, using dpkg-buildflags to set
>> CFLAGS should pass this option by default.
>> 
>> 
>> Thanks for maintaining libdebian-installer!
>
> I know we haven't always been stellar when it comes to merging repro
> build work, sorry about that. Any chance you could chase^Wremind us
> about such issues once Bullseye (r0, and maybe r1) is out the door?

The long-awaited requested reminder... is here! :)


live well,
  vagrant

[signature.asc (application/pgp-signature, inline)]

Message #25 received at 991177@bugs.debian.org (full text, mbox, reply):

From: Cyril Brulebois <kibi@debian.org>

To: Vagrant Cascadian <vagrant@reproducible-builds.org>

Cc: 991177@bugs.debian.org

Subject: Re: Bug#991177: libdebian-installer: reproducible builds: Embeds build path in libdebian-installer-extra.so.*

Date: Sun, 17 Oct 2021 19:05:54 +0200

[Message part 1 (text/plain, inline)]

Vagrant Cascadian <vagrant@reproducible-builds.org> (2021-10-16):
> On 2021-07-16, Cyril Brulebois wrote:
> > I know we haven't always been stellar when it comes to merging repro
> > build work, sorry about that. Any chance you could chase^Wremind us
> > about such issues once Bullseye (r0, and maybe r1) is out the door?
> 
> The long-awaited requested reminder... is here! :)

Thanks, the patch no longer applies cleanly (some fuzz, can be applied
trivially anyway, no need to resubmit), and I do wonder whether Samuel's
commit[1] doesn't make the issue go away on its own: CFLAGS is now
inherited from the environment, and I'm seeing the flag you're proposing
to add in various Makefile (and related) files after a build.

 1. https://salsa.debian.org/installer-team/libdebian-installer/-/commit/aaaa4b679de89592dccb6446637498e619738ee1

Any chance you could check whether current master is fine, please?


Cheers,
-- 
Cyril Brulebois (kibi@debian.org)            <https://debamax.com/>
D-I release manager -- Release team member -- Freelance Consultant

[signature.asc (application/pgp-signature, inline)]

Message #30 received at 991177@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: Cyril Brulebois <kibi@debian.org>

Cc: 991177@bugs.debian.org

Subject: Re: Bug#991177: libdebian-installer: reproducible builds: Embeds build path in libdebian-installer-extra.so.*

Date: Sun, 17 Oct 2021 10:19:16 -0700

[Message part 1 (text/plain, inline)]

On 2021-10-17, Cyril Brulebois wrote:
> Vagrant Cascadian <vagrant@reproducible-builds.org> (2021-10-16):
>> On 2021-07-16, Cyril Brulebois wrote:
>> > I know we haven't always been stellar when it comes to merging repro
>> > build work, sorry about that. Any chance you could chase^Wremind us
>> > about such issues once Bullseye (r0, and maybe r1) is out the door?
>> 
>> The long-awaited requested reminder... is here! :)
>
> Thanks, the patch no longer applies cleanly (some fuzz, can be applied
> trivially anyway, no need to resubmit), and I do wonder whether Samuel's
> commit[1] doesn't make the issue go away on its own: CFLAGS is now
> inherited from the environment, and I'm seeing the flag you're proposing
> to add in various Makefile (and related) files after a build.
>
>  1. https://salsa.debian.org/installer-team/libdebian-installer/-/commit/aaaa4b679de89592dccb6446637498e619738ee1
>
> Any chance you could check whether current master is fine, please?

Yes, that fixes the issue, great!

Just need to add the appropriate Closes line in debian/changelog and be
done with it, then. :)


live well,
  vagrant

[signature.asc (application/pgp-signature, inline)]

Message #35 received at 991177@bugs.debian.org (full text, mbox, reply):

From: Cyril Brulebois <kibi@debian.org>

To: Vagrant Cascadian <vagrant@reproducible-builds.org>, 991177@bugs.debian.org

Subject: Re: Bug#991177: libdebian-installer: reproducible builds: Embeds build path in libdebian-installer-extra.so.*

Date: Tue, 19 Oct 2021 14:02:19 +0200

[Message part 1 (text/plain, inline)]

Vagrant Cascadian <vagrant@reproducible-builds.org> (2021-10-17):
> Yes, that fixes the issue, great!

Thanks for confirming.

> Just need to add the appropriate Closes line in debian/changelog and
> be done with it, then. :)

Yeah, uploaded.

If you have other rb.o things on your radar, feel free to ping the
relevant bugs, cc-ing me.


Cheers,
-- 
Cyril Brulebois (kibi@debian.org)            <https://debamax.com/>
D-I release manager -- Release team member -- Freelance Consultant

[signature.asc (application/pgp-signature, inline)]

Message #40 received at 991177-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 991177-close@bugs.debian.org

Subject: Bug#991177: fixed in libdebian-installer 0.122

Date: Tue, 19 Oct 2021 12:18:42 +0000

Source: libdebian-installer
Source-Version: 0.122
Done: Cyril Brulebois <kibi@debian.org>

We believe that the bug you reported is fixed in the latest version of
libdebian-installer, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 991177@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Cyril Brulebois <kibi@debian.org> (supplier of updated libdebian-installer package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Tue, 19 Oct 2021 13:55:29 +0200
Source: libdebian-installer
Architecture: source
Version: 0.122
Distribution: unstable
Urgency: medium
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Cyril Brulebois <kibi@debian.org>
Closes: 991177
Changes:
 libdebian-installer (0.122) unstable; urgency=medium
 .
   [ Samuel Thibault ]
   * debian/rules: Inherit CFLAGS from environment. That includes the
     -ffile-prefix-map= option (as pointed out by Vagrant Cascadian,
     thanks!), making the build reproducible. Closes: #991177
Checksums-Sha1:
 6f3600de79958623ca678826f8b4c04e2581470f 2213 libdebian-installer_0.122.dsc
 c1d488805c7a1b0e3a83087c166b06cedfa178b7 72328 libdebian-installer_0.122.tar.xz
 54aa7f368fc09cf94ea4d02be543a3819e79f526 6340 libdebian-installer_0.122_source.buildinfo
Checksums-Sha256:
 6c9842ae754b1ea4f466d052f9389ecc70b659ae043aef84a9d571adc695c6c8 2213 libdebian-installer_0.122.dsc
 f465d8e92f4a6178c9c9ccdbc1da8cbf2091b743a326aa49e2c336caf0fbe393 72328 libdebian-installer_0.122.tar.xz
 e327abf7f002476e0bdbe7549ac322b003c2f5fcd4e0f338f523027931177dda 6340 libdebian-installer_0.122_source.buildinfo
Files:
 104e81cdcacca6c7d154607b175e7c0c 2213 libs optional libdebian-installer_0.122.dsc
 2929f70c3b4f55a54f24c50367482723 72328 libs optional libdebian-installer_0.122.tar.xz
 5adb00dac115093bca8bcb5b8e36efa0 6340 libs optional libdebian-installer_0.122_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJEBAEBCgAuFiEEtg6/KYRFPHDXTPR4/5FK8MKzVSAFAmFus2sQHGtpYmlAZGVi
aWFuLm9yZwAKCRD/kUrwwrNVIO3VD/9be0eq5UU1oe5jZKfpRoWliYrPsrWVa7Rw
0Pq4Pw+XSno8Up933mJRjfsulsOM31nYp/KPYZAGsphZqqXLF6rdPjFigd1h+cC5
rXadOEKEOpCjBVpwevO0L7DcbrN6U37fotIOzzlqy07LUR5ZT3VXTJFTMmd3yCDF
jnknHY2K9tBvKq81nExX6MH3Ajh0+tfhsHjyQBqRl6OnWZBIY56tF/P+69yGTNeQ
/CWJ3e6W3Fyki0DMtk6euK5AM0rg+hoR7JkocRXCWDXcR0EP/NvpB1SQEb1MAIJP
hE4KNHI+8mEr6hJx2l+MbS5q6XMSdCKIwEw8omGqKUdgVCTU2aIeY4ncNoveGeiw
DcRjUGYYTkVfhnuc6Is+oZ6tJQvZsfuFaiE1ZwiGA7r9Y9nrZ1s1Ar7p2P5UFkWn
FwGth+pBjQrQKhK5z6mbt+A9A+hnaVRkLfxwFkGEQUlF5GfQJEzYRAdcu/oP9k6r
3dS1XpWjTFvjFMdW4RgiKqaBD2iFPaa5q5WNPX6Tp3YZx9NV5hGZ8SAzqq9r64h2
Aq6v7SDK+B2B7vNMxfIawwgpCRVrHMVWsmgvzOLDAxUv9te8c8R7IP5Odxp05wvl
GZNDCZwlBQULLsWN8u3nKXhpAiVUZqQpvxv6KJrY6Bs9teW+iRw5KmJQ4Md34nEB
xM0AnGS/EA==
=W07K
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.