Debian Bug report logs - #991104
antlr: reproducible-builds: Example Makefiles embed build paths and binary paths

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: submit@bugs.debian.org

Subject: antlr: reproducible-builds: Example Makefiles embed build paths and binary paths

Date: Wed, 14 Jul 2021 07:37:58 -0700

[Message part 1 (text/plain, inline)]

Source: antlr
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath usrmerge
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The build path and several binary paths are embedded in example Makefiles
shipped in the package:

  https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/antlr.html

  ./usr/share/doc/antlr/examples/Makefile

  MKDIR···········=·/bin/mkdir
  vs.
  MKDIR···········=·/usr/bin/mkdir

  ANTLR_JAR······=·/build/1st/antlr-2.7.7+dfsg/antlr/antlr.jar
  vs.
  ANTLR_JAR······=·/build/2/antlr-2.7.7+dfsg/2nd/antlr/antlr.jar

Since these values may differ with the installed system, in order to use
the example Makefile, a person would have to regenerate it from
Makefile.in, which is also provided in the package.

The attached patch modifies debian/rules to remove the exmaple
Makefiles.


With this patch applied (and some timestamp related patches i will
submit shortly...) antlr should become reproducible on
tests.reproducible-builds.org.


If removing the Makefiles is somehow not an option, an alternate option
would be to sanitize the Makefiles stripping the build path, and
possibly passing various variables to configure (e.g. GREP=/bin/grep,
SHELL=/bin/sh, ...).


Thanks for maintaining antlr!


live well,
  vagrant

[0001-debian-rules-Do-not-install-example-Makefiles.patch (text/x-diff, inline)]

From 30308f6a4b3c6907f0f89d7e37512a1b647a3cd7 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Wed, 14 Jul 2021 14:14:06 +0000
Subject: [PATCH 1/3] debian/rules: Do not install example Makefiles.

The build path and several binary paths are embedded Makefiles shipped
in the package.

Since these values may differ with the installed system, in order to
use the example Makefile, a person would have to regenerate it from
Makefile.in, which is included in the package.
---
 debian/rules | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/debian/rules b/debian/rules
index 77396e35..c1e9921c 100755
--- a/debian/rules
+++ b/debian/rules
@@ -46,6 +46,8 @@ override_dh_installdocs:
 override_dh_installexamples:
 	dh_installexamples
 	find debian/antlr-doc/usr/share/doc/antlr/examples -type f -print | xargs -r chmod 0644
+	# Remove example Makefiles containing build paths and binary paths
+	find debian/antlr-doc/usr/share/doc/antlr/examples -name Makefile -print -delete
 	rm -rf debian/antlr-doc/usr/share/doc/antlr/examples/csharp
 
 override_dh_auto_clean:
-- 
2.32.0

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 991104@bugs.debian.org (full text, mbox, reply):

From: tony mancill <tmancill@debian.org>

To: Vagrant Cascadian <vagrant@reproducible-builds.org>, 991104@bugs.debian.org

Subject: Re: Bug#991104: antlr: reproducible-builds: Example Makefiles embed build paths and binary paths

Date: Tue, 10 Aug 2021 19:54:51 -0700

[Message part 1 (text/plain, inline)]

Hi Vagrant!

On Wed, Jul 14, 2021 at 07:37:58AM -0700, Vagrant Cascadian wrote:
> Source: antlr
> Severity: normal
> Tags: patch
> User: reproducible-builds@lists.alioth.debian.org
> Usertags: buildpath usrmerge
> X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org
> 
> The build path and several binary paths are embedded in example Makefiles
> shipped in the package:

Right... I can't imagine why a user would want to have these in
installed as examples.  They seem more like build artifacts.  Thanks for
the patch.

I will prepare a new upload of antlr real soon now.

> If removing the Makefiles is somehow not an option, an alternate option
> would be to sanitize the Makefiles stripping the build path, and
> possibly passing various variables to configure (e.g. GREP=/bin/grep,
> SHELL=/bin/sh, ...).

Sanitization sounds like a good plan, if there ends up being a use case.

Cheers,
tony

[signature.asc (application/pgp-signature, inline)]

Message #13 received at 991104-submitter@bugs.debian.org (full text, mbox, reply):

From: Tony Mancill <noreply@salsa.debian.org>

To: 991104-submitter@bugs.debian.org

Subject: Bug#991104 marked as pending in antlr

Date: Wed, 11 Aug 2021 03:56:40 +0000

Control: tag -1 pending

Hello,

Bug #991104 in antlr reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/java-team/antlr/-/commit/e28c91f14ddd3a2cfef31f452c0b923ac740fca4

------------------------------------------------------------------------
debian/rules: Do not install example Makefiles (Closes: #991104)
------------------------------------------------------------------------

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/991104

Message #20 received at 991104-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 991104-close@bugs.debian.org

Subject: Bug#991104: fixed in antlr 2.7.7+dfsg-11

Date: Fri, 20 Aug 2021 04:33:57 +0000

Source: antlr
Source-Version: 2.7.7+dfsg-11
Done: tony mancill <tmancill@debian.org>

We believe that the bug you reported is fixed in the latest version of
antlr, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 991104@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
tony mancill <tmancill@debian.org> (supplier of updated antlr package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Thu, 19 Aug 2021 20:39:15 -0700
Source: antlr
Architecture: source
Version: 2.7.7+dfsg-11
Distribution: unstable
Urgency: medium
Maintainer: Debian Java Maintainers <pkg-java-maintainers@lists.alioth.debian.org>
Changed-By: tony mancill <tmancill@debian.org>
Closes: 991104 991106
Changes:
 antlr (2.7.7+dfsg-11) unstable; urgency=medium
 .
   * Add patches for reproducible builds:
     - Do not install example Makefiles (Closes: #991104)
     - Predictable timestamps in .jar file (Closes: #991106)
     Thanks to Vagrant Cascadian for the patches.
   * antlr-doc and libantlr-java are Multi-Arch: foreign
   * Bump Standards-Version to 4.5.1
   * Use debhelper-compat 13
   * Freshen debian/copyright
   * Add myself to Uploaders
Checksums-Sha1:
 7b69be57c5a54bc5ed3f08027564bfa75b4a96d7 2295 antlr_2.7.7+dfsg-11.dsc
 bee343931d8e2cc831ab16c7a5d30e76ce3624cf 15536 antlr_2.7.7+dfsg-11.debian.tar.xz
 089fbaed46c7667f0479fa930cd031bdfa31892d 10334 antlr_2.7.7+dfsg-11_amd64.buildinfo
Checksums-Sha256:
 c3602caeef055462644ff41c00090d3f70c10d55b8ab73eb5dc556fec09a6a59 2295 antlr_2.7.7+dfsg-11.dsc
 519396e88fb92db24462408a86776301adaa86855702929db324efc66d41b357 15536 antlr_2.7.7+dfsg-11.debian.tar.xz
 19341458d1154a04b08bdfa4d334f50ab1a313dbe78d2c1c751b35ff8cd4e4dc 10334 antlr_2.7.7+dfsg-11_amd64.buildinfo
Files:
 2624b868cf14cb2abaffa71a67caad97 2295 java optional antlr_2.7.7+dfsg-11.dsc
 6586aa840438cfea752821734635eb6e 15536 java optional antlr_2.7.7+dfsg-11.debian.tar.xz
 735b1af163df04fcb44e3d3feddb7e87 10334 java optional antlr_2.7.7+dfsg-11_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJIBAEBCgAyFiEE5Qr9Va3SequXFjqLIdIFiZdLPpYFAmEfJ98UHHRtYW5jaWxs
QGRlYmlhbi5vcmcACgkQIdIFiZdLPpZeTQ/+N8I7FxdX7NGm+U9ZW2vaLG4L3cAv
uEOj5JAgsRrq2Fa0nFXV8IyeZ44sgdnFB7tvzFpVkbzM4e4mRmLyT0CE7ervAvsw
ek8Hud5wL7CI5rhY7iFE/DyFV8ueatJIUAS4whGedwPjK7nF9CR//fiKxpxw1koM
MvbjRCfSsPANI2OLeiUuGdWwfczZUjOcfRH70qBgIR5MiD9LVwXiLCE0i04cyELE
MZZNpotH58hOM3e3Q4pjCTUguSNuWNO4iwnEMXMPUGTqVShqi59GO0jgMjSdJHRG
D3akmeCmfV1JfvYdDna6CSc3S02p3+6fr9d+srlgEhWtdsR/oQnwFZL9de92cw7y
DyFZRoUvN/TK7PCtTOTeaknjicV0/CPFlI+0YnjAEdk6JPwzno038n9WqCeeKd+H
OCS6xvd/WX0oqs3sKMQm8f2/P4JvYRH9Jx6wAVVQRG6Llq22MzQaLuQZlGt9ZGEe
nBF+rQUZhS10fD9kYNQRoSiqApN5MCSOAH9Y71R5Sm9pGQRvGpCQZj47+3iuSLxq
v22DJdh/+04LRHUuZloTRZa3gQSiZZigYFoLj260czi6RcRrR34s65JFnrUkLvEp
6gBVpRBSk2y9Huc67ETKqJnfoIzpTee6whOaVlbP2WDJU5GjYQBUv7W8Xl36vebZ
m1kOITVjiGLiM1o=
=SMrO
-----END PGP SIGNATURE-----

Message #25 received at 991104@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: 991104@bugs.debian.org

Cc: tmancill@debian.org

Subject: Re: antlr: reproducible-builds: Example Makefiles embed build paths and binary paths

Date: Fri, 20 Aug 2021 00:04:57 -0700

[Message part 1 (text/plain, inline)]

On 2021-07-14, Vagrant Cascadian wrote:
> The attached patch modifies debian/rules to remove the exmaple
> Makefiles.

Unfortunately, I only tested this with arch:all+arch:any builds, not
arch:any builds without arch:all builds, and so the arch:any builds on
buildd.debian.org are failing...

It needs some special-casing to only run when the specified examples
directory is actually present.


> diff --git a/debian/rules b/debian/rules
> index 77396e35..c1e9921c 100755
> --- a/debian/rules
> +++ b/debian/rules
> @@ -46,6 +46,8 @@ override_dh_installdocs:
>  override_dh_installexamples:
>  	dh_installexamples
>  	find debian/antlr-doc/usr/share/doc/antlr/examples -type f -print | xargs -r chmod 0644
> +	# Remove example Makefiles containing build paths and binary paths
> +	find debian/antlr-doc/usr/share/doc/antlr/examples -name Makefile -print -delete
>  	rm -rf debian/antlr-doc/usr/share/doc/antlr/examples/csharp
>  
>  override_dh_auto_clean:
> -- 
> 2.32.0

Probably prefixing with something like:

  test ! -d debian/antlr-doc/usr/share/doc/antlr/examples || find ... -print -delete

(using "test -d ... && find ..." will error out when the directory isn't
there, e.g. arch:any builds)

This way the arch:any builds will just skip this step...


live well,
  vagrant

[signature.asc (application/pgp-signature, inline)]

Message #30 received at 991104@bugs.debian.org (full text, mbox, reply):

From: tony mancill <tmancill@debian.org>

To: Vagrant Cascadian <vagrant@reproducible-builds.org>

Cc: 991104@bugs.debian.org

Subject: Re: antlr: reproducible-builds: Example Makefiles embed build paths and binary paths

Date: Fri, 20 Aug 2021 21:36:43 -0700

[Message part 1 (text/plain, inline)]

Hi Vagrant,

On Fri, Aug 20, 2021 at 12:04:57AM -0700, Vagrant Cascadian wrote:
> On 2021-07-14, Vagrant Cascadian wrote:
> > The attached patch modifies debian/rules to remove the exmaple
> > Makefiles.
> 
> Unfortunately, I only tested this with arch:all+arch:any builds, not
> arch:any builds without arch:all builds, and so the arch:any builds on
> buildd.debian.org are failing...
> 
> It needs some special-casing to only run when the specified examples
> directory is actually present.
> 
> 
> > diff --git a/debian/rules b/debian/rules
> > index 77396e35..c1e9921c 100755
> > --- a/debian/rules
> > +++ b/debian/rules
> > @@ -46,6 +46,8 @@ override_dh_installdocs:
> >  override_dh_installexamples:
> >  	dh_installexamples
> >  	find debian/antlr-doc/usr/share/doc/antlr/examples -type f -print | xargs -r chmod 0644
> > +	# Remove example Makefiles containing build paths and binary paths
> > +	find debian/antlr-doc/usr/share/doc/antlr/examples -name Makefile -print -delete
> >  	rm -rf debian/antlr-doc/usr/share/doc/antlr/examples/csharp
> >  
> >  override_dh_auto_clean:
> > -- 
> > 2.32.0
> 
> Probably prefixing with something like:
> 
>   test ! -d debian/antlr-doc/usr/share/doc/antlr/examples || find ... -print -delete
> 
> (using "test -d ... && find ..." will error out when the directory isn't
> there, e.g. arch:any builds)
> 
> This way the arch:any builds will just skip this step...

Thanks for catching this and the pointer on the fix.  I will get an
update uploaded soon.

Cheers,
tony

[signature.asc (application/pgp-signature, inline)]

Send a report that this bug log contains spam.