Debian Bug report logs - #990910
p7zip: reproducible builds: parallelism triggers differences

Package: src:p7zip; Maintainer for src:p7zip is Robert Luberda <robert@debian.org>;

Reported by: Vagrant Cascadian <vagrant@reproducible-builds.org>

Date: Sat, 10 Jul 2021 22:57:04 UTC

Severity: normal

Tags: patch

Reply or subscribe to this bug.

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, reproducible-bugs@lists.alioth.debian.org, Robert Luberda <robert@debian.org>:
Bug#990910; Package src:p7zip. (Sat, 10 Jul 2021 22:57:06 GMT) (full text, mbox, link).


Acknowledgement sent to Vagrant Cascadian <vagrant@reproducible-builds.org>:
New Bug report received and forwarded. Copy sent to reproducible-bugs@lists.alioth.debian.org, Robert Luberda <robert@debian.org>. (Sat, 10 Jul 2021 22:57:06 GMT) (full text, mbox, link).


Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>
To: submit@bugs.debian.org
Subject: p7zip: reproducible builds: parallelism triggers differences
Date: Sat, 10 Jul 2021 15:55:39 -0700
[Message part 1 (text/plain, inline)]
Source: p7zip
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: randomness
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Apparently p7zip includes different paths when built in parallel:

  https://tests.reproducible-builds.org/debian/rb-pkg/bullseye/amd64/diffoscope-results/p7zip.html

  /usr/lib/p7zip/7z

  ../../../../CPP/myWindows/StdAfx.h:68
  vs.
  ../../../myWindows/StdAfx.h:68


The attached patch fixes this by disabling parallelism during the build.

With this patch applied, p7zip should be reproducible on
tests.reproducible-builds.org.


It may be possible to dig deeper into p7zip to fix the issues with a
parallel build, but I haven't found a good starting point to do so.


Thanks for maintaining p7zip!


live well,
  vagrant
[0001-debian-rules-Disable-parallel-builds-to-enable-repro.patch (text/x-diff, inline)]
From ef7ff07a47b785e48be34d32810a4a65c5edacee Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Sat, 10 Jul 2021 22:42:22 +0000
Subject: [PATCH] debian/rules: Disable parallel builds to enable reproducible
 builds.

---
 debian/rules | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/debian/rules b/debian/rules
index 49bfcac..de763c1 100755
--- a/debian/rules
+++ b/debian/rules
@@ -1,6 +1,6 @@
 #!/usr/bin/make -f
 
-DH_AUTO_OPTIONS := -v -Smakefile --parallel
+DH_AUTO_OPTIONS := -v -Smakefile
 stampfile       := debian/build-stamp
 
 DEB_BUILD_MAINT_OPTIONS := hardening=+all
@@ -19,7 +19,7 @@ else
 endif
 
 %:
-	dh ${@}
+	dh ${@} --no-parallel
 
 override_dh_auto_clean:
 	# Make sure patches are applied otherwise `make clean' fails
-- 
2.32.0

[signature.asc (application/pgp-signature, inline)]

Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Wed May 17 12:27:12 2023; Machine Name: buxtehude

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.