Debian Bug report logs - #989965
gtk-sharp3: reproducible-builds: Example Makefiles embed build paths and binary paths

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: submit@bugs.debian.org

Subject: gtk-sharp3: reproducible-builds: Example Makefiles embed build paths and binary paths

Date: Wed, 16 Jun 2021 14:29:48 -0700

[Message part 1 (text/plain, inline)]

Source: gtk-sharp3
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath usrmerge shell
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The build path, several binary paths, and the value of the SHELL
variable are embedded in example Makefiles shipped in the package:

  https://tests.reproducible-builds.org/debian/rb-pkg/unstable/i386/diffoscope-results/gtk-sharp3.html

  ACLOCAL·=·${SHELL}·/build/1st/gtk-sharp3-2.99.3/missing·aclocal-1.14
  vs.
  ACLOCAL·=·${SHELL}·/build/2/gtk-sharp3-2.99.3/2nd/missing·aclocal-1.14

  GREP·=·/bin/grep
  vs.
  GREP·=·/usr/bin/grep

  SHELL·=·/bin/bash
  vs.
  SHELL·=·/bin/sh

Since these values may differ with the installed system, in order to use
the example Makefiles, a person would have to regenerate them from
Makefile.am or Makefile.in, which are also provided.

The attached patch adjusts debian/gtk-sharp3-examples.install to avoid
installing the Makefiles.

If that is somehow not an option, an alternate option would be to
sanitize the Makefiles stripping the build path (or replacing with
/usr/src?), and possibly passing various variables to configure
(e.g. GREP=/bin/grep, SHELL=/bin/sh, ...).

Thanks for maintaining gtk-sharp3!

live well,
  vagrant

[0001-Do-not-install-example-Makefiles.patch (text/x-diff, inline)]

From f8cfb91164ef09f34b3f820c7fe4ad53a419bccb Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Wed, 16 Jun 2021 21:06:10 +0000
Subject: [PATCH 1/2] Do not install example Makefiles.

The example Makefiles embed build paths, binary paths (e.g. /bin/grep
vs. /usr/bin/grep) and the value of the SHELL variable.

Since these values may differ with the installed system, in order to use
the example Makefiles, a person would have to regenerate them from
Makefile.am or Makefile.in, which are also provided.
---
 debian/gtk-sharp3-examples.install | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/debian/gtk-sharp3-examples.install b/debian/gtk-sharp3-examples.install
index 8d73b12..f486eca 100644
--- a/debian/gtk-sharp3-examples.install
+++ b/debian/gtk-sharp3-examples.install
@@ -2,5 +2,5 @@ sample/*.cs	/usr/share/gtk-sharp3-examples/
 sample/*.exe	/usr/share/gtk-sharp3-examples/
 sample/GtkDemo/*.cs	/usr/share/gtk-sharp3-examples/GtkDemo
 sample/GtkDemo/*.exe	/usr/share/gtk-sharp3-examples/GtkDemo
-sample/Makefile	/usr/share/gtk-sharp3-examples/
-sample/pixmaps/	/usr/share/gtk-sharp3-examples/
+sample/pixmaps/Makefile.*	/usr/share/gtk-sharp3-examples/pixmaps/
+sample/pixmaps/*.png	/usr/share/gtk-sharp3-examples/pixmaps/
-- 
2.20.1

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 989965@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: 989965@bugs.debian.org, 989966@bugs.debian.org

Subject: gtk-sharp3: NMU fixing reproducible builds issues

Date: Tue, 10 Jan 2023 11:17:54 -0800

[Message part 1 (text/plain, inline)]

Control: tags 989965 pending
Control: tags 989966 pending

I have uploaded an NMU to DELAYED/10 fixing two reproducible builds
issues:

diff -Nru gtk-sharp3-2.99.3/debian/changelog gtk-sharp3-2.99.3/debian/changelog
--- gtk-sharp3-2.99.3/debian/changelog	2020-02-24 14:14:23.000000000 -0800
+++ gtk-sharp3-2.99.3/debian/changelog	2023-01-10 10:56:28.000000000 -0800
@@ -1,3 +1,12 @@
+gtk-sharp3 (2.99.3-4.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Do not install example Makefiles. (Closes: #989965)
+  * Build with C.UTF-8 locale to ensure reproducible builds of .dll files.
+    (Closes: #989966)
+
+ -- Vagrant Cascadian <vagrant@reproducible-builds.org>  Tue, 10 Jan 2023 10:56:28 -0800
+
 gtk-sharp3 (2.99.3-4) unstable; urgency=medium
 
   * [09ff38e] Fix for building on newer Mono
diff -Nru gtk-sharp3-2.99.3/debian/gtk-sharp3-examples.install gtk-sharp3-2.99.3/debian/gtk-sharp3-examples.install
--- gtk-sharp3-2.99.3/debian/gtk-sharp3-examples.install	2017-10-30 10:42:23.000000000 -0700
+++ gtk-sharp3-2.99.3/debian/gtk-sharp3-examples.install	2023-01-10 10:56:28.000000000 -0800
@@ -2,5 +2,5 @@
 sample/*.exe	/usr/share/gtk-sharp3-examples/
 sample/GtkDemo/*.cs	/usr/share/gtk-sharp3-examples/GtkDemo
 sample/GtkDemo/*.exe	/usr/share/gtk-sharp3-examples/GtkDemo
-sample/Makefile	/usr/share/gtk-sharp3-examples/
-sample/pixmaps/	/usr/share/gtk-sharp3-examples/
+sample/pixmaps/Makefile.*	/usr/share/gtk-sharp3-examples/pixmaps/
+sample/pixmaps/*.png	/usr/share/gtk-sharp3-examples/pixmaps/
diff -Nru gtk-sharp3-2.99.3/debian/rules gtk-sharp3-2.99.3/debian/rules
--- gtk-sharp3-2.99.3/debian/rules	2017-10-30 10:42:23.000000000 -0700
+++ gtk-sharp3-2.99.3/debian/rules	2023-01-10 10:56:28.000000000 -0800
@@ -2,6 +2,10 @@
 
 DEB_API_VERSION = 2.99.3
 
+# Set locale to ensure .dll files are built reproducibly.
+export LC_ALL=C.UTF-8
+export LANG=C.UTF-8
+
 # override libdir to workaround multi-arched pkg-config paths
 override_dh_auto_configure:
 	dh_auto_configure -- \


live well,
  vagrant

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 989965-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 989965-close@bugs.debian.org

Subject: Bug#989965: fixed in gtk-sharp3 2.99.3-4.1

Date: Fri, 20 Jan 2023 20:43:25 +0000

Source: gtk-sharp3
Source-Version: 2.99.3-4.1
Done: Vagrant Cascadian <vagrant@reproducible-builds.org>

We believe that the bug you reported is fixed in the latest version of
gtk-sharp3, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 989965@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Vagrant Cascadian <vagrant@reproducible-builds.org> (supplier of updated gtk-sharp3 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Tue, 10 Jan 2023 10:56:28 -0800
Source: gtk-sharp3
Architecture: source
Version: 2.99.3-4.1
Distribution: unstable
Urgency: medium
Maintainer: Debian CLI Libraries Team <pkg-cli-libs-team@lists.alioth.debian.org>
Changed-By: Vagrant Cascadian <vagrant@reproducible-builds.org>
Closes: 989965 989966
Changes:
 gtk-sharp3 (2.99.3-4.1) unstable; urgency=medium
 .
   * Non-maintainer upload.
   * Do not install example Makefiles. (Closes: #989965)
   * Build with C.UTF-8 locale to ensure reproducible builds of .dll files.
     (Closes: #989966)
Checksums-Sha1:
 4d7459819e3703346904e7cb9b4cb5688280c831 2879 gtk-sharp3_2.99.3-4.1.dsc
 2d46a1bdf5156ad152d066304d7e134b482db0a8 6720 gtk-sharp3_2.99.3-4.1.debian.tar.xz
Checksums-Sha256:
 562776095a6799e9588737eb83dc362d7c7c397cf0503b1ebeebb84898aa5898 2879 gtk-sharp3_2.99.3-4.1.dsc
 44ee1f579d2011c46a69eb410741283182b536c6276cf62224d8f853f5e4474c 6720 gtk-sharp3_2.99.3-4.1.debian.tar.xz
Files:
 dfe7f7315d494dea9488a10ddffbdb12 2879 cli-mono optional gtk-sharp3_2.99.3-4.1.dsc
 40b9457375c23c577131653985228268 6720 cli-mono optional gtk-sharp3_2.99.3-4.1.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iJYEARYKAD4WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCY7245yAcdmFncmFudEBy
ZXByb2R1Y2libGUtYnVpbGRzLm9yZwAKCRDcUY/If5cWqjxzAP9KXz/RyfpFsjuS
/Ekim8nOlh0ktUoJRaFuitO8mlYyZwD8Dd7MsZZCFegZ+oq0SMIJtcJ2Er61NtW3
5aePvNqjtQ4=
=9OC8
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.