Debian Bug report logs - #988964
please demote diffoscope to Recommends

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: John Scott <jscott@posteo.net>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: please demote diffoscope to Recommends

Date: Fri, 21 May 2021 22:26:58 +0000

[Message part 1 (text/plain, inline)]

Package: reprotest
Version: 0.7.16
Severity: minor

On my system, reprotest has the following Depends/Recommends:
Depends: diffoscope (>= 112~), python3-distro, python3-rstr, python3:any, python3-debian, apt-utils, libdpkg-perl, procps, python3-pkg-resources
Recommends: disorderfs, faketime, locales-all, sudo

Reprotest should really recommend Diffoscope so that users don't need
to install it whom only want to check if packages are reproducible;
this is what the --no-diffoscope argument is for.

I would send a Merge Request, but I frankly can't figure out where this
comes from. The applicable section in debian/control says
Depends: ${python3:Depends},
 python3-debian,
 apt-utils,
 libdpkg-perl,
 procps,
 python3-pkg-resources,
 python3-rstr,
 ${misc:Depends}
Recommends:
 diffoscope (>= 112~),
 disorderfs,
 faketime,
 locales-all,
 sudo,

so my only guess is that Diffoscope gets pulled into
${python3:Depends}?

-- System Information:
Debian Release: 11.0
  APT prefers testing
  APT policy: (500, 'testing'), (2, 'unstable'), (1, 'testing-debug'),
(1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.10.0-6-amd64 (SMP w/2 CPU threads)
Kernel taint flags: TAINT_USER, TAINT_WARN, TAINT_FIRMWARE_WORKAROUND
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8),
LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages reprotest depends on:
ii  apt-utils              2.2.3
ii  diffoscope             172
ii  libdpkg-perl           1.20.9
ii  procps                 2:3.3.17-5
ii  python3                3.9.2-3
ii  python3-debian         0.1.39
ii  python3-distro         1.5.0-1
ii  python3-pkg-resources  52.0.0-3
ii  python3-rstr           2.2.6-2

Versions of packages reprotest recommends:
ii  disorderfs   0.5.11-1
ii  faketime     0.9.8-9
ii  locales-all  2.31-12
ii  sudo         1.9.5p2-3

Versions of packages reprotest suggests:
ii  autodep8     0.24
pn  qemu-system  <none>
ii  qemu-utils   1:5.2+dfsg-10
pn  schroot      <none>

-- no debconf information

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 988964@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: John Scott <jscott@posteo.net>, 988964@bugs.debian.org

Subject: Re: Bug#988964: please demote diffoscope to Recommends

Date: Fri, 21 May 2021 17:23:46 -0700

[Message part 1 (text/plain, inline)]

On 2021-05-21, John Scott wrote:
> On my system, reprotest has the following Depends/Recommends:
> Depends: diffoscope (>= 112~), python3-distro, python3-rstr, python3:any, python3-debian, apt-utils, libdpkg-perl, procps, python3-pkg-resources
> Recommends: disorderfs, faketime, locales-all, sudo
>
> Reprotest should really recommend Diffoscope so that users don't need
> to install it whom only want to check if packages are reproducible;
> this is what the --no-diffoscope argument is for.
>
> I would send a Merge Request, but I frankly can't figure out where this
> comes from. The applicable section in debian/control says
> Depends: ${python3:Depends},
>  python3-debian,
>  apt-utils,
>  libdpkg-perl,
>  procps,
>  python3-pkg-resources,
>  python3-rstr,
>  ${misc:Depends}
> Recommends:
>  diffoscope (>= 112~),
>  disorderfs,
>  faketime,
>  locales-all,
>  sudo,
>
> so my only guess is that Diffoscope gets pulled into
> ${python3:Depends}?

Yes, just confirmed that it gets added through python3:Depends.

So, I presume it will require mangling python3:Depends, or adjusting the
code to convince the pybuild/dh_python/etc that it doesn't belong there.

live well,
  vagrant

[signature.asc (application/pgp-signature, inline)]

Message #15 received at 988964@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: John Scott <jscott@posteo.net>, 988964@bugs.debian.org

Subject: Re: Bug#988964: please demote diffoscope to Recommends

Date: Fri, 21 May 2021 17:33:42 -0700

[Message part 1 (text/plain, inline)]

On 2021-05-21, Vagrant Cascadian wrote:
> On 2021-05-21, John Scott wrote:
>> On my system, reprotest has the following Depends/Recommends:
>> Depends: diffoscope (>= 112~), python3-distro, python3-rstr, python3:any, python3-debian, apt-utils, libdpkg-perl, procps, python3-pkg-resources
>> Recommends: disorderfs, faketime, locales-all, sudo
>>
>> Reprotest should really recommend Diffoscope so that users don't need
>> to install it whom only want to check if packages are reproducible;
>> this is what the --no-diffoscope argument is for.
>>
>> I would send a Merge Request, but I frankly can't figure out where this
>> comes from. The applicable section in debian/control says
>> Depends: ${python3:Depends},
>>  python3-debian,
>>  apt-utils,
>>  libdpkg-perl,
>>  procps,
>>  python3-pkg-resources,
>>  python3-rstr,
>>  ${misc:Depends}
>> Recommends:
>>  diffoscope (>= 112~),
>>  disorderfs,
>>  faketime,
>>  locales-all,
>>  sudo,
>>
>> so my only guess is that Diffoscope gets pulled into
>> ${python3:Depends}?
>
> Yes, just confirmed that it gets added through python3:Depends.
>
> So, I presume it will require mangling python3:Depends, or adjusting the
> code to convince the pybuild/dh_python/etc that it doesn't belong there.

diffoscope is in install_requires, removing it gets it out of
python3:Depends, but may have other unintended consequences:

diff --git a/setup.py b/setup.py
index 72c2c00..d04d554 100644
--- a/setup.py
+++ b/setup.py
@@ -20,7 +20,6 @@ setup(name='reprotest',
               ],
           },
       install_requires=[
-          'diffoscope',
           'rstr',
           'distro',
           ],


live well,
  vagrant

[signature.asc (application/pgp-signature, inline)]

Message #18 received at 988964@bugs.debian.org (full text, mbox, reply):

From: Mattia Rizzolo <mattia@debian.org>

To: Vagrant Cascadian <vagrant@reproducible-builds.org>, 988964@bugs.debian.org

Cc: John Scott <jscott@posteo.net>

Subject: Re: Bug#988964: please demote diffoscope to Recommends

Date: Tue, 25 May 2021 17:46:12 +0200

[Message part 1 (text/plain, inline)]

On Fri, May 21, 2021 at 05:33:42PM -0700, Vagrant Cascadian wrote:
> > Yes, just confirmed that it gets added through python3:Depends.
> >
> > So, I presume it will require mangling python3:Depends, or adjusting the
> > code to convince the pybuild/dh_python/etc that it doesn't belong there.
> 
> diffoscope is in install_requires, removing it gets it out of
> python3:Depends, but may have other unintended consequences:

Yes, currently diffoscope is run unconditionally unless --no-diffoscope
is passed.  which means that it need to learn to check before running it
:)

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
More about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-

[signature.asc (application/pgp-signature, inline)]

Message #25 received at 988964@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: Mattia Rizzolo <mattia@debian.org>, 988964@bugs.debian.org

Cc: John Scott <jscott@posteo.net>

Subject: Re: Bug#988964: please demote diffoscope to Recommends

Date: Wed, 07 Jul 2021 22:11:29 -0700

[Message part 1 (text/plain, inline)]

Control: tags 988964 +patch

On 2021-05-25, Mattia Rizzolo wrote:
> On Fri, May 21, 2021 at 05:33:42PM -0700, Vagrant Cascadian wrote:
>> > Yes, just confirmed that it gets added through python3:Depends.
>> >
>> > So, I presume it will require mangling python3:Depends, or adjusting the
>> > code to convince the pybuild/dh_python/etc that it doesn't belong there.
>> 
>> diffoscope is in install_requires, removing it gets it out of
>> python3:Depends, but may have other unintended consequences:
>
> Yes, currently diffoscope is run unconditionally unless --no-diffoscope
> is passed.  which means that it need to learn to check before running it
> :)

How about this not really at all tested patch:

diff --git a/reprotest/__init__.py b/reprotest/__init__.py
index 6fd159a..f8ba450 100644
--- a/reprotest/__init__.py
+++ b/reprotest/__init__.py
@@ -824,8 +824,11 @@ def run(argv, dry_run=None):
     diffoscope = parsed_args.diffoscope
     if parsed_args.no_diffoscope:
         diffoscope_args = None
-    else:
+    elif shutil.which('diffoscope'):
         diffoscope_args = [diffoscope] + diffoscope_args
+    else:
+        logger.warning("diffoscope not available, falling back to regular diff")
+        diffoscope_args = None
     control_build = parsed_args.control_build

     if not artifact_pattern:


Will try to test it soon...


live well,
  vagrant

[signature.asc (application/pgp-signature, inline)]

Message #30 received at 988964-submitter@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <noreply@salsa.debian.org>

To: 988964-submitter@bugs.debian.org

Subject: Bug#988964 marked as pending in reprotest

Date: Thu, 15 Jul 2021 21:56:35 +0000

Control: tag -1 pending

Hello,

Bug #988964 in reprotest reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/reproducible-builds/reprotest/-/commit/7437776ff63a4bf3f62dfd1165e2f8663da64199

------------------------------------------------------------------------
Make diffoscope optional (Closes: #988964)

This allows diffoscope to really only be in Recommends.
------------------------------------------------------------------------

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/988964

Message #37 received at 988964-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 988964-close@bugs.debian.org

Subject: Bug#988964: fixed in reprotest 0.7.17

Date: Wed, 29 Sep 2021 21:06:30 +0000

Source: reprotest
Source-Version: 0.7.17
Done: Holger Levsen <holger@debian.org>

We believe that the bug you reported is fixed in the latest version of
reprotest, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 988964@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Holger Levsen <holger@debian.org> (supplier of updated reprotest package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 29 Sep 2021 22:22:09 +0200
Source: reprotest
Architecture: source
Version: 0.7.17
Distribution: unstable
Urgency: medium
Maintainer: Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>
Changed-By: Holger Levsen <holger@debian.org>
Closes: 988964 992694
Changes:
 reprotest (0.7.17) unstable; urgency=medium
 .
   [ Frédéric Pierret (fepitre) ]
   * Remove spec file as a specific branch will be created with it.
   * rpm: keep rpmbuild layout with RPMS folder.
   * test_reprotest: add spaces and regorganize functions.
   * test_reprotest: filter per distribution and register custom marks.
   * test_shell: Fix warnings about invalid escape sequences.
 .
   [ Vagrant Cascadian ]
   * Make diffoscope optional. (Closes: #988964)
 .
   [ Mattia Rizzolo ]
   * Set the diffoscope "optional dependency" the Python way.
   * Update doc to mention how `ldconfig` conflicts with the kernel variation.
     (Closes: #992694)
 .
   [ Holger Levsen ]
   * Bump standards version to 4.6.0.
   * Release as 0.7.17.
Checksums-Sha1:
 cb7ae6ad15b51e78c5a3681b8e38553a8c997112 2162 reprotest_0.7.17.dsc
 b4fba81c9c2e4b71c4913bbe7b04ef25d742863f 87164 reprotest_0.7.17.tar.xz
 03247e4da0f2a5838e24326abda999475860da02 11126 reprotest_0.7.17_source.buildinfo
Checksums-Sha256:
 6a0d1b9b80f6bc2e81b65fb13120b06ce5635ed5b44a563205a126cea750e1a2 2162 reprotest_0.7.17.dsc
 2ce8454e706a900ee16463a22c7792a4ea39a4af9b2204a9a6f883e0cca9c4d2 87164 reprotest_0.7.17.tar.xz
 0bdbcc4a909e17b199dcd538c495e565bea89cae9aac66a87b1f2ff8df7c988d 11126 reprotest_0.7.17_source.buildinfo
Files:
 033e94d1abb33f9579fb5df863bfd2a6 2162 devel optional reprotest_0.7.17.dsc
 f1e5df1789c5ada88734c27dfb813ab2 87164 devel optional reprotest_0.7.17.tar.xz
 13f2585e2bc6c6cf7eaedb2f3ac5892e 11126 devel optional reprotest_0.7.17_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEuL9UE3sJ01zwJv6dCRq4VgaaqhwFAmFUznMACgkQCRq4Vgaa
qhyn1w/+OggEazS2dUOLJxICvP5RJVSKVhRzodjxDvHPLyCLgo0ABN48vWWBQxRO
ubvoSKLlOIRjuvJ/NuKIwkk3SLRp6zIxGr2HdVxxa6/DeLyeMMt6jpbQo9rn1TKN
VZtrmpPlK2T+ThCWmz0Nd5sZMa7BT8TfAZ5j2dARDkOSQenFg+CCkf1zd/F6wFsd
T4CiqUiYPMeeNxKYdkk/s6so2phkw5ndnetkeIazn6nRN95TTbVdFFwzHDpgwAto
PytQwQjLX+qsY7i12RI3qIpx7DsMo532IxhjiIUAnf2RIfC/TMZCJAfbesmzjy/Z
47q3vMTHH/wZlcf9kM4zavfnTiwVf1jEHfOYXpUQvKCcb5rXyQzrjzS4E5CqO8wH
ymGeFyTBS+psebd3xgzA1GAvsg9hPyDIZxZnBKz5ZYnE+rmNdMWN/wb1GrUuGp7F
jNHdHVePk46JMFziEdbrT57cPTsGjCv/URRzx6Zvlm+PlQPNKbknYno8BWTEuR6N
+7yVqfwizP1lDh5HFVKMn72s2bMuda1ZY7CkHGEqL23pmwcsqlPd0EWLmTbadNLc
9ESxZezfhASlNqbR9o76WwPMhW5NdbYK0Bvvf+KuDEtxdWBWso8fvTF0R+I7G3Dy
MPfcxcFCbH3aIqU1cXbpV8W3bijG+AH92IeSJpWsIa6t5JBXEzc=
=ulqv
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.