Debian Bug report logs - #98819
debhelper: alsa-source-0.9-0beta4-4 doesn't work with debhelper >3.0.24

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: trini@kernel.crashing.org

To: submit@bugs.debian.org

Subject: debhelper: alsa-source-0.9-0beta4-4 doesn't work with debhelper >3.0.24

Date: Sat, 26 May 2001 13:16:17 -0700

Package: debhelper
Version: 3.0.26
Severity: normal

When trying to run make-kpkg modules_image on a 2.4.5 kernel tree and with
alsa-source-0.9-0beta4-4, I get the following:
dh_strip
dh_compress
dh_fixperms
dh_installdeb
dh_shlibdeps
dh_gencontrol -- -v`cat debian/MODVERS`
dpkg-gencontrol: warning: unknown substitution variable ${kvers}
dpkg-gencontrol: warning: unknown substitution variable ${kversdeb}
dpkg-gencontrol: warning: unknown substitution variable ${kvers}
dh_md5sums 
dh_builddeb --destdir=/usr/src/kern/linux-2.4.5/..
dpkg-deb: parse error, in file `debian/tmp/DEBIAN/control' near line 7 package `
alsa-modules-2.4.5':
 `Recommends' field, reference to `kernel-image-': error in version: version str
ing is empty
dh_builddeb: command returned error code
make[2]: *** [binary-modules] Error 1
make[2]: Leaving directory `/usr/src/modules/alsa-driver-0.9+0beta4-4'
make[1]: *** [kdist_image] Error 2
make[1]: Leaving directory `/usr/src/modules/alsa-driver-0.9+0beta4-4'
Module /usr/src/modules/alsa-driver-0.9+0beta4-4 failed.
Hit return to Continue

The package built fine on May 18th, so I suspect I had debhelper 3.0.24
installed.

-- System Information
Debian Release: testing/unstable
Kernel Version: Linux opus.bloom.county 2.4.4 #1 SMP Fri Apr 27 22:21:08 MST 2001 i686 unknown

Versions of the packages debhelper depends on:
ii  binutils       2.11.90.0.7-2  The GNU assembler, linker and binary utiliti
ii  debconf-utils  0.9.59         Debconf utilities
ii  dpkg-dev       1.9.6          Package building tools for Debian
ii  file           3.33-5         Determines file type using "magic" numbers
ii  fileutils      4.1-2          GNU file management utilities.
ii  html2text      1.2.3-2        An advanced HTML to text converter.
ii  perl           5.6.1-2        Larry Wall's Practical Extracting and Report

Message #12 received at 98819@bugs.debian.org (full text, mbox, reply):

From: David Schmitt <david@schmitt.edv-bus.at>

To: Debian Bug Tracking System <98819@bugs.debian.org>

Subject: Re: debhelper: alsa-source-0.9-0beta4-4 doesn't work with debhelper >3.0.24 [FIX]

Date: Tue, 29 May 2001 13:26:14 +0200

Hi!

I had the same problem and could fix it by doing 

cp debian/substvars debian/alsa-modules-2.2.19

in /usr/src/modules/alsa-driver-0.9+0beta4-4


HTH.

Regards, David



-- System Information
Debian Release: testing/unstable
Architecture: i386
Kernel: Linux zion 2.2.19 #1 Wed May 16 07:41:58 EST 2001 i686
Locale: LANG=C, LC_CTYPE=de_AT

Versions of packages alsa-source depends on:
ii  debconf                0.9.62            Debian configuration management sy
ii  gcc                    1:2.95.4-1        The GNU C compiler.               
ii  gcc [c-compiler]       1:2.95.4-1        The GNU C compiler.               
ii  gcc-2.95 [c-compiler]  1:2.95.4-0.010522 The GNU C compiler.               
ii  gcc-3.0 [c-compiler]   1:3.0-0pre010526  The GNU C compiler.               
ii  make                   3.79.1-6          The GNU version of the "make" util

Message #17 received at 98819@bugs.debian.org (full text, mbox, reply):

From: Masato Taruishi <taru@debian.org>

To: Joey Hess <joeyh@debian.org>

Cc: 98819@bugs.debian.org, control@bugs.debian.org

Subject: Re: FWD: Bug#98819: debhelper: alsa-source-0.9-0beta4-4 doesn't work with debhelper >3.0.24

Date: Tue, 29 May 2001 23:44:06 +0900

reassign 98819 debhelper
thanks

At Sat, 26 May 2001 21:42:06 -0400,
Joey Hess wrote:

> dh_gencontrol -- -v`cat debian/MODVERS`
> dpkg-gencontrol: warning: unknown substitution variable ${kvers}
> dpkg-gencontrol: warning: unknown substitution variable ${kversdeb}
> dpkg-gencontrol: warning: unknown substitution variable ${kvers}

I checked this problem and noticed that Dh_Lib.pm was changed recently.

An old version of pkgext procedure was as follows:

        if ($package ne $dh{MAINPACKAGE}) {
                return "$package.";
        }

and now 

        if (compat(1) and $package eq $dh{MAINPACKAGE}) {
                return "";
        }

For this change, if DH_COMPAT != 1, pkgext always returns its
package name. Well, this is not a direct problem.

The problem of this bug is as follows:

        doit("dpkg-gencontrol","-l$changelog","-isp","-p$package",
                "-Tdebian/${ext}substvars","-P$tmp",@{$dh{U_PARAMS}});

dh_gencontrol always invokes dpkg-gencontrol with -Tdebian/${ext}substvars
, dh_gencontrol should check the substvars file and select a proper file
with pkgfile procedure. It does cause problems until recently, but not anymore
because of the change of pkgext procedure.

-- 

Message #24 received at 98819@bugs.debian.org (full text, mbox, reply):

From: Masato Taruishi <taru@debian.org>

To: 98819@bugs.debian.org

Subject: patch

Date: Wed, 30 May 2001 00:01:19 +0900

*** /usr/bin/dh_gencontrol	Fri Apr 20 14:25:28 2001
--- /tmp/dh_gencontrol	Tue May 29 23:52:08 2001
***************
*** 42,48 ****
  foreach my $package (@{$dh{DOPACKAGES}}) {
  	my $tmp=tmpdir($package);
  	my $ext=pkgext($package);
! 	
  	my $changelog=pkgfile($package,'changelog');
  	if (! $changelog) {
  		$changelog='debian/changelog';
--- 42,49 ----
  foreach my $package (@{$dh{DOPACKAGES}}) {
  	my $tmp=tmpdir($package);
  	my $ext=pkgext($package);
! 	my $subst=pkgfile($package,"substvars");
! 
  	my $changelog=pkgfile($package,'changelog');
  	if (! $changelog) {
  		$changelog='debian/changelog';
***************
*** 54,60 ****
  
  	# Generate and install control file.
  	doit("dpkg-gencontrol","-l$changelog","-isp","-p$package",
! 		"-Tdebian/${ext}substvars","-P$tmp",@{$dh{U_PARAMS}});
  
  	# This chmod is only necessary if the user sets the umask to something odd.
  	doit("chmod","644","$tmp/DEBIAN/control");
--- 55,61 ----
  
  	# Generate and install control file.
  	doit("dpkg-gencontrol","-l$changelog","-isp","-p$package",
! 		"-T$subst","-P$tmp",@{$dh{U_PARAMS}});
  
  	# This chmod is only necessary if the user sets the umask to something odd.
  	doit("chmod","644","$tmp/DEBIAN/control");

Message #29 received at 98819@bugs.debian.org (full text, mbox, reply):

From: Joey Hess <joeyh@debian.org>

To: Masato Taruishi <taru@debian.org>

Cc: 98819@bugs.debian.org

Subject: Re: FWD: Bug#98819: debhelper: alsa-source-0.9-0beta4-4 doesn't work with debhelper >3.0.24

Date: Tue, 29 May 2001 12:25:41 -0400

Masato Taruishi wrote:
> dh_gencontrol always invokes dpkg-gencontrol with -Tdebian/${ext}substvars
> , dh_gencontrol should check the substvars file and select a proper file
> with pkgfile procedure. It does cause problems until recently, but not anymore
> because of the change of pkgext procedure.

Er, it uses debian/${ext}substvars because that is the exact same file
name that dh_shlibdeps makes the substvars information be written to.

What evil thing are you doing to the substvars file? You have clearly
been relying on an undocumented interface.

-- 
see shy jo

Message #34 received at 98819@bugs.debian.org (full text, mbox, reply):

From: Masato Taruishi <masato@cmd.taru.net>

To: Joey Hess <joeyh@debian.org>

Cc: Masato Taruishi <taru@debian.org>, 98819@bugs.debian.org

Subject: Re: FWD: Bug#98819: debhelper: alsa-source-0.9-0beta4-4 doesn't work with debhelper >3.0.24

Date: Wed, 30 May 2001 02:28:16 +0900

At Tue, 29 May 2001 12:25:41 -0400,
Joey Hess wrote:

> > dh_gencontrol always invokes dpkg-gencontrol with -Tdebian/${ext}substvars
> > , dh_gencontrol should check the substvars file and select a proper file
> > with pkgfile procedure. It does cause problems until recently, but not anymore
> > because of the change of pkgext procedure.
> 
> Er, it uses debian/${ext}substvars because that is the exact same file
> name that dh_shlibdeps makes the substvars information be written to.

Then, I wonder how dh_shlibdeps take care of debian/substvars if the file
already exist.

> What evil thing are you doing to the substvars file? You have clearly
> been relying on an undocumented interface.

I'm simply generating the substvars file dynamically by `debian/rules'
target as to be in policy-manual 5.4.

So, I guess this problem is how debhelper programs take care of
debian/substvars file of a main package.

1. doing nothing: always put its package name in the substvars file name.
   (all of substvars generaters must be forced to use the spec).

2. dh_shlibdeps writes entries into debian/substvars. 

3. dh_gencontrol merges debian/<package>.substvars and debian/substvars
   and invokes dpkg-gencontrol with the merged substvars file.

-- 

Message #41 received at 98819@bugs.debian.org (full text, mbox, reply):

From: owner@bugs.debian.org (Debian Bug Tracking System)

To: Masato Taruishi <taru@debian.org>, 98819@bugs.debian.org

Cc: Joey Hess <joeyh@debian.org> (debhelper #98819)

Subject: Processed: Bug#98819: FWD: Bug#98819: debhelper: alsa-source-0.9-0beta4-4 doesn't work with debhelper >3.0.24

Date: Wed, 30 May 2001 09:09:02 -0500

Processing commands for control@bugs.debian.org:

> reassign 98819 debhelper
Bug#98819: debhelper: alsa-source-0.9-0beta4-4 doesn't work with debhelper >3.0.24
Bug reassigned from package `debhelper' to `debhelper'.

> thanks
Stopping processing here.

Please contact me if you need assistance.

Darren Benham
(administrator, Debian Bugs database)

Message #46 received at 98819@bugs.debian.org (full text, mbox, reply):

From: Joey Hess <joey@kitenet.net>

To: Masato Taruishi <masato@cmd.taru.net>

Cc: 98819@bugs.debian.org

Subject: Re: FWD: Bug#98819: debhelper: alsa-source-0.9-0beta4-4 doesn't work with debhelper >3.0.24

Date: Sun, 3 Jun 2001 16:49:22 -0400

Masato Taruishi wrote:
> So, I guess this problem is how debhelper programs take care of
> debian/substvars file of a main package.

Yes, and if you had asked me for a solution for that problem instead of
relying on an undocumented interface, we would not be in this mess.

I have now added a way to specify your own substvars data to debhelper
3.0.30. I think it may well be compatabile with what you are doing now.
This is because I value consistency and the way I did it makes debhelper
more consistent, and not because I'm trying to give you an easy break
after using my undocumented internal interfaces. :-P

I'm reassigning this bug back to alsa-source. You should make sure it
uses the new, documented interface properly.

-- 
see shy jo

Message #53 received at 98819@bugs.debian.org (full text, mbox, reply):

From: Masato Taruishi <masato@cmd.taru.net>

To: Joey Hess <joey@kitenet.net>

Cc: 98819@bugs.debian.org

Subject: Re: FWD: Bug#98819: debhelper: alsa-source-0.9-0beta4-4 doesn't work with debhelper >3.0.24

Date: Mon, 04 Jun 2001 13:05:51 +0900

At Sun, 3 Jun 2001 16:49:22 -0400,
Joey Hess wrote:

> > So, I guess this problem is how debhelper programs take care of
> > debian/substvars file of a main package.
> 
> Yes, and if you had asked me for a solution for that problem instead of
> relying on an undocumented interface, we would not be in this mess.
> 
> I have now added a way to specify your own substvars data to debhelper
> 3.0.30. I think it may well be compatabile with what you are doing now.
> This is because I value consistency and the way I did it makes debhelper
> more consistent, and not because I'm trying to give you an easy break
> after using my undocumented internal interfaces. :-P
> 
> I'm reassigning this bug back to alsa-source. You should make sure it
> uses the new, documented interface properly.

I'm sorry but I can't find where the interface (i.e. <package>.substvars
will be used) is documented, but the following:

       Note that if a package is the first (or only) binary pack-
       age listed in debian/control, debhelper will use
       debian/foo if no debian/package.foo file can be found.

The debhelper in question used debian/package.substvars forcibly
whether the file is exist or not.

I also think alsa-source should write substvar dbs into
debian/<package>.substvars. What I was worried about was the force way
wasn't documented anywhere(If we follow the manpage's documentation,
dh_gencontrol should also use debian/substvars if no debian/package.substvars
file can be found.)

-- 

Message #58 received at 98819-close@bugs.debian.org (full text, mbox, reply):

From: Masato Taruishi <taru@debian.org>

To: 98819-close@bugs.debian.org

Subject: Bug#98819: fixed in alsa-driver 0.9+0beta4-5

Date: Sat, 23 Jun 2001 14:53:49 -0400

We believe that the bug you reported is fixed in the latest version of
alsa-driver, which has been installed in the Debian FTP archive:

alsa-driver_0.9+0beta4-5.dsc
  to pool/main/a/alsa-driver/alsa-driver_0.9+0beta4-5.dsc
alsa-source_0.9+0beta4-5_all.deb
  to pool/main/a/alsa-driver/alsa-source_0.9+0beta4-5_all.deb
alsa-base_0.9+0beta4-5_all.deb
  to pool/main/a/alsa-driver/alsa-base_0.9+0beta4-5_all.deb
alsa-driver_0.9+0beta4-5.diff.gz
  to pool/main/a/alsa-driver/alsa-driver_0.9+0beta4-5.diff.gz
alsa-headers_0.9+0beta4-5_all.deb
  to pool/main/a/alsa-driver/alsa-headers_0.9+0beta4-5_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 98819@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Masato Taruishi <taru@debian.org> (supplier of updated alsa-driver package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sun, 24 Jun 2001 01:03:12 +0900
Source: alsa-driver
Binary: alsa-source alsa-headers alsa-base
Architecture: source all
Version: 0.9+0beta4-5
Distribution: unstable
Urgency: low
Maintainer: Masato Taruishi <taru@debian.org>
Changed-By: Masato Taruishi <taru@debian.org>
Description: 
 alsa-base  - ALSA driver common files
 alsa-headers - ALSA driver header files
 alsa-source - ALSA driver source
Closes: 97210 97976 98800 98819 99709 101854 101877
Changes: 
 alsa-driver (0.9+0beta4-5) unstable; urgency=low
 .
   * Maintainer release (closes: #97210).
   * Added || true to `rmdir /etc/sound/' (closes: #101854).
   * Wrote substvars datas into debian/$KVERS.substvars (closes: #98800, #99709, #101877, #98819)
   * Changed a checking of ALSA_CARDS in rules. (closes: #97976).
Files: 
 5db0bc434e1cd442a6351ebfcec38e09 744 sound optional alsa-driver_0.9+0beta4-5.dsc
 d7c782c68577e9385632c65e1907049a 41928 sound optional alsa-driver_0.9+0beta4-5.diff.gz
 f5d6159cec5cc887b1e02f18cac2c346 30962 sound optional alsa-base_0.9+0beta4-5_all.deb
 9b6100f2c9450007f479f8ee24bd9bd9 1333382 sound optional alsa-source_0.9+0beta4-5_all.deb
 e576848d6d2a7021fa316b7f8c513fa2 36684 sound optional alsa-headers_0.9+0beta4-5_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: KUHASIKU WA http://www.gnupg.org/ WO GORANKUDASAI

iEYEARECAAYFAjs0zkEACgkQ1SOm5mAGKIRQcQCffAw8YoWlOZ2zO7OwNQQ8E+6F
gwEAoIoT3CWeZmFIHNbi0gjVnhiErYiH
=2fit
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.