Debian Bug report logs - #987994
diffoscope: crash when comparing two ZIP files

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Hans-Christoph Steiner <hans@eds.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: diffoscope: crash when comparing two ZIP files

Date: Mon, 03 May 2021 14:38:19 +0200

Package: diffoscope
Version: 168~bpo10+1
Severity: important

Dear Maintainer,

I downloaded the job artifact files from two related GitLab CI jobs and compared them:

https://gitlab.com/guardianproject/tor-android/-/jobs/1231242475/artifacts/download

https://gitlab.com/eighthave/tor-android/-/jobs/1227385382/artifacts/download

diffoscope --html jobzip.html \
    tor-android_release_0.4.5.7_044c580d3aeed61b315cd1c22520bbba3137acfb.zip \
    tor-android_release_0.4.5.7_044c580d3aeed61b315cd1c22520bbba3137acfb\(1\).zip


Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/diffoscope/main.py", line 771, in main
    sys.exit(run_diffoscope(parsed_args))
  File "/usr/lib/python3/dist-packages/diffoscope/main.py", line 725, in run_diffoscope
    difference = compare_root_paths(path1, path2)
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/utils/compare.py", line 69, in compare_root_paths
    difference = compare_files(file1, file2)
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/utils/compare.py", line 125, in compare_files
    return file1.compare(file2, source)
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/utils/file.py", line 499, in compare
    difference = self._compare_using_details(other, source)
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/utils/file.py", line 436, in _compare_using_details
    other.as_container, no_recurse=no_recurse
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/utils/container.py", line 192, in compare_pair
    file1, file2, source=None, diff_content_only=no_recurse
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/utils/compare.py", line 125, in compare_files
    return file1.compare(file2, source)
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/utils/file.py", line 499, in compare
    difference = self._compare_using_details(other, source)
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/utils/file.py", line 406, in _compare_using_details
    details.extend(self.compare_details(other, source))
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/debian.py", line 195, in compare_details
    self._deb822.get_as_string("Checksums-Sha256"),
  File "/usr/lib/python3/dist-packages/debian/deb822.py", line 1657, in get_as_string
    if hasattr(self[key], 'keys'):   # single-line
  File "/usr/lib/python3/dist-packages/debian/deb822.py", line 500, in __getitem__
    value = self.__dict[keyi]
KeyError: 'Checksums-Sha256'


-- System Information:
Debian Release: 10.9
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable'), (100, 'proposed-updates')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0-16-amd64 (SMP w/8 CPU cores)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages diffoscope depends on:
ii  diffoscope-minimal  168~bpo10+1

Versions of packages diffoscope recommends:
ii  abootimg                         0.6-1+b2
ii  acl                              2.2.53-4
ii  apksigner                        30.0.3-4
ii  apktool                          2.4.1-1
ii  binutils-multiarch               2.31.1-16
ii  bzip2                            1.0.6-9.2~deb10u1
ii  caca-utils                       0.99.beta19-2.1
ii  colord                           1.4.3-4
ii  db-util                          5.3.1+nmu1
ii  default-jdk [java-sdk]           2:1.11-71
ii  default-jdk-headless             2:1.11-71
ii  device-tree-compiler             1.4.7-4
ii  docx2txt                         1.4-1
ii  e2fsprogs                        1.44.5-1+deb10u3
ii  enjarify                         1:1.0.3-4
ii  ffmpeg                           7:4.1.6-1~deb10u1
ii  fontforge-extras                 0.3-4
ii  fp-utils                         3.0.4+dfsg-22
ii  fp-utils-3.0.4 [fp-utils]        3.0.4+dfsg-22
ii  genisoimage                      9:1.1.11-3+b2
ii  gettext                          0.19.8.1-9
ii  ghc                              8.4.4+dfsg1-3
ii  ghostscript                      9.27~dfsg-2+deb10u4
ii  giflib-tools                     5.1.4-3
ii  gnumeric                         1.12.44-1
ii  gnupg                            2.2.12-1+deb10u1
ii  gnupg-utils                      2.2.12-1+deb10u1
ii  hdf5-tools                       1.10.4+repack-10
ii  imagemagick                      8:6.9.10.23+dfsg-2.1+deb10u1
ii  imagemagick-6.q16 [imagemagick]  8:6.9.10.23+dfsg-2.1+deb10u1
ii  jsbeautifier                     1.6.4-7
ii  libarchive-tools                 3.3.3-4+deb10u1
ii  llvm                             1:7.0-47
ii  lz4 [liblz4-tool]                1.8.3-1
ii  mono-utils                       5.18.0.240+dfsg-3
ii  ocaml-nox                        4.05.0-11
ii  odt2txt                          0.5-1+b2
ii  oggvideotools                    0.9.1-5
ii  openjdk-11-jdk [java-sdk]        11.0.11+9-1~deb10u1
ii  openssh-client                   1:7.9p1-10+deb10u2
ii  openssl                          1.1.1d-0+deb10u6
ii  pgpdump                          0.33-1
ii  poppler-utils                    0.71.0-5
ii  procyon-decompiler               0.5.32-5
ii  python3-argcomplete              1.8.1-1
ii  python3-binwalk                  2.1.2~git20180830+dfsg1-1
ii  python3-debian                   0.1.35
ii  python3-defusedxml               0.5.0-2
ii  python3-guestfs                  1:1.40.2-2
ii  python3-jsondiff                 1.1.1-2
ii  python3-pdfminer                 20181108+dfsg-3
ii  python3-progressbar              2.5-1
ii  python3-pypdf2                   1.26.0-2
ii  python3-pyxattr                  0.6.1-1
ii  python3-rpm                      4.14.2.1+dfsg1-1
ii  python3-tlsh                     3.4.4+20151206-1.1
ii  r-base-core                      3.5.2-1
pn  radare2                          <none>
ii  rpm2cpio                         4.14.2.1+dfsg1-1
ii  sng                              1.1.0-1+b1
ii  sqlite3                          3.27.2-3+deb10u1
ii  squashfs-tools                   1:4.3-12
ii  tcpdump                          4.9.3-1~deb10u2
ii  u-boot-tools                     2019.01+dfsg-7
ii  unzip                            6.0-23+deb10u2
ii  vim-common                       2:8.1.0875-5
ii  wabt                             1.0.8-1
ii  xmlbeans                         3.0.2-1
ii  xxd                              2:8.1.0875-5
ii  xz-utils                         5.2.4-1
ii  zip                              3.0-11+b1
ii  zstd                             1.4.4+dfsg-3~bpo10+1

Versions of packages diffoscope suggests:
ii  libjs-jquery  3.3.1~dfsg-3+deb10u1

-- no debconf information

Message #10 received at 987994@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>

To: 987994@bugs.debian.org

Cc: "Hans-Christoph Steiner" <hans@eds.org>

Subject: Re: diffoscope: crash when comparing two ZIP files

Date: Fri, 07 May 2021 10:41:06 +0100

forwarded 987994 https://salsa.debian.org/reproducible-builds/diffoscope/-/issues/254
thanks

I've forwarded this upstream here:

  https://salsa.debian.org/reproducible-builds/diffoscope/-/issues/254


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #17 received at 987994-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 987994-close@bugs.debian.org

Subject: Bug#987994: fixed in diffoscope 174

Date: Fri, 07 May 2021 10:18:42 +0000

Source: diffoscope
Source-Version: 174
Done: Chris Lamb <lamby@debian.org>

We believe that the bug you reported is fixed in the latest version of
diffoscope, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 987994@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Chris Lamb <lamby@debian.org> (supplier of updated diffoscope package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Fri, 07 May 2021 10:48:54 +0100
Source: diffoscope
Built-For-Profiles: nocheck
Architecture: source
Version: 174
Distribution: unstable
Urgency: medium
Maintainer: Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>
Changed-By: Chris Lamb <lamby@debian.org>
Closes: 987994
Changes:
 diffoscope (174) unstable; urgency=medium
 .
   [ Chris Lamb ]
   * Check that we are parsing an actual Debian .buildinfo file, not just
     a file with that extension.
     (Closes: #987994, reproducible-builds/diffoscope#254)
   * Support signed .buildinfo files again -- file(1) reports them as
     "PGP signed message".
 .
   [ Mattia Rizzolo ]
   * Make the testsuite pass with file(1) version 5.40.
   * Embed some short test fixtures in the test code itself.
   * Fix recognition of compressed .xz files with file(1) 5.40.
Checksums-Sha1:
 a93bf56093aac8c30c91fc6efef7baf912a329de 4938 diffoscope_174.dsc
 35fad3c4a89be65c628ac836c3d23fa7b3b6305e 1014684 diffoscope_174.tar.xz
 31dda0b459f6a7383166efc9febc8daaaa688aef 6828 diffoscope_174_amd64.buildinfo
Checksums-Sha256:
 7443641c12c25a5da90302e433c6f726bdba66be625e89c2744632539ac03c63 4938 diffoscope_174.dsc
 dccffb75e223ac225bff063286f3f9710e5121031d6dd88b706f642d08f7edab 1014684 diffoscope_174.tar.xz
 2a006403a1e980532cb27207f3905b34ae4192359ea7e1d93e7bd36334ce45d3 6828 diffoscope_174_amd64.buildinfo
Files:
 951fdb5c1f20a38e24582169f95aac34 4938 devel optional diffoscope_174.dsc
 0598097b991a1030ecfb80a4a168541e 1014684 devel optional diffoscope_174.tar.xz
 e42ebb7e0dfbdffe56fe86012fc9253b 6828 devel optional diffoscope_174_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEwv5L0nHBObhsUz5GHpU+J9QxHlgFAmCVEEwACgkQHpU+J9Qx
HljmbA/7B5zW4aNfYp7Z4CG7AIFf6ZuCj2K0D3eP8zHS6onn48Me5SIYHQLD8MJ5
6G6/FpSyEODnKarjj41Q8tOixxP1phoESaGcUKO0PHUAXxyFlUjUs3t7+nk9XMz3
gJVa1vm9sglmiymufCeAAPUL8QbxUPju1jOd+9OwqyI1bWb2EnKQcbbMePYxkkXm
RroMRiQeVhsGYUkbohekUFIKW2GZ4X6VhpLf9TSSJpc5eP/IthfRll+wCPIHcCee
+SkumKYl6Mt0gAPMIjhkJZIqIts2z45XCTulDpRMcYXzFJfJR6K3TkQgeUAWvvwi
PHM0TxfjkiDUa4IsqRhXaE3nUiFdQYDKSIcbuQjHadMfZpIHq2R8FsG50jlYI2ti
Mh8j8JrSRC/cl6+twKNFz3CLe9V7Xk1APUiZ/aTzsBlyEcbYODiN/7KzDO7tmZa2
wvCfwNiNLD7oQ4A2arCFnvB6DZGXZyPWK7tZWCnSy3bijE2heBaEI8Mu29XtpHuz
D6Hjcoa3vx4XZEy8ioPOdwlRT5YuB0qY2Bv0kYL3YTDl7SToDPom8owScjT05Gj1
KU6hrzuQU/G8iSIgmWKGBI621UIkx2oGcMaCCoA66C4asxfsRSWZodgX4cdj6Q1n
rpspTI9caiyzH6chDTnyAiHjf9O3k6XN2MU5vBgPYO3E2oRDnpI=
=gBIT
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.