Debian Bug report logs - #986653
stressapptest FTCBFS: AC_TRY_RUN

version graph

Package: src:stressapptest; Maintainer for src:stressapptest is Pierre Blanc <pierreblanc75@gmail.com>;

Reported by: Helmut Grohne <helmut@subdivi.de>

Date: Thu, 8 Apr 2021 20:57:06 UTC

Severity: normal

Tags: patch, upstream

Found in version stressapptest/1.0.6-2

Fixed in version stressapptest/1.0.6-2.2

Done: Vagrant Cascadian <vagrant@debian.org>

Bug is archived. No further changes may be made.

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, Pierre Blanc <pierreblanc75@gmail.com>:
Bug#986653; Package src:stressapptest. (Thu, 08 Apr 2021 20:57:08 GMT) (full text, mbox, link).


Acknowledgement sent to Helmut Grohne <helmut@subdivi.de>:
New Bug report received and forwarded. Copy sent to Pierre Blanc <pierreblanc75@gmail.com>. (Thu, 08 Apr 2021 20:57:09 GMT) (full text, mbox, link).


Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Helmut Grohne <helmut@subdivi.de>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: stressapptest FTCBFS: AC_TRY_RUN
Date: Thu, 8 Apr 2021 20:38:30 +0200
[Message part 1 (text/plain, inline)]
Source: stressapptest
Version: 1.0.6-2
Tags: patch upstream
User: debian-cross@lists.debian.org
Usertags: ftcbfs

stressapptest fails to cross build from source, because it uses
AC_TRY_RUN. Indeed, it uses a cache variable, so it can be made to cross
build in principle. However, the check does not actually need to perform
any test. All it needs to know is whether the pthread_barrier_t type
exists. For that check, AC_CHECK_TYPE is better suited and it works
without extra effort during cross builds. Please consider applying the
attached patch.

Helmut
[cross.patch (text/x-diff, attachment)]

Added tag(s) pending. Request was from Vagrant Cascadian <vagrant@reproducible-builds.org> to 831587-submit@bugs.debian.org. (Thu, 17 Nov 2022 22:21:05 GMT) (full text, mbox, link).


Information forwarded to debian-bugs-dist@lists.debian.org, Pierre Blanc <pierreblanc75@gmail.com>:
Bug#986653; Package src:stressapptest. (Thu, 17 Nov 2022 22:21:07 GMT) (full text, mbox, link).


Acknowledgement sent to Vagrant Cascadian <vagrant@reproducible-builds.org>:
Extra info received and forwarded to list. Copy sent to Pierre Blanc <pierreblanc75@gmail.com>. (Thu, 17 Nov 2022 22:21:07 GMT) (full text, mbox, link).


Message #12 received at 986653@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>
To: 831587@bugs.debian.org, 986653@bugs.debian.org
Subject: NMU for reproducible builds and cross building fixes
Date: Thu, 17 Nov 2022 14:18:01 -0800
[Message part 1 (text/plain, inline)]
Control: tags 831587 pending
Control: tags 986653 pending

Uploaded an NMU to DELAYED/10 fixing these reproducible builds and
cross-building issues:

diff -Nru stressapptest-1.0.6/debian/changelog stressapptest-1.0.6/debian/changelog
--- stressapptest-1.0.6/debian/changelog	2022-09-04 14:42:31.000000000 -0700
+++ stressapptest-1.0.6/debian/changelog	2022-11-17 14:06:40.000000000 -0800
@@ -1,3 +1,15 @@
+stressapptest (1.0.6-2.2) unstable; urgency=medium
+
+  * Non-maintainer upload.
+
+  [ Bernhard M. Wiedemann ]
+  * Allow to override build date with SOURCE_DATE_EPOCH (Closes: #831587)
+
+  [ Helmut Grohne ]
+  * Fix FTCBFS. (Closes: #986653)
+
+ -- Vagrant Cascadian <vagrant@debian.org>  Thu, 17 Nov 2022 14:06:40 -0800
+
 stressapptest (1.0.6-2.1) unstable; urgency=low
 
   * Non-maintainer upload.
diff -Nru stressapptest-1.0.6/debian/patches/allow-to-override-build-date-with-source.patch stressapptest-1.0.6/debian/patches/allow-to-override-build-date-with-source.patch
--- stressapptest-1.0.6/debian/patches/allow-to-override-build-date-with-source.patch	1969-12-31 16:00:00.000000000 -0800
+++ stressapptest-1.0.6/debian/patches/allow-to-override-build-date-with-source.patch	2022-11-17 14:06:40.000000000 -0800
@@ -0,0 +1,36 @@
+From: Bernhard M. Wiedemann <bwiedemann@suse.de>
+Date: Sun, 9 Sep 2018 05:34:37 +0200
+X-Dgit-Generated: 1.0.6-2.2 5763ff92141056c712e2f63a5c1363090e2581aa
+Subject: Allow to override build date with SOURCE_DATE_EPOCH
+
+(Closes: #831587)
+
+in order to make builds reproducible.
+See https://reproducible-builds.org/ for why this is good
+and https://reproducible-builds.org/specs/source-date-epoch/
+for the definition of this variable.
+This date call works with all variants of date (GNU,BSD,Solaris).
+
+Also do not capture build user+host in this case
+to allow to get the same build results anywhere and anytime.
+
+---
+
+diff --git a/configure.ac b/configure.ac
+index 603ba73..818d357 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -99,6 +99,13 @@ timestamp=$(date)
+ AC_MSG_CHECKING([current timestamp])
+ AC_MSG_RESULT([$timestamp])
+ 
++if test -n "$SOURCE_DATE_EPOCH"
++then
++  timestamp=$(date -u -d "@$SOURCE_DATE_EPOCH" 2>/dev/null || date -u -r "$SOURCE_DATE_EPOCH" 2>/dev/null || date -u)
++  username=reproducible
++  hostname=reproducible
++fi
++
+ AC_DEFINE_UNQUOTED([STRESSAPPTEST_TIMESTAMP],
+                    "$username @ $hostname on $timestamp",
+                    [Timestamp when ./configure was executed])
diff -Nru stressapptest-1.0.6/debian/patches/fix-ftcbfs.-closes-986653.patch stressapptest-1.0.6/debian/patches/fix-ftcbfs.-closes-986653.patch
--- stressapptest-1.0.6/debian/patches/fix-ftcbfs.-closes-986653.patch	1969-12-31 16:00:00.000000000 -0800
+++ stressapptest-1.0.6/debian/patches/fix-ftcbfs.-closes-986653.patch	2022-11-17 14:06:40.000000000 -0800
@@ -0,0 +1,41 @@
+From: Helmut Grohne <helmut@subdivi.de>
+Date: Thu, 8 Apr 2021 20:38:30 +0200
+X-Dgit-Generated: 1.0.6-2.2 3b999e567fe8d9786f08825a389114ddf6e6cf15
+Subject: Fix FTCBFS. (Closes: #986653)
+
+
+---
+
+diff --git a/configure.ac b/configure.ac
+index 818d357..82de856 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -127,26 +127,9 @@ AC_SEARCH_LIBS([io_setup], [aio])
+ AC_CHECK_HEADERS([sys/shm.h])
+ AC_SEARCH_LIBS([shm_open], [rt])
+ 
+-AC_MSG_CHECKING(for pthread_barrier)
+-AC_CACHE_VAL(
+-  ac_cv_func_pthread_barrier,
+-  AC_TRY_RUN(
+-    [
+-      #include <pthread.h>
+-      int main(void)
+-      {
+-        pthread_barrier_t t;
+-        return 0;
+-      }
+-    ],
+-    ac_cv_func_pthread_barrier=yes,
+-    ac_cv_func_pthread_barrier=no
+-  )
+-)
+-AC_MSG_RESULT($ac_cv_func_pthread_barrier)
+-if test "$ac_cv_func_pthread_barrier" = "yes"; then
++AC_CHECK_TYPE([pthread_barrier_t],[
+   AC_DEFINE(HAVE_PTHREAD_BARRIER, [1], [Define to 1 if the system has `pthread_barrier'.])
+-fi
++],[],[#include <pthread.h>])
+ 
+ # Checks for typedefs, structures, and compiler characteristics.
+ AC_HEADER_STDBOOL
diff -Nru stressapptest-1.0.6/debian/patches/series stressapptest-1.0.6/debian/patches/series
--- stressapptest-1.0.6/debian/patches/series	2022-09-04 14:42:31.000000000 -0700
+++ stressapptest-1.0.6/debian/patches/series	2022-11-17 14:06:40.000000000 -0800
@@ -2,3 +2,5 @@
 support_i486_builds
 support_i586_builds
 gcc-12
+allow-to-override-build-date-with-source.patch
+fix-ftcbfs.-closes-986653.patch


The reproducible builds patch was pulled from upstream git, which was
similar to the patch originally submitted.


live well,
  vagrant
[signature.asc (application/pgp-signature, inline)]

Reply sent to Vagrant Cascadian <vagrant@debian.org>:
You have taken responsibility. (Sun, 27 Nov 2022 23:15:21 GMT) (full text, mbox, link).


Notification sent to Helmut Grohne <helmut@subdivi.de>:
Bug acknowledged by developer. (Sun, 27 Nov 2022 23:15:21 GMT) (full text, mbox, link).


Message #17 received at 986653-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>
To: 986653-close@bugs.debian.org
Subject: Bug#986653: fixed in stressapptest 1.0.6-2.2
Date: Sun, 27 Nov 2022 23:12:03 +0000
Source: stressapptest
Source-Version: 1.0.6-2.2
Done: Vagrant Cascadian <vagrant@debian.org>

We believe that the bug you reported is fixed in the latest version of
stressapptest, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 986653@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Vagrant Cascadian <vagrant@debian.org> (supplier of updated stressapptest package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Thu, 17 Nov 2022 14:06:40 -0800
Source: stressapptest
Architecture: source
Version: 1.0.6-2.2
Distribution: unstable
Urgency: medium
Maintainer: Pierre Blanc <pierreblanc75@gmail.com>
Changed-By: Vagrant Cascadian <vagrant@debian.org>
Closes: 831587 986653
Changes:
 stressapptest (1.0.6-2.2) unstable; urgency=medium
 .
   * Non-maintainer upload.
 .
   [ Bernhard M. Wiedemann ]
   * Allow to override build date with SOURCE_DATE_EPOCH (Closes: #831587)
 .
   [ Helmut Grohne ]
   * Fix FTCBFS. (Closes: #986653)
Checksums-Sha1:
 d8f7854b24cf7295732f696c39344614d3aed828 1519 stressapptest_1.0.6-2.2.dsc
 9cfaa2610a27909e4c92f02f1f547a06ad870ce0 4712 stressapptest_1.0.6-2.2.debian.tar.xz
Checksums-Sha256:
 37d5c48a90511621ea602a96e922f164ce03645e76aa4164588aaef29c2ad352 1519 stressapptest_1.0.6-2.2.dsc
 efc6168eb49845346c2751ec12cdde450fdfdf43c6bacd6ddf313bc41a26b287 4712 stressapptest_1.0.6-2.2.debian.tar.xz
Files:
 2dd05759b9b2338e815c4642041de0a8 1519 utils extra stressapptest_1.0.6-2.2.dsc
 85a272879fdb84aad59c7302a6d55f8a 4712 utils extra stressapptest_1.0.6-2.2.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iIkEARYKADEWIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCY3axuBMcdmFncmFudEBk
ZWJpYW4ub3JnAAoJENxRj8h/lxaq9dkBANvv/vgTRBu0wMMDAz9ZxUW390ZadYqY
14NBKj2sDGF9AP4zDJhXnvHvZZKwgDttOjh5Q8BzGVIfDIJkRUhv8DB4BA==
=3Td7
-----END PGP SIGNATURE-----




Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Sat, 31 Dec 2022 07:30:33 GMT) (full text, mbox, link).


Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Wed May 17 11:30:44 2023; Machine Name: buxtehude

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.