Debian Bug report logs - #983208
lynx: embeds path to various binaries that differ with usrmerge

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: submit@bugs.debian.org

Subject: lynx: embeds path to various binaries that differ with usrmerge

Date: Sat, 20 Feb 2021 21:04:29 -0800

[Message part 1 (text/plain, inline)]

Source: lynx
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: usrmerge
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The paths to various binaries are embedded in /usr/bin/lynx, which
differs on a usrmerge vs. non-usrmerge system.

  https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/lynx.html

  /usr/bin/lynx

  "/bin/gzip"
  vs.
  "/usr/bin/gzip"


Patch attached which passes variables to configure to use the
non-usrmerge locations, as usrmerge installations typically have
compatibility symlinks, but not vice-versa.


This does not resolve all reproducibility issues (e.g. when /bin/sh
points to bash), but should reduce some of the noise when comparing the
differences.


live well,
  vagrant

[0001-debian-rules-Pass-paths-to-various-binaries.patch (text/x-diff, inline)]

From 65e7a04ed68d33c7adf0a278948f9a7138bb1a69 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Sun, 21 Feb 2021 02:29:36 +0000
Subject: [PATCH 1/2] debian/rules: Pass paths to various binaries.

Use the non-usrmerge locations for binaries, which works on both
usrmerge and non-usrmerge systems.

https://tests.reproducible-builds.org/debian/issues/paths_vary_due_to_usrmerge_issue.html
---
 debian/rules | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/debian/rules b/debian/rules
index b0ca680..7e4ca22 100755
--- a/debian/rules
+++ b/debian/rules
@@ -13,6 +13,15 @@ else
 	CONFTLS := --with-ssl
 endif
 
+# Ensure the most compatible helper program paths to work on both
+# usrmerge and non-usrmerge systems.
+BINARY_PATHS += GZIP=/bin/gzip
+BINARY_PATHS += UNCOMPRESS=/bin/gunzip
+BINARY_PATHS += MV=/bin/mv
+BINARY_PATHS += ZCAT=/bin/zcat
+BINARY_PATHS += TAR=/bin/tar
+BINARY_PATHS += RM=/bin/rm
+
 override_dh_auto_configure:
 ifeq ($(SSL),gnu)
 	sed -i -e s/libssl-dev/libgnutls28-dev/g debian/control
@@ -36,6 +45,7 @@ endif
         --enable-read-eta --enable-scrollbar --enable-syslog \
 	--with-zlib --with-bzlib --without-included-gettext \
 	--with-screen=ncursesw --enable-justify-elts \
+	$(BINARY_PATHS) \
 	$(CONFTLS)
 
 override_dh_autoreconf:
-- 
2.20.1

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 983208@bugs.debian.org (full text, mbox, reply):

From: Andreas Metzler <ametzler@bebt.de>

To: Vagrant Cascadian <vagrant@reproducible-builds.org>, 983208@bugs.debian.org

Subject: Re: Bug#983208: lynx: embeds path to various binaries that differ with usrmerge

Date: Sun, 21 Feb 2021 13:51:39 +0100

Control: tags -1 pending

On 2021-02-21 Vagrant Cascadian <vagrant@reproducible-builds.org> wrote:
> Source: lynx
> Severity: normal
> Tags: patch
> User: reproducible-builds@lists.alioth.debian.org
> Usertags: usrmerge
> X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

> The paths to various binaries are embedded in /usr/bin/lynx, which
> differs on a usrmerge vs. non-usrmerge system.

>   https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/lynx.html

>   /usr/bin/lynx

>   "/bin/gzip"
>   vs.
>   "/usr/bin/gzip"


> Patch attached which passes variables to configure to use the
> non-usrmerge locations, as usrmerge installations typically have
> compatibility symlinks, but not vice-versa.

> This does not resolve all reproducibility issues (e.g. when /bin/sh
> points to bash), but should reduce some of the noise when comparing the
> differences.
[...]

Hello,

Reluctantly applied. I don't get the point of trying to do reproducible
builds on systems that differ significantly (usrmerge or not), it feels
like make-work.

cu Andreas
-- 
`What a good friend you are to him, Dr. Maturin. His other friends are
so grateful to you.'
`I sew his ears on from time to time, sure'

Message #17 received at 983208@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: Andreas Metzler <ametzler@bebt.de>, 983208@bugs.debian.org

Subject: Re: Bug#983208: lynx: embeds path to various binaries that differ with usrmerge

Date: Sun, 21 Feb 2021 09:38:56 -0800

[Message part 1 (text/plain, inline)]

On 2021-02-21, Andreas Metzler wrote:
> On 2021-02-21 Vagrant Cascadian <vagrant@reproducible-builds.org> wrote:
>> The paths to various binaries are embedded in /usr/bin/lynx, which
>> differs on a usrmerge vs. non-usrmerge system.
...
>> Patch attached which passes variables to configure to use the
>> non-usrmerge locations, as usrmerge installations typically have
>> compatibility symlinks, but not vice-versa.
>
>> This does not resolve all reproducibility issues (e.g. when /bin/sh
>> points to bash), but should reduce some of the noise when comparing the
>> differences.
> [...]
>
> Hello,
>
> Reluctantly applied.

Thanks for applying.


> I don't get the point of trying to do reproducible builds on systems
> that differ significantly (usrmerge or not), it feels like make-work.

I get that, for sure.

The current reproducible builds test infrastructure is geared towards
finding issues so that we can fix them; some of the issues may seem to
be nuanced corner-cases.

In the case of usrmerge, both usrmerge and non-usrmerge systems exist in
the wild; having fewer variables that affect the build makes it
significantly easier to reproduce a build and more resilient. Bugs
triggered by building in a usrmerge environment have actually resulted
in functionally broken packages in several cases, too, so it does seem
to me important to find them early.


live well,
  vagrant

[signature.asc (application/pgp-signature, inline)]

Message #22 received at 983208@bugs.debian.org (full text, mbox, reply):

From: Andreas Metzler <ametzler@bebt.de>

To: Vagrant Cascadian <vagrant@reproducible-builds.org>

Cc: 983208@bugs.debian.org

Subject: Re: Bug#983208: lynx: embeds path to various binaries that differ with usrmerge

Date: Mon, 22 Feb 2021 18:44:35 +0100

On 2021-02-21 Vagrant Cascadian <vagrant@reproducible-builds.org> wrote:
> On 2021-02-21, Andreas Metzler wrote:
[...]

> Thanks for applying.


> > I don't get the point of trying to do reproducible builds on systems
> > that differ significantly (usrmerge or not), it feels like make-work.

> I get that, for sure.

> The current reproducible builds test infrastructure is geared towards
> finding issues so that we can fix them; some of the issues may seem to
> be nuanced corner-cases.

> In the case of usrmerge, both usrmerge and non-usrmerge systems exist in
> the wild; having fewer variables that affect the build makes it
> significantly easier to reproduce a build and more resilient. Bugs
> triggered by building in a usrmerge environment have actually resulted
> in functionally broken packages in several cases, too, so it does seem
> to me important to find them early.

Ok, I see.

Thankfully we will get rid of that major source of make-work
(supporting both usrmerge and unmerged) post bullseye ;-) #981582

Thanks, cu Andreas
-- 
`What a good friend you are to him, Dr. Maturin. His other friends are
so grateful to you.'
`I sew his ears on from time to time, sure'

Message #27 received at 983208-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 983208-close@bugs.debian.org

Subject: Bug#983208: fixed in lynx 2.9.0dev.6-2

Date: Tue, 02 Mar 2021 12:18:44 +0000

Source: lynx
Source-Version: 2.9.0dev.6-2
Done: Andreas Metzler <ametzler@debian.org>

We believe that the bug you reported is fixed in the latest version of
lynx, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 983208@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Andreas Metzler <ametzler@debian.org> (supplier of updated lynx package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Tue, 02 Mar 2021 13:02:20 +0100
Source: lynx
Architecture: source
Version: 2.9.0dev.6-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Lynx Packaging Team <pkg-lynx-maint@lists.alioth.debian.org>
Changed-By: Andreas Metzler <ametzler@debian.org>
Closes: 983208 983209
Changes:
 lynx (2.9.0dev.6-2) unstable; urgency=medium
 .
   [ Axel Beckert ]
   * Retroactively mention #961080 in previous debian/changelog entry.
 .
   [ Debian Janitor ]
   * Fix day-of-week for changelog entries 2.8.8dev.2-1, 2.8.6-1.
 .
   [ Andreas Metzler ]
   * Hardcode paths for gzip et al for improved reproducible build with/without
     usrmerge. (Patch by Vagrant Cascadian) Closes: #983208
   * [lintian] Use v4 watchfile standard.
   * Add override for lintian false positive
     debian-changelog-file-is-a-symlink.
   * 40_parallel_build_fix.diff: Use "grouped target" to fix doc breakage on
     parallel build. Closes: #983209
   * Bump Standards-Version to 4.5.1. (No changes)
Checksums-Sha1: 
 fba320366134844af62edac605d0e22c76ff9b3e 2528 lynx_2.9.0dev.6-2.dsc
 e65d633de51fa7415bd80d4f79b64ff046e35f35 29476 lynx_2.9.0dev.6-2.debian.tar.xz
Checksums-Sha256: 
 8a8d439e9e053e2ead6e34dbd30fd17d3e14bc0ec02f228cd1c2bfeffcba8979 2528 lynx_2.9.0dev.6-2.dsc
 207c6504519b6c992c17edbda1c7d586789c07c35b31c5aad31bfe2c6f87a5bb 29476 lynx_2.9.0dev.6-2.debian.tar.xz
Files: 
 e8259d97acf1483f5f0901aa58fe29dd 2528 web optional lynx_2.9.0dev.6-2.dsc
 25d0bfd4775f414b56df446d2949707c 29476 web optional lynx_2.9.0dev.6-2.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE0uCSA5741Jbt9PpepU8BhUOCFIQFAmA+KlAACgkQpU8BhUOC
FIRHqA/9G63TQZX6c46PI3rqYrh1Z926+ex7GxYm/FfYCTA/m18TMhkXbifstxNE
o6kPwYaz4Y9f6e80QzGdfAboHAFsnaxzL7f8EU5vV9UGA37CaEop/AT3DTMYk334
wjHTUCQw+lgPdRSgIIZmznfXbvBFLrKhpBbr+eO5atTloGqMclAwf7uPOq4Or+WW
Ut0ar+whH/vpU1tRKV6XolchqfMbu0AeYtVmdMl2bKlQH0M1jZFuBzAFF2UQTQnD
S0jP8uz+TzPO2/RqMXuGbIZBsOIBN68hi1i8m0MKncOtKXgTC7wTjsXQ/Uv3Nd5E
YnNGM/QerpLLIVSwXPaRjDngnTssY4weeLn8xwGa52FhrZIWXPAOGne79UKx9drB
A0St3/1V0bU/5W8SqmwD6CLf/NowaYQkpZdZFf4U3Fo5s/oaSAEz1CPHroiyWztQ
FoaScQeGLo+09thOgjDXTl2HFgN7PLEKfumrbzslV/j6iM6iEglJsztdG+oL1xN8
6v41kVOWFDJvtHBFPes3RtpfSuqdstxVLHf1aPtGaI8fMeL3W75OI/icThD0bxeR
JYiurQH1kpFMAGkYfq/y+tvVNhY+ZCbyrfqUhHTlDOj7kubjftQ1C/B+06bP+gkD
zfhMwI7GEsTyeZLwCywcYjUkJRIpO9Ba0UddZXtzbc4yLiZum+Q=
=RvCk
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.