Debian Bug report logs - #980356
dh-strip-nondeterminism: Should not bail out on read-only files

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Axel Beckert <abe@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: dh-strip-nondeterminism: Should not bail out on read-only files

Date: Mon, 18 Jan 2021 05:33:57 +0100

Package: dh-strip-nondeterminism
Version: 1.9.0-1
Severity: wishlist

Hi,

working on packages not updated for quite a while, I did the following
changes to libcgi-github-webhook-perl:

* Bump debhelper from 9 to 13.
* Set "Rules-Requires-Root: no".

This caused a FTBFS because dh_strip_nondeterminism failed to strip
non-determinism from files installed with mode 444:

[…]
   dh_strip_nondeterminism
dh_strip_nondeterminism: error: debian/libcgi-github-webhook-perl/usr/share/perl5/auto/share/module/CGI-Github-Webhook/errored.png: debian/libcgi-github-webhook-perl/usr/share/perl5/auto/share/module/CGI-Github-Webhook/errored.png: unable to overwrite: copy_data: Permission denied at /usr/share/perl5/File/StripNondeterminism/handlers/png.pm line 78.

dh_strip_nondeterminism: error: debian/libcgi-github-webhook-perl/usr/share/perl5/auto/share/module/CGI-Github-Webhook/failed.png: debian/libcgi-github-webhook-perl/usr/share/perl5/auto/share/module/CGI-Github-Webhook/failed.png: unable to overwrite: copy_data: Permission denied at /usr/share/perl5/File/StripNondeterminism/handlers/png.pm line 78.

dh_strip_nondeterminism: error: debian/libcgi-github-webhook-perl/usr/share/perl5/auto/share/module/CGI-Github-Webhook/success.png: debian/libcgi-github-webhook-perl/usr/share/perl5/auto/share/module/CGI-Github-Webhook/success.png: unable to overwrite: copy_data: Permission denied at /usr/share/perl5/File/StripNondeterminism/handlers/png.pm line 78.

dh_strip_nondeterminism: error: Aborting due to earlier error
[…]

The files in question were installed by the build system (probably
caused by libdist-zilla-perl's Dist::Zilla::Plugin::ModuleShareDirs) as
follows:

-r--r--r-- 1 abe abe 1629 Jan 18 05:22 errored.png
-r--r--r-- 1 abe abe  756 Jan 18 05:22 errored.svg
-r--r--r-- 1 abe abe 1645 Jan 18 05:22 failed.png
-r--r--r-- 1 abe abe  754 Jan 18 05:22 failed.svg
-r--r--r-- 1 abe abe 1672 Jan 18 05:22 success.png
-r--r--r-- 1 abe abe  749 Jan 18 05:22 success.svg

My workaround so far is this in debian/rules:

override_dh_strip_nondeterminism:
	find debian/libcgi-github-webhook-perl -perm 444 | xargs chmod -c 644
	dh_strip_nondeterminism

But IMHO this shouldn't be necessary.

How to reproduce:

Use a git checkout of https://github.com/xtaran/CGI-Github-Webhook and
comment out that "find" line in debian/rules.

-- System Information:
Debian Release: bullseye/sid
  APT prefers unstable
  APT policy: (990, 'unstable'), (600, 'testing'), (500, 'unstable-debug'), (500, 'buildd-unstable'), (110, 'experimental'), (1, 'experimental-debug'), (1, 'buildd-experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.10.0-1-amd64 (SMP w/4 CPU threads)
Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)
LSM: AppArmor: enabled

Versions of packages dh-strip-nondeterminism depends on:
ii  libdebhelper-perl                 13.3.1
ii  libfile-stripnondeterminism-perl  1.9.0-1
ii  perl                              5.32.0-6

dh-strip-nondeterminism recommends no packages.

dh-strip-nondeterminism suggests no packages.

-- no debconf information

Message #10 received at 980356@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>

To: "Axel Beckert" <abe@debian.org>, 980356@bugs.debian.org

Subject: Re: Bug#980356: dh-strip-nondeterminism: Should not bail out on read-only files

Date: Mon, 18 Jan 2021 09:35:51 +0000

tags 980356 + pending
thanks

Hi Axel,

> My workaround so far is this in debian/rules:
>
> override_dh_strip_nondeterminism:
> 	find debian/libcgi-github-webhook-perl -perm 444 | xargs chmod -c 644
> 	dh_strip_nondeterminism
>
> But IMHO this shouldn't be necessary.

Agreed, and thanks for the report plus the steps on how to easily
reproduce. I'm uploading strip-nondeterminism 1.10.0 very shortly that
prints the following when run against your package with the "find"
line removed.

     dh_link
     dh_strip_nondeterminism
  dh_strip_nondeterminism: warning: Ignoring unwritable file: errored.png
  dh_strip_nondeterminism: warning: Ignoring unwritable file: failed.png
  dh_strip_nondeterminism: warning: Ignoring unwritable file: success.png
     dh_compress
     dh_fixperms


Best wishes,

--
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org 🍥 chris-lamb.co.uk
       `-

Message #15 received at 980356-submitter@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: 980356-submitter@bugs.debian.org

Subject: Bug#980356 marked as pending in strip-nondeterminism

Date: Mon, 18 Jan 2021 09:36:08 +0000

Control: tag -1 pending

Hello,

Bug #980356 in strip-nondeterminism reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/reproducible-builds/strip-nondeterminism/-/commit/3fe0b33b0b8a76f5148f442087fdfbe00cff27af

------------------------------------------------------------------------
Ignore unwritable files, printing a warning. (Closes: #980356)
------------------------------------------------------------------------

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/980356

Message #20 received at 980356@bugs.debian.org (full text, mbox, reply):

From: Axel Beckert <abe@debian.org>

To: Chris Lamb <lamby@debian.org>

Cc: 980356@bugs.debian.org

Subject: Re: Bug#980356: dh-strip-nondeterminism: Should not bail out on read-only files

Date: Mon, 18 Jan 2021 10:49:58 +0100

Hi Chris,

Chris Lamb wrote:
> > My workaround so far is this in debian/rules:
> >
> > override_dh_strip_nondeterminism:
> > 	find debian/libcgi-github-webhook-perl -perm 444 | xargs chmod -c 644
> > 	dh_strip_nondeterminism
> >
> > But IMHO this shouldn't be necessary.
> 
> Agreed, and thanks for the report plus the steps on how to easily
> reproduce. I'm uploading strip-nondeterminism 1.10.0 very shortly that
> prints the following when run against your package with the "find"
> line removed.
> 
>      dh_link
>      dh_strip_nondeterminism
>   dh_strip_nondeterminism: warning: Ignoring unwritable file: errored.png
>   dh_strip_nondeterminism: warning: Ignoring unwritable file: failed.png
>   dh_strip_nondeterminism: warning: Ignoring unwritable file: success.png
>      dh_compress
>      dh_fixperms

Hmmm, ok, that was not the solution I expected, but is indeed a very
unintrusive solution.

I kinda expected that it kinda forces an optimization as it obviously
does when running under root.

Then again, it's just a kind of optimization. If that one is no more
done and the RB buildds show a regression, it's at least clear where
it comes from.

So thanks for the unexpectedly prompt fix! :-)

		Regards, Axel
-- 
 ,''`.  |  Axel Beckert <abe@debian.org>, https://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-    |  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE

Message #25 received at 980356-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 980356-close@bugs.debian.org

Subject: Bug#980356: fixed in strip-nondeterminism 1.10.0-1

Date: Mon, 18 Jan 2021 09:52:48 +0000

Source: strip-nondeterminism
Source-Version: 1.10.0-1
Done: Chris Lamb <lamby@debian.org>

We believe that the bug you reported is fixed in the latest version of
strip-nondeterminism, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 980356@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Chris Lamb <lamby@debian.org> (supplier of updated strip-nondeterminism package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Mon, 18 Jan 2021 09:30:40 +0000
Source: strip-nondeterminism
Architecture: source
Version: 1.10.0-1
Distribution: unstable
Urgency: medium
Maintainer: Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>
Changed-By: Chris Lamb <lamby@debian.org>
Closes: 980356
Changes:
 strip-nondeterminism (1.10.0-1) unstable; urgency=medium
 .
   [ Chris Lamb ]
   * Ignore unwritable files, printing a warning. (Closes: #980356)
 .
   [ Holger Levsen ]
   * Update Standards-Version to 4.5.1, no changes needed.
Checksums-Sha1:
 434a530b63a23934efa10db2596dcb754ca90676 2828 strip-nondeterminism_1.10.0-1.dsc
 232173685faf45d094b2a70336bff345956092a3 278913 strip-nondeterminism_1.10.0.orig.tar.bz2
 2e36cc970e67d2c517859725fe39be480807548a 833 strip-nondeterminism_1.10.0.orig.tar.bz2.asc
 4859c1b20c39c33f70ba37dcd27cabe36d973211 33220 strip-nondeterminism_1.10.0-1.debian.tar.xz
 e451a5a6a69b2a6910a7faa2040c7e16c85cf9d2 6820 strip-nondeterminism_1.10.0-1_amd64.buildinfo
Checksums-Sha256:
 6b576d6904db42efcb35a1bae619fac36b82cb8acc2ff70b0f4a73ebb4bcd39e 2828 strip-nondeterminism_1.10.0-1.dsc
 4abdab8b55060aa151d78f56fca1a200e37ba6561db97168572163f7db5bcd9b 278913 strip-nondeterminism_1.10.0.orig.tar.bz2
 10dd2f6ea299df24cfc1d063fa9c83922fb28fb1624de870adfac11ce5c7cae9 833 strip-nondeterminism_1.10.0.orig.tar.bz2.asc
 cd6f393f31da531d88f18688e222e6f5d27701efef8cacc8d597c066b479e38f 33220 strip-nondeterminism_1.10.0-1.debian.tar.xz
 348b54ace71c55016b86ad9641eee64c2090633990c39ebeaeee78543f72f00f 6820 strip-nondeterminism_1.10.0-1_amd64.buildinfo
Files:
 acbf46691c4921e36c09e04a7d8d31ee 2828 devel optional strip-nondeterminism_1.10.0-1.dsc
 88db4d501649d47deb58eb61d9fef031 278913 devel optional strip-nondeterminism_1.10.0.orig.tar.bz2
 68a6a345585704243d4de6f534715d9c 833 devel optional strip-nondeterminism_1.10.0.orig.tar.bz2.asc
 8296dfb62cb9fd0ea5311c1e4504c0b0 33220 devel optional strip-nondeterminism_1.10.0-1.debian.tar.xz
 716ba05025017fae40ce6f35347f9f22 6820 devel optional strip-nondeterminism_1.10.0-1_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEwv5L0nHBObhsUz5GHpU+J9QxHlgFAmAFVo8ACgkQHpU+J9Qx
HljXOg//ZFWiHEk6JSxFh+S87pmCuokNZe53mJNDaW9UBMGUSEP6jvMtfiTHTkPp
HWftHJ0kz989zdmy0kyF+AgH+rtr7FWhajfLnGOYAo1eXVsNnX5ibifAGCvpHcc+
tMsjEgCcQak9l5CTGPJb2AL5Epg+S28ucAgQeeYlqZoI7Dhx3B/Hp5IE2e73SqSX
mEHB781Bke30DOShpBUbhRVlyFzw+72CGcdW+LRHAP0R98gAlvjqU0SQ8bGP80DS
6a8r3/8g9w5HpgHrBxVEWdd3lfXsY6RwZEmXZPjyr4opi4inmdoHqPvindJs9s6X
+J43e23lkzWlk0PxncfEeQf0pgyJJ6F3c4OameK/0tmL80TE4sUU5RoQyRwZTY91
OcoakaSDgqyuKYwLnU0OXSMZf0b3hCvhD3t0v9DfYFLT3lI9xehdluFTChhSQqUL
TGwbmU0k96ZF9uhnwvUgN8Ntt44OItNOjyQ0f6BdyleuK5hyHV/vB9zCXBDhtcY4
g4Nvv3oQzpUweqqnuIri8WRnrZOF9UTHQm2oH2svZmyb+PB3OjGzvCCC9AnE2NDF
qlFbaSFUeRC29WdQ1G5Y3gZ7wSWhckoiDb1/2bCNKpALe+zeshtyK/fAfw+t9Abv
sml2k4jmCM0gnZjzysBDK+Ug/oz/4F6oMYuz43WabtJfW99Lct8=
=1bIW
-----END PGP SIGNATURE-----

Message #30 received at 980356@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>

To: "Axel Beckert" <abe@debian.org>

Cc: 980356@bugs.debian.org

Subject: Re: Bug#980356: dh-strip-nondeterminism: Should not bail out on read-only files

Date: Mon, 18 Jan 2021 11:27:28 +0000

Hi Axel,

> I kinda expected that it kinda forces an optimization as it obviously
> does when running under root.

I do see the merit in this approach, but it would make the behaviour
both slightly inconsistent and opaque, so I thought this alternative
(which, as you imply, logs it loudly) would, on balance, be worth
trying first.

Happy to revisit this in the future, especially if it generates too
many spurious and distracting warnings when building packages.


Regards,

--
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org 🍥 chris-lamb.co.uk
       `-

Send a report that this bug log contains spam.