Debian Bug report logs - #979134
apertium-anaphora: please make the build reproducible

[Message part 1 (text/plain, inline)]
Source: apertium-anaphora
Version: 1.0.1-1
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: environment
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0] we noticed that
apertium-anaphora could not be built reproducibly.

This is because it uses a BASH variable, which appears to vary
depending on whether /bin/sh points to /bin/bash or not.

Patch attached that forces /bin/bash — this script needs Bash (it uses
'[[', for example).

 [0] https://reproducible-builds.org/

Regards,

--
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-
[apertium-anaphora.diff.txt (text/plain, attachment)]
[Message part 1 (text/plain, inline)]
How does it vary? $BASH is set by AC_PATH_PROG(BASH, bash, no) at
https://github.com/apertium/apertium-anaphora/blob/master/configure.ac#L39
which should never find /bin/sh

I agree it always needs Bash, but I don't see how it can find anything but
/bin/bash or /usr/bin/bash or whatever bash is in $PATH. The idea, as
horrible as it is, is to respect and bake-in any Bash found from a user's
home folder install.

What I did for apertium is to change it to /usr/bin/env bash (which a
helper script turns into /bin/bash for Debian packaging), which I can also
do for apertium-anaphora and other Apertium tools.

-- Tino Didriksen

On Sun, 3 Jan 2021 at 11:48, Chris Lamb <lamby@debian.org> wrote:

> Source: apertium-anaphora
> Version: 1.0.1-1
> Severity: wishlist
> Tags: patch
> User: reproducible-builds@lists.alioth.debian.org
> Usertags: environment
> X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org
>
> Hi,
>
> Whilst working on the Reproducible Builds effort [0] we noticed that
> apertium-anaphora could not be built reproducibly.
>
> This is because it uses a BASH variable, which appears to vary
> depending on whether /bin/sh points to /bin/bash or not.
>
> Patch attached that forces /bin/bash — this script needs Bash (it uses
> '[[', for example).
>
>  [0] https://reproducible-builds.org/
>
>
> Regards,
>
> --
>       ,''`.
>      : :'  :     Chris Lamb
>      `. `'`      lamby@debian.org / chris-lamb.co.uk
>        `---
> debian-science-maintainers mailing list
> debian-science-maintainers@alioth-lists.debian.net
>
> https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/debian-science-maintainers

[Message part 2 (text/html, inline)]
Hi Tino,

> How does it vary? $BASH is set by AC_PATH_PROG(BASH, bash, no) at
> https://github.com/apertium/apertium-anaphora/blob/master/configure.ac#L39 which should never find /bin/sh

It varies as follows:

  https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/apertium-anaphora.html

… although that doesn't really answer the question. I wonder if it is
(reverse?) resolving symlinks? I'm afraid I didn't poke deep into it
enough...

> What I did for apertium is to change it to /usr/bin/env bash (which a
> helper script turns into /bin/bash for Debian packaging), which I can
> also do for apertium-anaphora and other Apertium tools.

Ah, interesting. Sounds like this should work.

Best wishes,

--
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org 🍥 chris-lamb.co.uk
       `-

[Message part 1 (text/plain, inline)]
Fixed upstream and in Salsa
https://salsa.debian.org/science-team/apertium-anaphora

-- Tino Didriksen

[Message part 2 (text/html, inline)]
Source: apertium-anaphora
Source-Version: 1.0.2-1
Done: Kartik Mistry <kartik@debian.org>

We believe that the bug you reported is fixed in the latest version of
apertium-anaphora, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 979134@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Kartik Mistry <kartik@debian.org> (supplier of updated apertium-anaphora package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sun, 17 Jan 2021 13:22:41 +0530
Source: apertium-anaphora
Architecture: source
Version: 1.0.2-1
Distribution: unstable
Urgency: low
Maintainer: Debian Science Team <debian-science-maintainers@alioth-lists.debian.net>
Changed-By: Kartik Mistry <kartik@debian.org>
Closes: 979134
Changes:
 apertium-anaphora (1.0.2-1) unstable; urgency=low
 .
   [ Tino Didriksen ]
   * Don't search for Bash (Closes: #979134)
 .
   [ Kartik Mistry ]
   * debian/upstream/metadata:
     + Use better Documentation link.
Checksums-Sha1:
 834875d21495821b53066158cf87ea9a6dc4ef6b 2103 apertium-anaphora_1.0.2-1.dsc
 b4b14968506c30c8d9bb078fad5c523a66e88625 24620 apertium-anaphora_1.0.2.orig.tar.bz2
 a66767ae70b58ebcd78d4b3a7f2377d0a0bea189 2316 apertium-anaphora_1.0.2-1.debian.tar.xz
Checksums-Sha256:
 491643f67601090ca87e20dbbea73ca6e234f2d8316f1b8463c3c087571fc42e 2103 apertium-anaphora_1.0.2-1.dsc
 0a49b66faa82534857dac43535b8671f33ef284bccf85bd5cf7c6f9ca1170b19 24620 apertium-anaphora_1.0.2.orig.tar.bz2
 09029b91476849e74f763869759f67d25fcfd7f0285736645529ad0bf32148dc 2316 apertium-anaphora_1.0.2-1.debian.tar.xz
Files:
 ecdca79f029c93a41b52b5289506651b 2103 science optional apertium-anaphora_1.0.2-1.dsc
 22bc1d1c9831c0096387b3aa16a9ee08 24620 science optional apertium-anaphora_1.0.2.orig.tar.bz2
 8dc0a68e0fc269d3833e705440e25726 2316 science optional apertium-anaphora_1.0.2-1.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEa2MbXvVUr2sRlmKSAsHT8ng6pN4FAmAD8CgACgkQAsHT8ng6
pN7K1Q//XSSGqlWlWP1Wo6aS2X+nXyFcHkdTJkQemqby3xF4QRAgcGf91NtVc8SA
Vcls3X6u3lWbKM88dyBAMjf1JlquKFZTGAkrbCCw2MKB3i8f1MJzJFxcaqI3e+hm
NXBHHfd8rvhaGu3JaULKOXwaSxLSwUIeS/OUbyV+QZ8cOltpjsEUg45cVwXnllTM
kXW51tSblvg+jxVmvyHUsJ57D2nCB9DSWb1074sF6TlBxAUjK/GA40KRXwsDXdIz
qsFsrJWIgHonuDlr9+wzw+jguq1uimMFxhXyVkEbE59NZkU+MSEHbsepTAsg6qlf
ot7dVVVO6Gz7onDxTiqJSCLw8KYzixL+Gc7Bcrn6TWTC7jELkruS3YH5ul0m3OeF
ndN9mJ5Eg/i2BSLwnpVdnlLh3rFkP7VVJHKPQgyhAAyrPBtlMCwQOu7NNvk/Q/Qo
LR00dRMGgvIqxHhL/qzQrNk07bXoVLG0s1IGQhTvydeJ2d59Cwsi1PuKaLnEH9tR
qmKEUIuBmD63SJHioy6dNAeLP9H7jpeHdNtwwImEe+3pzFUafozQLo51JBgtsaPw
Fv2Jdt4DzCx3sDLX4GUt+vTcPXVRhbJYp/Ousw2v2Bkz9Z6CS9JlMGZVLOAUOH5M
2ERQqusKWBERqcIvP0sX0/Kax7poPE9ynxUnbwSaX/EGbeuOlMk=
=vGdq
-----END PGP SIGNATURE-----

Debian Bug report logs - #979134 apertium-anaphora: please make the build reproducible

Debian Bug report logs - #979134
apertium-anaphora: please make the build reproducible