Debian Bug report logs - #979019
lirc: reproducible builds: Embeds timestamps and kernel version in various files

Reply or subscribe to this bug.

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: submit@bugs.debian.org

Subject: lirc: reproducible builds: Embeds timestamps and kernel version in various files

Date: Fri, 01 Jan 2021 17:19:48 -0800

[Message part 1 (text/plain, inline)]

Source: lirc
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: timestamps kernel
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Various files embed timestamps and the running kernel version:

  https://tests.reproducible-builds.org/debian/rb-pkg/bullseye/i386/diffoscope-results/lirc.html

  /etc/lirc/lircd.conf.d/devinput.lircd.conf

  #·Generated·by·lirc-make-devinput·on·4.19.0-11-amd64
  vs.
  #·Generated·by·lirc-make-devinput·on·4.19.0-11-686-pae
  
  #·Date:·Thu·Nov·11·01:28:19·-12·2021
  vs.
  #·Date:·Fri·Oct··9·21:13:04·+14·2020

The attached patch fixes this by adjusting the tools used to generate
these files to not embed the timestamps or kernel version.


Thanks for maintaining lirc!


live well,
  vagrant

[0001-debian-patches-Add-patch-to-avoid-embedding-build-ti.patch (text/x-diff, inline)]

From 5a83c1b30f769d00d8a5f60785f001eda842981a Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Sat, 2 Jan 2021 00:41:38 +0000
Subject: [PATCH 1/3] debian/patches: Add patch to avoid embedding build time
 and kernel version in build results.

---
 ...ld-date-and-kernel-version-in-variou.patch | 60 +++++++++++++++++++
 debian/patches/series                         |  1 +
 2 files changed, 61 insertions(+)
 create mode 100644 debian/patches/0009-Do-not-embed-build-date-and-kernel-version-in-variou.patch

diff --git a/debian/patches/0009-Do-not-embed-build-date-and-kernel-version-in-variou.patch b/debian/patches/0009-Do-not-embed-build-date-and-kernel-version-in-variou.patch
new file mode 100644
index 0000000..66455ed
--- /dev/null
+++ b/debian/patches/0009-Do-not-embed-build-date-and-kernel-version-in-variou.patch
@@ -0,0 +1,60 @@
+From 557300dcda769bb04e0ae03393b892c7e371403f Mon Sep 17 00:00:00 2001
+From: Vagrant Cascadian <vagrant@reproducible-builds.org>
+Date: Sat, 2 Jan 2021 00:01:20 +0000
+Subject: [PATCH] Do not embed build date and kernel version in various files.
+
+https://reproducible-builds.org/docs/timestamps/
+https://tests.reproducible-builds.org/debian/issues/unstable/captures_kernel_version_issue.html
+---
+ tools/irdb-get           | 2 +-
+ tools/lirc-lsplugins.cpp | 5 ++---
+ tools/lirc-make-devinput | 3 +--
+ 3 files changed, 4 insertions(+), 6 deletions(-)
+
+diff --git a/tools/irdb-get b/tools/irdb-get
+index e4e0a26..7688475 100755
+--- a/tools/irdb-get
++++ b/tools/irdb-get
+@@ -193,7 +193,7 @@ def do_yaml_config():
+         lircmd_by_driver[driver].append("%s/%s" % (tokens[0], tokens[2]))
+ 
+     print("#")
+-    print("# Created by 'irdb-get yaml-config' at " + time.ctime())
++    print("# Created by 'irdb-get yaml-config' ")
+     print("#")
+     print("\nlircd_by_driver:")
+     print_yaml_dict(lircd_by_driver)
+diff --git a/tools/lirc-lsplugins.cpp b/tools/lirc-lsplugins.cpp
+index ba67a3c..d38087f 100644
+--- a/tools/lirc-lsplugins.cpp
++++ b/tools/lirc-lsplugins.cpp
+@@ -415,10 +415,9 @@ static void print_header(void)
+ static void print_yaml_header(void)
+ {
+ 	static const char* const YAML_HEADER =
+-		"#\n# Generated by lirc-lsplugins --yaml (%s) at %s#\n ";
+-	const time_t now = time(NULL);
++		"#\n# Generated by lirc-lsplugins --yaml (%s)\n ";
+ 
+-	printf(YAML_HEADER, VERSION, ctime(&now));
++	printf(YAML_HEADER, VERSION);
+ 	printf("\ndrivers:\n");
+ }
+ 
+diff --git a/tools/lirc-make-devinput b/tools/lirc-make-devinput
+index f7e6f97..c37b5e1 100755
+--- a/tools/lirc-make-devinput
++++ b/tools/lirc-make-devinput
+@@ -61,8 +61,7 @@ if test -n "$lirc_map"; then
+ fi
+ 
+ 
+-echo "# Generated by $(basename $0) on $(uname -r)"
+-echo "# Date: $(date)"
++echo "# Generated by $(basename $0)"
+ cat <<EOF
+ 
+ begin remote
+-- 
+2.30.0
+
diff --git a/debian/patches/series b/debian/patches/series
index cb72009..7797a6c 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -6,3 +6,4 @@
 0006-lirc-gpio-ir-0.10.patch
 0007-python3.8.diff
 0008-doxyfile-Don-t-include-full-pathname-961954.patch
+0009-Do-not-embed-build-date-and-kernel-version-in-variou.patch
-- 
2.20.1

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 979019@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: 979019@bugs.debian.org

Subject: Re: lirc: reproducible builds: Embeds timestamps and kernel version in various files

Date: Tue, 31 May 2022 08:45:15 -0700

[Message part 1 (text/plain, inline)]

Control: forwarded 979019 https://sourceforge.net/p/lirc/git/merge-requests/36/

On 2021-01-01, Vagrant Cascadian wrote:
> Various files embed timestamps and the running kernel version:
>
>   https://tests.reproducible-builds.org/debian/rb-pkg/bullseye/i386/diffoscope-results/lirc.html
>
>   /etc/lirc/lircd.conf.d/devinput.lircd.conf
>
>   #·Generated·by·lirc-make-devinput·on·4.19.0-11-amd64
>   vs.
>   #·Generated·by·lirc-make-devinput·on·4.19.0-11-686-pae
>   
>   #·Date:·Thu·Nov·11·01:28:19·-12·2021
>   vs.
>   #·Date:·Fri·Oct··9·21:13:04·+14·2020
>
> The attached patch fixes this by adjusting the tools used to generate
> these files to not embed the timestamps or kernel version.

Appears to have been submitted and/or merged upstream:

  https://sourceforge.net/p/lirc/git/merge-requests/36/

live well,
  vagrant

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 979019@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: 979019@bugs.debian.org

Subject: Re: lirc: reproducible builds: Embeds timestamps and kernel version in various files

Date: Tue, 31 May 2022 09:02:43 -0700

[Message part 1 (text/plain, inline)]

On 2022-05-31, Vagrant Cascadian wrote:
> On 2021-01-01, Vagrant Cascadian wrote:
>> Various files embed timestamps and the running kernel version:
>>
>>   https://tests.reproducible-builds.org/debian/rb-pkg/bullseye/i386/diffoscope-results/lirc.html
>>
>>   /etc/lirc/lircd.conf.d/devinput.lircd.conf
>>
>>   #·Generated·by·lirc-make-devinput·on·4.19.0-11-amd64
>>   vs.
>>   #·Generated·by·lirc-make-devinput·on·4.19.0-11-686-pae
>>   
>>   #·Date:·Thu·Nov·11·01:28:19·-12·2021
>>   vs.
>>   #·Date:·Fri·Oct··9·21:13:04·+14·2020
>>
>> The attached patch fixes this by adjusting the tools used to generate
>> these files to not embed the timestamps or kernel version.
>
> Appears to have been submitted and/or merged upstream:
>
>   https://sourceforge.net/p/lirc/git/merge-requests/36/

That actually only seems to be a partial fix, unless upstream has
dropped the other files or otherwise changed the sources...


live well,
  vagrant

[signature.asc (application/pgp-signature, inline)]

Message #22 received at 979019@bugs.debian.org (full text, mbox, reply):

From: Holger Levsen <holger@layer-acht.org>

To: 979019@bugs.debian.org

Subject: fixed upstream

Date: Thu, 29 Dec 2022 18:58:14 +0000

[Message part 1 (text/plain, inline)]

hi,

the fix for https://sourceforge.net/p/lirc/git/merge-requests/36/ has been
merged upstream.


-- 
cheers,
	Holger

 ⢀⣴⠾⠻⢶⣦⠀
 ⣾⠁⢠⠒⠀⣿⡁  holger@(debian|reproducible-builds|layer-acht).org
 ⢿⡄⠘⠷⠚⠋⠀  OpenPGP: B8BF54137B09D35CF026FE9D 091AB856069AAA1C
 ⠈⠳⣄

People call vaccine mandates "Orwellian" even though Orwell died at 46 of
tuberculosis, which is now preventable with a vaccine.

[signature.asc (application/pgp-signature, inline)]

Send a report that this bug log contains spam.