Debian Bug report logs - #977530
vtk7: reproducible builds: Embeds running kernel into XdmfConfig.h

Reply or subscribe to this bug.

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: submit@bugs.debian.org

Subject: vtk7: reproducible builds: Embeds running kernel into XdmfConfig.h

Date: Tue, 15 Dec 2020 20:43:17 -0800

[Message part 1 (text/plain, inline)]

Source: vtk7
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: kernel
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The running kernel is embedded in /usr/include/vtk-7.1/vtkxdmf2/XdmfConfig.h:

  https://tests.reproducible-builds.org/debian/rb-pkg/bullseye/amd64/diffoscope-results/vtk7.html
  
  34 	#define·XDMF_SYSTEM·Linux-5.8.0-0.bpo.2-amd64
  34 	#define·XDMF_SYSTEM·Linux-4.19.0-12-amd64


The attached patch fixes this by using CMAKE_SYSTEM_NAME (e.g. Linux)
instead of CMAKE_SYSTEM (e.g. Linux-4.19.0-12-amd64) to set the
XDMF_SYSTEM header.


Thanks for maintaining vtk7!


live well,
  vagrant

[0002-XdmfConfig.h.in-Set-XDMF_SYSTEM-using-CMAKE_SYSTEM_N.patch (text/x-diff, inline)]

From 73c5fc29fc6694aa95d0c48ac748d5c9e22080f1 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Wed, 16 Dec 2020 02:32:12 +0000
Subject: [PATCH 2/3] XdmfConfig.h.in: Set XDMF_SYSTEM using CMAKE_SYSTEM_NAME.

Using CMAKE_SYSTEM embeds the running kernel in the resulting .h file,
which will likely vary between builds and other systems that use the
.h file.

https://tests.reproducible-builds.org/debian/issues/unstable/captures_kernel_version_via_CMAKE_SYSTEM_issue.html
---
 ThirdParty/xdmf2/vtkxdmf2/libsrc/XdmfConfig.h.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ThirdParty/xdmf2/vtkxdmf2/libsrc/XdmfConfig.h.in b/ThirdParty/xdmf2/vtkxdmf2/libsrc/XdmfConfig.h.in
index 04f82a5..845ea3f 100644
--- a/ThirdParty/xdmf2/vtkxdmf2/libsrc/XdmfConfig.h.in
+++ b/ThirdParty/xdmf2/vtkxdmf2/libsrc/XdmfConfig.h.in
@@ -32,7 +32,7 @@
   #define XDMF_BYTE_ORDER_LITTLE
 #endif
 
-#define XDMF_SYSTEM ${CMAKE_SYSTEM}
+#define XDMF_SYSTEM ${CMAKE_SYSTEM_NAME}
 
 #cmakedefine XDMF_VOID_VALID
 #ifndef XDMF_VOID_VALID
-- 
2.29.2

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 977530-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 977530-close@bugs.debian.org

Subject: Bug#977530: fixed in vtk7 7.1.1+dfsg2-9

Date: Fri, 19 Feb 2021 21:05:32 +0000

Source: vtk7
Source-Version: 7.1.1+dfsg2-9
Done: Shayan Doust <hello@shayandoust.me>

We believe that the bug you reported is fixed in the latest version of
vtk7, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 977530@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Shayan Doust <hello@shayandoust.me> (supplier of updated vtk7 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Fri, 19 Feb 2021 19:17:17 +0000
Source: vtk7
Architecture: source
Version: 7.1.1+dfsg2-9
Distribution: unstable
Urgency: medium
Maintainer: Debian Science Team <debian-science-maintainers@lists.alioth.debian.org>
Changed-By: Shayan Doust <hello@shayandoust.me>
Closes: 977529 977530 977531
Changes:
 vtk7 (7.1.1+dfsg2-9) unstable; urgency=medium
 .
   * Team Upload
   * Fix some cross-build issues (Closes: #977529, #977530, #977531)
   * Run cme fix dpkg-patches
   * Standards-Version: 4.5.1 (routine-update)
   * debhelper-compat 13 (routine-update)
   * Remove trailing whitespace in debian/changelog (routine-update)
   * Remove trailing whitespace in debian/control (routine-update)
   * Remove trailing whitespace in debian/copyright (routine-update)
   * Remove trailing whitespace in debian/rules (routine-update)
   * Add salsa-ci file (routine-update)
   * Rules-Requires-Root: no (routine-update)
   * Rectify pattern globbing issue in copyright
   * Fix lintian malformed override error
Checksums-Sha1:
 e76097b049df4e36030dea02004c2ac1fbd3cd21 3948 vtk7_7.1.1+dfsg2-9.dsc
 a8bf3300016621ff7cc55ebabb1ca67f2966a7dd 29576 vtk7_7.1.1+dfsg2-9.debian.tar.xz
 3c0d9e7afdb326fb017cda7e4e86fbbb90b965ea 36482 vtk7_7.1.1+dfsg2-9_amd64.buildinfo
Checksums-Sha256:
 4369263cc56062b47d6bc41764e34a2f02646fb3a8353c21e2c564ddec17651d 3948 vtk7_7.1.1+dfsg2-9.dsc
 1d70f28d324235e9bfe87e352859e7a310c834d8f0375fdcf7a372b5307e6c7b 29576 vtk7_7.1.1+dfsg2-9.debian.tar.xz
 52da59c4271ea9dec18bdfcfe1b282b60f9ee7868c08ea54576f190eef7fb775 36482 vtk7_7.1.1+dfsg2-9_amd64.buildinfo
Files:
 1cfe055f8f53932f5dc193577a53ecd3 3948 graphics optional vtk7_7.1.1+dfsg2-9.dsc
 2984c1a30338d086b2036a1cfb8a8732 29576 graphics optional vtk7_7.1.1+dfsg2-9.debian.tar.xz
 bc3f3766e48dc7dfd11510df2a916b49 36482 graphics optional vtk7_7.1.1+dfsg2-9_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJJBAEBCgAzFiEEBAGoEKbyQwMeo5dZbX1EGRnQI5UFAmAwI/cVHGhlbGxvQHNo
YXlhbmRvdXN0Lm1lAAoJEG19RBkZ0COVZjYP/3++POrqCGg5LPjgWlATLfltvg9f
dJpnk0edItD5HWGtNEfLpjRM5FYeOwWR/twkDhL3FsTxWyJQqBLk8Mbyk+sZQrnG
R0DgYiVteKo2CHpK6KldJcL+yrRHVFB9EftpjnwdOGlht8FnVGf71/ds1SpNR6Em
9V+yl14BOm+TSlPXIYdmt8qrotHfHmeG1YNa+KqOF+OMuO14Eavk20lK25NqKZsB
DqEHMmm9C1kQHvZk0ERFDC2dvDfZ9HxtP8l4sxUNuYGVkrG9hTWe9byOrPaolSMG
OtgxCE8tgdIBAMeg6ActLFP8HVVjPHcocA0PYc3gs/sulzs0i1erSAwwihqVZ7Lx
ZJu4wNRUyKuJWYX1wlsjL+NpRLQ6e/svWrMmM70uXiDfFZ2poLz9MzEuhjRSeGqW
3M3VtSy4JNEm5sqPYL4OvZjWMWmrnhgv3XkTq6YIqp6sOkdR01u3cg8BhkfjVB7V
Pj+qFgftYyEhC5YY2lUgRJDd3FcCqHAR2YpREwCSPFs91rYOqYhuDVBRvVILoAQ2
/MItyrpeVWaQHSxCTQG8dyf74xKz3Tn5+H8pEdjQCphTKNEolXm4v5KMUr+H9rh6
g6Q0+GQV9aEh4OIpT0RF4VyMMkfbPx+y3xs1KXfGxZCzA9lc3cMmrmvm1HF59vIV
vGJkxSnmDRU6XEc+
=cBSD
-----END PGP SIGNATURE-----

Message #21 received at 977530@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: 977531@bugs.debian.org, 977530@bugs.debian.org, 977529@bugs.debian.org

Subject: vtk7: reproducible builds bugs not fixed

Date: Wed, 08 Jun 2022 10:37:41 -0700

[Message part 1 (text/plain, inline)]

It does not appear that these bugs were actually fixed in vtk7:

  vtk7: reproducible builds: unpredictible ordering in documentation
  vtk7: reproducible builds: Embeds running kernel into XdmfConfig.h
  vtk7: reproducible builds: build timestamps in documentation

It still fails to build reproducibly:

  https://tests.reproducible-builds.org/debian/rb-pkg/bookworm/amd64/diffoscope-results/vtk7.html

No versions uploaded to debian ever built reproducibly:

  https://tests.reproducible-builds.org/debian/history/amd64/vtk7.html

I'm not sure if the patches were once included and then reverted, or
never applied... regardless, please consider applying them in the next
upload!


Thanks for maintaining vtk7!


live well,
  vagrant

[signature.asc (application/pgp-signature, inline)]

Send a report that this bug log contains spam.