Debian Bug report logs - #977424
gnuradio: reproducible builds: files contain build timestamp dependent on timezone

version graph

Package: src:gnuradio; Maintainer for src:gnuradio is A. Maitland Bottoms <bottoms@debian.org>;

Reported by: Vagrant Cascadian <vagrant@reproducible-builds.org>

Date: Mon, 14 Dec 2020 23:42:01 UTC

Severity: normal

Tags: patch

Fixed in version gnuradio/3.8.2.0-12

Done: A. Maitland Bottoms <bottoms@debian.org>

Bug is archived. No further changes may be made.

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, reproducible-bugs@lists.alioth.debian.org, A. Maitland Bottoms <bottoms@debian.org>:
Bug#977424; Package src:gnuradio. (Mon, 14 Dec 2020 23:42:03 GMT) (full text, mbox, link).


Acknowledgement sent to Vagrant Cascadian <vagrant@reproducible-builds.org>:
New Bug report received and forwarded. Copy sent to reproducible-bugs@lists.alioth.debian.org, A. Maitland Bottoms <bottoms@debian.org>. (Mon, 14 Dec 2020 23:42:03 GMT) (full text, mbox, link).


Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>
To: submit@bugs.debian.org
Subject: gnuradio: reproducible builds: files contain build timestamp dependent on timezone
Date: Mon, 14 Dec 2020 15:38:35 -0800
[Message part 1 (text/plain, inline)]
Source: gnuradio
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: timestamps timezone
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Several files shipped with gnuradio include the build time:

  ./usr/lib/aarch64-linux-gnu/libgnuradio-runtime.so.3.8.2.0

  2061 	Mon,·07·Dec·2020·14:42:43
  2061 	Tue,·08·Dec·2020·16:42:43


While gnuradio includes a patch to respect SOURCE_DATE_EPOCH, it does
not handle the timezone variation. The attached patch to the patch
updates it to use the UTC timezone.

This patch does not resolve all reproducibility issues (e.g. build
paths), but should make gnuradio reproducible when it lands in bullseye
(where build paths are not tested).


Thanks for maintaining gnuradio!


live well,
  vagrant
[0001-debian-patches-Update-cmake-timestamp-patch-to-use-U.patch (text/x-diff, inline)]
From 93250947630cb7c26882805d1287e44c5a414e4d Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Mon, 14 Dec 2020 21:24:50 +0000
Subject: [PATCH 1/2] debian/patches: Update cmake timestamp patch to use UTC
 timezone.

Without this, the timestamp may vary based on the timezone of the
build system.
---
 .../patches/cmake-use-TIMESTAMP-function-to-generate-build_date | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/patches/cmake-use-TIMESTAMP-function-to-generate-build_date b/debian/patches/cmake-use-TIMESTAMP-function-to-generate-build_date
index d196d26..aa06074 100644
--- a/debian/patches/cmake-use-TIMESTAMP-function-to-generate-build_date
+++ b/debian/patches/cmake-use-TIMESTAMP-function-to-generate-build_date
@@ -30,7 +30,7 @@ Thanks to Sebastian Kosloswki for pointing out the right way in CMake
 +
 +# Use TIMESTAMP to be compatible with reproducible builds
 +# and put in in the cache so configure_file sees it
-+string(TIMESTAMP BUILD_DATE "%a, %d %b %Y %H:%M:%S")
++string(TIMESTAMP BUILD_DATE "%a, %d %b %Y %H:%M:%S" UTC)
 +set(BUILD_DATE ${BUILD_DATE} CACHE INTERNAL "Build date")
 +message(STATUS "Loading build date ${BUILD_DATE} into constants...")
 +message(STATUS "Loading version ${VERSION} into constants...")
-- 
2.29.2

[signature.asc (application/pgp-signature, inline)]

Reply sent to bottoms@debian.org (A. Maitland Bottoms):
You have taken responsibility. (Thu, 14 Jan 2021 05:21:03 GMT) (full text, mbox, link).


Notification sent to Vagrant Cascadian <vagrant@reproducible-builds.org>:
Bug acknowledged by developer. (Thu, 14 Jan 2021 05:21:03 GMT) (full text, mbox, link).


Message #10 received at 977424-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>
To: 977424-close@bugs.debian.org
Subject: Bug#977424: fixed in gnuradio 3.8.2.0-12
Date: Thu, 14 Jan 2021 05:18:20 +0000
Source: gnuradio
Source-Version: 3.8.2.0-12
Done: A. Maitland Bottoms <bottoms@debian.org>

We believe that the bug you reported is fixed in the latest version of
gnuradio, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 977424@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
A. Maitland Bottoms <bottoms@debian.org> (supplier of updated gnuradio package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 13 Jan 2021 23:27:39 -0500
Source: gnuradio
Architecture: source
Version: 3.8.2.0-12
Distribution: unstable
Urgency: medium
Maintainer: A. Maitland Bottoms <bottoms@debian.org>
Changed-By: A. Maitland Bottoms <bottoms@debian.org>
Closes: 977424 977425
Changes:
 gnuradio (3.8.2.0-12) unstable; urgency=medium
 .
   * update to v3.8.2.0-41-gcaca1219b: msg_handler-Use-lambdas
   * use the UTC timezone for reproducible BUILD_DATE timestamp
     Thanks vagrant! (Closes: #977424)
   * grc-setup-freedesktop not-installed - redundant to Debian packaging
     (Closes: #977425)
Checksums-Sha1:
 68ebc3199e330763916244f7531abef68082a44a 4623 gnuradio_3.8.2.0-12.dsc
 1dc8a5e0307c54605370c72a11a0b5f076bc2a59 1555488 gnuradio_3.8.2.0-12.debian.tar.xz
 23f23af209870080eec5edc334a9106e69b1ac76 33913 gnuradio_3.8.2.0-12_amd64.buildinfo
Checksums-Sha256:
 df7fb1f04afcb5bd1bb421bae1cb6449fd1441b16e1c7763f682822b34a9bf57 4623 gnuradio_3.8.2.0-12.dsc
 32b981e0016fb33aa3c5734ab5eaabaaca6159468b6cf74acb1849fbd0ce6958 1555488 gnuradio_3.8.2.0-12.debian.tar.xz
 3254ded8b5e748feae57e3b6eb85afd659bab3879727234f347011b1f02d6410 33913 gnuradio_3.8.2.0-12_amd64.buildinfo
Files:
 91706d06ee89a05c5a8d9c98038487ed 4623 comm optional gnuradio_3.8.2.0-12.dsc
 b9f4274adf801b149370c645bc496047 1555488 comm optional gnuradio_3.8.2.0-12.debian.tar.xz
 ac16289cd365b2c95cdec7d0503ae8f8 33913 comm optional gnuradio_3.8.2.0-12_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEB8qH3cTCsGJAtrF0UEHxiR9E4JAFAl//0ZwACgkQUEHxiR9E
4JAylxAA3lvXH11PjYD2Yqlku3bM8WZ0kYz+GTfXnz94+QXdYbW03hdiyJvPDFWV
ro/Q+2Y62rEmmXvV95QhC76FnbdmUBsIYmudHaG8bj7oTAbt+T02OL+hAMa3mq0o
3SfuE+7LECYovA1XlZ0jqh1BHVwhHLzih2GOP24pH+50HnZ5uEAzA6cPi4L5nUCc
3gKB0e6S+jYLSHOKWav/XKcvl8nictta4SwOGD9Ofnw+1TSb6sp76fML6Wercy1i
gKcgOIwdOvVXuU0JC4RX8PB2+4cNrb+2dp4sUBtObSRpb3jPH4xY3oJNuHFA5cxv
SgG80bKonLArrvE6Jf7enlIKmPB/y51zdtBew4QF0mJHaG8e0jBKBAz6Yr3+3Cse
W+TS6kVqnGNUvDFhhAmUwFa3lCOZZn3m2oNkx1qeAkPH+sBCzgd9l2mYS2f46P69
6PvMAPVYq4keYNlNEmZ2t2pHRwTCTzEplJodaO7YXXbAcD9EZ9ba21O6Cq2jU6cJ
Nb/wKF2K5XlZSAeYBUHKqS9fmzqZ5A5YOmmkQN2Q7psUzxVmQkx/poZJ8yOnxapd
6zhzsMzeku9J+3E13edwKOHR871v3Oki1AQVW+Cz9iTaWgPTmKsc2/WjjfoKpifB
pY5PO5EEtIl18IcPFv0Me5XswJ6VMtupvrldX1XAl4Q/iJmE4nc=
=AEpc
-----END PGP SIGNATURE-----




Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Tue, 16 Feb 2021 07:27:01 GMT) (full text, mbox, link).


Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Wed May 17 12:49:35 2023; Machine Name: buxtehude

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.