Debian Bug report logs - #977168
west-chamber: reproducible builds: Generated Makefiles contain variable information

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: submit@bugs.debian.org

Subject: west-chamber: reproducible builds: Generated Makefiles contain variable information

Date: Fri, 11 Dec 2020 15:13:50 -0800

[Message part 1 (text/plain, inline)]

Source: west-chamber
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath usrmerge environment kernel
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The files Makefile, extensions/Makefile and Makefile.iptrules would
need to be regenerated from the corresponding Makefile.am or
Makefile.in files, as they contain specific information about the
build environment which may not match the environment of the system in
which the Makefile will be executed from the installed system:

  https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/west-chamber.html

Some of the variations include embedded build paths, shell variable,
kernel version, binary locations on usrmerge vs. non-usrmerge systems.


The attached patch fixes this by not including these Makefiles from
debian/rules.

Please test to make sure this does not break the functioning of the
package, as I have only tested that it builds when applied!

If these files do need to be present for some reason, another option
might be to sanitize these Makefiles from debian/rules. Passing various
things to configure can help with this (e.g. GREP=/bin/grep,
SHELL=/bin/sh, etc.) though the build paths would need to be removed
manually, most likely.


live well,
  vagrant

[0002-debian-rules-Do-not-install-generated-Makefiles.patch (text/x-diff, inline)]

From 0105038ede4ce6b076f58c6fe26defbce47bf1eb Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Fri, 11 Dec 2020 22:43:31 +0000
Subject: [PATCH 2/2] debian/rules: Do not install generated Makefiles.

The files Makefile, extensions/Makefile and Makefile.iptrules would
need to be regenerated from the corresponding Makefile.am or
Makefile.in files, as they contain specific information about the
build environment which may not match the environment of the system in
which the Makefile will be executed from the installed system:

https://tests.reproducible-builds.org/debian/issues/captures_build_path_issue.html
https://tests.reproducible-builds.org/debian/issues/captures_shell_variable_in_autofoo_script_issue.html
https://tests.reproducible-builds.org/debian/issues/captures_kernel_version_issue.html
https://tests.reproducible-builds.org/debian/issues/records_build_flags_issue.html
https://tests.reproducible-builds.org/debian/issues/paths_vary_due_to_usrmerge_issue.html
---
 debian/rules | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/debian/rules b/debian/rules
index 9b4cf78..b22e45b 100755
--- a/debian/rules
+++ b/debian/rules
@@ -75,11 +75,11 @@ override_dh_auto_install:
 	mkdir -p $(CURDIR)/debian/$(dkmssource)/usr/src/$(dkmssname)/extensions
 	# DKMS: Copy only the driver source to the proper location
 	cp extensions/*.c debian/$(dkmssource)/usr/src/$(dkmssname)/extensions
-	cp extensions/Kbuild extensions/Makefile extensions/Makefile.in debian/$(dkmssource)/usr/src/$(dkmssname)/extensions
-	cp Makefile.* Makefile \
+	cp extensions/Kbuild extensions/Makefile.in debian/$(dkmssource)/usr/src/$(dkmssname)/extensions
+	cp Makefile.* \
 	   mconfig \
 	   debian/$(dkmssource)/usr/src/$(dkmssname)
-	find debian/$(dkmssource)/usr/src -name ".gitignore" -delete
+	find debian/$(dkmssource)/usr/src -name ".gitignore" -o -name Makefile.iptrules -delete
 	#sed 's/compat_xtables.o//' extensions/Kbuild > debian/$(dkmssource)/usr/src/$(dkmssname)/Kbuild
 	echo 'ccflags-y += -I$${XTABLESDIR}/extensions -I.' >> debian/$(dkmssource)/usr/src/$(dkmssname)/extensions/Kbuild
 
-- 
2.29.2

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 977168-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 977168-close@bugs.debian.org

Subject: Bug#977168: fixed in west-chamber 20100405+svn20111107.r124-13

Date: Wed, 30 Dec 2020 08:17:02 +0000

Source: west-chamber
Source-Version: 20100405+svn20111107.r124-13
Done: Ying-Chun Liu (PaulLiu) <paulliu@debian.org>

We believe that the bug you reported is fixed in the latest version of
west-chamber, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 977168@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Ying-Chun Liu (PaulLiu) <paulliu@debian.org> (supplier of updated west-chamber package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 30 Dec 2020 15:14:59 +0800
Source: west-chamber
Architecture: source
Version: 20100405+svn20111107.r124-13
Distribution: unstable
Urgency: low
Maintainer: Ying-Chun Liu (PaulLiu) <paulliu@debian.org>
Changed-By: Ying-Chun Liu (PaulLiu) <paulliu@debian.org>
Closes: 977167 977168
Changes:
 west-chamber (20100405+svn20111107.r124-13) unstable; urgency=low
 .
   [ Vagrant Cascadian <vagrant@reproducible-builds.org> ]
   * Fix source tarball with inconsistent file order (Closes: #977167)
   * Fix generated Makefiles contain variable information (Closes: #977168)
 .
   [ Logan Rosen <logan@ubuntu.com> ]
   * Update 02_port_to_xtables_2.10.patch to work with xtables-addons 3.13,
     which handles Linux version compatibility for 4-arg ip_route_me_harder.
   * Bump dependencies on xtables-addons to >= 3.13.
Checksums-Sha1:
 766d022075bb86192f123caa70dcf75e35686f0e 2185 west-chamber_20100405+svn20111107.r124-13.dsc
 40f695c03a0cf54fb4bc3de4e70de2725a66e719 8472 west-chamber_20100405+svn20111107.r124-13.debian.tar.xz
 64d29e2abf94237fcf3c8af956f9c7fe6c187364 6858 west-chamber_20100405+svn20111107.r124-13_source.buildinfo
Checksums-Sha256:
 4970f4416d758bc26b5b250772a0a7c9b9a9b20e90fffe0672a9d15f73a16528 2185 west-chamber_20100405+svn20111107.r124-13.dsc
 83b067bdde677db492e5b945710aea6502631d3fef262ff8ef687b3c1f8eeacc 8472 west-chamber_20100405+svn20111107.r124-13.debian.tar.xz
 c8303bdcd79048673b95ef11782378b79d0df6060993d2e79cea854d5d74a5ae 6858 west-chamber_20100405+svn20111107.r124-13_source.buildinfo
Files:
 a88f5d40cc23ef7030d7739ad9694858 2185 admin optional west-chamber_20100405+svn20111107.r124-13.dsc
 8bd2548f856efc6a56284d1cf993f59d 8472 admin optional west-chamber_20100405+svn20111107.r124-13.debian.tar.xz
 c49dc5c3dca2c3ea1c74c2021879f533 6858 admin optional west-chamber_20100405+svn20111107.r124-13_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJHBAEBCgAxFiEEo2h49GQQhoFgDLZIRBc/oT0FiIgFAl/sL6ETHHBhdWxsaXVA
ZGViaWFuLm9yZwAKCRBEFz+hPQWIiHIgEACRZTJijgIHzYTgm922U3WBL0E5LoAK
RDGKxL5Q7Y6cSZVHLtEMzEPtzyv7NBVy6rs0aq3eqT96C3hlaIgIa3cLmYOXdoqB
lLFMj7TyLanu4C6W3qVAPB9zu9ufVnH4lwmFf/nIfY7StW5Y44YLfWQMIcD2mJ3H
FHwmVXybx2ecJSPtETwCcwPhPTS3LibH1vP4KuSnDYaWlb834BQYqAdx92oM70/S
wi4eeKt2/vkJub677dJk8Itxfb9TjFJJFay/PSoPJFHNzCy8Lknk8JEQhzMln9Ee
+AwEnAF9MmaPNaEnwJR9mReZajbP6BYoeWIvV2JdB+Dkqjo7oOvofASDmDWvU58T
XLnNVCOOXxY2RvtZsm+l66kx+uo50EYJlII/D+RhW7h31qovYy41drhnU+qp2U0W
uZht8dUA+6P4c5yVqQSXOLyQ636JCelK33Fd3UWYMAEieTb3dBdZwoJv9fYyZ9Jq
lLiG6bySGH0Bt3Sj7URwnt9ZlgPFbxPEqSXD9LnLSw+ao8tHsLzzkZdjRZIT09Kf
Q8fbprTWZSWo0iGKYEzKZ8BuXfJeC0mpbSTZUQgqpUlp7Ivf5vVgOSaFo/GEV7AW
SPa1PHYvTVXjsEmXZ1hmiU9UkNQcSwtPDLWxcYItqxVRDJ361rPmKpIavWJG3rfX
Dk25r6k3kyjldQ==
=1ej6
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.