Debian Bug report logs - #976445
libjs-qunit: please make the build reproducible

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>

To: submit@bugs.debian.org

Subject: libjs-qunit: please make the build reproducible

Date: Sat, 05 Dec 2020 10:34:59 +0000

[Message part 1 (text/plain, inline)]

Source: libjs-qunit
Version: 1.23.1~dfsg-1
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: timestamps
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0] we noticed that
libjs-qunit could not be built reproducibly.

This is because it includes the current date in some generated files.
I tried to use SOURCE_DATE_EPOCH in the Gruntfile.js but I couldn't
access process.env (I'm not a JS expert, alas).

Patch attached that at least strips these dates out in debian/rules.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

[libjs-qunit.diff.txt (text/plain, attachment)]

Message #10 received at 976445@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: Chris Lamb <lamby@debian.org>, 976445@bugs.debian.org

Subject: Re: Bug#976445: libjs-qunit: please make the build reproducible

Date: Thu, 08 Dec 2022 14:17:00 -0800

[Message part 1 (text/plain, inline)]

Control: tags 976445 pending

On 2020-12-05, Chris Lamb wrote:
> Whilst working on the Reproducible Builds effort [0] we noticed that
> libjs-qunit could not be built reproducibly.
>
> This is because it includes the current date in some generated files.
> I tried to use SOURCE_DATE_EPOCH in the Gruntfile.js but I couldn't
> access process.env (I'm not a JS expert, alas).

I have uploaded an NMU to DELAYED/10 fixing this issue:

diff -Nru libjs-qunit-1.23.1~dfsg/debian/changelog libjs-qunit-1.23.1~dfsg/debian/changelog
--- libjs-qunit-1.23.1~dfsg/debian/changelog	2022-12-06 06:09:01.000000000 -0800
+++ libjs-qunit-1.23.1~dfsg/debian/changelog	2022-12-08 14:00:56.000000000 -0800
@@ -1,3 +1,12 @@
+libjs-qunit (1.23.1~dfsg-3.2) unstable; urgency=medium
+
+  * Non-maintainer upload.
+
+  [ Chris Lamb ]
+  * Make the build reproducible (Closes: #976445)
+
+ -- Vagrant Cascadian <vagrant@reproducible-builds.org>  Thu, 08 Dec 2022 14:00:56 -0800
+
 libjs-qunit (1.23.1~dfsg-3) unstable; urgency=medium
 
   [ Debian Janitor ]
diff -Nru libjs-qunit-1.23.1~dfsg/debian/rules libjs-qunit-1.23.1~dfsg/debian/rules
--- libjs-qunit-1.23.1~dfsg/debian/rules	2022-12-06 06:09:01.000000000 -0800
+++ libjs-qunit-1.23.1~dfsg/debian/rules	2022-12-08 14:00:56.000000000 -0800
@@ -34,6 +34,7 @@
 	$(GRUNT) concat:src-js concat:src-css
 
 override_dh_auto_build: $(DOCS) $(CHANGELOGS) dist/qunit.min.js.gz
+	sed -i '/ Date: /d' dist/qunit.*
 
 override_dh_auto_test:
 	$(GRUNT) test-on-node

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 976445-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 976445-close@bugs.debian.org

Subject: Bug#976445: fixed in libjs-qunit 1.23.1~dfsg-3.2

Date: Mon, 19 Dec 2022 21:02:30 +0000

Source: libjs-qunit
Source-Version: 1.23.1~dfsg-3.2
Done: Vagrant Cascadian <vagrant@reproducible-builds.org>

We believe that the bug you reported is fixed in the latest version of
libjs-qunit, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 976445@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Vagrant Cascadian <vagrant@reproducible-builds.org> (supplier of updated libjs-qunit package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Thu, 08 Dec 2022 14:00:56 -0800
Source: libjs-qunit
Architecture: source
Version: 1.23.1~dfsg-3.2
Distribution: unstable
Urgency: medium
Maintainer: Debian Javascript Maintainers <pkg-javascript-devel@lists.alioth.debian.org>
Changed-By: Vagrant Cascadian <vagrant@reproducible-builds.org>
Closes: 976445
Changes:
 libjs-qunit (1.23.1~dfsg-3.2) unstable; urgency=medium
 .
   * Non-maintainer upload.
 .
   [ Chris Lamb ]
   * Make the build reproducible (Closes: #976445)
Checksums-Sha1:
 d1a014cded7029e9ec467c8c957b5703f9118178 1687 libjs-qunit_1.23.1~dfsg-3.2.dsc
 3fc987f9d0e9a6db40c7251571814819353b52d1 6516 libjs-qunit_1.23.1~dfsg-3.2.debian.tar.xz
Checksums-Sha256:
 a987a6cab81a2214a40a3e3111f82d69cdf2f7ff3447529e336702a2d79deba4 1687 libjs-qunit_1.23.1~dfsg-3.2.dsc
 ec66d92a96a241e19f37d0538ef8a9da2cd2c3f9af9cd48d038804397631499b 6516 libjs-qunit_1.23.1~dfsg-3.2.debian.tar.xz
Files:
 bbfadd5b16b261190c440829205fd64a 1687 javascript optional libjs-qunit_1.23.1~dfsg-3.2.dsc
 d09e5ed888553b17f6f7db95e7cf64b0 6516 javascript optional libjs-qunit_1.23.1~dfsg-3.2.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iJYEARYKAD4WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCY5JhySAcdmFncmFudEBy
ZXByb2R1Y2libGUtYnVpbGRzLm9yZwAKCRDcUY/If5cWqlgFAQDiQeKT6S1gj5Ee
ATQhPKkm/GY3Fs5aGNrQIYfyU0kXRwD+I/RQ/EQkh0+aczAoPqHccWq9D2tXsABy
tmFt7QsGCw4=
=hVXq
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.