Debian Bug report logs - #975504
obs-studio: reproducible builds: Embeds date in appdata.xml file

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: submit@bugs.debian.org

Subject: obs-studio: reproducible builds: Embeds date in appdata.xml file

Date: Sun, 22 Nov 2020 18:24:40 -0800

[Message part 1 (text/plain, inline)]

Source: obs-studio
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: timestamps
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

A date string that defaults to the current date is embedded in
/usr/share/metainfo/com.obsproject.Studio.appdata.xml, causing builds on
different days to not build reproducibly.

  https://tests.reproducible-builds.org/debian/rb-pkg/bullseye/amd64/diffoscope-results/obs-studio.html
  21 	····<release·version="26.0.2+dfsg1-1"·date="2021-12-18"/>	21 	····<release·version="26.0.2+dfsg1-1"·date="2020-11-15"/>

This can be fixed by setting a value from the configure target that uses
SOURCE_DATE_EPOCH:

  https://reproducible-builds.org/docs/source-date-epoch/

The attached patch does this.


Alternately, it may be worth exploring patching
UI/xdg-data/CMakeLists.txt to support SOURCE_DATE_EPOCH and get the
support merged upstream.


Thanks for maintaining obs-studio!


live well,
  vagrant

[0001-debian-rules-Set-APPDATA_RELEASE_DATE-using-the-SOUR.patch (text/x-diff, inline)]

From afafba3e2105ca188e1a2b14398d65014b5fc370 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Mon, 23 Nov 2020 01:58:40 +0000
Subject: [PATCH] debian/rules: Set APPDATA_RELEASE_DATE using the
 SOURCE_DATE_EPOCH variable to avoid embedding the current date in the
 /usr/share/metainfo/com.obsproject.Studio.appdata.xml file.

  https://reproducible-builds.org/docs/source-date-epoch/
---
 debian/rules | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/debian/rules b/debian/rules
index 80a4ae9..e0b1c17 100755
--- a/debian/rules
+++ b/debian/rules
@@ -16,7 +16,8 @@ override_dh_auto_configure:
 		-DUNIX_STRUCTURE=TRUE \
 		-DDISABLE_UPDATE_MODULE=TRUE \
 		-DBUILD_CAPTIONS=ON \
-		-DOBS_VERSION_OVERRIDE=${DEB_VERSION}
+		-DOBS_VERSION_OVERRIDE=${DEB_VERSION} \
+		-DAPPDATA_RELEASE_DATE=$(shell date --utc --date=@$${SOURCE_DATE_EPOCH} +'%Y-%m-%d') \
 
 execute_after_dh_auto_build:
 	rst2man debian/obs.rst > debian/obs.1
-- 
2.20.1

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 975504@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: 975504@bugs.debian.org

Subject: Re: obs-studio: reproducible builds: Embeds date in appdata.xml file

Date: Sun, 22 Nov 2020 19:17:42 -0800

[Message part 1 (text/plain, inline)]

On 2020-11-22, Vagrant Cascadian wrote:
> A date string that defaults to the current date is embedded in
> /usr/share/metainfo/com.obsproject.Studio.appdata.xml, causing builds on
> different days to not build reproducibly.
>
>   https://tests.reproducible-builds.org/debian/rb-pkg/bullseye/amd64/diffoscope-results/obs-studio.html
>   21 	····<release·version="26.0.2+dfsg1-1"·date="2021-12-18"/>	21 	····<release·version="26.0.2+dfsg1-1"·date="2020-11-15"/>
>
> This can be fixed by setting a value from the configure target that uses
> SOURCE_DATE_EPOCH:
>
>   https://reproducible-builds.org/docs/source-date-epoch/
>
> The attached patch does this.
>
>
> Alternately, it may be worth exploring patching
> UI/xdg-data/CMakeLists.txt to support SOURCE_DATE_EPOCH and get the
> support merged upstream.

In case you prefer that approach, the attached patch implements
it... though needs more work to be cross-platform as it relies on
specific features of GNU date. The source-date-epoch link above
documents some of that.


live well,
  vagrant

[0009-UI-xdg-data-CMakeLists.txt-Set-APPDATA_RELEASE_DATE-.patch (text/x-diff, inline)]

From b18355ee4991bb1a1c1160f35d7abe2f18175cfc Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Mon, 23 Nov 2020 02:59:54 +0000
Subject: [PATCH 3/3] UI/xdg-data/CMakeLists.txt: Set APPDATA_RELEASE_DATE from
 SOURCE_DATE_EPOCH environment variable to ensure reproducible builds.

  https://reproducible-builds.org/docs/source-date-epoch/
---
 UI/xdg-data/CMakeLists.txt | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/UI/xdg-data/CMakeLists.txt b/UI/xdg-data/CMakeLists.txt
index 9acd14e..1883902 100644
--- a/UI/xdg-data/CMakeLists.txt
+++ b/UI/xdg-data/CMakeLists.txt
@@ -4,6 +4,9 @@ if(NOT DEFINED APPDATA_RELEASE_DATE)
 			OUTPUT_VARIABLE APPDATA_RELEASE_DATE
 			WORKING_DIRECTORY "${CMAKE_SOURCE_DIR}"
 			OUTPUT_STRIP_TRAILING_WHITESPACE)
+	elseif(DEFINED SOURCE_DATE_EPOCH)
+	        execute_process(COMMAND date --utc --date="@${SOURCE_DATE_EPOCH}" +"%Y-%m-%d"
+	                OUTPUT_VARIABLE APPDATA_RELEASE_DATE)
 	else()
 		file(TIMESTAMP "${CMAKE_SOURCE_DIR}/CMakeLists.txt" APPDATA_RELEASE_DATE "%Y-%m-%d")
 	endif()
-- 
2.29.2

[signature.asc (application/pgp-signature, inline)]

Message #13 received at 975504-submitter@bugs.debian.org (full text, mbox, reply):

From: IOhannes zmölnig <noreply@salsa.debian.org>

To: 975504-submitter@bugs.debian.org

Subject: Bug#975504 marked as pending in obs-studio

Date: Tue, 20 Sep 2022 14:50:24 +0000

Control: tag -1 pending

Hello,

Bug #975504 in obs-studio reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/multimedia-team/obs-studio/-/commit/a6da680b706be63f31b6b735414217a01b9d0620

------------------------------------------------------------------------
Use reproducible build-date

Closes: #975504
Thanks: Vagrant Cascadian <vagrant@reproducible-builds.org>
------------------------------------------------------------------------

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/975504

Message #20 received at 975504-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 975504-close@bugs.debian.org

Subject: Bug#975504: fixed in obs-studio 28.0.1+dfsg1-1

Date: Tue, 20 Sep 2022 23:46:15 +0000

Source: obs-studio
Source-Version: 28.0.1+dfsg1-1
Done: IOhannes m zmölnig (Debian/GNU) <umlaeute@debian.org>

We believe that the bug you reported is fixed in the latest version of
obs-studio, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 975504@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
IOhannes m zmölnig (Debian/GNU) <umlaeute@debian.org> (supplier of updated obs-studio package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 20 Sep 2022 23:44:10 +0200
Source: obs-studio
Architecture: source
Version: 28.0.1+dfsg1-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Multimedia Maintainers <debian-multimedia@lists.debian.org>
Changed-By: IOhannes m zmölnig (Debian/GNU) <umlaeute@debian.org>
Closes: 975504 993458 993600 1017166
Changes:
 obs-studio (28.0.1+dfsg1-1) unstable; urgency=medium
 .
   * Team upload.
 .
   * New upstream version 28.0.1+dfsg1
     (Closes: #1017166)
 .
   [ Sebastian Ramacher ]
   * New upstream version 28.0.0+dfsg1
     * Refresh patches
   * Remove cmake/bundle
   * Exclude mac plugins and a copy of AMF
   * Add BD on libffmpeg-nvenc-dev
   * Add BD on libxcb-composite0-dev
   * Disable browser check
 .
   [ IOhannes m zmölnig (Debian/GNU) ]
   * Refresh patches (again)
   * Additional networking related B-Ds
   * Drop the '+dfsg' from the VERSION_OVERRIDE
   * Set build options
     + Explicitly enable JACK
     + Explicitly disable sndio modules (Closes: #993458)
     + Disable AJA
   * Use reproducible build-date.
     Thanks to Vagrant Cascadian <vagrant@reproducible-builds.org>
     (Closes: #975504)
   * Add another patch to make build reproducible
   * Add patch to fix spelling errors
   * Add patch to build obs-websocket against system libraries
   * Use 'target_compile_options()' to inject "-fvisibility=hidden"
   * Fix install paths to plugins
   * Install pipewire plugin
   * Make sure that PEM files are non-executable
   * Use d/clean to cleanup temporary files
   * Do not embed RPATH/RUNPATH into binaries
   * Update d/*.symbols
   * Update description of obs-plugins (Closes: #993600)
   * d/watch
     - Switch to new github location
     - Import Multi-Upstream-Tarballs
   * Add verbatim copy of Nayuki's Qr-Code-Generator
   * Add salsa-ci configuration
   * Apply 'wrap-and-sort -ast'
   * Update d/copyright
     * Drop superfluous file-patterns
     * Add 'licensecheck' target
     * Generate d/copyright_hints
   * Bump standards version to 4.6.1
Checksums-Sha1:
 074d64868a061590c14b054a74e688a15d98a6f1 3507 obs-studio_28.0.1+dfsg1-1.dsc
 ae42b3ca083c210317b4b67e939b19e09ccbed3b 187548 obs-studio_28.0.1+dfsg1.orig-websocket.tar.xz
 8ba53466a22510a16fb0a2bcae57862999536fb4 4849728 obs-studio_28.0.1+dfsg1.orig.tar.xz
 223e54ecacff770af0f60dc0ee299c27dc545730 64288 obs-studio_28.0.1+dfsg1-1.debian.tar.xz
 6b116485f0b6c2cd88fdd4302bd3cd32a135eacc 13115 obs-studio_28.0.1+dfsg1-1_source.buildinfo
Checksums-Sha256:
 420c1e51973fbad9ec161892046b4cda7f0cab6284f64292506f685dca4afac3 3507 obs-studio_28.0.1+dfsg1-1.dsc
 0e7a1a39bf75ee7fd7409d9446e7451c3de1ad96d4c4d5113f886adffe78a721 187548 obs-studio_28.0.1+dfsg1.orig-websocket.tar.xz
 0a6e01a4cc4cf6f6ebbf94670e1516aed06bd694a1645af83abf85db92cb8921 4849728 obs-studio_28.0.1+dfsg1.orig.tar.xz
 8bf4b8dba1263f59859a0e434d8e88d340c1e74e7a03b5ee8b3288a9742e941e 64288 obs-studio_28.0.1+dfsg1-1.debian.tar.xz
 f06a2d2d22a059f04b8fe2dbf1476a2f9084130f2b2db4f00f7aa652928f5137 13115 obs-studio_28.0.1+dfsg1-1_source.buildinfo
Files:
 d19af5f788e37104ada5674ccf68ef53 3507 video optional obs-studio_28.0.1+dfsg1-1.dsc
 044bbbee556112de8d1a364ce670e142 187548 video optional obs-studio_28.0.1+dfsg1.orig-websocket.tar.xz
 d2262b0e06c10d859f6b78adcdfb4142 4849728 video optional obs-studio_28.0.1+dfsg1.orig.tar.xz
 d3def05308067cef9149f06a8a545f19 64288 video optional obs-studio_28.0.1+dfsg1-1.debian.tar.xz
 495a43bb6d7339ccee949468d7bba9e8 13115 video optional obs-studio_28.0.1+dfsg1-1_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJKBAEBCAA0FiEEdAXnRVdICXNIABVttlAZxH96NvgFAmMqNoYWHGZvcnVtQHVt
bGFldXRlLm11ci5hdAAKCRC2UBnEf3o2+Po1D/wMd5puFI0La4rdawdx1gRySDwI
IoxpDU66cYw8ktXWZGN98FYEkSb7n3cYHjCESjCaTN6wsszuCBHLyMizux98Pgrw
jwZuTxZnM048EfB0VKHHuvoWZHWC4JzS9613o/I8M21g2+uBiB/S2Hv338hrr3NC
bayj2HCJUTwIwkiSw4e5BsvbKz4q92oySPCo3YBAVH5RlHMx+DW9Td2f4pvfcSQB
WCQyf5D3XNf7KF76g4xnlbBFkCm2SoOG6YDTRIVJApKj5NOEY/H6X0/GMkAFseIA
Gis4/bZFOvTw3m21S8IDXRUTB16wDe3UUDsI3XyVjuc4y8IUeHvZBLai58WLD0O4
VIflFfkEtnz2/9yyjUrgR+IXbKpwduGehnWkHQkYH8bIj+29s9B2ahPydRm5Ffs9
pyzH8UZwHozxrLt5xjgKtGEFMoNNGlokrP8DYPi6gYzPVHGrc5B2DQqptGQ7FgL3
8IW7qm9ZMuQG1EYECzAYdWVOBqCqihdtmmw5ztPhHJ7ffF4HXG7wwD5IXw1Z3t2s
pptAfVWPNqqT1jKM1RiZY3+YntGePcGuYk3QrylfSZkkHNtk4wqwzKkJ8Kr8DjNp
woLbIXd8+cU7nVDAYwfavs4H15Zduwq8oZTKmR0j6EtAXL6Ho1MbEv3cnnQabHRq
apwdkwBBlYJkeJpa8w==
=z8K4
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.