Debian Bug report logs - #975374
sugar-calculate-activity: reproducible builds: Embeds build path in .desktop file

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: submit@bugs.debian.org

Subject: sugar-calculate-activity: reproducible builds: Embeds build path in .desktop file

Date: Sat, 21 Nov 2020 02:12:04 -0800

[Message part 1 (text/plain, inline)]

Source: sugar-calculate-activity
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpaths
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

In /usr/share/applications/org.laptop.Calculate.activity.desktop the
build path is embedded, which will presumably not be accessible in the
running system:

  https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/sugar-calculate-activity.html

  171 	Icon·=·/build/1st/sugar-calculate-activity-46/debian/sugar-calculate-activity//usr/share/sugar/activities/Calculate.activity/activity/calculate.svg	171 	Icon·=·/build/2/sugar-calculate-activity-46/2nd/debian/sugar-calculate-activity//usr/share/sugar/activities/Calculate.activity/activity/calculate.svg

There was a workaround applied to sugar-read-activity in the past, but
it was removed, though it still appears to be necessary. The attached
patch applies this workaround to sugar-calculate-activity.

Ideally, this would be fixed in sugar-toolkit-gtk3
src/sugar3/activity/bundlebuilder.py in the _install_desktop_file
function, but does not appear to be fixed as of 0.117.

live well,
  vagrant

[0001-Fix-embedded-build-paths-in-.desktop-files.patch (text/x-diff, inline)]

From 2bfe971dc4cb69464efdcf5ef88b49cfdad86cbd Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Sat, 21 Nov 2020 09:52:10 +0000
Subject: [PATCH] Fix embedded build paths in .desktop files.

This fix/workaround originally found in sugar-read-activity history.
---
 debian/rules | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/debian/rules b/debian/rules
index 126a462..b5971b6 100755
--- a/debian/rules
+++ b/debian/rules
@@ -12,3 +12,7 @@ binary-post-install/$(pkg)::
 
 binary-fixup/$(pkg)::
 	find $(cdbs_curdestdir) -type f -name '*.svg' -exec chmod -R -x '{}' \;
+	# Fix broken paths in desktop file
+	#  * TODO: drop when fixed in sugar-toolkit-gtk3
+	find $(cdbs_curdestdir)/usr/share -type f -name '*.desktop' \
+		-execdir perl -pi -e 's,^\S+\s*=\s*\K\S*(?=/usr/share),,g' '{}' ';'
-- 
2.29.2

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 975374@bugs.debian.org (full text, mbox, reply):

From: James Cameron <quozl@laptop.org>

To: Vagrant Cascadian <vagrant@reproducible-builds.org>, 975374@bugs.debian.org

Cc: submit@bugs.debian.org

Subject: Re: [Pkg-sugar-devel] Bug#975374: sugar-calculate-activity: reproducible builds: Embeds build path in .desktop file

Date: Mon, 23 Nov 2020 13:06:48 +1100

Upstream bug
https://github.com/sugarlabs/sugar-toolkit-gtk3/issues/453

sugar-toolkit-gtk3 does not provide DESTDIR support yet, and
cdbs passes DEB_DESTDIR as PREFIX.

Message #17 received at 975374@bugs.debian.org (full text, mbox, reply):

From: James Cameron <quozl@laptop.org>

To: 975373@bugs.debian.org, 975374@bugs.debian.org

Subject: Upstream patch proposed

Date: Wed, 2 Dec 2020 11:35:11 +1100

Upstream has a patch and would like reviewers.

https://github.com/sugarlabs/sugar-toolkit-gtk3/pull/454

-- 
James Cameron
http://quozl.netrek.org/

Message #24 received at 975374-done@bugs.debian.org (full text, mbox, reply):

From: Jonas Smedegaard <jonas@jones.dk>

To: 975374-done@bugs.debian.org

Cc: James Cameron <quozl@laptop.org>, Vagrant Cascadian <vagrant@reproducible-builds.org>

Subject: Re: [Pkg-sugar-devel] Bug#975374: Bug#975374: sugar-calculate-activity: reproducible builds: Embeds build path in .desktop file

Date: Thu, 16 Dec 2021 12:41:46 +0100

[Message part 1 (text/plain, inline)]

Version: 47-1

Quoting James Cameron (2020-11-23 03:06:48)
> Upstream bug
> https://github.com/sugarlabs/sugar-toolkit-gtk3/issues/453
> 
> sugar-toolkit-gtk3 does not provide DESTDIR support yet, and
> cdbs passes DEB_DESTDIR as PREFIX.

This issue was fixed in sugar-toolkit-gtk3 0.118-3, which was used for 
building sugar-calculate-activity 47-1.

Thanks for reporting the issue, Vargrant, and for the added details 
about its origin, James!


 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private

[signature.asc (application/pgp-signature, inline)]

Send a report that this bug log contains spam.