Debian Bug report logs - #975373
sugar-read-activity: reproducible builds: Embeds build path in .desktop files

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: submit@bugs.debian.org

Subject: sugar-read-activity: reproducible builds: Embeds build path in .desktop files

Date: Sat, 21 Nov 2020 02:06:28 -0800

[Message part 1 (text/plain, inline)]

Source: sugar-read-activity
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpaths
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

In /usr/share/applications/org.laptop.sugar.ReadActivity.activity.desktop
the build path is embedded, which will presumably not be accessible in
the running system:

  https://tests.reproducible-builds.org/debian/rb-pkg/unstable/armhf/diffoscope-results/sugar-read-activity.html

  165 	Icon·=·/build/1st/sugar-read-activity-123/debian/sugar-read-activity//usr/share/sugar/activities/Read.activity/activity/activity-read.svg	165 	Icon·=·/build/2/sugar-read-activity-123/2nd/debian/sugar-read-activity//usr/share/sugar/activities/Read.activity/activity/activity-read.svg

There was a workaround applied in the past, but it was removed, though
it still appears to be necessary. The attached patch reverts the removal
of the workaround.

Ideally, this would be fixed in sugar-toolkit-gtk3
src/sugar3/activity/bundlebuilder.py in the _install_desktop_file
function, but does not appear to be fixed as of 0.117.


live well,
  vagrant

[0001-Fix-embedded-build-paths-in-.desktop-files.patch (text/x-diff, inline)]

From aa837521253419d9468c829a0e8772108c359216 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Sat, 21 Nov 2020 09:46:54 +0000
Subject: [PATCH] Fix embedded build paths in .desktop files.

Revert "Stop fix broken paths in desktop file: Fixed in sugar-toolkit-gtk3 since (at least) 0.110.0."

This reverts commit a5ed233b952df6756fbd4709b6450b3734cb2bdb.

It does not appear to be fixed in sugar-toolkit-gtk3 as of 0.117.
---
 debian/rules | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/debian/rules b/debian/rules
index 5bd5d22..80fb3bb 100755
--- a/debian/rules
+++ b/debian/rules
@@ -12,3 +12,9 @@ binary-post-install/$(pkg)::
 binary-post-install/$(pkg)::
 	mv debian/$(cdbs_curpkg)/usr/share/locale/aym \
 		debian/$(cdbs_curpkg)/usr/share/locale/ay
+
+# Fix broken paths in desktop file
+#  * TODO: drop when fixed in sugar-toolkit-gtk3
+binary-fixup/$(pkg)::
+	find $(cdbs_curdestdir)/usr/share -type f -name '*.desktop' \
+		-execdir perl -pi -e 's,^\S+\s*=\s*\K\S*(?=/usr/share),,g' '{}' ';'
-- 
2.29.2

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 975373@bugs.debian.org (full text, mbox, reply):

From: James Cameron <quozl@laptop.org>

To: Vagrant Cascadian <vagrant@reproducible-builds.org>, 975373@bugs.debian.org

Cc: submit@bugs.debian.org

Subject: Re: [Pkg-sugar-devel] Bug#975373: sugar-read-activity: reproducible builds: Embeds build path in .desktop files

Date: Mon, 23 Nov 2020 13:06:51 +1100

Upstream bug
https://github.com/sugarlabs/sugar-toolkit-gtk3/issues/453

sugar-toolkit-gtk3 does not provide DESTDIR support yet, and
cdbs passes DEB_DESTDIR as PREFIX.

Message #17 received at 975373@bugs.debian.org (full text, mbox, reply):

From: James Cameron <quozl@laptop.org>

To: 975373@bugs.debian.org, 975374@bugs.debian.org

Subject: Upstream patch proposed

Date: Wed, 2 Dec 2020 11:35:11 +1100

Upstream has a patch and would like reviewers.

https://github.com/sugarlabs/sugar-toolkit-gtk3/pull/454

-- 
James Cameron
http://quozl.netrek.org/

Send a report that this bug log contains spam.