Debian Bug report logs - #975313
diffoscope test-depends on radare2, which is not in testing

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Matthias Klose <doko@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: diffoscope test-depends on radare2, which is not in testing

Date: Fri, 20 Nov 2020 12:30:16 +0100

Package: src:diffoscope
Version: 161
Severity: important
Tags: sid bullseye

diffoscope test-depends on radare2, which is not in testing, likely something
which should be fixed for the release.

Message #8 received at 975313-submitter@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: 975313-submitter@bugs.debian.org

Subject: Bug#975313 marked as pending in diffoscope

Date: Mon, 23 Nov 2020 11:03:33 +0000

Control: tag -1 pending

Hello,

Bug #975313 in diffoscope reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/reproducible-builds/diffoscope/-/commit/a615cc31a6e6d767a388ad3e074fc828703419d8

------------------------------------------------------------------------
Don't depends on radare2 in the Debian autopkgtests; it will not be in bullseye due to security considerations (see #950372). (Closes: #975313)
------------------------------------------------------------------------

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/975313

Message #15 received at 975313@bugs.debian.org (full text, mbox, reply):

From: Matthias Klose <doko@debian.org>

To: 975313@bugs.debian.org

Subject: Re: diffoscope test-depends on radare2, which is not in testing

Date: Wed, 25 Nov 2020 08:13:40 +0100

the patch committed in

https://salsa.debian.org/reproducible-builds/diffoscope/-/commit/a615cc31a6e6d767a388ad3e074fc828703419d8

removed the test dependency, but the tests are still run:

=================================== FAILURES ===================================
________________________ test_obj_compare_non_existing _________________________

args2 = (), kwargs2 = {}

    def inner(*args2, **kwargs2):
        if args[0]:  # i.e. the condition of the skipif() is True
>           return pytest.fail(msg)
E           Failed: requires radare2 (try installing radare2)
(DIFFOSCOPE_FAIL_TESTS_ON_MISSING_TOOLS='apktool zipinfo pedump oggDump ppudump
cbfstool otool lipo')

args       = (True,)
args2      = ()
kwargs2    = {}
msg        = ('requires radare2 (try installing radare2) '
 "(DIFFOSCOPE_FAIL_TESTS_ON_MISSING_TOOLS='apktool zipinfo pedump oggDump "
 "ppudump cbfstool otool lipo')")

tests/utils/tools.py:84: Failed
_______________________________ test_ghidra_diff _______________________________

args2 = (), kwargs2 = {}

    def inner(*args2, **kwargs2):
        if args[0]:  # i.e. the condition of the skipif() is True
>           return pytest.fail(msg)
E           Failed: requires radare2 (try installing radare2)
(DIFFOSCOPE_FAIL_TESTS_ON_MISSING_TOOLS='apktool zipinfo pedump oggDump ppudump
cbfstool otool lipo')

args       = (True,)
args2      = ()
kwargs2    = {}
msg        = ('requires radare2 (try installing radare2) '
 "(DIFFOSCOPE_FAIL_TESTS_ON_MISSING_TOOLS='apktool zipinfo pedump oggDump "
 "ppudump cbfstool otool lipo')")

tests/utils/tools.py:84: Failed
______________________________ test_radare2_diff _______________________________

args2 = (), kwargs2 = {}

    def inner(*args2, **kwargs2):
        if args[0]:  # i.e. the condition of the skipif() is True
>           return pytest.fail(msg)
E           Failed: requires radare2 (try installing radare2)
(DIFFOSCOPE_FAIL_TESTS_ON_MISSING_TOOLS='apktool zipinfo pedump oggDump ppudump
cbfstool otool lipo')

args       = (True,)
args2      = ()
kwargs2    = {}
msg        = ('requires radare2 (try installing radare2) '
 "(DIFFOSCOPE_FAIL_TESTS_ON_MISSING_TOOLS='apktool zipinfo pedump oggDump "
 "ppudump cbfstool otool lipo')")

tests/utils/tools.py:84: Failed
=========================== short test summary info ============================
SKIPPED [1] tests/test_presenters.py:89: requires file (try installing file) >=
5.39 (5.38 detected)
SKIPPED [1] tests/comparators/test_apk.py:76: requires apktool (try installing
apktool) >= 2.5.0 (2.4.1-dirty detected)
SKIPPED [1] tests/comparators/test_cbfs.py:101: requires cbfstool
SKIPPED [1] tests/comparators/test_cbfs.py:106: requires cbfstool
SKIPPED [1] tests/comparators/test_cbfs.py:111: requires cbfstool
SKIPPED [1] tests/comparators/test_cbfs.py:123: requires cbfstool
SKIPPED [1] tests/comparators/test_cbfs.py:135: requires cbfstool
SKIPPED [1] tests/comparators/test_cbfs.py:143: requires cbfstool
SKIPPED [1] tests/comparators/test_macho.py:50: requires otool and lipo
SKIPPED [1] tests/comparators/test_macho.py:58: requires otool and lipo
SKIPPED [1] tests/comparators/test_utils.py:50: requires
SKIPPED [1] tests/comparators/test_utils.py:55: requires /missing
FAILED tests/comparators/test_elf_decompiler.py::test_obj_compare_non_existing
FAILED tests/comparators/test_elf_decompiler.py::test_ghidra_diff - Failed: r...
FAILED tests/comparators/test_elf_decompiler.py::test_radare2_diff - Failed: ...
============== 3 failed, 437 passed, 12 skipped in 222.28 seconds ==============
autopkgtest [00:58:08]: test pytest-with-recommends: -----------------------]

Message #20 received at 975313@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>

To: "Matthias Klose" <doko@debian.org>, 975313@bugs.debian.org

Subject: Re: Bug#975313: diffoscope test-depends on radare2, which is not in testing

Date: Wed, 25 Nov 2020 10:49:08 +0000

Hi Matthias,

> the patch committed in
>
> https://salsa.debian.org/reproducible-builds/diffoscope/-/commit/a615cc31a6e6d767a388ad3e074fc828703419d8
>
> removed the test dependency, but the tests are still run […]

Thanks. I forgot about some magic we do in our autopkgtests. This
should be fixed in:

  https://salsa.debian.org/reproducible-builds/diffoscope/commit/793376de78d79f5d8e9db140cf0ccc468c7421db


Regards,

--
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org 🍥 chris-lamb.co.uk
       `-

Message #23 received at 975313-submitter@bugs.debian.org (full text, mbox, reply):

From: Mattia Rizzolo <mattia@debian.org>

To: 975313-submitter@bugs.debian.org

Subject: Bug#975313 marked as pending in diffoscope

Date: Wed, 25 Nov 2020 15:32:07 +0000

Control: tag -1 pending

Hello,

Bug #975313 in diffoscope reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/reproducible-builds/diffoscope/-/commit/a615cc31a6e6d767a388ad3e074fc828703419d8

------------------------------------------------------------------------
Don't depends on radare2 in the Debian autopkgtests; it will not be in bullseye due to security considerations (see #950372). (Closes: #975313)
------------------------------------------------------------------------

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/975313

Message #28 received at 975313-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 975313-close@bugs.debian.org

Subject: Bug#975313: fixed in diffoscope 162

Date: Mon, 30 Nov 2020 17:00:08 +0000

Source: diffoscope
Source-Version: 162
Done: Chris Lamb <lamby@debian.org>

We believe that the bug you reported is fixed in the latest version of
diffoscope, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 975313@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Chris Lamb <lamby@debian.org> (supplier of updated diffoscope package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Fri, 27 Nov 2020 09:41:32 +0000
Source: diffoscope
Binary: diffoscope diffoscope-minimal
Architecture: source all
Version: 162
Distribution: unstable
Urgency: medium
Maintainer: Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>
Changed-By: Chris Lamb <lamby@debian.org>
Description:
 diffoscope - in-depth visual diff tool for files, archives and directories
 diffoscope-minimal - in-depth visual diff tool for files, archives and directories
Closes: 975261 975313
Changes:
 diffoscope (162) unstable; urgency=medium
 .
   [ Chris Lamb ]
   * Don't depends on radare2 in the Debian autopkgtests as it will not be in
     bullseye due to security considerations (#950372). (Closes: #975313)
   * Avoid "Command `s p a c e d o u t` failed" messages when creating an
     artificial CalledProcessError instance in our generic from_operation
     feeder creator.
   * Overhaul long and short descriptions.
   * Use the operation's full name so that "command failed" messages include
     its arguments.
   * Add a missing comma in a comment.
 .
   [ Jelmer Vernooij ]
   * Add missing space to the error message when only one argument is passed to
     diffoscope.
 .
   [ Holger Levsen ]
   * Update Standards-Version to 4.5.1.
 .
   [ Mattia Rizzolo ]
   * Split the diffoscope package into a diffoscope-minimal package that
     excludes the larger packages from Recommends. (Closes: #975261)
   * Drop support for Python 3.6.
Checksums-Sha1:
 bedc0ad10ec79da33c0edb773087246cda7cd4b2 4875 diffoscope_162.dsc
 70937a61ed0ccda602f67436753a3514b6b0a6c2 988200 diffoscope_162.tar.xz
 1bb78efe3763959dc43a9265b12b8d2850214c11 153988 diffoscope-minimal_162_all.deb
 f4a83c4e25aa30a0d5807d088d1bb8bca1aa80b4 58104 diffoscope_162_all.deb
 206e353136f1785e91fb0693dcc45cd8ba743ab1 27490 diffoscope_162_amd64.buildinfo
Checksums-Sha256:
 baf3c5df25b0828881c685bffb053c227792bddab5e03779da34851d1528901f 4875 diffoscope_162.dsc
 3dfe6bb2241701401cefefde5c243b755542393cd0e4d00feed80ab30c34e43e 988200 diffoscope_162.tar.xz
 9448b25b4be2c9d51e6e9b938a1c904cf159ba379255767df3196683a2c21be1 153988 diffoscope-minimal_162_all.deb
 c7cb67589886be2a412705ec9c5d4aa0b002f7b7a3a24280ba486e7dc965688a 58104 diffoscope_162_all.deb
 3efa0a67dc50e0e6371ce592164b8bb141a44f02d220ae8f0a0bf2a85af6f0fb 27490 diffoscope_162_amd64.buildinfo
Files:
 1942740a0e27532c3350ebbc78c762eb 4875 devel optional diffoscope_162.dsc
 ecd33d0ed596db8b4604ed613cbdb7d8 988200 devel optional diffoscope_162.tar.xz
 74abf3a2a33404fd3500291505e0a267 153988 devel optional diffoscope-minimal_162_all.deb
 60459c500dd672bb8794c0bc8543c17e 58104 devel optional diffoscope_162_all.deb
 75f2365fbd6fbf1036805302c39fdb8e 27490 devel optional diffoscope_162_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEwv5L0nHBObhsUz5GHpU+J9QxHlgFAl/AznUACgkQHpU+J9Qx
Hlh77xAAssMbLFA1Iay0VXPLJEM8jnTQNxMokrhYwckNL0LA/Mb1l5obVk0vPq3z
hb4KyWr6XvWKw28RBY46xNT0Xh4g6qW1HpqTaHr5JroOVx1vQaejifEWX7l+np0r
WJkW9btnFPIt42jMKM7oLyON6trQJjgrIPH51t7CDzREGW1yWnAORbGrQBGezFfR
6DwXPxocGDqPxfYI3RSYld3Fqop8FTXnstTeSntoEY3De5ATLx52sy4Bfie/dn1u
k2uRg30LeXCSFN02AxglGURQwFdL2i+Dr8VC4KHU9W3nWZt7uvKz9XintAX7Fm2f
io5GcSSL/+Jne6bF1Tqvu1VgyvusiyaNS47G92ps1qD47/ZFeVcMOevDRXAJuDyS
0DQGuA3dkzFj5zHF79Z/ZqOF/hqIdWireR7jgi8wZ5I5T/LNoNam5wCHwN/dPcXI
h4wiXzWHqKy7ynPNMfnDKb1EeomTUS+cazOAXyQino+bjFhS4vyeuMR4yFt5dSmq
IgTXtSqT2A1Tq93/zJOTQEgCMQlfpVy/4lM12kmY9y7qw61/+YWW81CJjR1I4WWI
3QUGR+c5qyibHWqfS9pVxaBiuCPZKkeZdki+Yhf900p8FwD2vyOr16NbpEZ6xToP
dooK4oMnsgsFMutgW2QuP35WT4V/fZ6eJF4s1KK4iuRA9Y6AAKg=
=77+o
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.