Debian Bug report logs - #975096
diffoscope: sources for some test files missing

Reply or subscribe to this bug.

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Holger Levsen <holger@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: diffoscope: sources for some test files missing

Date: Wed, 18 Nov 2020 22:18:12 +0100

[Message part 1 (text/plain, inline)]

Package: diffoscope
Version: 161
Severity: normal

Dear Maintainer,

building diffoscope 161 results in the following lintian warnings and errors
which we should fix, because also tests should ship their sources (in general,
there are some exceptions...)

E: diffoscope source: source-is-missing tests/data/test1.debug
E: diffoscope source: source-is-missing tests/data/test1.o
E: diffoscope source: source-is-missing tests/data/test2.debug
E: diffoscope source: source-is-missing tests/data/test2.o
W: diffoscope source: source-contains-prebuilt-windows-binary tests/data/test1.exe
W: diffoscope source: source-contains-prebuilt-windows-binary tests/data/test2.exe

I *believe* these six files, test(1|2).(exe|o|debug), come from two source files...


-- 
cheers,
	Holger

 ⢀⣴⠾⠻⢶⣦⠀
 ⣾⠁⢠⠒⠀⣿⡁       holger@(debian|reproducible-builds|layer-acht).org
 ⢿⡄⠘⠷⠚⠋⠀ PGP fingerprint: B8BF 5413 7B09 D35C F026 FE9D 091A B856 069A AA1C
 ⠈⠳⣄

There are no jobs on a dead planet. (Also many other things but people mostly
seem to care about jobs.)

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 975096@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>

To: "Holger Levsen" <holger@debian.org>, 975096@bugs.debian.org

Subject: Re: Bug#975096: diffoscope: sources for some test files missing

Date: Fri, 20 Nov 2020 13:07:02 -0000

Hi Holger,

> building diffoscope 161 results in the following lintian warnings and errors
> which we should fix, because also tests should ship their sources (in general,
> there are some exceptions...)

This has been a work in progress for some time and, indeed, something
I have been working on:

  https://salsa.debian.org/reproducible-builds/diffoscope/-/issues/66

We have some grounds to override these *Lintian* warnings though. This
starts with the observation that these executables are usually no more
than just:

   int main() {
       printf("Free Jeremy Hammond\n");
       return 0;
   }

Short stubs of this kind are not copyrightable to begin with, and
therefore the legal situation (which is the angle that Lintian is
primarily concerned about) becomes a little less urgent.

Of course, for all the reasons you imply this would not invalidate the
idea that sources should be shipped regardless of legal stuff, it only
rounds off what first looks like a rather sharp edge and reduces its
priority relative to other tasks.


Regards,

--
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org 🍥 chris-lamb.co.uk
       `-

Message #15 received at 975096@bugs.debian.org (full text, mbox, reply):

From: Holger Levsen <holger@layer-acht.org>

To: 975096@bugs.debian.org

Subject: Re: Bug#975096: diffoscope: sources for some test files missing

Date: Wed, 27 Jan 2021 13:53:30 +0000

[Message part 1 (text/plain, inline)]

Hi Chris,

On Fri, Nov 20, 2020 at 01:07:02PM -0000, Chris Lamb wrote:
> > building diffoscope 161 results in the following lintian warnings and errors
> > which we should fix, because also tests should ship their sources (in general,
> > there are some exceptions...)
> This has been a work in progress for some time and, indeed, something
> I have been working on:
>   https://salsa.debian.org/reproducible-builds/diffoscope/-/issues/66

Ah, cool, I wasn't aware we were aware of this already. :)

> We have some grounds to override these *Lintian* warnings though.
> [...]

This would be fine with me for the time being, especially given we can link
this bug and the above mentioned issue.


-- 
cheers,
	Holger

 ⢀⣴⠾⠻⢶⣦⠀
 ⣾⠁⢠⠒⠀⣿⡁       holger@(debian|reproducible-builds|layer-acht).org
 ⢿⡄⠘⠷⠚⠋⠀ PGP fingerprint: B8BF 5413 7B09 D35C F026 FE9D 091A B856 069A AA1C
 ⠈⠳⣄

[signature.asc (application/pgp-signature, inline)]

Send a report that this bug log contains spam.