Debian Bug report logs - #975025
flex: reproducible builds: example Makefiles contain build paths

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: submit@bugs.debian.org

Subject: flex: reproducible builds: example Makefiles contain build paths

Date: Tue, 17 Nov 2020 20:37:06 -0800

[Message part 1 (text/plain, inline)]

Source: flex
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpaths
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Well, this is a bit of a re-run: Bug#949343: flex: Embeds build paths in
example Makefiles

But in my proposed fix for that version, I neglected to test only
building arch:all packages, which triggered: #961778 flex: binary-all
FTBFS

This time, I'm proposing a much simpler fix; just remove the generated
Makefiles, but only remove them when ... they are actually present!
(e.g. arch:any build vs. arch:all build)

I think this is a better approach than sanitizing the Makefile, since
the Makefile.am is also shipped, and a person who wanted to build the
examples would probably need to regenerate the Makefile anyways.

Patch attached, tested with arch:all only, arch:any only and
arch:all+any builds.


live well,
  vagrant

[0001-debian-rules-Remove-example-autogenerated-Makefiles-.patch (text/x-diff, inline)]

From 4b9384cc7b73f984507c75f15f293982896135a4 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Wed, 18 Nov 2020 04:04:02 +0000
Subject: [PATCH] debian/rules: Remove example autogenerated Makefiles which
 contain build paths.

---
 debian/rules | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/debian/rules b/debian/rules
index d0d5597..31a4c72 100755
--- a/debian/rules
+++ b/debian/rules
@@ -91,6 +91,15 @@ ifneq (,$(filter flex-doc, $(shell dh_listpackages)))
            debian/flex-doc/usr/share/doc/flex-doc/
 endif
 
+override_dh_installexamples:
+	dh_installexamples
+	# Remove autogenerated Makefiles which contain embedded build
+	# paths in order to ensure reproducible builds.
+	test ! -f debian/flex/usr/share/doc/flex/examples/fastwc/Makefile || \
+		rm -f debian/flex/usr/share/doc/flex/examples/fastwc/Makefile
+	test ! -f debian/flex/usr/share/doc/flex/examples/manual/Makefile || \
+		rm -f debian/flex/usr/share/doc/flex/examples/manual/Makefile
+
 override_dh_auto_build:
 	dh_auto_build
 ifneq (,$(filter flex-doc, $(shell dh_listpackages)))
-- 
2.29.2

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 975025@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: 975025@bugs.debian.org

Cc: srivasta@debian.org

Subject: Re: Bug#975025: flex: reproducible builds: example Makefiles contain build paths

Date: Fri, 01 Jan 2021 12:56:53 -0800

[Message part 1 (text/plain, inline)]

On 2020-11-17, Vagrant Cascadian wrote:
> From 4b9384cc7b73f984507c75f15f293982896135a4 Mon Sep 17 00:00:00 2001
> From: Vagrant Cascadian <vagrant@reproducible-builds.org>
> Date: Wed, 18 Nov 2020 04:04:02 +0000
> Subject: [PATCH] debian/rules: Remove example autogenerated Makefiles which
>  contain build paths.
>
> ---
>  debian/rules | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/debian/rules b/debian/rules
> index d0d5597..31a4c72 100755
> --- a/debian/rules
> +++ b/debian/rules
> @@ -91,6 +91,15 @@ ifneq (,$(filter flex-doc, $(shell dh_listpackages)))
>             debian/flex-doc/usr/share/doc/flex-doc/
>  endif
>  
> +override_dh_installexamples:
> +	dh_installexamples
> +	# Remove autogenerated Makefiles which contain embedded build
> +	# paths in order to ensure reproducible builds.
> +	test ! -f debian/flex/usr/share/doc/flex/examples/fastwc/Makefile || \
> +		rm -f debian/flex/usr/share/doc/flex/examples/fastwc/Makefile
> +	test ! -f debian/flex/usr/share/doc/flex/examples/manual/Makefile || \
> +		rm -f debian/flex/usr/share/doc/flex/examples/manual/Makefile
> +
>  override_dh_auto_build:
>  	dh_auto_build
>  ifneq (,$(filter flex-doc, $(shell dh_listpackages)))
> -- 
> 2.29.2

Would very much like to see this land in bullseye... would you consider
uploading soon, or be amenable to an NMU?


Thanks for maintaining flex!


live well,
  vagrant

[signature.asc (application/pgp-signature, inline)]

Message #15 received at 975025@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: 975025@bugs.debian.org

Cc: srivasta@debian.org

Subject: Re: Bug#975025: flex: reproducible builds: example Makefiles contain build paths

Date: Tue, 30 Nov 2021 17:01:47 -0800

[Message part 1 (text/plain, inline)]

On 2021-01-01, Vagrant Cascadian wrote:
> On 2020-11-17, Vagrant Cascadian wrote:
>> From 4b9384cc7b73f984507c75f15f293982896135a4 Mon Sep 17 00:00:00 2001
>> From: Vagrant Cascadian <vagrant@reproducible-builds.org>
>> Date: Wed, 18 Nov 2020 04:04:02 +0000
>> Subject: [PATCH] debian/rules: Remove example autogenerated Makefiles which
>>  contain build paths.
>>
>> ---
>>  debian/rules | 9 +++++++++
>>  1 file changed, 9 insertions(+)
>>
>> diff --git a/debian/rules b/debian/rules
>> index d0d5597..31a4c72 100755
>> --- a/debian/rules
>> +++ b/debian/rules
>> @@ -91,6 +91,15 @@ ifneq (,$(filter flex-doc, $(shell dh_listpackages)))
>>             debian/flex-doc/usr/share/doc/flex-doc/
>>  endif
>>  
>> +override_dh_installexamples:
>> +	dh_installexamples
>> +	# Remove autogenerated Makefiles which contain embedded build
>> +	# paths in order to ensure reproducible builds.
>> +	test ! -f debian/flex/usr/share/doc/flex/examples/fastwc/Makefile || \
>> +		rm -f debian/flex/usr/share/doc/flex/examples/fastwc/Makefile
>> +	test ! -f debian/flex/usr/share/doc/flex/examples/manual/Makefile || \
>> +		rm -f debian/flex/usr/share/doc/flex/examples/manual/Makefile
>> +
>>  override_dh_auto_build:
>>  	dh_auto_build
>>  ifneq (,$(filter flex-doc, $(shell dh_listpackages)))
>> -- 
>> 2.29.2
>
> Would very much like to see this land in bullseye... would you consider
> uploading soon, or be amenable to an NMU?

Still hoping to see this fixed for bookworm!


live well,
  vagrant

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 975025@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: 975025@bugs.debian.org

Cc: srivasta@debian.org

Subject: Re: Bug#975025: flex: reproducible builds: example Makefiles contain build paths

Date: Wed, 21 Sep 2022 16:56:24 -0700

[Message part 1 (text/plain, inline)]

On 2021-11-30, Vagrant Cascadian wrote:
> On 2021-01-01, Vagrant Cascadian wrote:
>> On 2020-11-17, Vagrant Cascadian wrote:
>>> From 4b9384cc7b73f984507c75f15f293982896135a4 Mon Sep 17 00:00:00 2001
>>> From: Vagrant Cascadian <vagrant@reproducible-builds.org>
>>> Date: Wed, 18 Nov 2020 04:04:02 +0000
>>> Subject: [PATCH] debian/rules: Remove example autogenerated Makefiles which
>>>  contain build paths.
>>>
>>> ---
>>>  debian/rules | 9 +++++++++
>>>  1 file changed, 9 insertions(+)
>>>
>>> diff --git a/debian/rules b/debian/rules
>>> index d0d5597..31a4c72 100755
>>> --- a/debian/rules
>>> +++ b/debian/rules
>>> @@ -91,6 +91,15 @@ ifneq (,$(filter flex-doc, $(shell dh_listpackages)))
>>>             debian/flex-doc/usr/share/doc/flex-doc/
>>>  endif
>>>  
>>> +override_dh_installexamples:
>>> +	dh_installexamples
>>> +	# Remove autogenerated Makefiles which contain embedded build
>>> +	# paths in order to ensure reproducible builds.
>>> +	test ! -f debian/flex/usr/share/doc/flex/examples/fastwc/Makefile || \
>>> +		rm -f debian/flex/usr/share/doc/flex/examples/fastwc/Makefile
>>> +	test ! -f debian/flex/usr/share/doc/flex/examples/manual/Makefile || \
>>> +		rm -f debian/flex/usr/share/doc/flex/examples/manual/Makefile
>>> +
>>>  override_dh_auto_build:
>>>  	dh_auto_build
>>>  ifneq (,$(filter flex-doc, $(shell dh_listpackages)))
>>> -- 
>>> 2.29.2
>>
>> Would very much like to see this land in bullseye... would you consider
>> uploading soon, or be amenable to an NMU?
>
> Still hoping to see this fixed for bookworm!

I have uploaded an NMU fixing this to DELAYED 10, with the following
debdiff:

diff -u flex-2.6.4/debian/changelog flex-2.6.4/debian/changelog
--- flex-2.6.4/debian/changelog
+++ flex-2.6.4/debian/changelog
@@ -1,3 +1,11 @@
+flex (2.6.4-8.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * debian/rules: Remove example autogenerated Makefiles which contain
+    build paths. (Closes: #975025)
+
+ -- Vagrant Cascadian <vagrant@reproducible-builds.org>  Wed, 21 Sep 2022 23:35:53 +0000
+
 flex (2.6.4-8) unstable; urgency=medium

   * The source does not ship with example Makefiles, so no need to massage them.
diff -u flex-2.6.4/debian/rules flex-2.6.4/debian/rules
--- flex-2.6.4/debian/rules
+++ flex-2.6.4/debian/rules
@@ -91,6 +91,13 @@
            debian/flex-doc/usr/share/doc/flex-doc/
 endif

+override_dh_installexamples:
+       dh_installexamples
+       # Remove autogenerated Makefiles which contain embedded build
+       # paths in order to ensure reproducible builds.
+       rm -f debian/flex/usr/share/doc/flex/examples/fastwc/Makefile
+       rm -f debian/flex/usr/share/doc/flex/examples/manual/Makefile
+
 override_dh_auto_build:
        dh_auto_build
 ifneq (,$(filter flex-doc, $(shell dh_listpackages)))


live well,
  vagrant

[signature.asc (application/pgp-signature, inline)]

Message #27 received at 975025-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 975025-close@bugs.debian.org

Subject: Bug#975025: fixed in flex 2.6.4-8.1

Date: Sun, 02 Oct 2022 00:49:15 +0000

Source: flex
Source-Version: 2.6.4-8.1
Done: Vagrant Cascadian <vagrant@reproducible-builds.org>

We believe that the bug you reported is fixed in the latest version of
flex, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 975025@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Vagrant Cascadian <vagrant@reproducible-builds.org> (supplier of updated flex package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 21 Sep 2022 23:35:53 +0000
Source: flex
Architecture: source
Version: 2.6.4-8.1
Distribution: unstable
Urgency: medium
Maintainer: Manoj Srivastava <srivasta@debian.org>
Changed-By: Vagrant Cascadian <vagrant@reproducible-builds.org>
Closes: 975025
Changes:
 flex (2.6.4-8.1) unstable; urgency=medium
 .
   * Non-maintainer upload.
   * debian/rules: Remove example autogenerated Makefiles which contain
     build paths. (Closes: #975025)
Checksums-Sha1:
 fd17171e345756517cadd64281e68c5b3902cc1f 1659 flex_2.6.4-8.1.dsc
 b5fb605a2850878471f857142cb13a68626e699b 60469 flex_2.6.4-8.1.diff.gz
Checksums-Sha256:
 72e2badabc3c42ee840451eb2b967aabcf406213036e90848f24c3f0fc657794 1659 flex_2.6.4-8.1.dsc
 294674d0bcdb14b08b626c719a0995d0856eb299cd878317d2e688449e3f404a 60469 flex_2.6.4-8.1.diff.gz
Files:
 af8491ba5fa5e09f46aadaa037e7c4a4 1659 devel optional flex_2.6.4-8.1.dsc
 9227d8c2b735e348e05ba7878de36e29 60469 devel optional flex_2.6.4-8.1.diff.gz

-----BEGIN PGP SIGNATURE-----

iJYEARYKAD4WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCYyukByAcdmFncmFudEBy
ZXByb2R1Y2libGUtYnVpbGRzLm9yZwAKCRDcUY/If5cWqtVRAQC+LiNfUu+BNK6/
14Ubk6NrZ6tCaXdyhuibdqd2dKMrAwEA0I6jQ0/WNjOwdD4u0TzfpaGmHHVUrsWi
O5XbTXLbKQI=
=2QGJ
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.