Debian Bug report logs - #974065
rails: nocheck builds should not depend on qunit-selenium

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Sven Mueller <sven.mueller72@gmail.com>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: rails: nocheck builds should not depend on qunit-selenium

Date: Mon, 9 Nov 2020 15:40:15 +0100

[Message part 1 (text/plain, inline)]

Package: rails
Version: 2:6.0.3.4+dfsg-1
Tags: patch

Turns out that this isn't needed and pulls in a lot of dependencies if the
build is done without tests.

The attached patch moves the start of the redis server (only needed for
tests) inside the override_dh_auto_test section in debian/rules (I suspect
that the redis server was also only pulled in via the qunit-selenium
dependency? - without this move, the resulting build failed). The
dependency on qunit-selenium is marked as <!nocheck> so it is now only
pulled in if tests are enabled.

Please consider merging this. The change is trivial and I don't believe it
would create any copyright concerns, but just in case a license would
actually be required, I license this under the Expat license or CC-BY 3.0
or CC-BY-SA-4.0, the choice of license is left to the receiver of the
license and should  be fully compatible with the Debian packaging as well
as upstream (though this only affects the packaging, so I doubt they care).

[Message part 2 (text/html, inline)]

[rails-nocheck-noselenium.patch (text/x-patch, attachment)]

Message #10 received at 974065@bugs.debian.org (full text, mbox, reply):

From: Antonio Terceiro <terceiro@debian.org>

To: Sven Mueller <sven.mueller72@gmail.com>, 974065@bugs.debian.org

Subject: Re: [DRE-maint] Bug#974065: rails: nocheck builds should not depend on qunit-selenium

Date: Tue, 1 Dec 2020 20:09:15 -0300

[Message part 1 (text/plain, inline)]

On Mon, Nov 09, 2020 at 03:40:15PM +0100, Sven Mueller wrote:
> Package: rails
> Version: 2:6.0.3.4+dfsg-1
> Tags: patch
> 
> Turns out that this isn't needed and pulls in a lot of dependencies if the
> build is done without tests.
> 
> The attached patch moves the start of the redis server (only needed for
> tests) inside the override_dh_auto_test section in debian/rules (I suspect
> that the redis server was also only pulled in via the qunit-selenium
> dependency? - without this move, the resulting build failed). The
> dependency on qunit-selenium is marked as <!nocheck> so it is now only
> pulled in if tests are enabled.
> 
> Please consider merging this. The change is trivial and I don't believe it
> would create any copyright concerns, but just in case a license would
> actually be required, I license this under the Expat license or CC-BY 3.0
> or CC-BY-SA-4.0, the choice of license is left to the receiver of the
> license and should  be fully compatible with the Debian packaging as well
> as upstream (though this only affects the packaging, so I doubt they care).

> diff --git a/debian/control b/debian/control
> index 59d14bfe..3d067e13 100644
> --- a/debian/control
> +++ b/debian/control
> @@ -18,7 +18,7 @@ Build-Depends: debhelper-compat (= 12),
>                 ruby-byebug,
>  # Ruby packages - from Gemfile
>                 puma (>= 4.1~),
> -               qunit-selenium,
> +               qunit-selenium <!nocheck>,
>                 racc (>= 1.4.6),
>                 rake (>= 11.1),
>                 ruby-bcrypt (<< 3.2),
> diff --git a/debian/rules b/debian/rules
> index d3747fee..41bfe45a 100755
> --- a/debian/rules
> +++ b/debian/rules
> @@ -20,17 +20,17 @@ override_dh_clean:
>  	debian/stop-redis-server.sh || true
>  	
>  override_dh_auto_install:
> -	# start redis server for tests
> -	debian/start-redis-server.sh
>  	# auto install
>  	dh_auto_install -O--buildsystem=ruby
> -	# kill redis server used for tests
> -	debian/stop-redis-server.sh	
>  	$(RM) debian/ruby-activesupport/usr/bin/generate_tables
>  	$(RM) debian/*/usr/bin/test
>  	rmdir debian/*/usr/bin || true
>  
>  override_dh_auto_test:
>  ifeq ($(filter nocheck,$(DEB_BUILD_PROFILES)),)
> +	# start redis server for tests
> +	debian/start-redis-server.sh
>  	dh_auto_test
> +	# kill redis server used for tests
> +	debian/stop-redis-server.sh	
>  endif

Did you test this on a full build? gem2deb has a limitation/bug that
causes the tests to be executed during the install target, and not the
test one.

[signature.asc (application/pgp-signature, inline)]

Message #15 received at 974065@bugs.debian.org (full text, mbox, reply):

From: Sven Mueller <sven.mueller72@gmail.com>

To: Antonio Terceiro <terceiro@debian.org>

Cc: 974065@bugs.debian.org

Subject: Re: [DRE-maint] Bug#974065: rails: nocheck builds should not depend on qunit-selenium

Date: Wed, 2 Dec 2020 13:02:48 +0100

[Message part 1 (text/plain, inline)]

Oh my, I didn't expect that.

Turns out "dh_ruby test" doesn't do anything... Oh my.
I updated the patch to compensate. It works now for both the full build (in
pbuilder) and with nocheck (and qunit-selenium not getting installed).

Cheers,
Sven

Am Mi., 2. Dez. 2020 um 00:09 Uhr schrieb Antonio Terceiro <
terceiro@debian.org>:

> On Mon, Nov 09, 2020 at 03:40:15PM +0100, Sven Mueller wrote:
> > Package: rails
> > Version: 2:6.0.3.4+dfsg-1
> > Tags: patch
> >
> > Turns out that this isn't needed and pulls in a lot of dependencies if
> the
> > build is done without tests.
> >
> > The attached patch moves the start of the redis server (only needed for
> > tests) inside the override_dh_auto_test section in debian/rules (I
> suspect
> > that the redis server was also only pulled in via the qunit-selenium
> > dependency? - without this move, the resulting build failed). The
> > dependency on qunit-selenium is marked as <!nocheck> so it is now only
> > pulled in if tests are enabled.
> >
> > Please consider merging this. The change is trivial and I don't believe
> it
> > would create any copyright concerns, but just in case a license would
> > actually be required, I license this under the Expat license or CC-BY 3.0
> > or CC-BY-SA-4.0, the choice of license is left to the receiver of the
> > license and should  be fully compatible with the Debian packaging as well
> > as upstream (though this only affects the packaging, so I doubt they
> care).
>
> > diff --git a/debian/control b/debian/control
> > index 59d14bfe..3d067e13 100644
> > --- a/debian/control
> > +++ b/debian/control
> > @@ -18,7 +18,7 @@ Build-Depends: debhelper-compat (= 12),
> >                 ruby-byebug,
> >  # Ruby packages - from Gemfile
> >                 puma (>= 4.1~),
> > -               qunit-selenium,
> > +               qunit-selenium <!nocheck>,
> >                 racc (>= 1.4.6),
> >                 rake (>= 11.1),
> >                 ruby-bcrypt (<< 3.2),
> > diff --git a/debian/rules b/debian/rules
> > index d3747fee..41bfe45a 100755
> > --- a/debian/rules
> > +++ b/debian/rules
> > @@ -20,17 +20,17 @@ override_dh_clean:
> >       debian/stop-redis-server.sh || true
> >
> >  override_dh_auto_install:
> > -     # start redis server for tests
> > -     debian/start-redis-server.sh
> >       # auto install
> >       dh_auto_install -O--buildsystem=ruby
> > -     # kill redis server used for tests
> > -     debian/stop-redis-server.sh
> >       $(RM) debian/ruby-activesupport/usr/bin/generate_tables
> >       $(RM) debian/*/usr/bin/test
> >       rmdir debian/*/usr/bin || true
> >
> >  override_dh_auto_test:
> >  ifeq ($(filter nocheck,$(DEB_BUILD_PROFILES)),)
> > +     # start redis server for tests
> > +     debian/start-redis-server.sh
> >       dh_auto_test
> > +     # kill redis server used for tests
> > +     debian/stop-redis-server.sh
> >  endif
>
> Did you test this on a full build? gem2deb has a limitation/bug that
> causes the tests to be executed during the install target, and not the
> test one.
>

[Message part 2 (text/html, inline)]

[nocheck-noselenium.patch (text/x-patch, attachment)]

Message #20 received at 974065-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 974065-close@bugs.debian.org

Subject: Bug#974065: fixed in rails 2:6.0.3.4+dfsg-2

Date: Fri, 11 Dec 2020 21:49:41 +0000

Source: rails
Source-Version: 2:6.0.3.4+dfsg-2
Done: Utkarsh Gupta <utkarsh@debian.org>

We believe that the bug you reported is fixed in the latest version of
rails, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 974065@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Utkarsh Gupta <utkarsh@debian.org> (supplier of updated rails package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sat, 12 Dec 2020 02:42:08 +0530
Source: rails
Architecture: source
Version: 2:6.0.3.4+dfsg-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Ruby Team <pkg-ruby-extras-maintainers@lists.alioth.debian.org>
Changed-By: Utkarsh Gupta <utkarsh@debian.org>
Closes: 974065 976291
Changes:
 rails (2:6.0.3.4+dfsg-2) unstable; urgency=medium
 .
   [ Pirate Praveen ]
   * Allow build with "nocheck" build profile to skip selenium
     dependency. (Closes: #974065)
     - Thanks, Sven Mueller, for the patch.
   * Drop build dependency on qunit-selenium. (Closes: #976291)
     - We do not have tests enabled that need qunit-selenium.
 .
   [ Utkarsh Gupta ]
   * Fix d/control spacing issue.
   * Remove unnecessary version guards.
     + cme fix dpkg to the resuce.
   * Bump debhelper-compat to 13.
   * Re-format d/gbp.conf.
     - To help properly branch out stuff.
Checksums-Sha1:
 ce1148d7d44256c271f4400a9ac41b4f7db552f8 4856 rails_6.0.3.4+dfsg-2.dsc
 bcfcaf7d3d1c6eb6d6dfffaa58392c9346e78b6b 97452 rails_6.0.3.4+dfsg-2.debian.tar.xz
 70c81cd9d3228ef2ea1604d663e344332bcc7008 34234 rails_6.0.3.4+dfsg-2_amd64.buildinfo
Checksums-Sha256:
 0f37d8fb9bd8b6c5498591dbb793c8f98670df5ede55fb6117a296c41def0d0c 4856 rails_6.0.3.4+dfsg-2.dsc
 ef1035ea8a8fecaf474f3b1aeddb9212136990b618fe79488585a6a35720c99f 97452 rails_6.0.3.4+dfsg-2.debian.tar.xz
 016a9a3af6183c136162966869f8c91a1441fd56d302455bb2adf5f8f2e17214 34234 rails_6.0.3.4+dfsg-2_amd64.buildinfo
Files:
 6d39689ade46ddfac23b58cb36c0dc53 4856 ruby optional rails_6.0.3.4+dfsg-2.dsc
 1cb74cf10cfecc608ee8cdfcaeb2af81 97452 ruby optional rails_6.0.3.4+dfsg-2.debian.tar.xz
 51e5eb013723e2b0400687bdbbc2e4e3 34234 ruby optional rails_6.0.3.4+dfsg-2_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJHBAEBCAAxFiEEbJ0QSEqa5Mw4X3xxgj6WdgbDS5YFAl/T44oTHHV0a2Fyc2hA
ZGViaWFuLm9yZwAKCRCCPpZ2BsNLlrXBEACNyhQIW+SOMcO8J8q98JJYC+BgloC6
pJ6lmjl66SDTaTFD2MsGP12Ef3gsPH6pdEXrXgQbKt6pozgmOA9nzPmQvYobDkmf
huA2ByvsV7nGSVymjAYBVgUjfdNt6R0Rrj0SYAH9KAP6y7juprYqDZAIdoKBULKm
nWrLrD2AhdzZTEt040yZlxx5d4/5dSd1xW1xGDPacXTFVIEJkivfIRIUyT8103F7
BN4ruLUz7FdNdzmxiojdK9YrcthWCTKDLoKUosXIdWWZef/fsQS55KqZj3h1CzCF
i7xNc+0RkGOPdyfxzIJYRzPMvfimc8A/329mNuxDhASzn9o04yacH+U5eQvR3ZTw
RibZI6kgHTkZ0TDe99UxV1ep7SGIRRRYajJJoZ2Njq2UpKCKYPvXFjf6b1R1IZJH
LoMkPIhrqREUKMBBpHcXetVuE4f6qMY5r7Thy1OdXJZ3raww3caBZ0Dn9KSUzjWa
CQmauGtyHfsGmXk6LzNsl1xPPmy+f9PsNna2h+Aavlmq5gQlFGNWev7z4HVNTuX+
FZ+Lp02mbd10VemR9pgwnhCPzdgcosS/pfNncPxkhltUyg/Y54j3VNPuacaPqaYf
vXqbi/SPer/V4hj8/S0MKZhwucw4brgK/oeeCNjzK57SHSE+ExaLwWUuTeDchEQx
9X7WKePC6bopbg==
=gq4d
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.