Debian Bug report logs - #971420
jhbuild: please make the build reproducible

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>

To: submit@bugs.debian.org

Subject: jhbuild: please make the build reproducible

Date: Wed, 30 Sep 2020 10:56:04 +0100

[Message part 1 (text/plain, inline)]

Source: jhbuild
Version: 3.38.0-1
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0] we noticed that
jhbuild could not be built reproducibly.

This is because the /usr/bin/jhbuild binary embedded the absolute
build to get it's "source" directory. A patch is attached that imports
the jhbuild module and determines this location programmatically
instead.

 [0] https://reproducible-builds.org/


Regards,

--
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

[jhbuild.diff.txt (text/plain, attachment)]

Message #10 received at 971420@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>

To: 971420@bugs.debian.org, reproducible-bugs@lists.alioth.debian.org

Subject: Re: Bug#971420: jhbuild: please make the build reproducible

Date: Tue, 29 Dec 2020 10:38:34 +0000

Chris Lamb wrote:

> Source: jhbuild
> Version: 2.29.2-2
> Tags: patch

Gentle ping on the above?


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #15 received at 971420@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: Chris Lamb <lamby@debian.org>, 971420@bugs.debian.org

Subject: Re: Bug#971420: jhbuild: please make the build reproducible

Date: Thu, 08 Dec 2022 14:33:54 -0800

[Message part 1 (text/plain, inline)]

Control: tags 971420 pending

On 2020-09-30, Chris Lamb wrote:
> Whilst working on the Reproducible Builds effort [0] we noticed that
> jhbuild could not be built reproducibly.
>
> This is because the /usr/bin/jhbuild binary embedded the absolute
> build to get it's "source" directory. A patch is attached that imports
> the jhbuild module and determines this location programmatically
> instead.

Uploaded an NMU to DELAYED/10 fixing this issue:

diff -Nru jhbuild-3.38.0/debian/changelog jhbuild-3.38.0/debian/changelog
--- jhbuild-3.38.0/debian/changelog	2020-10-11 14:41:31.000000000 -0700
+++ jhbuild-3.38.0/debian/changelog	2022-12-08 14:22:05.000000000 -0800
@@ -1,3 +1,12 @@
+jhbuild (3.38.0-3.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+
+  [ Chris Lamb ]
+  * Make the build reproducible (Closes: #971420)
+
+ -- Vagrant Cascadian <vagrant@reproducible-builds.org>  Thu, 08 Dec 2022 14:22:05 -0800
+
 jhbuild (3.38.0-3) unstable; urgency=medium
 
   * Fix typo in python3-distutils dependency.
diff -Nru jhbuild-3.38.0/debian/patches/make-the-build-reproducible-closes-97142.patch jhbuild-3.38.0/debian/patches/make-the-build-reproducible-closes-97142.patch
--- jhbuild-3.38.0/debian/patches/make-the-build-reproducible-closes-97142.patch	1969-12-31 16:00:00.000000000 -0800
+++ jhbuild-3.38.0/debian/patches/make-the-build-reproducible-closes-97142.patch	2022-12-08 14:22:05.000000000 -0800
@@ -0,0 +1,28 @@
+From: Chris Lamb <lamby@debian.org>
+Date: Wed, 30 Sep 2020 10:56:04 +0100
+X-Dgit-Generated: 3.38.0-3.1 420fe3c97b471d30e2ae455f67a1feae60f67b63
+Subject: Make the build reproducible (Closes: #971420)
+
+
+---
+
+diff --git a/scripts/jhbuild.in b/scripts/jhbuild.in
+index a24406f..ae1683f 100644
+--- a/scripts/jhbuild.in
++++ b/scripts/jhbuild.in
+@@ -20,13 +20,10 @@ if USE_CHECKOUT_SRC:
+ else:
+     pkgdatadir = "@pkgdatadir@"
+     datadir = "@datadir@"
+-    srcdir = "@srcdir@"
+     if '@pythondir@' not in sys.path:
+         sys.path.insert(0, '@pythondir@')
+-    try:
+-        import jhbuild
+-    except ImportError:
+-        sys.path.insert(0, srcdir)
++    import jhbuild
++    srcdir = os.path.abspath(os.path.dirname(jhbuild.__file__))
+ 
+ builtins.__dict__['PKGDATADIR'] = pkgdatadir
+ builtins.__dict__['DATADIR'] = datadir
diff -Nru jhbuild-3.38.0/debian/patches/series jhbuild-3.38.0/debian/patches/series
--- jhbuild-3.38.0/debian/patches/series	1969-12-31 16:00:00.000000000 -0800
+++ jhbuild-3.38.0/debian/patches/series	2022-12-08 14:22:05.000000000 -0800
@@ -0,0 +1 @@
+make-the-build-reproducible-closes-97142.patch


live well,
  vagrant

[signature.asc (application/pgp-signature, inline)]

Message #22 received at 971420@bugs.debian.org (full text, mbox, reply):

From: Jeremy Bicha <jeremy.bicha@canonical.com>

To: Vagrant Cascadian <vagrant@reproducible-builds.org>, 971420@bugs.debian.org

Subject: Re: Bug#971420: jhbuild: please make the build reproducible

Date: Thu, 8 Dec 2022 17:48:57 -0500

On Thu, Dec 8, 2022 at 5:36 PM Vagrant Cascadian
<vagrant@reproducible-builds.org> wrote:
> Control: tags 971420 pending
>
> On 2020-09-30, Chris Lamb wrote:
> > Whilst working on the Reproducible Builds effort [0] we noticed that
> > jhbuild could not be built reproducibly.
> >
> > This is because the /usr/bin/jhbuild binary embedded the absolute
> > build to get it's "source" directory. A patch is attached that imports
> > the jhbuild module and determines this location programmatically
> > instead.
>
> Uploaded an NMU to DELAYED/10 fixing this issue:

Feel free to upload now without delay.

Thank you,
Jeremy Bicha

Message #27 received at 971420@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: Jeremy Bicha <jeremy.bicha@canonical.com>, 971420@bugs.debian.org

Subject: Re: Bug#971420: jhbuild: please make the build reproducible

Date: Thu, 08 Dec 2022 17:22:53 -0800

[Message part 1 (text/plain, inline)]

On 2022-12-08, Jeremy Bicha wrote:
> On Thu, Dec 8, 2022 at 5:36 PM Vagrant Cascadian
> <vagrant@reproducible-builds.org> wrote:
>> On 2020-09-30, Chris Lamb wrote:
>> > Whilst working on the Reproducible Builds effort [0] we noticed that
>> > jhbuild could not be built reproducibly.
>> >
>> > This is because the /usr/bin/jhbuild binary embedded the absolute
>> > build to get it's "source" directory. A patch is attached that imports
>> > the jhbuild module and determines this location programmatically
>> > instead.
>>
>> Uploaded an NMU to DELAYED/10 fixing this issue:
>
> Feel free to upload now without delay.

Thanks, done!

live well,
  vagrant

[signature.asc (application/pgp-signature, inline)]

Message #30 received at 971420-submitter@bugs.debian.org (full text, mbox, reply):

From: Jeremy Bicha <noreply@salsa.debian.org>

To: 971420-submitter@bugs.debian.org

Subject: Bug#971420 marked as pending in jhbuild

Date: Fri, 09 Dec 2022 02:03:26 +0000

Control: tag -1 pending

Hello,

Bug #971420 in jhbuild reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/gnome-team/jhbuild/-/commit/4ae2bd57974d02bd340fc0c73c22bc07c9bf32d4

------------------------------------------------------------------------
Make the build reproducible

Closes: #971420
------------------------------------------------------------------------

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/971420

Message #35 received at 971420-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 971420-close@bugs.debian.org

Subject: Bug#971420: fixed in jhbuild 3.38.0-3.1

Date: Fri, 09 Dec 2022 18:34:22 +0000

Source: jhbuild
Source-Version: 3.38.0-3.1
Done: Vagrant Cascadian <vagrant@reproducible-builds.org>

We believe that the bug you reported is fixed in the latest version of
jhbuild, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 971420@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Vagrant Cascadian <vagrant@reproducible-builds.org> (supplier of updated jhbuild package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Thu, 08 Dec 2022 14:22:05 -0800
Source: jhbuild
Architecture: source
Version: 3.38.0-3.1
Distribution: unstable
Urgency: medium
Maintainer: Debian GNOME Maintainers <pkg-gnome-maintainers@lists.alioth.debian.org>
Changed-By: Vagrant Cascadian <vagrant@reproducible-builds.org>
Closes: 971420
Changes:
 jhbuild (3.38.0-3.1) unstable; urgency=medium
 .
   * Non-maintainer upload.
 .
   [ Chris Lamb ]
   * Make the build reproducible (Closes: #971420)
Checksums-Sha1:
 cf9eb3f4507265ffe85021ce40cca88a9556c128 1640 jhbuild_3.38.0-3.1.dsc
 4a74b66cbae81f8e23a405d3bf1ec3d4b178bc8d 6452 jhbuild_3.38.0-3.1.debian.tar.xz
Checksums-Sha256:
 b08dd36eb8fab94f77012fd95c649432014c83728e7d325c603fce1fe4fda141 1640 jhbuild_3.38.0-3.1.dsc
 8aa078252b76376a4ea5cf55d84af661e0a905f4514c433975ba1c182c412afa 6452 jhbuild_3.38.0-3.1.debian.tar.xz
Files:
 672314a2c6644b6209252d116ce1b13a 1640 devel optional jhbuild_3.38.0-3.1.dsc
 0bb0e55652e1e8c350771860729a6ab9 6452 devel optional jhbuild_3.38.0-3.1.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iJYEARYKAD4WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCY5JlrCAcdmFncmFudEBy
ZXByb2R1Y2libGUtYnVpbGRzLm9yZwAKCRDcUY/If5cWql4fAQCQyTdDGXSOFlbU
rXeJkltdE9kCGomgekKekY05Th4x6gD/XxpXobmetF5j+EGUV6JuSiJDrYjfQWka
ohC1y/g/kg4=
=b0dI
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.