Debian Bug report logs - #971408
simde: FTBFS when dpkg-buildflags passes -ffile-prefix-map

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: simde: FTBFS when dpkg-buildflags passes -ffile-prefix-map

Date: Tue, 29 Sep 2020 18:26:40 -0700

[Message part 1 (text/plain, inline)]

Package: simde
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: fixfilepath ftbfs
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

When run with DEB_BUILD_OPTIONS=reproducible=+fixfilepath, simde FTBFS:

  clang: error: unknown argument: '-ffile-prefix-map=/<<PKGBUILDDIR>>=.'

This is because clang 10 is the first version to support
-ffile-prefix-map, and simde is building with the default clang version
9.

The attached patch updates to clang-10 to fix this issue.

Alternately, you could stick with the default gcc, setting in
debian/rules:

  # Remove when switching to clang 10 or newer.
  export DEB_BUILD_MAINT_OPTIONS=reproducible=-fixfilepath+fixdebugpath


The "fixfilepath" feature is not yet enabled by default in
dpkg-buildflags, but it is used in the tests.reproducible-builds.org
infrastructure for unstable and experimental, and might be enabled by
default for dpkg-buildflags in the future.


Thanks for maintaining simde!


live well,
  vagrant

[0001-Update-to-clang-10-to-add-support-for-ffile-prefix-m.patch (text/x-diff, inline)]

From ee5ce7156a2918a44cd37268ccc149873b481a49 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Wed, 30 Sep 2020 00:55:25 +0000
Subject: [PATCH] Update to clang-10 to add support for -ffile-prefix-map.

Setting the DEB_BUILD_OPTIONS=reproducible=+fixfilepath adds
-ffile-prefix-map from dpkg-buildflags to default compiler
arguments. This feature is not currently enabled by default in
dpkg-buildflags, but is enabled for parts of the
tests.reproducible-builds.org infrastructure to solve some
reproducibility issues.
---
 debian/control | 2 +-
 debian/rules   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/debian/control b/debian/control
index 2588a77..312644a 100644
--- a/debian/control
+++ b/debian/control
@@ -5,7 +5,7 @@ Maintainer: Debian Med Packaging Team <debian-med-packaging@lists.alioth.debian.
 Uploaders: Michael R. Crusoe <crusoe@debian.org>
 Build-Depends: debhelper-compat (= 13),
                cmake,
-               clang [!alpha !hppa !ia64 !m68k !sh4 !x32] <!nocheck>
+               clang-10 [!alpha !hppa !ia64 !m68k !sh4 !x32] <!nocheck>
 Standards-Version: 4.5.0
 Vcs-Browser: https://salsa.debian.org/med-team/simde
 Vcs-Git: https://salsa.debian.org/med-team/simde.git
diff --git a/debian/rules b/debian/rules
index abd2908..9b525bc 100755
--- a/debian/rules
+++ b/debian/rules
@@ -19,7 +19,7 @@ endif
 override_dh_auto_configure:
 ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))
   ifeq (,$(filter $(DEB_HOST_ARCH),$(CLANG_SKIP)))
-	CC=clang CXX=clang++ dh_auto_configure --builddirectory=clang_test --sourcedirectory=test
+	CC=clang-10 CXX=clang++-10 dh_auto_configure --builddirectory=clang_test --sourcedirectory=test
   endif
 # According to https://wiki.debian.org/ArchitectureSpecificsMemo#Architecture_baselines
 # It is odd that gcc doesn't include this automatically, but clang does
-- 
2.28.0

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 971408@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: 971408@bugs.debian.org

Subject: Re: simde: FTBFS when dpkg-buildflags passes -ffile-prefix-map

Date: Sat, 03 Oct 2020 09:38:03 -0700

[Message part 1 (text/plain, inline)]

On 2020-09-29, Vagrant Cascadian wrote:
> When run with DEB_BUILD_OPTIONS=reproducible=+fixfilepath, simde FTBFS:
>
>   clang: error: unknown argument: '-ffile-prefix-map=/<<PKGBUILDDIR>>=.'
>
> This is because clang 10 is the first version to support
> -ffile-prefix-map, and simde is building with the default clang version
> 9.
>
> The attached patch updates to clang-10 to fix this issue.

Though clang 11 might become the default for bullseye, in which case
this would be a needless change; I haven't tested if simde builds fine
with clang 11.


> Alternately, you could stick with the default gcc, setting in
                                                ^ clang :)
> debian/rules:
>
>   # Remove when switching to clang 10 or newer.
>   export DEB_BUILD_MAINT_OPTIONS=reproducible=-fixfilepath+fixdebugpath

Oops, that should have been:

   # Remove when switching to clang 10 or newer.
   export DEB_BUILD_MAINT_OPTIONS=reproducible=-fixfilepath,+fixdebugpath

Though from a reproducible builds perspective, building with a version
of clang that supports -ffile-prefix-map is still preferable to
disabling the feature.


live well,
  vagrant

[signature.asc (application/pgp-signature, inline)]

Message #15 received at 971408@bugs.debian.org (full text, mbox, reply):

From: "Michael R. Crusoe" <crusoe@debian.org>

To: 971408@bugs.debian.org

Subject: Re: simde: FTBFS when dpkg-buildflags passes -ffile-prefix-map

Date: Sat, 21 Nov 2020 15:34:06 +0100

[Message part 1 (text/plain, inline)]

On Sat, 03 Oct 2020 09:38:03 -0700 Vagrant Cascadian
<vagrant@reproducible-builds.org> wrote:
> On 2020-09-29, Vagrant Cascadian wrote:
> > When run with DEB_BUILD_OPTIONS=reproducible=+fixfilepath, simde FTBFS:
> >
> > clang: error: unknown argument: '-ffile-prefix-map=/<<PKGBUILDDIR>>=.'
> >
> > This is because clang 10 is the first version to support
> > -ffile-prefix-map, and simde is building with the default clang version
> > 9.
> >
> > The attached patch updates to clang-10 to fix this issue.
>
> Though clang 11 might become the default for bullseye, in which case
> this would be a needless change; I haven't tested if simde builds fine
> with clang 11.

Thank you Vagrant for reporting this issue and your patch.

SIMDe is a header-only library, the compilation is just to test the
library against the default GCC & clang versions in Debian. I would
prefer to keep testing the default versions, to get ahead of any bugs
that might appear.

I guess testing for all versions of clang and gcc in Debian could be
done as part of the package building and autopkgtest.

So I'm leaning towards adding the other fix of disabling setting
DEB_BUILD_MAINT_OPTIONS=reproducible=-fixfilepath+fixdebugpath

What do you think?

-- 
Michael R. Crusoe

[signature.asc (application/pgp-signature, attachment)]

Message #20 received at 971408-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 971408-close@bugs.debian.org

Subject: Bug#971408: fixed in whitakers-words 0.2020.10.27-1

Date: Sat, 21 Nov 2020 22:00:20 +0000

Source: whitakers-words
Source-Version: 0.2020.10.27-1
Done: Calum McConnell <calumlikesapplepie@gmail.com>

We believe that the bug you reported is fixed in the latest version of
whitakers-words, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 971408@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Calum McConnell <calumlikesapplepie@gmail.com> (supplier of updated whitakers-words package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Mon, 02 Nov 2020 18:54:34 -0500
Binary: whitakers-words whitakers-words-data whitakers-words-dbgsym
Source: whitakers-words
Architecture: all amd64 source
Version: 0.2020.10.27-1
Distribution: unstable
Urgency: low
Maintainer: Calum McConnell <calumlikesapplepie@gmail.com>
Changed-By: Calum McConnell <calumlikesapplepie@gmail.com>
Closes: 971408
Description: 
 whitakers-words-data - Latin word parser and translation aid - data
 whitakers-words - Latin word parser and translation aid
Changes:
 whitakers-words (0.2020.10.27-1) unstable; urgency=low
 .
   * Initial release. Closes: 971408
   * This Debian version is based on upstream commit 4571565
Checksums-Sha1: 
 2071a135890db0055aebc653048b137a34dcf413 2162 whitakers-words_0.2020.10.27-1.dsc
 d58cf0bf8657ebea592c338873a0114dcdb1a572 1749173 whitakers-words_0.2020.10.27.orig.tar.gz
 50ece7e13a21bf131b615533c8fc2aefac4ee25e 9092 whitakers-words_0.2020.10.27-1.debian.tar.xz
 ef7dec61dd3aa88a70c9019a240cfce4a154673b 1183540 whitakers-words-data_0.2020.10.27-1_all.deb
 0f4d17c72f7be0cf44acac1a3492e41de6ef5cac 563196 whitakers-words-dbgsym_0.2020.10.27-1_amd64.deb
 897abfd473758ca3a0313f679cfd56744fd20400 7153 whitakers-words_0.2020.10.27-1_amd64.buildinfo
 bc5eb00e69955f67d4cc310d11e87c634e7259b5 284892 whitakers-words_0.2020.10.27-1_amd64.deb
Checksums-Sha256: 
 69343abde988637599800adb46709fb916bc87d03624b90013974d2d53c554ea 2162 whitakers-words_0.2020.10.27-1.dsc
 6014f061c47d86d387615ce36265f1a3dfa52d1306ba0a3bb29f72ce0c7ab957 1749173 whitakers-words_0.2020.10.27.orig.tar.gz
 74f3a3a323efb14de7eeff23341a560ffe4dec03fc705f37d8b70258e2695eb0 9092 whitakers-words_0.2020.10.27-1.debian.tar.xz
 c9f87adebc5ebdd1fa3a3706d55185e1894d54b7e64084b51fde3b233d2674ae 1183540 whitakers-words-data_0.2020.10.27-1_all.deb
 ed5a0e49c1b46defe7260464190e42999e48f5ce4b91b09d4be905d2f01c4b4c 563196 whitakers-words-dbgsym_0.2020.10.27-1_amd64.deb
 6b910900d56886f20a237299eb30b531842a88519234870218c053e9f14b62f3 7153 whitakers-words_0.2020.10.27-1_amd64.buildinfo
 9ff881f1bae7b47a504c32f49b52511aabc976c11097d2e0eb49655a1dd7ddb0 284892 whitakers-words_0.2020.10.27-1_amd64.deb
Files: 
 4196c16ec65a09a00f428eb2de868693 2162 education optional whitakers-words_0.2020.10.27-1.dsc
 55001b28c3b56940824429f2ee5115ac 1749173 education optional whitakers-words_0.2020.10.27.orig.tar.gz
 91ef6e04e899c6cebe191da890071e2a 9092 education optional whitakers-words_0.2020.10.27-1.debian.tar.xz
 30e95043f283eb2825075e6f24b12094 1183540 education optional whitakers-words-data_0.2020.10.27-1_all.deb
 7f56fd96fedb40d01d41842d05c4f566 563196 debug optional whitakers-words-dbgsym_0.2020.10.27-1_amd64.deb
 6839fb9083f7d1ada480832df314729e 7153 education optional whitakers-words_0.2020.10.27-1_amd64.buildinfo
 f4c0b3c74a29ffac39cd57d7dbbc9d85 284892 education optional whitakers-words_0.2020.10.27-1_amd64.deb

-----BEGIN PGP SIGNATURE-----

iQJHBAEBCAAxFiEEYtlNMqmXIhEvWffytSqc9EkN/I0FAl+0DsYTHG5pY29sYXNA
ZGViaWFuLm9yZwAKCRC1Kpz0SQ38jRSaEACDXatbBAnu4zzFxTt73oadBoEI9fya
v3dZuewUZi35TwfH0DOJUoaTlw1E3V4tgemmd72AfRosf+QqmTlleaghif4Ckxu+
LkYSAofia2BMA8M+u/do6WFy+4TmdWIT0ejT42nF3Sm7fnAe29BG8Ud4MTZ8RZMs
0HAjvHemNWe2cxROCB2iggxV4ihlBOzcuI0Iv1wiI/uip1ltahDXSQCtwvTqpsKQ
oypNf9MnavrJPlDPiLG7VVV8NGIqrclp39Nm4SeeSbM0s24AeDRAyOWaB7O2zkip
oZAWoQCaPrCKAmRfjxiryTEFSK/0ZozzMY/e4VYGHqTVOd5wpAevBkzx4z1Kd1J2
7vIQ0zjp60u4/g5GeTujJwG9zUR8Gaq0MqoV4xu/AgNyy0OZOGU0M+tI1sXuRbB0
6T9qFepLOVdRll2ecdFjgRYZtv/SY0hdyNEntWOkFeHc/pHkqbSQ/7xrQSa6p2M5
OXg8F9MXsL+Mp6lv5U65MJ4W8BJJa89asjsLJwMIFTKyd/wbaOMTVG0mfwM92GsQ
mkNIbHUNOvWf680+lxYe7GvVwJvZWkckcMLTtYHOZMSUBlqPkiJzcceXmoyoGrPD
wUgv4CxPMZZ+zk9xVjBLDC9BNEaZujbaee08V74uXdAQ6dW7yKVopbEr4/oUWxNl
dtWBNVKyU/BnMg==
=uCG0
-----END PGP SIGNATURE-----

Message #25 received at 971408@bugs.debian.org (full text, mbox, reply):

From: Calum McConnell <calumlikesapplepie@gmail.com>

To: 971408@bugs.debian.org

Subject: Whoops

Date: Sat, 21 Nov 2020 18:17:36 -0500

[Message part 1 (text/plain, inline)]

Control: reopen -1

I accidentally wrote this bug number, 971408, as the ITP bug that my new
package was closing, number 971407.  As a result, the above message was
sent, and this bug was closed.

I'm sorry for the mistake,
Calum

[signature.asc (application/pgp-signature, inline)]

Message #34 received at 971408@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: "Michael R. Crusoe" <crusoe@debian.org>, 971408@bugs.debian.org

Subject: Re: simde: FTBFS when dpkg-buildflags passes -ffile-prefix-map

Date: Sat, 21 Nov 2020 18:22:34 -0800

[Message part 1 (text/plain, inline)]

On 2020-11-21, Michael R. Crusoe wrote:
> On Sat, 03 Oct 2020 09:38:03 -0700 Vagrant Cascadian
> <vagrant@reproducible-builds.org> wrote:
>> On 2020-09-29, Vagrant Cascadian wrote:
>> > When run with DEB_BUILD_OPTIONS=reproducible=+fixfilepath, simde FTBFS:
>> >
>> > clang: error: unknown argument: '-ffile-prefix-map=/<<PKGBUILDDIR>>=.'
>> >
>> > This is because clang 10 is the first version to support
>> > -ffile-prefix-map, and simde is building with the default clang version
>> > 9.
>> >
>> > The attached patch updates to clang-10 to fix this issue.
>>
>> Though clang 11 might become the default for bullseye, in which case
>> this would be a needless change; I haven't tested if simde builds fine
>> with clang 11.
>
> Thank you Vagrant for reporting this issue and your patch.

Thanks for the reply!


> SIMDe is a header-only library, the compilation is just to test the
> library against the default GCC & clang versions in Debian. I would
> prefer to keep testing the default versions, to get ahead of any bugs
> that might appear.

Yes, that makes perfect sense.

Another option might be to check the version of clang and strip the
unsupported -ffile-prefix-map=BUILDPATH=. argument if present when
running a version of clang that does not support -ffile-prefix-map
(e.g. 9 or less). Then it would "just work" whenever the updated clang
version lands, while keep working with older clang versions until
then. No idea how complicated that might be to actually implement, but
would solve all the corner cases nicely. :)


> I guess testing for all versions of clang and gcc in Debian could be
> done as part of the package building and autopkgtest.

Sure.


> So I'm leaning towards adding the other fix of disabling setting
> DEB_BUILD_MAINT_OPTIONS=reproducible=-fixfilepath+fixdebugpath
>
> What do you think?

If you do go that route, I would suggest a minor update to my patch:

  DEB_BUILD_MAINT_OPTIONS=reproducible=-fixfilepath

The dpkg patch I proposed should avoid disabling fixdebugpath without
having to specifically re-enable it. Based on the conversation on:

  https://bugs.debian.org/974087

It looks like fixfilepath may get enabled by default in dpkg "soon".


Thanks for taking a look at all the options!


FWIW, note that I only managed to see this reply because of the
accidental closing of this bug; normally you need to CC
NNN-submitter@bugs.debian.org or CC the submitter's email address
directly in order for them to see the reply. Luckily I saw it all the
same. :)


live well,
  vagrant

[signature.asc (application/pgp-signature, inline)]

Message #41 received at 971408-done@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: "Michael R. Crusoe" <crusoe@debian.org>, 971408-done@bugs.debian.org

Subject: Re: simde: FTBFS when dpkg-buildflags passes -ffile-prefix-map

Date: Thu, 24 Dec 2020 00:19:37 -0800

[Message part 1 (text/plain, inline)]

On 2020-11-21, Michael R. Crusoe wrote:
> On Sat, 03 Oct 2020 09:38:03 -0700 Vagrant Cascadian
> <vagrant@reproducible-builds.org> wrote:
>> On 2020-09-29, Vagrant Cascadian wrote:
>> > When run with DEB_BUILD_OPTIONS=reproducible=+fixfilepath, simde FTBFS:
>> >
>> > clang: error: unknown argument: '-ffile-prefix-map=/<<PKGBUILDDIR>>=.'
>> >
>> > This is because clang 10 is the first version to support
>> > -ffile-prefix-map, and simde is building with the default clang version
>> > 9.
>> >
>> > The attached patch updates to clang-10 to fix this issue.
>>
>> Though clang 11 might become the default for bullseye, in which case
>> this would be a needless change; I haven't tested if simde builds fine
>> with clang 11.
>
> Thank you Vagrant for reporting this issue and your patch.
>
> SIMDe is a header-only library, the compilation is just to test the
> library against the default GCC & clang versions in Debian. I would
> prefer to keep testing the default versions, to get ahead of any bugs
> that might appear.

With the update of llvm-defaults to use clang version 11, simde appears
to build fine on the reproducible builds infrastructure, even when
setting "DEB_BUILD_OPTIONS=reproducible=+fixfilepath" so I do not expect
any changes are needed for simde directly. Marking as done!


live well,
  vagrant

[signature.asc (application/pgp-signature, inline)]

Send a report that this bug log contains spam.