Debian Bug report logs - #971402
vboot-utils: FTBFS when fixfilepath is enabled from dpkg-buildflags

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: vboot-utils: FTBFS when fixfilepath is enabled from dpkg-buildflags

Date: Tue, 29 Sep 2020 15:18:01 -0700

[Message part 1 (text/plain, inline)]

Source: vboot-utils
Severity: normal
Version: 0~R81-12871.B-1
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: fixfilepath ftbfs
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

When the dpkg-buildflags "fixfilepath" is enabled, vboot-utils FTBFS, as
clang does not support the -ffile-prefix-map argument:

  clang: clang: error: error: unknown argument: '-ffile-prefix-map=/<<PKGBUILDDIR>>=.'unknown argument: '-ffile-prefix-map=/<<PKGBUILDDIR\>>=.'


This can be tested by passing the following DEB_BUILD_OPTIONS:

  DEB_BUILD_OPTIONS=reproducible=+fixfilepath

The "fixfilepath" is not currently enabled by dpkg-buildflags by
default, but might become the default at some point in the future.

The attached patch disables use of this feature in debian/rules and
enables the remaining reproducibility related build flags.


Thanks for maintaining vboot-utils!

live well,
  vagrant

[0002-debian-rules-Disable-use-of-fixfilepath-with-DEB_BUI.patch (text/x-diff, inline)]

From ec585212c265af22d69249459dcd05dbbc17b78f Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Tue, 29 Sep 2020 21:40:28 +0000
Subject: [PATCH 2/2] debian/rules: Disable use of fixfilepath with
 DEB_BUILD_MAINT_OPTIONS.

clang does not currently support it, and the build fails with:

  clang: clang: error: error: unknown argument: '-ffile-prefix-map=/<<PKGBUILDDIR>>=.'unknown argument: '-ffile-prefix-map=/<<PKGBUILDDIR\>>=.'

Enable other reproducible related build flags (fixdebugpath,
timeless), as these still work and are the current defaults for
dpkg-buildflags.
---
 debian/rules | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/rules b/debian/rules
index 90bf280..a2c916e 100755
--- a/debian/rules
+++ b/debian/rules
@@ -1,6 +1,6 @@
 #!/usr/bin/make -f
 
-export DEB_BUILD_MAINT_OPTIONS = hardening=+all
+export DEB_BUILD_MAINT_OPTIONS = hardening=+all reproducible=-fixfilepath,+fixdebugpath,+timeless
 export CC = clang-9
 
 override_dh_auto_build:
-- 
2.28.0

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 971402@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: 971402@bugs.debian.org

Subject: Re: vboot-utils: FTBFS when fixfilepath is enabled from dpkg-buildflags

Date: Tue, 29 Sep 2020 17:46:23 -0700

[Message part 1 (text/plain, inline)]

On 2020-09-29, Vagrant Cascadian wrote:
> When the dpkg-buildflags "fixfilepath" is enabled, vboot-utils FTBFS, as
> clang does not support the -ffile-prefix-map argument:
>
>   clang: clang: error: error: unknown argument: '-ffile-prefix-map=/<<PKGBUILDDIR>>=.'unknown argument: '-ffile-prefix-map=/<<PKGBUILDDIR\>>=.'

This is actually supported in clang-10, and appears to build fine with
clang-10.

New patch attached which switches to clang-10.

live well,
  vagrant

[0006-Switch-to-clang-10-to-support-ffile-prefix-map-Close.patch (text/x-diff, inline)]

From f39dec30b7ac4c5356473a0ac0489b85974db22c Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Wed, 30 Sep 2020 00:26:00 +0000
Subject: [PATCH 6/6] Switch to clang-10 to support -ffile-prefix-map (Closes:
 #971402).

---
 debian/control | 4 ++--
 debian/rules   | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/debian/control b/debian/control
index ed101bf..3605c05 100644
--- a/debian/control
+++ b/debian/control
@@ -4,8 +4,8 @@ Priority: optional
 Maintainer: Sophie Brun <sophie@offensive-security.com>
 Uploaders: Raphaël Hertzog <hertzog@debian.org>
 Build-Depends: debhelper-compat (= 12),
-               clang-9,
-               libfuzzer-9-dev,
+               clang-10,
+               libfuzzer-10-dev,
                liblzma-dev,
                libssl-dev,
                libyaml-dev,
diff --git a/debian/rules b/debian/rules
index 90bf280..277142b 100755
--- a/debian/rules
+++ b/debian/rules
@@ -1,7 +1,7 @@
 #!/usr/bin/make -f
 
 export DEB_BUILD_MAINT_OPTIONS = hardening=+all
-export CC = clang-9
+export CC = clang-10
 
 override_dh_auto_build:
 	dh_auto_build -- V=1
-- 
2.20.1

[signature.asc (application/pgp-signature, inline)]

Message #15 received at 971402@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: 971402@bugs.debian.org

Subject: Re: vboot-utils: FTBFS when fixfilepath is enabled from dpkg-buildflags

Date: Sat, 03 Oct 2020 09:40:51 -0700

[Message part 1 (text/plain, inline)]

On 2020-09-29, Vagrant Cascadian wrote:
> On 2020-09-29, Vagrant Cascadian wrote:
>> When the dpkg-buildflags "fixfilepath" is enabled, vboot-utils FTBFS, as
>> clang does not support the -ffile-prefix-map argument:
>>
>>   clang: clang: error: error: unknown argument: '-ffile-prefix-map=/<<PKGBUILDDIR>>=.'unknown argument: '-ffile-prefix-map=/<<PKGBUILDDIR\>>=.'
>
> This is actually supported in clang-10, and appears to build fine with
> clang-10.
>
> New patch attached which switches to clang-10.

And it has come to my attention that the default clang will likely end
up being clang 11 for bullseye, so maybe testing with clang-11 instead,
or waiting till the clang default is upgraded in bullseye.


live well,
  vagrant

[signature.asc (application/pgp-signature, inline)]

Message #18 received at 971402-submitter@bugs.debian.org (full text, mbox, reply):

From: Sophie Brun <noreply@salsa.debian.org>

To: 971402-submitter@bugs.debian.org

Subject: Bug#971402 marked as pending in vboot-utils

Date: Tue, 27 Oct 2020 20:11:59 +0000

Control: tag -1 pending

Hello,

Bug #971402 in vboot-utils reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/debian/vboot-utils/-/commit/9d95c66f40ac7298a757ca7090dfab8ce6541b17

------------------------------------------------------------------------
Switch to clang 10 and disable fixfilepath Flag (Closes: #971402)
------------------------------------------------------------------------

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/971402

Message #25 received at 971402-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 971402-close@bugs.debian.org

Subject: Bug#971402: fixed in vboot-utils 0~R87-13505.B-1

Date: Wed, 28 Oct 2020 11:36:20 +0000

Source: vboot-utils
Source-Version: 0~R87-13505.B-1
Done: Sophie Brun <sophie@offensive-security.com>

We believe that the bug you reported is fixed in the latest version of
vboot-utils, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 971402@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Sophie Brun <sophie@offensive-security.com> (supplier of updated vboot-utils package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Tue, 27 Oct 2020 21:01:46 +0100
Source: vboot-utils
Architecture: source
Version: 0~R87-13505.B-1
Distribution: unstable
Urgency: medium
Maintainer: Sophie Brun <sophie@offensive-security.com>
Changed-By: Sophie Brun <sophie@offensive-security.com>
Closes: 971400 971402
Changes:
 vboot-utils (0~R87-13505.B-1) unstable; urgency=medium
 .
   * New upstream version 0~R87-13505.B
   * Refresh patches
   * Add a patch to not embed user and time in version (Closes: #971400)
   * Switch to clang 10 (Closes: #971402)
   * Remove override_dh_fixperms no longer needed
   * Update installation for new upstream release
Checksums-Sha1:
 7c24fa0edcd2b94b0b1b9a307b1672b8d1a894f7 2025 vboot-utils_0~R87-13505.B-1.dsc
 d77012f338904707b9f0296fa9ff15798ba2786c 35833679 vboot-utils_0~R87-13505.B.orig.tar.gz
 eb6d44dec354cf0572b6ea45dfbbcfc56b42eb58 10764 vboot-utils_0~R87-13505.B-1.debian.tar.xz
 4c5d0257e53e077d7ca8dd6607048cf92ddefe52 6400 vboot-utils_0~R87-13505.B-1_source.buildinfo
Checksums-Sha256:
 b065fd4dd75e96f0acb1b4e781f42b709cdc6a50b32432d1f995da8fd0fe3a94 2025 vboot-utils_0~R87-13505.B-1.dsc
 6793298300e784d3ad356ed22641d9fff0ee769f13557c5b119a740410f5dc90 35833679 vboot-utils_0~R87-13505.B.orig.tar.gz
 38829936ab85148fbf5bb47607392b275e052343f7e6f27c5816e2e582713d2d 10764 vboot-utils_0~R87-13505.B-1.debian.tar.xz
 697d81650994976a33e436c3b81859dfdc0c607d56b1095ca2a31fcf85396b65 6400 vboot-utils_0~R87-13505.B-1_source.buildinfo
Files:
 1d711750683f1edfd9158d9eb3948d4d 2025 admin optional vboot-utils_0~R87-13505.B-1.dsc
 6a83c8dc5d9ce038e491f5a85f646ce7 35833679 admin optional vboot-utils_0~R87-13505.B.orig.tar.gz
 529d7eb0bcabe839309cc7566df8b190 10764 admin optional vboot-utils_0~R87-13505.B-1.debian.tar.xz
 6628c33afdd88ca81b4f136dd7d641c6 6400 admin optional vboot-utils_0~R87-13505.B-1_source.buildinfo

-----BEGIN PGP SIGNATURE-----
Comment: Signed by Raphael Hertzog

iQEzBAEBCgAdFiEE1823g1EQnhJ1LsbSA4gdq+vCmrkFAl+ZUbgACgkQA4gdq+vC
mrkbMwf+Pk9AU2/+4tb10rwu2RLoBC0zkevPEvrmXr/ASFUMtnhPsT1COKx47kiG
e/OH8i/HGxH6OO7Up0OXIhDt8TcSAepE7b/xjX3YtZ8Bb3FvuEW1MwWhsJ8qINs3
0VlETGlAnIYwXhKuBAEGCtyIQ+Iqo1b5LWXuliRvdA8g35FJwZrY9YhpgsFxiKt5
1g1+Guvz7HhBq9XTNQvaPNx1wn8geI7o6qqyI0RAG0QJ+9fSLYhEn4kttCGVrkvm
0G8SV3Bb1YAt7IrHP1WMYIzcgf5bkGlB0xUshhTCtUpifEgT8Ue2YDHNGlplrIU8
zC5xbAULK3knvG7uqr3rrGeGjDkAdg==
=WfuE
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.