Debian Bug report logs - #971282
ABI breakage: paths changed for sysusers.d/sysctl.d/binfmt/modules-load.d

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Michael Biebl <biebl@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: ABI breakage: paths changed for sysusers.d/sysctl.d/binfmt/modules-load.d

Date: Mon, 28 Sep 2020 21:00:51 +0200

[Message part 1 (text/plain, inline)]

Package: systemd
Version: 246.6-1
Severity: important

Upstream changed the paths in systemd.pc from prefix to rootprefix in
v246 for sysusers_dir, sysctl_dir, binfmt_dir and modules-load_dir:
https://github.com/systemd/systemd/commit/4a56315a990b802860170ecd1bbd3eb68e14a38b

This breaks packages which use pkg-config to determine those paths and
where .install files reference /usr/. An example is mandos.

I think we should revert this change. I don't see a compelling reason to
move those files from /usr to /lib given that we require /usr to be
pre-mounted by initramfs, if it's separate.
Moving files from /usr to /lib files kinda backwards nowadays.

I intend to apply a patch like the attached one in Debian.
That said, I hope I can convince Lennart to revert this change upstream
as well.

Thoughts, Comments?

Michael

[systemd-paths.diff (text/plain, attachment)]

Message #12 received at 971282@bugs.debian.org (full text, mbox, reply):

From: Felipe Sateler <fsateler@debian.org>

To: Michael Biebl <biebl@debian.org>, 971282@bugs.debian.org

Subject: Re: Bug#971282: ABI breakage: paths changed for sysusers.d/sysctl.d/binfmt/modules-load.d

Date: Mon, 28 Sep 2020 20:43:30 -0300

[Message part 1 (text/plain, inline)]

On Mon, Sep 28, 2020 at 4:03 PM Michael Biebl <biebl@debian.org> wrote:

> Package: systemd
> Version: 246.6-1
> Severity: important
>
> Upstream changed the paths in systemd.pc from prefix to rootprefix in
> v246 for sysusers_dir, sysctl_dir, binfmt_dir and modules-load_dir:
>
> https://github.com/systemd/systemd/commit/4a56315a990b802860170ecd1bbd3eb68e14a38b
>
> This breaks packages which use pkg-config to determine those paths and
> where .install files reference /usr/. An example is mandos.
>
> I think we should revert this change. I don't see a compelling reason to
> move those files from /usr to /lib given that we require /usr to be
> pre-mounted by initramfs, if it's separate.
> Moving files from /usr to /lib files kinda backwards nowadays.
>
> I intend to apply a patch like the attached one in Debian.
> That said, I hope I can convince Lennart to revert this change upstream
> as well.
>

Looks good to me.


>
> Thoughts, Comments?
>

I wonder if systemd can be fully installed into `/usr` now that we require
premounting. Maybe we should start changing lintian and other tools to
install into /usr instead of /lib for the tools that currently used
rootprefix (I believe systemd searches in /usr anyway).

This is likely to be a multi-release effort, but if we never start, we will
never end.

-- 

Saludos,
Felipe Sateler

[Message part 2 (text/html, inline)]

Message #17 received at 971282@bugs.debian.org (full text, mbox, reply):

From: Michael Biebl <biebl@debian.org>

To: 971282@bugs.debian.org, Felipe Sateler <fsateler@debian.org>

Subject: Re: Bug#971282: ABI breakage: paths changed for sysusers.d/sysctl.d/binfmt/modules-load.d

Date: Thu, 1 Oct 2020 21:09:22 +0200

[Message part 1 (text/plain, inline)]

On Mon, 28 Sep 2020 20:43:30 -0300 Felipe Sateler <fsateler@debian.org>
wrote:
> On Mon, Sep 28, 2020 at 4:03 PM Michael Biebl <biebl@debian.org> wrote:
> 
> > Package: systemd
> > Version: 246.6-1
> > Severity: important
> >
> > Upstream changed the paths in systemd.pc from prefix to rootprefix in
> > v246 for sysusers_dir, sysctl_dir, binfmt_dir and modules-load_dir:
> >
> > https://github.com/systemd/systemd/commit/4a56315a990b802860170ecd1bbd3eb68e14a38b
> >
> > This breaks packages which use pkg-config to determine those paths and
> > where .install files reference /usr/. An example is mandos.
> >
> > I think we should revert this change. I don't see a compelling reason to
> > move those files from /usr to /lib given that we require /usr to be
> > pre-mounted by initramfs, if it's separate.
> > Moving files from /usr to /lib files kinda backwards nowadays.
> >
> > I intend to apply a patch like the attached one in Debian.
> > That said, I hope I can convince Lennart to revert this change upstream
> > as well.
> >
> 
> Looks good to me.

Ok, thanks for the review. Will apply it to Debian then.
It doesn't look like upstream is interested in changing this back

https://github.com/systemd/systemd/commit/4a56315a990b802860170ecd1bbd3eb68e14a38b#commitcomment-42793750

> 
> >
> > Thoughts, Comments?
> >
> 
> I wonder if systemd can be fully installed into `/usr` now that we require
> premounting. Maybe we should start changing lintian and other tools to
> install into /usr instead of /lib for the tools that currently used
> rootprefix (I believe systemd searches in /usr anyway).

I gave this a try. It can.
See https://salsa.debian.org/systemd-team/systemd/-/merge_requests/104
Still very rough, but the package is usable and able to boot a system,
reading udev rules and systemd services from both /lib and /usr/lib.
We probably need quite a few more compat symlinks though.

This is only the systemd/udev side, though.
The i-s-h/debhelper side is still missing and we'd need to hash out a
plan for this. I'd need help with doing that.
Anyone interested?

Michael

[signature.asc (application/pgp-signature, attachment)]

Message #22 received at 971282@bugs.debian.org (full text, mbox, reply):

From: Michael Biebl <biebl@debian.org>

To: 971282@bugs.debian.org, Felipe Sateler <fsateler@debian.org>

Subject: Re: Bug#971282: ABI breakage: paths changed for sysusers.d/sysctl.d/binfmt/modules-load.d

Date: Thu, 1 Oct 2020 21:11:20 +0200

[Message part 1 (text/plain, inline)]

Am 01.10.20 um 21:09 schrieb Michael Biebl:

> https://github.com/systemd/systemd/commit/4a56315a990b802860170ecd1bbd3eb68e14a38b#commitcomment-42793750
> 
>>
>>>
>>> Thoughts, Comments?
>>>
>>
>> I wonder if systemd can be fully installed into `/usr` now that we require
>> premounting. Maybe we should start changing lintian and other tools to
>> install into /usr instead of /lib for the tools that currently used
>> rootprefix (I believe systemd searches in /usr anyway).
> 
> I gave this a try. It can.
> See https://salsa.debian.org/systemd-team/systemd/-/merge_requests/104
> Still very rough, but the package is usable and able to boot a system,
> reading udev rules and systemd services from both /lib and /usr/lib.
> We probably need quite a few more compat symlinks though.
> 
> This is only the systemd/udev side, though.
> The i-s-h/debhelper side is still missing and we'd need to hash out a
> plan for this. I'd need help with doing that.
> Anyone interested?


I'm a bit alarmed by "Hopefully we can drop the split soon." in the
github issue above. If upstream really plans to drop split-usr support,
we are up for a rough ride and we should plan for that now.

Michael

[signature.asc (application/pgp-signature, attachment)]

Message #27 received at 971282@bugs.debian.org (full text, mbox, reply):

From: Felipe Sateler <fsateler@debian.org>

To: Michael Biebl <biebl@debian.org>

Cc: 971282@bugs.debian.org

Subject: Re: Bug#971282: ABI breakage: paths changed for sysusers.d/sysctl.d/binfmt/modules-load.d

Date: Mon, 5 Oct 2020 12:25:37 -0300

[Message part 1 (text/plain, inline)]

On Thu, Oct 1, 2020 at 4:09 PM Michael Biebl <biebl@debian.org> wrote:

> On Mon, 28 Sep 2020 20:43:30 -0300 Felipe Sateler <fsateler@debian.org>
> wrote:
> > On Mon, Sep 28, 2020 at 4:03 PM Michael Biebl <biebl@debian.org> wrote:
> >
> > > Package: systemd
> > > Version: 246.6-1
> > > Severity: important
> > >
> > > Upstream changed the paths in systemd.pc from prefix to rootprefix in
> > > v246 for sysusers_dir, sysctl_dir, binfmt_dir and modules-load_dir:
> > >
> > >
> https://github.com/systemd/systemd/commit/4a56315a990b802860170ecd1bbd3eb68e14a38b
> > >
> > > This breaks packages which use pkg-config to determine those paths and
> > > where .install files reference /usr/. An example is mandos.
> > >
> > > I think we should revert this change. I don't see a compelling reason
> to
> > > move those files from /usr to /lib given that we require /usr to be
> > > pre-mounted by initramfs, if it's separate.
> > > Moving files from /usr to /lib files kinda backwards nowadays.
> > >
> > > I intend to apply a patch like the attached one in Debian.
> > > That said, I hope I can convince Lennart to revert this change upstream
> > > as well.
> > >
> >
> > Looks good to me.
>
> Ok, thanks for the review. Will apply it to Debian then.
> It doesn't look like upstream is interested in changing this back
>
>
> https://github.com/systemd/systemd/commit/4a56315a990b802860170ecd1bbd3eb68e14a38b#commitcomment-42793750
>
> >
> > >
> > > Thoughts, Comments?
> > >
> >
> > I wonder if systemd can be fully installed into `/usr` now that we
> require
> > premounting. Maybe we should start changing lintian and other tools to
> > install into /usr instead of /lib for the tools that currently used
> > rootprefix (I believe systemd searches in /usr anyway).
>
> I gave this a try. It can.
> See https://salsa.debian.org/systemd-team/systemd/-/merge_requests/104
> Still very rough, but the package is usable and able to boot a system,
> reading udev rules and systemd services from both /lib and /usr/lib.
> We probably need quite a few more compat symlinks though.



>
> This is only the systemd/udev side, though.
> The i-s-h/debhelper side is still missing and we'd need to hash out a
> plan for this. I'd need help with doing that.
> Anyone interested?
>

I think this is where we should start (i-s-h/debhelper/lintian). I'll try
to take a look over the weekend. It's a long weekend over here so I might
have some time to take a look.

I think the plan should be:

1. Change debhelper and i-s-h to install to /usr
2. Change the lintian warnings to point to /usr
3. Drop the /lib mangling from all the manpages
4. Wait a lot :(. At least a full release cycle, I think.
5. Drop the split and install fully to /usr, with some compat links for
non-merged-/usr.

What do you think?

-- 

Saludos,
Felipe Sateler

[Message part 2 (text/html, inline)]

Message #32 received at 971282@bugs.debian.org (full text, mbox, reply):

From: Michael Biebl <biebl@debian.org>

To: Felipe Sateler <fsateler@debian.org>, 971282@bugs.debian.org

Subject: Re: Bug#971282: ABI breakage: paths changed for sysusers.d/sysctl.d/binfmt/modules-load.d

Date: Mon, 5 Oct 2020 18:02:40 +0200

[Message part 1 (text/plain, inline)]

Am 05.10.20 um 17:25 schrieb Felipe Sateler:
> I think the plan should be:
> 
> 1. Change debhelper and i-s-h to install to /usr

I assume you mean, that dh_installsystemd/dh_systemd should install
debian/foo.service and debian/foo.udev to /usr/lib?

Should debhelper also actively move files from /lib to /usr/lib when
they are installed to /lib by the upstream build system?

We need to decide whether to tie that to a compat bump (in which case it
would be a very slow process) or whether to do that unconditionally.

> 2. Change the lintian warnings to point to /usr
> 3. Drop the /lib mangling from all the manpages
> 4. Wait a lot :(. At least a full release cycle, I think.
> 5. Drop the split and install fully to /usr, with some compat links for
> non-merged-/usr.

I guess we only need compat symlinks for binaries in /bin. We need to
determine if we create symlinks for all of them or only for a select few
ones, which would have a high impact and would cause unnecessary churn.

A few more bullet points
- Add support to udev to run udev helper binaries from both paths (see
the patch in my MR).

- Change systemd.pc and udev.pc and point udevdir to /usr/lib/udev and
let the various systemd paths point to /usr/lib/.
This will likely break a few packages, so it would probably be good to
do a archive wide rebuild of packages build-depending on systemd or udev.

[signature.asc (application/pgp-signature, attachment)]

Message #37 received at 971282@bugs.debian.org (full text, mbox, reply):

From: Felipe Sateler <fsateler@debian.org>

To: Michael Biebl <biebl@debian.org>

Cc: 971282@bugs.debian.org

Subject: Re: Bug#971282: ABI breakage: paths changed for sysusers.d/sysctl.d/binfmt/modules-load.d

Date: Mon, 5 Oct 2020 14:14:50 -0300

[Message part 1 (text/plain, inline)]

On Mon, Oct 5, 2020 at 1:02 PM Michael Biebl <biebl@debian.org> wrote:

> Am 05.10.20 um 17:25 schrieb Felipe Sateler:
> > I think the plan should be:
> >
> > 1. Change debhelper and i-s-h to install to /usr
>
> I assume you mean, that dh_installsystemd/dh_systemd should install
> debian/foo.service and debian/foo.udev to /usr/lib?
>

Correct, that's what I mean.


>
> Should debhelper also actively move files from /lib to /usr/lib when
> they are installed to /lib by the upstream build system?
>

Hmm, interesting idea. On the one hand, we didn't do it for /lib. On the
other hand, it would probably save a lot of churn.


>
> We need to decide whether to tie that to a compat bump (in which case it
> would be a very slow process) or whether to do that unconditionally.
>

I think the lintian maintainers would have a preference here. If we do it,
I would prefer unconditionally, but they might prefer a new compat level.

I'm not sure if debhelper does look in /usr/lib/systemd/system. If not,
that needs to be fixed.


>
> > 2. Change the lintian warnings to point to /usr
> > 3. Drop the /lib mangling from all the manpages
> > 4. Wait a lot :(. At least a full release cycle, I think.
> > 5. Drop the split and install fully to /usr, with some compat links for
> > non-merged-/usr.
>
> I guess we only need compat symlinks for binaries in /bin. We need to
> determine if we create symlinks for all of them or only for a select few
> ones, which would have a high impact and would cause unnecessary churn.
>
> A few more bullet points
> - Add support to udev to run udev helper binaries from both paths (see
> the patch in my MR).
>

Right. Ideally, only for the transition period.


>
> - Change systemd.pc and udev.pc and point udevdir to /usr/lib/udev and
> let the various systemd paths point to /usr/lib/.
> This will likely break a few packages, so it would probably be good to
> do a archive wide rebuild of packages build-depending on systemd or udev.
>

I believe doing systemd first is easier (it already has the logic for
multi-path search).

Do you think doing both udev and systemd at the same time is better?

-- 

Saludos,
Felipe Sateler

[Message part 2 (text/html, inline)]

Message #40 received at 971282-submitter@bugs.debian.org (full text, mbox, reply):

From: Michael Biebl <noreply@salsa.debian.org>

To: 971282-submitter@bugs.debian.org

Subject: Bug#971282 marked as pending in systemd

Date: Thu, 15 Oct 2020 22:50:03 +0000

Control: tag -1 pending

Hello,

Bug #971282 in systemd reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/systemd-team/systemd/-/commit/4ef284cd7a2abcbd8a1f93feaa9c7efa838ee1c7

------------------------------------------------------------------------
Move sysusers.d/sysctl.d/binfmt.d/modules-load.d back to /usr

In Debian, late mounting of /usr is no longer supported, so it is safe
to install those files in /usr.
We want those facilities in /usr, not /, as this will make an eventual
switch to a merged-usr setup easier.

Closes: #971282
------------------------------------------------------------------------

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/971282

Message #47 received at 971282-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 971282-close@bugs.debian.org

Subject: Bug#971282: fixed in systemd 246.6-2

Date: Thu, 15 Oct 2020 23:08:37 +0000

Source: systemd
Source-Version: 246.6-2
Done: Michael Biebl <biebl@debian.org>

We believe that the bug you reported is fixed in the latest version of
systemd, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 971282@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Michael Biebl <biebl@debian.org> (supplier of updated systemd package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 15 Oct 2020 23:48:34 +0200
Source: systemd
Architecture: source
Version: 246.6-2
Distribution: unstable
Urgency: medium
Maintainer: Debian systemd Maintainers <pkg-systemd-maintainers@lists.alioth.debian.org>
Changed-By: Michael Biebl <biebl@debian.org>
Closes: 968116 969144 970534 971282
Changes:
 systemd (246.6-2) unstable; urgency=medium
 .
   * XDG autostart improvements
     - Add support for Path= in XDG Desktop File
     - Ignore more common XDG Desktop Entry fields
     - Lower most info messages to debug level (Closes: #968116)
   * Re-enable seccomp support on riscv64.
     This should be safe now, as the code has fallbacks for systems with
     older libseccomp versions.
   * Move sysusers.d/sysctl.d/binfmt.d/modules-load.d back to /usr.
     In Debian, late mounting of /usr is no longer supported, so it is safe
     to install those files in /usr.
     We want those facilities in /usr, not /, as this will make an eventual
     switch to a merged-usr setup easier. (Closes: #971282)
   * units: update serial-getty@.service to support 57600 baud rate
     (Closes: #969144)
   * bootspec: don't fail with EIO if searching for ESP and finding one without
     an enveloping partition table
     (Closes: #970534)
Checksums-Sha1:
 f25abb4da85e179f0f22df02de7ac900ffb191fb 5149 systemd_246.6-2.dsc
 3d05c1e5292ee3f9499d30a0e392d6cf19ef9425 157024 systemd_246.6-2.debian.tar.xz
 c137ea08bdaa38eec900e429d790a892c7c539cc 9465 systemd_246.6-2_source.buildinfo
Checksums-Sha256:
 2e3093a9cd4ca63587d9d20ab0e4205e52de8fde20bf47138014dc85185595d1 5149 systemd_246.6-2.dsc
 ad154d24511ec25d54e480a56026f6017c092e20a2c36d27ac57c41a9dc12df6 157024 systemd_246.6-2.debian.tar.xz
 ad4954f008c6e0953ad1274472c09ca054fd7ee9fb935da2897824ae536bf799 9465 systemd_246.6-2_source.buildinfo
Files:
 6e9d33d093e3b477c8aa06b796f7a3cc 5149 admin optional systemd_246.6-2.dsc
 412b24243699378beef614cd293dc873 157024 admin optional systemd_246.6-2.debian.tar.xz
 2fab4bfbd0e329e271f0425e2ca47a08 9465 admin optional systemd_246.6-2_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEECbOsLssWnJBDRcxUauHfDWCPItwFAl+I0fQACgkQauHfDWCP
ItzA7g/+Op/0zm5hhMjPcU82raC9ZvR1hFny7i9nHgD7sH95cksawQaTV/1V/MRu
eIleImO13SVnD8WtzqA+SDZZW3gbwuyC8wMqOf2CffQkO0MFg06B8iUf4B0/gpvN
m27BXX3rZChq+ikeEoK6PqFH3bLvX14992x6/XKPbT3utVfQdpg8QL2RFXk2sIy9
Scgcfx09YNhd6lYK79XaIcyFxgUEHUDlXfRxjwaNN4TK4toome0jZkhLJcMnV/kj
eNqR5c/PB/cv1kSQaupyBLpPCE1oaeo0fPAV7VnU8sK4UfIZ5FINXeSPwudt7UX/
Qe2Fc8EKzu/yjKu58whsuHobhkCz7RRPy/CKl1Lh5TpMz6PyN5yKl3HfX0/9+8mI
dL6tSxPzczBJdFSCq7/sRGGcw1Ny1i9sFSI0sMfPWQz+yCg/fBLkNdqbAT0ke5HW
Kp9KhzMgfhtmAfB4LfrDHmSNdUAR+QVoJprGNI0w5LgA3X2Nreobdis6HN7rMGXt
VSvBBgoF9tpNVRK1sLu3wW/ss8AcEMU4A7jGiXjP9bNeCVah3hmL3JxaenKuSFMg
NpjZFGJaI/ejtxc7FYC0PICaWtMrNhERYgIxEnCAF+rMGFpty/29Oki21HDGlPbT
K7hhqgl0642opMuzuAIHmjoFe4W+lrmZP1LKGgr2icaZFBBH+Kg=
=mOEm
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.