Debian Bug report logs - #970278
smartlist: please make the build reproducible

Reply or subscribe to this bug.

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>

To: submit@bugs.debian.org

Subject: smartlist: please make the build reproducible

Date: Mon, 14 Sep 2020 10:54:31 +0100

[Message part 1 (text/plain, inline)]

Source: smartlist
Version: 3.15-25
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: environment
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0] we noticed that
smartlist could not be built reproducibly.

This is because the choplist binary contains the current user via the
LISTID define. Given that has been the build user's username for many
years (?), I suspect it makes no difference what value this actually
has, but patch attached that sets it to "list" (ie. to match the name
of uid 38).

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

[smartlist.diff.txt (text/plain, attachment)]

Message #10 received at 970278@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>

To: 970278@bugs.debian.org, reproducible-bugs@lists.alioth.debian.org

Subject: Re: Bug#970278: smartlist: please make the build reproducible

Date: Sun, 13 Dec 2020 17:52:03 -0000

Chris Lamb wrote:

> Source: smartlist
> Version: 3.15-23
> Tags: patch

Gentle ping on the above?


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #15 received at 970278@bugs.debian.org (full text, mbox, reply):

From: Santiago Vila <sanvila@unex.es>

To: Chris Lamb <lamby@debian.org>, 970278@bugs.debian.org

Subject: Re: Bug#970278: smartlist: please make the build reproducible

Date: Sun, 13 Dec 2020 19:32:44 +0100

On Sun, Dec 13, 2020 at 05:52:03PM -0000, Chris Lamb wrote:
> Chris Lamb wrote:
> 
> > Source: smartlist
> > Version: 3.15-23
> > Tags: patch
> 
> Gentle ping on the above?

I'm not interested in working on reproducible issues anymore
(including accepting patches) as far as there are any packages
in stable with unfixed FTBFS bugs on them.

Sorry.

Message #20 received at 970278@bugs.debian.org (full text, mbox, reply):

From: Santiago Vila <sanvila@debian.org>

To: Chris Lamb <lamby@debian.org>, 970278@bugs.debian.org

Subject: Re: smartlist: please make the build reproducible

Date: Mon, 23 Jan 2023 19:27:18 +0100

El 14/9/20 a las 11:54, Chris Lamb escribió:
> Source: smartlist
> Version: 3.15-25
> Severity: wishlist
> Tags: patch
> User: reproducible-builds@lists.alioth.debian.org
> Usertags: environment
> X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org
> 
> Hi,
> 
> Whilst working on the Reproducible Builds effort [0] we noticed that
> smartlist could not be built reproducibly.
> 
> This is because the choplist binary contains the current user via the
> LISTID define. Given that has been the build user's username for many
> years (?), I suspect it makes no difference what value this actually
> has, but patch attached that sets it to "list" (ie. to match the name
> of uid 38).

According to this page:

https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/smartlist.html

the package is already reproducible.

Am I missing anything?

Thanks.

Message #25 received at 970278@bugs.debian.org (full text, mbox, reply):

From: Santiago Vila <sanvila@debian.org>

To: Chris Lamb <lamby@debian.org>, 970278@bugs.debian.org

Subject: Re: smartlist: please make the build reproducible

Date: Mon, 23 Jan 2023 19:34:02 +0100

Sorry, I said:

> According to this page:
> 
> https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/smartlist.html
> 
> the package is already reproducible.
> 
> Am I missing anything?

Ok, it's reproducible only in bullseye, bookworm and unstable on amd64,
and not reproducible on i386.

But I don't understand how the patch might fix that, since the patch
does not depend on the architecture.

Could we postpone this until I switch to dh? (which I plan to do before the freeze)

Thanks.

Message #30 received at 970278@bugs.debian.org (full text, mbox, reply):

From: Santiago Vila <sanvila@debian.org>

To: Chris Lamb <lamby@debian.org>, 970278@bugs.debian.org

Subject: Re: smartlist: please make the build reproducible

Date: Tue, 24 Jan 2023 17:51:24 +0100

tags 970278 + moreinfo
tags 970278 - patch
thanks

Hi. To summarize: I'd appreciate a more detailed explanation about why
the patch is needed (if it's needed at all at this point).

Note: I have just switched to dh, which means the build now uses
dh_strip_nondeterminism (I guess this always helps).

Thanks.

Message #39 received at 970278@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>

To: "Santiago Vila" <sanvila@debian.org>, 970278@bugs.debian.org

Subject: Re: smartlist: please make the build reproducible

Date: Tue, 07 Feb 2023 13:30:06 -0800

Santiago Vila wrote:

> Hi. To summarize: I'd appreciate a more detailed explanation about why
> the patch is needed (if it's needed at all at this point).

Hm, the difficulty here is that the packaging and the surrounding
toolchain has changed quite a bit since we filed this bug, and we
don't keep historical archives of diffoscope output.

Looking again at my patch, however, what I believe was happening in
the past was that the build user (or similar) was being embedded into
a binary or in some configuration file. This doesn't appear to be
happening anymore on amd64 in our testing framework, and neither does
it occur locally on my amd64 laptop. What I can say is that smartlist
was definitely unreproducible on my laptop back in 2020, otherwise I
would not have filed a patch.

As to why it remains unreproducible on i386 today, I can't immediately
see why that is happening. But I don't think it's related to the
rationale I gave above. I therefore think keeping this "- patch" and
"+ moreinfo" is correct.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org 🍥 chris-lamb.co.uk
       `-

Message #44 received at 970278@bugs.debian.org (full text, mbox, reply):

From: Santiago Vila <sanvila@debian.org>

To: Chris Lamb <lamby@debian.org>, 970278@bugs.debian.org

Subject: Re: Bug#970278: smartlist: please make the build reproducible

Date: Tue, 7 Feb 2023 22:35:31 +0100

El 7/2/23 a las 22:30, Chris Lamb escribió:
> As to why it remains unreproducible on i386 today, I can't immediately
> see why that is happening. But I don't think it's related to the
> rationale I gave above. I therefore think keeping this "- patch" and
> "+ moreinfo" is correct.

Seems fair to me.

Thanks a lot.

Send a report that this bug log contains spam.