Debian Bug report logs - #969753
diffoscope: autopkgtest failures

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Gianfranco Costamagna <locutusofborg@debian.org>

To: submit@bugs.debian.org

Subject: diffoscope: autopkgtest failures

Date: Mon, 7 Sep 2020 20:53:13 +0200

[Message part 1 (text/plain, inline)]

Source: diffoscope
Version: 159
Severity: serious

Hello, autopkgtests looks sad, pytest-with-recommends works, while pytest doesn't, because of missing pgpdump

I did add some @skip_unless_tools_exist("pgpdump") around the failing tests (attached the diff), however I don't know
if this is the right solution, or something better has to be implemented.

G.

[diff (text/plain, attachment)]

Message #10 received at 969753@bugs.debian.org (full text, mbox, reply):

From: Gianfranco Costamagna <locutusofborg@debian.org>

To: 969753@bugs.debian.org

Subject: Re: diffoscope: autopkgtest failures

Date: Mon, 7 Sep 2020 23:19:46 +0200

Hello,

another additional diff:

--- diffoscope-159ubuntu1/tests/comparators/test_directory.py	2020-09-04 12:12:52.000000000 +0200
+++ diffoscope-159ubuntu2/tests/comparators/test_directory.py	2020-09-07 20:46:23.000000000 +0200
@@ -33,6 +33,7 @@
 TEST_FILE2_PATH = data("text_ascii2")
 
 
+@skip_unless_tools_exist("pgpdump")
 def test_no_differences():
     difference = compare_directories(
         os.path.dirname(__file__), os.path.dirname(__file__)
@@ -40,6 +41,7 @@
     assert difference is None
 
 
+@skip_unless_tools_exist("pgpdump")
 def test_no_differences_with_extra_slash():
     difference = compare_directories(
         os.path.dirname(__file__) + "/", os.path.dirname(__file__)
diff -Nru diffoscope-159ubuntu1/tests/comparators/test_rlib.py diffoscope-159ubuntu2/tests/comparators/test_rlib.py
--- diffoscope-159ubuntu1/tests/comparators/test_rlib.py	2020-09-07 20:46:23.000000000 +0200
+++ diffoscope-159ubuntu2/tests/comparators/test_rlib.py	2020-09-07 20:46:23.000000000 +0200
@@ -51,6 +51,7 @@
     assert isinstance(rlib1, ArFile)
 
 
+@skip_unless_tools_exist("pgpdump")
 def test_no_differences(rlib1):
     difference = rlib1.compare(rlib1)
     assert difference is None
@@ -121,6 +122,6 @@
     )
 
 
-@skip_unless_tools_exist("nm")
+@skip_unless_tools_exist("nm", "pgpdump")
 def test_compare_non_existing(monkeypatch, rlib1):
     assert_non_existing(monkeypatch, rlib1)


On Mon, 7 Sep 2020 20:53:13 +0200 Gianfranco Costamagna <locutusofborg@debian.org> wrote:
> Source: diffoscope
> Version: 159
> Severity: serious
> 
> Hello, autopkgtests looks sad, pytest-with-recommends works, while pytest doesn't, because of missing pgpdump
> 
> I did add some @skip_unless_tools_exist("pgpdump") around the failing tests (attached the diff), however I don't know
> if this is the right solution, or something better has to be implemented.
> 
> G.

Message #15 received at 969753@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>

To: "Gianfranco Costamagna" <locutusofborg@debian.org>, 969753@bugs.debian.org

Subject: Re: Bug#969753: diffoscope: autopkgtest failures

Date: Tue, 08 Sep 2020 12:49:15 +0100

Hi Gianfranco,

> Hello, autopkgtests looks sad, pytest-with-recommends works, while
> pytest doesn't, because of missing pgpdump
>
> I did add some @skip_unless_tools_exist("pgpdump") around the failing
> tests (attached the diff), however I don't know
> if this is the right solution, or something better has to be
> implemented.

Thanks. Adding the decorator in test_pgp.py looks fine at a first
glance, but needing PGP support to diff two directories (!) is a
symptom of a deeper problem with pgpdump integration.

Will investigate.


Regards,

--
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org 🍥 chris-lamb.co.uk
       `-

Message #18 received at 969753-submitter@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: 969753-submitter@bugs.debian.org

Subject: Bug#969753 marked as pending in diffoscope

Date: Fri, 11 Sep 2020 08:47:27 +0000

Control: tag -1 pending

Hello,

Bug #969753 in diffoscope reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/reproducible-builds/diffoscope/-/commit/4d60897d512e032a89e3bf4c25076454de6a2b17

------------------------------------------------------------------------
Mark some PGP tests that they require pgpdump. Thanks to Gianfranco Costamagna (locutusofborg). (Closes: #969753)
------------------------------------------------------------------------

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/969753

Message #25 received at 969753-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 969753-close@bugs.debian.org

Subject: Bug#969753: fixed in diffoscope 160

Date: Fri, 11 Sep 2020 09:34:51 +0000

Source: diffoscope
Source-Version: 160
Done: Chris Lamb <lamby@debian.org>

We believe that the bug you reported is fixed in the latest version of
diffoscope, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 969753@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Chris Lamb <lamby@debian.org> (supplier of updated diffoscope package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Fri, 11 Sep 2020 10:08:38 +0100
Source: diffoscope
Built-For-Profiles: nocheck
Architecture: source
Version: 160
Distribution: unstable
Urgency: medium
Maintainer: Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>
Changed-By: Chris Lamb <lamby@debian.org>
Closes: 969753
Changes:
 diffoscope (160) unstable; urgency=medium
 .
   * Check that pgpdump is actually installed before attempting to run it.
     Thanks to Gianfranco Costamagna (locutusofborg). (Closes: #969753)
   * Add some documentation for the EXTERNAL_TOOLS dictionary.
   * Ensure we check FALLBACK_FILE_EXTENSION_SUFFIX, otherwise we run pgpdump
     against all files that are recognised by file(1) as "data".
Checksums-Sha1:
 c69615b6f2a084807567cfa7d67c6bcad5614aa7 4807 diffoscope_160.dsc
 d1cd0945901f4d5daebaad7875b2ca9cf53de22f 984740 diffoscope_160.tar.xz
 eff483b199ae3a9a3597333b8e051e6cdefeadae 6200 diffoscope_160_amd64.buildinfo
Checksums-Sha256:
 26213c1c398085e04b5bbfa56cd3be292a6d6ca61a45c1e49823e4e015c0a7aa 4807 diffoscope_160.dsc
 1ca57ccf204cef2b5b275f64fb3fb14714511dfb0c261de57c281ac6c26b6541 984740 diffoscope_160.tar.xz
 5e241d14eac97b7528542af395f07c1e47bb011f4db8832939773f99e65d44f8 6200 diffoscope_160_amd64.buildinfo
Files:
 54dca34e7a53b7b5120074aa1a387a62 4807 devel optional diffoscope_160.dsc
 72d65b5a24d36a1451a7ed7ab49deda4 984740 devel optional diffoscope_160.tar.xz
 8ef679e9dbafe0446fcc2277ef1c07b9 6200 devel optional diffoscope_160_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEwv5L0nHBObhsUz5GHpU+J9QxHlgFAl9bQJ4ACgkQHpU+J9Qx
HliRIg//eZ3WsqmQn/8HF2C4pwmQrD5TwVWw4JNQyqS+QQjk+uyiHSH8or6UcjI4
wpMy7/QvDNUzB+1+ZvPVZdltTnsxArF6NUGoFqkH2y6zs42ltewc5x3ZwIwO54wI
SQ0V3s7wcWqMzCPSgVvIxDZXA+RRMe0widcHqyFTnb4GuD0Nt6flWAokDds3ZpFH
7OBAK2FigMhytjRxXhiswmvdSFKngkfj418Ub8hq10T17Eo0awTTpdVVuityEr/d
9b5P5vnmt1S1XFoBB7I1Gp6oNPswF5pGS14BlHvOP5rjJx66HbBg4vqZlw93VzdW
CaLwmYlhD4D/VR0m/1s9RNFKlqgHC21uKBOucfjq5ANmAi7zipNvqMhjtlWqEAQW
o4qmt6CIrPdHp7AMHjHMuY0Spv9dufuhhsp/mnEhiHbCbGY3aX518DfjVP1/kB1f
whHmI4nqRDfI4ayzaxpxQiWt2Xvh8ys+FHO8WihGfwBo1cSPcpmaQ91GMACwefm4
CQRePE2wr/l7xG36Wf5jvk3gbYTlLVJ8Qym7snU9EClXa0lX8NBjiP8Y3/rkPVpk
QOO+ZjrnypmQKHpCUK/mO59AEzxAtw32GJGIrruabiMke868cSZgDH8kNlFqoaWq
zAgLTm3UZn+FMyw+Oj+PU0+sEbEctkXIHIqSc64LiS5L0gidqC0=
=4/dN
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.