Debian Bug report logs - #969340
nvme-cli: generate /etc/nvme/host* files at install time, not build time

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Dan Streetman <ddstreet@canonical.com>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: nvme-cli: generate /etc/nvme/host* files at install time, not build time

Date: Mon, 31 Aug 2020 14:25:14 -0400

[Message part 1 (text/plain, inline)]

Package: nvme-cli
Version: 1.12-1
Severity: normal
Tags: patch
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu groovy ubuntu-patch

Dear Maintainer,

The nvme-cli package currently generates the /etc/nvme/hostnqn and
/etc/nvme/hostid files during the build, which results in the content
of the files being identical for all installed systems. Since these
files are supposed to contain ids unique to the installed system,
having them included in the binary package is incorrect, and instead
they should be generated during package install.

This patch removes the files from the binary package, and adds a postinst
to generate the files (if needed).

Note that this also requires the patch from:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=969183
because without that patch, the build doesn't include uuid-dev, and the
nvme 'gen-hostnqn' command is not able to be built.

This is also tracked in Ubuntu bug:
https://bugs.launchpad.net/ubuntu/+source/nvme-cli/+bug/1867366

Thanks for considering the patch.

[nvme-cli_1.12-1+test1.debdiff (text/plain, attachment)]

Message #10 received at 969340@bugs.debian.org (full text, mbox, reply):

From: Dan Streetman <ddstreet@canonical.com>

To: 969340@bugs.debian.org

Subject: Re: Bug#969340: nvme-cli: generate /etc/nvme/host* files at install time, not build time

Date: Mon, 31 Aug 2020 16:05:57 -0400

[Message part 1 (text/plain, inline)]

v2 debdiff, with slight adjustment that may be better

[nvme-cli-postinst_v2.patch (text/x-patch, attachment)]

Message #15 received at 969340-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 969340-close@bugs.debian.org

Subject: Bug#969340: fixed in nvme-cli 1.12-2

Date: Sun, 20 Sep 2020 09:35:01 +0000

Source: nvme-cli
Source-Version: 1.12-2
Done:  <leitao@debian.org>

We believe that the bug you reported is fixed in the latest version of
nvme-cli, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 969340@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
<leitao@debian.org> (supplier of updated nvme-cli package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 20 Sep 2020 10:14:36 +0100
Source: nvme-cli
Architecture: source
Version: 1.12-2
Distribution: unstable
Urgency: medium
Maintainer: Breno Leitao <leitao@debian.org>
Changed-By: <leitao@debian.org>
Closes: 969340
Changes:
 nvme-cli (1.12-2) unstable; urgency=medium
 .
   *  Generate /etc/nvme/host* files at install time, not build time.
      Thanks Dan for the patch. (Closes: #969340)
Checksums-Sha1:
 b416217e97fa91c1635836b5394e12c59b9250cc 1753 nvme-cli_1.12-2.dsc
 e0d869a4125252f200fda7957a41bf67c0e4238d 2628 nvme-cli_1.12-2.debian.tar.xz
 23236afac50da3e029f489eb29f2849b2c1a666c 6420 nvme-cli_1.12-2_source.buildinfo
Checksums-Sha256:
 b4d54eed3d95c6f2ddf248bd30ac0f64437f798d8df7a8c99437191a7e50a8a3 1753 nvme-cli_1.12-2.dsc
 ee08d1c53c9037c8f72e662e257613a1193413d5750c817be27ec65e5c1fd21f 2628 nvme-cli_1.12-2.debian.tar.xz
 bc341659ff9076d7637fda94a64548859aafab4f61bdff9598d6696bbf53a3fc 6420 nvme-cli_1.12-2_source.buildinfo
Files:
 ba910f20268333b123a13c2cd76b13cf 1753 admin optional nvme-cli_1.12-2.dsc
 0bdefda537da6b307c523cf69b112306 2628 admin optional nvme-cli_1.12-2.debian.tar.xz
 9c9d00dc5d1b507bf8faf23fcf28c604 6420 admin optional nvme-cli_1.12-2_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEErIU5puj0ZwLKSkObNaOTn/x4d20FAl9nHqgACgkQNaOTn/x4
d22mHw//VMzdEUKwvCInuEVYj5+9bj3LGP8c1TqfhfF8ATd3mFrt0VPIfVABDvp9
DtARL0555JbtlSpRzwo0x83YLnOP2ZbxF/qD6Y1oeZ3wgCJHlF7SaUzIWya5/t6c
dkYDCGAy/MKM629TdupIIDUcZCQfDYQyKJ4KEKpctx/w2hb3RMqSmu3qaGJudC2W
uYp/esaYKoke/O2P165UMYwxVVL7zcY0f4gL/cgPsnegfLyE93vJ/sHll3V9WXHg
pkS8CYuLwnY9LOsDBYTzC09MdE2ZVKFH0BXS3lb34ozU/ygFWGmdnlxzAM+fpnGW
G9wyzM2TWalnUNHZ+mcOMNquaHbMyBnjrpLI2lgx1kyZGjysrpjlrBSf9TCzp3rH
iGCXDRuIjJnCkSAP05ClUmSf1hD1jCXCg170xHu1Y9qwkWsBfr7KDswzc0kCqsiV
45ddT011pOM9UZfJlXweJyj/Ts/wfO7baDQJETwl9RdznJ5lJR2tRbjBLemF0FUA
HaAAZNuFFf78Nt3Xe0O15jBDt+YF7FeLuvtn2dUivDq9nYmDOo0NHrFFSEODUqin
DdyVS18olowJ6bJrMfL08AWD11XmmGSqWhyAZ8Sg8LBlAyeYWGC2FJSeOk2xQQrJ
2De2hVvbNJAPxYrKclBN9NhQ+2jTdFUvweMU8O+rUcw0oPXTnjU=
=DJno
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.