Debian Bug report logs - #966256
reprotest: fails with diffoscope 153

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: gregor herrmann <gregoa@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: reprotest: fails with diffoscope 153

Date: Sat, 25 Jul 2020 16:56:35 +0200

Package: reprotest
Version: 0.7.14
Severity: important
Tags: patch

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

After upgrading diffoscope to version 153, reprotest fails with

INFO:reprotest:Running diffoscope: ['diffoscope', '--exclude-directory-metadata', '/tmp/tmp7evaur28/control', '/tmp/tmp7evaur28/experiment-1']
usage: diffoscope [--debug] [--pdb] [--status-fd FD] [--progress]
                  [--no-default-limits] [--text OUTPUT_FILE]
                  [--text-color WHEN] [--output-empty] [--html OUTPUT_FILE]
                  [--html-dir OUTPUT_DIR] [--css URL] [--jquery URL]
                  [--json OUTPUT_FILE] [--markdown OUTPUT_FILE]
                  [--restructured-text OUTPUT_FILE] [--difftool TOOL]
                  [--profile OUTPUT_FILE] [--max-text-report-size BYTES]
                  [--max-report-size BYTES] [--max-diff-block-lines LINES]
                  [--max-page-size BYTES] [--max-page-diff-block-lines LINES]
                  [--new-file] [--exclude GLOB_PATTERN]
                  [--exclude-command REGEX_PATTERN]
                  [--exclude-directory-metadata {auto,yes,no,recursive}]
                  [--diff-mask REGEX_PATTERN]
                  [--fuzzy-threshold FUZZY_THRESHOLD]
                  [--tool-prefix-binutils PREFIX]
                  [--max-diff-input-lines LINES] [--max-container-depth DEPTH]
                  [--max-diff-block-lines-saved LINES] [--use-dbgsym WHEN]
                  [--force-details] [--help] [--version]
                  [--list-tools [DISTRO]] [--list-debian-substvars]
                  [--list-missing-tools [DISTRO]]
                  path1 [path2]
diffoscope: error: argument --exclude-directory-metadata: invalid choice: '/tmp/tmp7evaur28/control' (choose from 'auto', 'yes', 'no', 'recursive')


And diffoscope's d/changelog says:

  * Drop some legacy argument styles; --exclude-directory-metadata and
    --no-exclude-directory-metadata have been replaced with
    --exclude-directory-metadata={yes,no}.


So changing '--exclude-directory-metadata' to
'--exclude-directory-metadata=yes' seems to be the way to go.
(And monkey-patching =yes into
/usr/lib/python3/dist-packages/reprotest/__init__.py, line 608 seems
to work indeed.)


Cheers,
gregor

-----BEGIN PGP SIGNATURE-----

iQKTBAEBCgB9FiEE0eExbpOnYKgQTYX6uzpoAYZJqgYFAl8cSCNfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEQx
RTEzMTZFOTNBNzYwQTgxMDREODVGQUJCM0E2ODAxODY0OUFBMDYACgkQuzpoAYZJ
qgZpmg/9FJsu+K56j1TmHjShmBEq//HVAO3W9maTOxcUyxoq4+bPoDdtEO2eIA3n
6NXe9G8P0vvKzcyOSsO3vMSrN1YeAJmode0zHqPJ8K3Bcut10Ryp5GBK4GF3g/XP
gPRZ15df4C99/4D06/FdTDFyNLzziCIJYgcDU+JqLsn2EW7mx911h/NSLbjyLFJP
/7dpJnEXaucvzO5PU2g+AFM7ymgFLi6XEJsO29MzAhVCpdQSr3B2gx+QdVsoSLTi
ozso3x1EVFd3AggM4487p4/8xvCDCgknL7GUD46buApe/wO1+guoFjNZQC0e26wF
W0l8fUcRsp2i/X3Ce6V7RV69lNJf41j2ut1HOKwxQ4WieZH1Y+dYVtbZjMojjSpn
0hjaoL6h0r6/7vZXNwPpTLLr0CUK7g6q6Nb6EYigEv1vOr4Kgo8eyLci55e5PFNM
HCGiAZMTLMIgYFRDrgTPCPAiV4wWznjG2xjxlxMourowWSD/feItFzCc/IsmR/TG
gztr288XFk1twE+gQy8jX1mAHgJyRytMs+77x+OG8hLzavq4JNrJ1Y/8GodRKRub
dgvkKkJ5Na0jHWdQgmVyQXeMimBva0r+O8glvcGLbFGDxZvrC9pIhty7igQDzJ9J
jbi3LuSKj9aMv0H/VyRx7Pco0lAMp8GZdy30ouG4s9vjc0cRXwM=
=3x8g
-----END PGP SIGNATURE-----

Message #8 received at 966256-submitter@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <noreply@salsa.debian.org>

To: 966256-submitter@bugs.debian.org

Subject: Bug#966256 marked as pending in reprotest

Date: Sun, 26 Jul 2020 01:50:19 +0000

Control: tag -1 pending

Hello,

Bug #966256 in reprotest reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/reproducible-builds/reprotest/-/commit/c17411af610582935b401845610a3738e3971218

------------------------------------------------------------------------
Update default arguments passed to diffoscope to support diffoscope
version 153+. (Closes: #966256). Big thanks to Gregor Herrmann!
------------------------------------------------------------------------

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/966256

Message #15 received at 966256@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: gregor herrmann <gregoa@debian.org>, 966256@bugs.debian.org

Subject: Re: Bug#966256: reprotest: fails with diffoscope 153

Date: Sat, 25 Jul 2020 20:07:53 -0700

[Message part 1 (text/plain, inline)]

On 2020-07-25, gregor herrmann wrote:
> After upgrading diffoscope to version 153, reprotest fails with
>
> INFO:reprotest:Running diffoscope: ['diffoscope', '--exclude-directory-metadata', '/tmp/tmp7evaur28/control', '/tmp/tmp7evaur28/experiment-1']
> usage: diffoscope [--debug] [--pdb] [--status-fd FD] [--progress]
...
>                   [--list-missing-tools [DISTRO]]
>                   path1 [path2]
> diffoscope: error: argument --exclude-directory-metadata: invalid choice: '/tmp/tmp7evaur28/control' (choose from 'auto', 'yes', 'no', 'recursive')
>
>
> And diffoscope's d/changelog says:
>
>   * Drop some legacy argument styles; --exclude-directory-metadata and
>     --no-exclude-directory-metadata have been replaced with
>     --exclude-directory-metadata={yes,no}.
>
>
> So changing '--exclude-directory-metadata' to
> '--exclude-directory-metadata=yes' seems to be the way to go.
> (And monkey-patching =yes into
> /usr/lib/python3/dist-packages/reprotest/__init__.py, line 608 seems
> to work indeed.)

Thanks! I've tested and pushed a trivial fix based on the above.

Ideally it could check the version of diffoscope used and pass the
appropriate argument...

On closer look, the --exclude-directory-metadata=yes|no syntax was
introduced in 112 (present in buster at least), so it might be ok to
just assume a "new" version of diffoscope, though there is currently no
way to override this argument being passed.


live well,
  vagrant

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 966256@bugs.debian.org (full text, mbox, reply):

From: gregor herrmann <gregoa@debian.org>

To: Vagrant Cascadian <vagrant@reproducible-builds.org>, 966256@bugs.debian.org

Subject: Re: Bug#966256: reprotest: fails with diffoscope 153

Date: Sun, 26 Jul 2020 10:55:50 +0200

[Message part 1 (text/plain, inline)]

On Sat, 25 Jul 2020 20:07:53 -0700, Vagrant Cascadian wrote:

> > So changing '--exclude-directory-metadata' to
> > '--exclude-directory-metadata=yes' seems to be the way to go.
> > (And monkey-patching =yes into
> > /usr/lib/python3/dist-packages/reprotest/__init__.py, line 608 seems
> > to work indeed.)
> 
> Thanks! I've tested and pushed a trivial fix based on the above.

Thank you!
 
> On closer look, the --exclude-directory-metadata=yes|no syntax was
> introduced in 112 (present in buster at least), so it might be ok to
> just assume a "new" version of diffoscope, though there is currently no
> way to override this argument being passed.

Sounds good :)


Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-   NP: Peter Ratzenbeck: Dadi

[signature.asc (application/pgp-signature, inline)]

Message #25 received at 966256@bugs.debian.org (full text, mbox, reply):

From: Holger Levsen <holger@layer-acht.org>

To: Vagrant Cascadian <vagrant@reproducible-builds.org>, 966256@bugs.debian.org

Cc: gregor herrmann <gregoa@debian.org>

Subject: Re: Bug#966256: reprotest: fails with diffoscope 153

Date: Sun, 26 Jul 2020 09:27:46 +0000

[Message part 1 (text/plain, inline)]

On Sat, Jul 25, 2020 at 08:07:53PM -0700, Vagrant Cascadian wrote:
> Ideally it could check the version of diffoscope used and pass the
> appropriate argument...
> 
> On closer look, the --exclude-directory-metadata=yes|no syntax was
> introduced in 112 (present in buster at least), so it might be ok to
> just assume a "new" version of diffoscope, though there is currently no
> way to override this argument being passed.

I'm inclined to say that supporting pre-buster versions of diffoscope
is *less than ideal*...! ;)


-- 
cheers,
	Holger

-------------------------------------------------------------------------------
               holger@(debian|reproducible-builds|layer-acht).org
       PGP fingerprint: B8BF 5413 7B09 D35C F026 FE9D 091A B856 069A AA1C

[signature.asc (application/pgp-signature, inline)]

Message #30 received at 966256-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 966256-close@bugs.debian.org

Subject: Bug#966256: fixed in reprotest 0.7.15

Date: Sun, 26 Jul 2020 21:51:57 +0000

Source: reprotest
Source-Version: 0.7.15
Done: Vagrant Cascadian <vagrant@debian.org>

We believe that the bug you reported is fixed in the latest version of
reprotest, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 966256@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Vagrant Cascadian <vagrant@debian.org> (supplier of updated reprotest package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 26 Jul 2020 13:58:22 -0700
Source: reprotest
Architecture: source
Version: 0.7.15
Distribution: unstable
Urgency: medium
Maintainer: Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>
Changed-By: Vagrant Cascadian <vagrant@debian.org>
Closes: 966256
Changes:
 reprotest (0.7.15) unstable; urgency=medium
 .
   [ Holger Levsen ]
   * setup.py: bump version number for release.
   * Bump debhelper-compat to 13.
 .
   [ Vagrant Cascadian ]
   * Update default arguments passed to diffoscope to support diffoscope
     version 153+. (Closes: #966256). Big thanks to Gregor Herrmann!
   * debian/control: Add myself to Uploaders.
Checksums-Sha1:
 f5fd84d8854cbd16a9ee4f4b0e4ff58096b8db40 1585 reprotest_0.7.15.dsc
 a9d5f9a83261ce6b70eda1705fd7620b1edd0ca8 85712 reprotest_0.7.15.tar.xz
 6c197f247e2a75654b6b756111523a858c5caa35 10079 reprotest_0.7.15_arm64.buildinfo
Checksums-Sha256:
 48a54a9ecfac0418b94472cc82549dd359f751ba4419e54d99b615ab5999f795 1585 reprotest_0.7.15.dsc
 2983dc74e3b8ec27cfa6e79317d02ba3ccea929fa16c7e94ea0b9b5e24cbba4e 85712 reprotest_0.7.15.tar.xz
 0a027b1185b2047c65860720dc4d89deadecfb292f6fc677b83d96f1bf8fccf4 10079 reprotest_0.7.15_arm64.buildinfo
Files:
 2e0aaf08f740d06550f19ce26237fb91 1585 devel optional reprotest_0.7.15.dsc
 3566dd161326a81093c19383f87eadbe 85712 devel optional reprotest_0.7.15.tar.xz
 da79beb51453f8efff200ac6f5fa7c67 10079 devel optional reprotest_0.7.15_arm64.buildinfo

-----BEGIN PGP SIGNATURE-----

iIkEARYKADEWIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCXx32URMcdmFncmFudEBk
ZWJpYW4ub3JnAAoJENxRj8h/lxaqLsQA/1Zeqs24bLbRIc98m+7FvfrArmLLwPF0
VnrfBvw8Q11XAQDq4nrJ4a1jedE223CLGcMoY5Y4EV4PSiJm2cT0J5krCQ==
=6fl1
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.