Debian Bug report logs - #964772
gem2deb: should not install mkmf.log files

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>

To: submit@bugs.debian.org

Subject: gem2deb: should not install mkmf.log files

Date: Fri, 10 Jul 2020 10:38:59 +0100

[Message part 1 (text/plain, inline)]

Source: gem2deb
Version: 1.1
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: toolchain buildpath
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0] we noticed that
gem2deb was generating Debian packages that were not reproducible.

For example, ruby-enumerable-statistics was installing a mkmf.log file
that contained various absolute build paths, which will make the package
not reproducible.

I note that there is code already in gem2deb that attempts to not
install these (?), but it does not appear to be working. Patch
attached, although this is just a proof of concept and/or to
demonstrate the problem a little more.

  [0] https://reproducible-builds.org/


Regards,

--
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

[gem2deb.diff.txt (text/plain, attachment)]

Message #10 received at 964772@bugs.debian.org (full text, mbox, reply):

From: terceiro@debian.org

To: "Chris Lamb" <lamby@debian.org>, 964772@bugs.debian.org

Subject: Re: Bug#964772: gem2deb: should not install mkmf.log files

Date: Sat, 11 Jul 2020 15:56:34 -0300

[Message part 1 (text/plain, inline)]

On Fri, Jul 10, 2020 at 10:38:59AM +0100, Chris Lamb wrote:
> Source: gem2deb
> Version: 1.1
> Severity: wishlist
> Tags: patch
> User: reproducible-builds@lists.alioth.debian.org
> Usertags: toolchain buildpath
> X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org
> 
> Hi,
> 
> Whilst working on the Reproducible Builds effort [0] we noticed that
> gem2deb was generating Debian packages that were not reproducible.
> 
> For example, ruby-enumerable-statistics was installing a mkmf.log file
> that contained various absolute build paths, which will make the package
> not reproducible.
> 
> I note that there is code already in gem2deb that attempts to not
> install these (?), but it does not appear to be working.

That's a different code path that this package and others that use
--gem-install don't hit.


> Patch
> attached, although this is just a proof of concept and/or to
> demonstrate the problem a little more.

I'll apply your patch, thanks.

[signature.asc (application/pgp-signature, inline)]

Message #13 received at 964772-submitter@bugs.debian.org (full text, mbox, reply):

From: Antonio Terceiro <noreply@salsa.debian.org>

To: 964772-submitter@bugs.debian.org

Subject: Bug#964772 marked as pending in gem2deb

Date: Sat, 11 Jul 2020 20:58:08 +0000

Control: tag -1 pending

Hello,

Bug #964772 in gem2deb reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/ruby-team/gem2deb/-/commit/0122636d420f2c4299545e528605f148ede9fba0

------------------------------------------------------------------------
Gem2Deb::GemInstaller: delete mkmf.log from extension dir

Closes: #964772
------------------------------------------------------------------------

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/964772

Message #20 received at 964772-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 964772-close@bugs.debian.org

Subject: Bug#964772: fixed in gem2deb 1.2

Date: Sat, 11 Jul 2020 21:21:06 +0000

Source: gem2deb
Source-Version: 1.2
Done: Antonio Terceiro <terceiro@debian.org>

We believe that the bug you reported is fixed in the latest version of
gem2deb, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 964772@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Antonio Terceiro <terceiro@debian.org> (supplier of updated gem2deb package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sat, 11 Jul 2020 15:58:11 -0300
Source: gem2deb
Architecture: source
Version: 1.2
Distribution: unstable
Urgency: medium
Maintainer: Debian Ruby Team <pkg-ruby-extras-maintainers@lists.alioth.debian.org>
Changed-By: Antonio Terceiro <terceiro@debian.org>
Closes: 950629 964772
Changes:
 gem2deb (1.2) unstable; urgency=medium
 .
   [ Marc Dequènes (Duck) ]
   * Support dependency checks with multiple binaries (Closes: #950629).
 .
   [ Utkarsh Gupta ]
   * Bump debhelper-compat to 13
 .
   [ Chris Lamb ]
   * Gem2Deb::GemInstaller: delete mkmf.log from extension dir (Closes: #964772)
Checksums-Sha1:
 2ab4869bcd447cf427d41daa3f2325ff4792e53c 2278 gem2deb_1.2.dsc
 f29c5d4a0a921d83f51a525fa15fc11bbc028aa9 71524 gem2deb_1.2.tar.xz
 931b6ff080fd8a0ee0ab1df527b171ca60058c74 9195 gem2deb_1.2_amd64.buildinfo
Checksums-Sha256:
 62fdbfa229025314c7dddc327e33a1e151a60784de97d2c1b9f751739fbbebbe 2278 gem2deb_1.2.dsc
 d77d23a4829841b779067d0b243bbce93cc98a83bc90bc6e8fbb77d3e9e65d84 71524 gem2deb_1.2.tar.xz
 edbb5d40c54c8de756d54fd5e56d82cc9f6837043c7efac3c8dd056273fe9585 9195 gem2deb_1.2_amd64.buildinfo
Files:
 3df78f1ec87e5bb37225886f77e0cc63 2278 ruby optional gem2deb_1.2.dsc
 3603f6101dfd5e6925e75aaed0063969 71524 ruby optional gem2deb_1.2.tar.xz
 48fa95541394290c49f285872927de09 9195 ruby optional gem2deb_1.2_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEst7mYDbECCn80PEM/A2xu81GC94FAl8KJ88ACgkQ/A2xu81G
C97Ovw/8DAJIp/6enH2uipp4edujExNPkSanxENf75RbKqyUr2NGeTufBEp4lm/+
usfbM5rj5rdLUKLwrO0i192CF/KP5dZphzYvsk7Oloc8heTqvT1ov9a6lT4T2HxO
Sj3wnRxuWWjcoyBVTMpwWujn/W8WTnBd+CoXQQ9nn8abK2rdxOBqWFaHHYTqJBMs
z9fGSnAJ5zL7U2E+KHz68lYIH/WQY3Ev+fLJEcFr3GNAw/+z6dewfigNxgqcNWx6
Qfqw3fRAODS6HBJyLOYxFh44OVuYaDbf+2wBU7luXZRSuZIAQnY1ma+98Mkfk2t3
2znhb0zp+9V65yG7ORrF+2RemSTdSVlHrVFln3gziuoqkk14sFjDcCpT35BSbfzc
p8c6584FRrfZaHy0hOKj1lWu3lqGbrJfCL4zXmtiaYBiHGDS2FyeS2eJveBdFREA
Xtp86C4jUsOmJcIUNNoruiJ4ligZJyVVdEzRCsczY8aalaYwIRxrgn9SFYFkYAZV
9DAkUbQCf6iV9P40gjSX5p8/KSAU4okFK0171pNpJDNQ2IPxX2/hhv8xwABcDYUq
nNI9PSSInBUgjQsB0pJyZP/ufBL3eb4KafF4BDTWL9+KxVMF1lCG2kX2rUxRimDI
nrn7+ZMIlV0Nq0XEW5V3rA3KsmmmerKNIPrx9dAH0OVkd5wfmU8=
=Pjqz
-----END PGP SIGNATURE-----

Message #25 received at 964772@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>

To: "Antonio Terceiro" <terceiro@debian.org>, 964772@bugs.debian.org

Subject: Re: Bug#964772: gem2deb: should not install mkmf.log files

Date: Sun, 12 Jul 2020 07:30:03 -0000

Hi Antonio,

> > I note that there is code already in gem2deb that attempts to not
> > install these (?), but it does not appear to be working.
> 
> That's a different code path that this package and others that use
> --gem-install don't hit.

Okay. Anyway, thanks for applying my patch.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org 🍥 chris-lamb.co.uk
       `-

Send a report that this bug log contains spam.