Debian Bug report logs - #960132
mdadm: mdcheck_start.service trying to start unexisting file

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Павел Мотырев <legioner.r@gmail.com>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: mdadm: mdcheck_start.service trying to start unexisting file

Date: Sun, 10 May 2020 02:16:57 +0700

[Message part 1 (text/plain, inline)]

X-Debbugs-Cc: none
Package: mdadm
Version: 4.1-5
Severity: normal

mdcheck_start.service trying to start unexisting file

root@debian:/# cat /lib/systemd/system/mdcheck_start.service | grep Exec
ExecStartPre=-/usr/lib/mdadm/mdadm_env.sh
ExecStart=/usr/share/mdadm/mdcheck --duration $MDADM_CHECK_DURATION
root@debian:/# ls -la /usr/share/mdadm/mdcheck
ls: cannot access '/usr/share/mdadm/mdcheck': No such file or directory
root@debian:/# dpkg -L mdadm | grep mdcheck
/lib/systemd/system/mdcheck_continue.service
/lib/systemd/system/mdcheck_continue.timer
/lib/systemd/system/mdcheck_start.service
/lib/systemd/system/mdcheck_start.timer

-- System Information:
Debian Release: 10.4
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0-9-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8),
LANGUAGE=en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages mdadm depends on:
ii  debconf [debconf-2.0]  1.5.71
ii  libc6                  2.28-10
ii  lsb-base               10.2019051400
ii  udev                   241-7~deb10u4

Versions of packages mdadm recommends:
ii  exim4-daemon-light [mail-transport-agent]  4.92-8+deb10u3
ii  kmod                                       26-1

Versions of packages mdadm suggests:
pn  dracut-core  <none>

-- debconf information:
  mdadm/autoscan: true
  mdadm/mail_to: root
  mdadm/start_daemon: true
  mdadm/autocheck: true

There is a patch in attachment, that adds missed scripts into the
package during build process.
This bug also affects Ubuntu mdadm package -
https://bugs.launchpad.net/ubuntu/+source/mdadm/+bug/1852747

[mdcheck-fix.patch (text/x-patch, attachment)]

Message #10 received at 960132@bugs.debian.org (full text, mbox, reply):

From: Павел Мотырев <legioner.r@gmail.com>

To: 960132@bugs.debian.org

Subject: Re: mdadm: mdcheck_start.service trying to start unexisting file

Date: Thu, 14 May 2020 01:09:13 +0700

Bug affects all versions since release 4.1-1 - systemd services for
mdcheck was created in
0004-mdcheck-add-systemd-unit-files-to-run-mdcheck.patch
(https://sources.debian.org/patches/mdadm/4.1-1/0004-mdcheck-add-systemd-unit-files-to-run-mdcheck.patch/)

Message #15 received at 960132@bugs.debian.org (full text, mbox, reply):

From: Richard Laager <rlaager@wiktel.com>

To: 960132@bugs.debian.org

Subject: Re: mdadm: mdcheck_start.service trying to start unexisting file

Date: Fri, 11 Sep 2020 17:33:33 -0500

[Message part 1 (text/plain, inline)]

On Sun, 10 May 2020 02:16:57 +0700 Павел Мотырев <legioner.r@gmail.com>
wrote:
> There is a patch in attachment, that adds missed scripts into the
> package during build process.

syslog-events is already installed by a dh_installexamples call.

Also, I'm not sure why this would need to install the mdcheck script
into the udeb.

So I end up with this (sorry for my mail client line wrapping the
context lines):

diff -Nru mdadm-4.1/debian/rules mdadm-4.1/debian/rules
--- mdadm-4.1/debian/rules	2019-03-11 22:58:03.000000000 -0500
+++ mdadm-4.1/debian/rules	2020-09-11 17:08:40.000000000 -0500
@@ -63,6 +63,7 @@

 	install -Dm0755 debian/mkconf $(DESTDIR)/usr/share/mdadm/mkconf
 	install -Dm0755 debian/checkarray $(DESTDIR)/usr/share/mdadm/checkarray
+	install -Dm0755 misc/mdcheck $(DESTDIR)/usr/share/mdadm/mdcheck
 	install -Dm0755 debian/bugscript $(DESTDIR)/usr/share/bug/mdadm/script
 	install -Dm0755 udeb/mdadm $(DESTDIR_UDEB)/sbin/mdadm
 	install -Dm0755 udeb/mdmon $(DESTDIR_UDEB)/sbin/mdmon


-- 
Richard

[signature.asc (application/pgp-signature, attachment)]

Message #20 received at 960132-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 960132-close@bugs.debian.org

Subject: Bug#960132: fixed in mdadm 4.1-6

Date: Sun, 13 Sep 2020 04:18:28 +0000

Source: mdadm
Source-Version: 4.1-6
Done: Felix Lechner <felix.lechner@lease-up.com>

We believe that the bug you reported is fixed in the latest version of
mdadm, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 960132@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Felix Lechner <felix.lechner@lease-up.com> (supplier of updated mdadm package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 12 Sep 2020 20:46:58 -0700
Source: mdadm
Architecture: source
Version: 4.1-6
Distribution: unstable
Urgency: medium
Maintainer: Felix Lechner <felix.lechner@lease-up.com>
Changed-By: Felix Lechner <felix.lechner@lease-up.com>
Closes: 619043 872118 915182 916946 924367 932791 933773 935184 940851 956350 960132 962946
Changes:
 mdadm (4.1-6) unstable; urgency=medium
 .
   * Install misc/mdcheck; thanks Richard Laager. (Closes: #960132)
   * Update French, Dutch and German debconf translations. (Closes: #935184,
     #940851, #956350)
   * Bring command-line help in line with manual page. (Closes: #932791)
   * Fix spelling and groff macro issues in manual pages. (Closes: #915182,
     #916946, #962946)
   * Explain 'max' keyword in command-line option --size. (Closes: #933773)
   * Patch d/README.recipes for clarity. (Closes: #619043)
   * Enable autopkgtest for installed version. Requires isolation-machine,
     untested. (Closes: #872118)
   * Adopt package. (Closes: #924367)
   * Turn on hardening.
   * Avoid a race condition in d/mdadm-shutdown.service.
   * Implement missing status option in /etc/init.d/mdadm-waitidle.
   * Add missing Documentation keys to several service files.
   * Upgrade debhelper compat to 13; use new prerequisite style.
   * Set Rules-Requires-Root: no.
   * Bump Standards-Version to 4.5.0.
   * Convert copyright to DEP-5 machine-readable format.
   * Host Vcs on salsa.d.o.
   * Adopt DEP-14 branch naming in Vcs-Git
   * Enable standard Salsa CI pipeline.
   * Fix typos in executables.
   * Explain that --name does not work in Grow mode.
   * Convert international debconf translations to UTF-8.
   * Capitalize first word in package synopsis.
   * Add Lintian overrides for tags that may not be appropriate.
Checksums-Sha1:
 873a812a68104f767be0d35b2b5c7e6e55b412d7 2148 mdadm_4.1-6.dsc
 7b5116fb99260d795b519f7c45e2590ca0f90784 100380 mdadm_4.1-6.debian.tar.xz
 948c8399bf8723b200e98c78366dd04928c24b02 5486 mdadm_4.1-6_source.buildinfo
Checksums-Sha256:
 c3116debefb5234d347fd3ac7aa3536ae4753ec80b9ec74fd4c628fd9db05148 2148 mdadm_4.1-6.dsc
 b95fd225cdc8576e785b72d53d2e3d6d5aa243c73228645a0aab5084ef267bcc 100380 mdadm_4.1-6.debian.tar.xz
 36c88aa092bec9037ef22dc4e347d0e7d80aa58ec4dea6e6aed8847b9ab22d3e 5486 mdadm_4.1-6_source.buildinfo
Files:
 4ff5b02c7cd441930b18151855880e64 2148 admin optional mdadm_4.1-6.dsc
 53eba9fdd269fff44726764c4c0f9cb4 100380 admin optional mdadm_4.1-6.debian.tar.xz
 a519f85c9e40526085e18b37f95e6fe4 5486 admin optional mdadm_4.1-6_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQKvBAEBCgCZFiEE8E0cIgLi+g0BiFTarFipTxFhjuAFAl9dmHVfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEYw
NEQxQzIyMDJFMkZBMEQwMTg4NTREQUFDNThBOTRGMTE2MThFRTAbHGZlbGl4Lmxl
Y2huZXJAbGVhc2UtdXAuY29tAAoJEKxYqU8RYY7gQwkQAMgy5/OaE5b/pfuguw18
dubix9jfO9QzGz5Kd1nv6KDMRflYNuLjLRdZM088nRs1eVSrd9Ezc6GgS2UhuY02
3+QE8b4YDa6QaYHZZWoxVAkmKPGq9LNlmikI3RjxjmhrIwWPXqzJXOHsc2QI1Dn0
p/rFz7DeOQEgcm0+x5GUQSTuZ3v6FkewL0Ua8EEF5OPH34tUDelrjibiCa+6r9m8
TThLynOYCLYjHW6Remn74oPzL+wbxZQLp5tpDuhiv/2IHjvpqXOHsqKZlWu/Ikvw
y0R8Sl6ssN6CYbIQ3QnXnoBfw+J0NQrMiSW5mBL0klicVy/7CppdQU9lGzEtZult
oc2pu/uods7REM9i3NgLdlH7qNts5hJkZr5gdM1r1W/89TIZz8znE8ShFF6ewv4u
Jcx2jQuebQpkewll+1jYlhPDU3cCSBrZFtehJGIeHsUH3hEEFeel5HKY75E7yc02
jzXTbJQFhhmctmXkHb57IeEaw2F0LhoWTYsITSyfP86RcDPDRmH0tzAg4Pe2nJXO
r98NfNFqAiX+I/NY7tAWQjSonl54lOus/jrR14QX2r6EQO6JYlS0jIqnJ5mJxBu2
zvHs1qT7XSxxI31U3+aZtguFXrFIn0afpFa+wh9a8qFtBJUITBZ0yA06KYf361Zy
G6N3ANCsjUgzE0E9+wodE/gp
=mRDk
-----END PGP SIGNATURE-----

Message #25 received at 960132@bugs.debian.org (full text, mbox, reply):

From: Richard Laager <rlaager@wiktel.com>

To: 960132@bugs.debian.org

Subject: Re: mdadm: mdcheck_start.service trying to start unexisting file

Date: Fri, 18 Sep 2020 02:16:29 -0500

[Message part 1 (text/plain, inline)]

found 960132 4.1-1
severity 960132 serious

Justification for "serious":

This bug causes a shipped service (mdcheck_start.service) to completely
fail to start, due to the fact that its script
(/usr/share/mdadm/mdcheck) does not exist. A package should not release
in that state.

I considered going up or down a level, but ultimately landed on "serious".

Argument for increasing to "grave":

For someone expecting/needing this service to work, this could lead to
data loss. The entire point of MD's "check" functionality is to make
sure that all the blocks are readable. In e.g. a two-disk mirror, if one
disk ends up with an unreadable block and then the other disk fails,
data loss occurs. If the check script runs as intended and catches this
before the second failure, the unreadable block will be detected and
then rewritten (from the good copy on the other disk).

Argument for decreasing to "important":

mdcheck_start.timer is disabled by default and /etc/cron.d/mdadm still
exists.


Regardless of the particular severity (>= important), I think this is a
good candidate for a stable update. Here is an example debdiff (sub in
your name):

--- mdadm-4.1/debian/changelog	2019-01-15 12:23:53.000000000 -0600
+++ mdadm-4.1/debian/changelog	2020-09-18 02:09:41.000000000 -0500
@@ -1,3 +1,9 @@
+mdadm (4.1-1+deb10u1) buster; urgency=medium
+
+  * Install misc/mdcheck (Closes: #960132)
+
+ -- Richard Laager <rlaager@debian.org>  Fri, 18 Sep 2020 02:09:41 -0500
+
 mdadm (4.1-1) unstable; urgency=medium

   * New upstream release.
diff -Nru mdadm-4.1/debian/rules mdadm-4.1/debian/rules
--- mdadm-4.1/debian/rules	2019-01-15 12:23:53.000000000 -0600
+++ mdadm-4.1/debian/rules	2020-09-18 02:08:04.000000000 -0500
@@ -64,6 +64,7 @@
 	install -Dm0755 debian/mkconf $(DESTDIR)/usr/share/mdadm/mkconf
 	install -Dm0755 debian/checkarray $(DESTDIR)/usr/share/mdadm/checkarray
 	install -Dm0755 debian/bugscript $(DESTDIR)/usr/share/bug/mdadm/script
+	install -Dm0755 misc/mdcheck $(DESTDIR)/usr/share/mdadm/mdcheck
 	install -Dm0755 udeb/mdadm $(DESTDIR_UDEB)/sbin/mdadm
 	install -Dm0755 udeb/mdmon $(DESTDIR_UDEB)/sbin/mdmon
 	install -Dm0644 $(DESTDIR)/lib/udev/rules.d/63-md-raid-arrays.rules
$(DESTDIR_UDEB)/lib/udev/rules.d/63-md-raid-arrays.rules

-- 
Richard

[signature.asc (application/pgp-signature, attachment)]

Message #30 received at 960132@bugs.debian.org (full text, mbox, reply):

From: Eric Desrochers <eric.desrochers@canonical.com>

To: 960132@bugs.debian.org

Subject: Extra fixes neeeded in mdadm package

Date: Mon, 28 Sep 2020 12:56:08 -0400

[Message part 1 (text/plain, inline)]

Dear maintainers,

Could you please consider the backport of the following upstream commits:

3b7aae9 mdcheck: Log when done
<https://git.kernel.org/pub/scm/utils/mdadm/mdadm.git/commit/?id=3b7aae9>
6636788 mdcheck: when mdcheck_start is enabled, enable mdcheck_continue too.
<https://git.kernel.org/pub/scm/utils/mdadm/mdadm.git/commit/?id=6636788>

Along with the following proposals:
[PATCH 1/2] mdcheck: Prefix pause message with mdcheck
<https://marc.info/?l=linux-raid&m=160098735125487&w=2>
[PATCH 2/2] mdcheck: Set a tag of mdcheck
<https://marc.info/?l=linux-raid&m=160098735125488&w=2>
[PATCH] mdcheck: Remove extra spaces in systemd timer directives
<https://marc.info/?l=linux-raid&m=160130979927617&w=2> (Regression fix for
commit '6636788')

Regards,
Eric

[Message part 2 (text/html, inline)]

Message #35 received at 960132@bugs.debian.org (full text, mbox, reply):

From: Felix Lechner <felix.lechner@lease-up.com>

To: Eric Desrochers <eric.desrochers@canonical.com>, 960132@bugs.debian.org

Subject: Re: Bug#960132: Extra fixes neeeded in mdadm package

Date: Tue, 13 Oct 2020 06:51:54 -0700

Hi Eric,

On Mon, Sep 28, 2020 at 10:00 AM Eric Desrochers
<eric.desrochers@canonical.com> wrote:
>

You commented on a bug that was closed. (Plus, I am not sure how your
five requests relate.) Please open a new bug.

> 3b7aae9 mdcheck: Log when done
> 6636788 mdcheck: when mdcheck_start is enabled, enable mdcheck_continue too.

I have no issue with backporting commits from upstream, and have in
fact been leaning on them for a new release.

> [PATCH 1/2] mdcheck: Prefix pause message with mdcheck
> [PATCH 2/2] mdcheck: Set a tag of mdcheck
> [PATCH] mdcheck: Remove extra spaces in systemd timer directives (Regression fix for commit '6636788')

What is the status of these proposals, please? Are you asking me to
deploy them in Debian before they are accepted upstream? If so, please
explain why Debian should diverge from upstream. Thank you!

Kind regards
Felix Lechner

Message #40 received at 960132@bugs.debian.org (full text, mbox, reply):

From: Felix Lechner <felix.lechner@lease-up.com>

To: Richard Laager <rlaager@wiktel.com>, 960132@bugs.debian.org

Subject: Re: Bug#960132: mdadm: mdcheck_start.service trying to start unexisting file

Date: Tue, 13 Oct 2020 06:55:48 -0700

Hi Richard,

On Fri, Sep 18, 2020 at 12:21 AM Richard Laager <rlaager@wiktel.com> wrote:
>
> found 960132 4.1-1
> severity 960132 serious

You commented on a bug that was closed. I believe those settings had no effect.

> This bug causes a shipped service (mdcheck_start.service) to completely
> fail to start, due to the fact that its script
> (/usr/share/mdadm/mdcheck) does not exist. A package should not release
> in that state.

Due to other comments this bug has become too long and too confusing.
Please open another bug if your issue still exists. Thank you!

Kind regards
Felix Lechner

Send a report that this bug log contains spam.