Debian Bug report logs - #958382
node-mqtt: please make the build reproducible

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>

To: submit@bugs.debian.org

Subject: node-mqtt: please make the build reproducible

Date: Tue, 21 Apr 2020 09:36:08 +0100

[Message part 1 (text/plain, inline)]

Source: node-mqtt
Version: 3.0.0-1
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: umask
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort we noticed that node-
mqtt could not be built reproducibly.

This is because it does not fix the permissions of a number of .js
files (ie. it excludes them via "dh_fixperms -X") and thus they are
affected the build system's umask:

│ │ │ │ --rwxr-xr-x   0 root         (0) root         (0)     3076 2019-05-27 08:20:41.000000 ./usr/share/nodejs/mqtt/bin/pub.js
│ │ │ │ --rwxr-xr-x   0 root         (0) root         (0)     2605 2019-05-27 08:20:41.000000 ./usr/share/nodejs/mqtt/bin/sub.js
│ │ │ │ +-rwxrwxr-x   0 root         (0) root         (0)     3076 2019-05-27 08:20:41.000000 ./usr/share/nodejs/mqtt/bin/pub.js
│ │ │ │ +-rwxrwxr-x   0 root         (0) root         (0)     2605 2019-05-27 08:20:41.000000 ./usr/share/nodejs/mqtt/bin/sub.js

I can't quite tell the underlying reason for these excludes as the
files appear to be correctly installed for me (ie. 0644) so a patch
attached that simply drops the dh_fixperms override entirely. If it is
needed for another reason, please ensure that any change or similar is
not affected by the umask. 


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

[node-mqtt.diff.txt (text/plain, attachment)]

Message #10 received at 958382@bugs.debian.org (full text, mbox, reply):

From: "Ying-Chun Liu (PaulLiu)" <paulliu@debian.org>

To: 958382@bugs.debian.org

Cc: Chris Lamb <lamby@debian.org>

Subject: Re: node-mqtt: please make the build reproducible

Date: Mon, 27 Apr 2020 01:18:08 +0800

[Message part 1 (text/plain, inline)]

Hi Chris,

I think I need to preserve the permission of that file because
/usr/bin/mqtt is linked to /usr/share/nodejs/mqtt/mqtt.js
Thus that file needs to be executable. So simply run dh_fixperms doesn't solve the problem.
Is there any other solution for this? 

Yours,
Paul

[Message part 2 (text/html, inline)]

[signature.asc (application/pgp-signature, attachment)]

Message #15 received at 958382@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>

To: 劉穎駿 <paulliu@debian.org>, 958382@bugs.debian.org

Subject: Re: node-mqtt: please make the build reproducible

Date: Sun, 26 Apr 2020 18:29:07 +0100

Hi Ying-Chun,

> I think I need to preserve the permission of that file because
> /usr/bin/mqtt is linked to /usr/share/nodejs/mqtt/mqtt.js
> Thus that file needs to be executable. So simply run dh_fixperms 
> doesn't solve the problem.

Ah, then try:

    override_dh_fixperms:
	    dh_fixperms
	    chmod +x debian/FIXME/usr/bin/mqtt

(The goal here being to prevent the *group* part being variable depending
on the build umask.)


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org 🍥 chris-lamb.co.uk
       `-

Message #18 received at 958382-submitter@bugs.debian.org (full text, mbox, reply):

From: Ying-Chun Liu <noreply@salsa.debian.org>

To: 958382-submitter@bugs.debian.org

Subject: Bug#958382 marked as pending in node-mqtt

Date: Sun, 26 Apr 2020 18:29:32 +0000

Control: tag -1 pending

Hello,

Bug #958382 in node-mqtt reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/js-team/node-mqtt/-/commit/755b8b8a21d7b125c7c8b2f8c179663568031209

------------------------------------------------------------------------
Import Debian changes 3.0.0-3

node-mqtt (3.0.0-3) unstable; urgency=low

  [ Ying-Chun Liu (PaulLiu) <paulliu@debian.org> ]
  * Make the build reproducible (Closes: #958382)
    - Thanks to "Chris Lamb" <lamby@debian.org>

Signed-off-by: Ying-Chun Liu (PaulLiu) <paulliu@debian.org>
------------------------------------------------------------------------

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/958382

Message #25 received at 958382-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 958382-close@bugs.debian.org

Subject: Bug#958382: fixed in node-mqtt 3.0.0-3

Date: Sun, 26 Apr 2020 18:48:51 +0000

Source: node-mqtt
Source-Version: 3.0.0-3
Done: Ying-Chun Liu (PaulLiu) <paulliu@debian.org>

We believe that the bug you reported is fixed in the latest version of
node-mqtt, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 958382@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Ying-Chun Liu (PaulLiu) <paulliu@debian.org> (supplier of updated node-mqtt package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Mon, 27 Apr 2020 02:23:57 +0800
Source: node-mqtt
Architecture: source
Version: 3.0.0-3
Distribution: unstable
Urgency: low
Maintainer: Debian Javascript Maintainers <pkg-javascript-devel@lists.alioth.debian.org>
Changed-By: Ying-Chun Liu (PaulLiu) <paulliu@debian.org>
Closes: 958382
Changes:
 node-mqtt (3.0.0-3) unstable; urgency=low
 .
   [ Ying-Chun Liu (PaulLiu) <paulliu@debian.org> ]
   * Make the build reproducible (Closes: #958382)
     - Thanks to "Chris Lamb" <lamby@debian.org>
Checksums-Sha1:
 dd5fb5a0b22db048e3e5353328bac8169765e85c 2654 node-mqtt_3.0.0-3.dsc
 688719c77163a111fe40c7696ee767328881f630 6080 node-mqtt_3.0.0-3.debian.tar.xz
 192a9a8bf9fedb49c4f95d25257ecfa68d2083b9 17703 node-mqtt_3.0.0-3_source.buildinfo
Checksums-Sha256:
 402015e6b58c28ea51dd58c044c8b8724e29a2dd0216b7155ac6b656a70c5377 2654 node-mqtt_3.0.0-3.dsc
 a6f222fd1394c32fe75a388829345355d4dc668b5eb38a1b8c019a4e23de8e06 6080 node-mqtt_3.0.0-3.debian.tar.xz
 1251761b6b476e5dd14c921bb0ed4f314e395b0b8e54fe5b3198444f1ce02f5c 17703 node-mqtt_3.0.0-3_source.buildinfo
Files:
 4adda74590c44acb7611716f18a224e7 2654 javascript optional node-mqtt_3.0.0-3.dsc
 89eb43cf26967378f5d4917a87a06f65 6080 javascript optional node-mqtt_3.0.0-3.debian.tar.xz
 6f4d7cbace4fc2592bbdbe43fb1648e7 17703 javascript optional node-mqtt_3.0.0-3_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJHBAEBCgAxFiEEo2h49GQQhoFgDLZIRBc/oT0FiIgFAl6l0nMTHHBhdWxsaXVA
ZGViaWFuLm9yZwAKCRBEFz+hPQWIiJfdD/9qV4v9KZ0OShU1vtnXjgQ+SxAVN4Ko
zIDSgX+XxvzyOTHq3aWLybZyUMOGVjw4jJJcH/FR7fCvg1+mNEneT3antzvcsQ21
28wIgFsMagoap5SP64HVjrUUrNVgxYPMNatlgfOAlGhQzjTmtS7Y8PLV7l6aTdGq
EkHjLiJijXWkd0vdzOm7klYPsU0FN+bdjk7OO71ncBcpNmDGSOR6jI70Ydb1n0uE
8KzyyZLYuLw7phosLRn3Ifornj043u6o/c2PIH4EygP+JRftntAlRFpzLMjf6zXV
8VCZCl7bI4abFGubTI1loyxO/qubc517bmA3yNnnMNVa+WYRUhaw4R2vT5xorOLB
gqRa2ZyG2/Tba+lX1KrP025N5tII362G6US8Lt+5vAwfqIjnFyV9RkXLnNtkhjC0
8Zi5sOmiXojfj5KugxFGxar/uWQ1VR4N6u0mJpf8JeEztiyLKuLOvYhAPJS7vJMQ
edPrHXtKI137/KSP0Zc5BJBxJy3Ur6ukvf2oKs2/Isf6JbnLAg8KUGGni395TuP4
JKncmlVKltLMD5ZfpBP26PUe2suvlBp4BZMbSI2XLppY3GzbOq9tHZwFP+jB0Jl9
wzcknGc1WhBYhgh6JmrRMD4prJZfJThwRLrtIo0XeTAPebYtDPPYT7FVrpGT+pWv
g2XVZwOPwoJmgg==
=2hXb
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.