Debian Bug report logs - #954409
node-browserify-lite: please make the output reproducible

version graph

Package: src:node-browserify-lite; Maintainer for src:node-browserify-lite is Debian Javascript Maintainers <pkg-javascript-devel@lists.alioth.debian.org>;

Reported by: "Chris Lamb" <lamby@debian.org>

Date: Sat, 21 Mar 2020 10:33:03 UTC

Severity: wishlist

Tags: patch

Found in version node-browserify-lite/0.5.0-8

Fixed in version node-browserify-lite/0.5.1-1

Done: Xavier Guimard <yadd@debian.org>

Bug is archived. No further changes may be made.

Forwarded to https://github.com/andrewrk/browserify-lite/pull/14

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, reproducible-bugs@lists.alioth.debian.org, Debian Javascript Maintainers <pkg-javascript-devel@lists.alioth.debian.org>:
Bug#954409; Package src:node-browserify-lite. (Sat, 21 Mar 2020 10:33:05 GMT) (full text, mbox, link).


Acknowledgement sent to "Chris Lamb" <lamby@debian.org>:
New Bug report received and forwarded. Copy sent to reproducible-bugs@lists.alioth.debian.org, Debian Javascript Maintainers <pkg-javascript-devel@lists.alioth.debian.org>. (Sat, 21 Mar 2020 10:33:05 GMT) (full text, mbox, link).


Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>
To: submit@bugs.debian.org
Subject: node-browserify-lite: please make the output reproducible
Date: Sat, 21 Mar 2020 10:30:22 +0000
[Message part 1 (text/plain, inline)]
Source: node-browserify-lite
Version: 0.5.0-8
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: toolchain randomness
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0] we noticed that
node-browserify-lite generates non-deterministic output.

I tracked this down to JSON.stringify not ordering its result by
default, resulting in output varying like the below (after pretty-
printing):

    -    "./foo": 2,
    -    "./bar": 1,
    +    "./bar": 1,
    +    "./foo": 2,

This was affecting many packages, including libjs-webrtc-adapter and
likely many more.

A patch (by myself) is attached. It is upstream blessed but a new
upstream release is also promised shortly if you want to wait for that
too.

  [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-
[node-browserify-lite.diff.txt (text/plain, attachment)]

Information forwarded to debian-bugs-dist@lists.debian.org, Debian Javascript Maintainers <pkg-javascript-devel@lists.alioth.debian.org>:
Bug#954409; Package src:node-browserify-lite. (Sat, 21 Mar 2020 10:42:02 GMT) (full text, mbox, link).


Acknowledgement sent to "Chris Lamb" <lamby@debian.org>:
Extra info received and forwarded to list. Copy sent to Debian Javascript Maintainers <pkg-javascript-devel@lists.alioth.debian.org>. (Sat, 21 Mar 2020 10:42:02 GMT) (full text, mbox, link).


Message #10 received at 954409@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>
To: 954409@bugs.debian.org
Subject: Re: node-browserify-lite: please make the output reproducible
Date: Sat, 21 Mar 2020 10:38:32 +0000
forwarded 954409 https://github.com/andrewrk/browserify-lite/pull/14
thanks

The upstream PR for this issue is:

  https://github.com/andrewrk/browserify-lite/pull/14


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-



Set Bug forwarded-to-address to 'https://github.com/andrewrk/browserify-lite/pull/14'. Request was from "Chris Lamb" <lamby@debian.org> to control@bugs.debian.org. (Sat, 21 Mar 2020 10:42:03 GMT) (full text, mbox, link).


Message sent on to "Chris Lamb" <lamby@debian.org>:
Bug#954409. (Sat, 21 Mar 2020 12:51:06 GMT) (full text, mbox, link).


Message #15 received at 954409-submitter@bugs.debian.org (full text, mbox, reply):

From: Xavier Guimard <noreply@salsa.debian.org>
To: 954409-submitter@bugs.debian.org
Subject: Bug#954409 marked as pending in node-browserify-lite
Date: Sat, 21 Mar 2020 12:47:56 +0000
Control: tag -1 pending

Hello,

Bug #954409 in node-browserify-lite reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/js-team/node-browserify-lite/-/commit/d71b21aa3a84183b069d1e7bda69bb432c30435e

------------------------------------------------------------------------
Patch to make output reproducible

Closes: #954409
------------------------------------------------------------------------

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/954409



Added tag(s) pending. Request was from Xavier Guimard <noreply@salsa.debian.org> to 954409-submitter@bugs.debian.org. (Sat, 21 Mar 2020 12:51:06 GMT) (full text, mbox, link).


Reply sent to Xavier Guimard <yadd@debian.org>:
You have taken responsibility. (Sat, 21 Mar 2020 13:09:03 GMT) (full text, mbox, link).


Notification sent to "Chris Lamb" <lamby@debian.org>:
Bug acknowledged by developer. (Sat, 21 Mar 2020 13:09:03 GMT) (full text, mbox, link).


Message #22 received at 954409-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>
To: 954409-close@bugs.debian.org
Subject: Bug#954409: fixed in node-browserify-lite 0.5.1-1
Date: Sat, 21 Mar 2020 13:04:39 +0000
Source: node-browserify-lite
Source-Version: 0.5.1-1
Done: Xavier Guimard <yadd@debian.org>

We believe that the bug you reported is fixed in the latest version of
node-browserify-lite, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 954409@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Xavier Guimard <yadd@debian.org> (supplier of updated node-browserify-lite package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 21 Mar 2020 13:43:59 +0100
Source: node-browserify-lite
Architecture: source
Version: 0.5.1-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Javascript Maintainers <pkg-javascript-devel@lists.alioth.debian.org>
Changed-By: Xavier Guimard <yadd@debian.org>
Closes: 954409
Changes:
 node-browserify-lite (0.5.1-1) unstable; urgency=medium
 .
   * Team upload
   * Declare compliance with policy 4.5.0
   * Add "Rules-Requires-Root: no"
   * Add debian/gbp.conf
   * Use pkg-js-tools auto test & install
   * New upstream version 0.5.1 (Closes: #954409)
Checksums-Sha1: 
 e98fdb1d66754d94a3fca06fde4bfc5678ec17e7 2217 node-browserify-lite_0.5.1-1.dsc
 aaf7ecc9acc7617aa985d4cfca8deb31376859c2 4895 node-browserify-lite_0.5.1.orig.tar.gz
 8f19fd89822ac2b08e39edabbe7ba69ad9970d5f 4960 node-browserify-lite_0.5.1-1.debian.tar.xz
Checksums-Sha256: 
 b8952cba8009632295fd03a5db472d040d03c552b095d6af0281f09282c7d34b 2217 node-browserify-lite_0.5.1-1.dsc
 364bd195d39ea91c085f536d59eefd12a54e2440e2ddbdb0b6080c3c4ca3cbbb 4895 node-browserify-lite_0.5.1.orig.tar.gz
 2d5ed58bed4bec3caee2b0f6ded83e40d19b0a3664cf82fa230d076651b93ec8 4960 node-browserify-lite_0.5.1-1.debian.tar.xz
Files: 
 3bb7525e48304bfe95e726b0b6e5a6ee 2217 javascript optional node-browserify-lite_0.5.1-1.dsc
 fc607c5a6d0694fd5d7529b83d299db3 4895 javascript optional node-browserify-lite_0.5.1.orig.tar.gz
 346fa96f3f3eefa3ff2052c82bcf3118 4960 javascript optional node-browserify-lite_0.5.1-1.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEAN/li4tVV3nRAF7J9tdMp8mZ7ukFAl52DOIACgkQ9tdMp8mZ
7ul0ehAAkmFppgQvWH5v4ig2/Aoz3KckWxI5/fXBPHd4CkvektsN0h1j8BTaRRQY
YDlSLZSYUGTWelyC9TF5218YbIHgPwKXNvQmHrpByBdAPNJInLX46apEX/pfJLfA
aBVnhy0E/UWvp76XRW6mIWW0WEYTx/UMg5FrsxLYzXkJ9VpNcXxdU48EBdnk73lL
bfVZngAVPDT+uZz3ea5Afh+480tk5z0tHtRWqXT2/xt994a6H1E5FnPx1L0MDhH1
w836yneWQQ7B1FMlhVSn/rvK7U3tfTTxZX4EnIhf3PZ0CDzrtAXp79ucH0goeSYW
ogYWDgt5E4zzQTrXpDkD59FDDtwTDco34H6Z9DO3CcSQiWq8m17gcohQBkVpNkKl
upIuTE05yGuUNe5G4x69mosIQxVdvoKjeFCoer/iEXmfK+TTWiOwyUqNlFsYQcUG
2Y7f2tIfnCT4X73fNc6veetYLN9VL5R72/I/efev352ttGj7SUKKWr3vQiER3vtk
ylzF4r0oWYZadiQGl3ecwdTtY9FKlbokNIoHpv+EZSp/CNkMZFQTuLml9Kndv61+
ZYdQ9lD+TSBAM5OCBpbkvVI8yV9RfxNsPZjZ8wdhuF98qZEU7Vb5ymUXvlXQ+Ph+
uxRe0HL98TzW/RSi0O1aZJhAtP8urW5r8Pc1ZKCOd/ZzsYMbHBc=
=9wdy
-----END PGP SIGNATURE-----




Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Tue, 21 Apr 2020 07:25:46 GMT) (full text, mbox, link).


Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Wed May 17 14:11:14 2023; Machine Name: buxtehude

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.